From patchwork Tue May 8 13:59:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 910205 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oTUpF4Md"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40gLng2jRKz9s27 for ; Wed, 9 May 2018 00:04:07 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=drpj2mf1ffWL5NAFlmb3tbTGBLRXsF7i0YykpSri6MM=; b=oTUpF4MdTyBY+R kP7cdcmuVxxzuDSKlfMTeWJnZU9kvq9tDE6pVGaMr++XO70aMj1ROnF/IstOnmva70ImvmnF3bwcs KvC1IObXxXS2P72ad9FNtDBq/bbnL/L0oS36h4wzlEGP/1Fkr2gNwYwNdDRfNy2u4gS3zzvK+i5gw QEE2CfzEuCSX4LOM/6IGMes1JLB5T0Ab5eiqbMTKt66KBVGYal7ihnDPwJ8WSYX2TVwx0mffscZiQ +111KxWyp95TP7Uogh6yDkWxOzRR4HYSqqTLK/PW7eiqRxYLJCEs5TK2pDu8gLk80j1YeaUAneJsN jMbWIxCGeUDLKzXDHckg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fG3Dm-0002j4-5B; Tue, 08 May 2018 14:04:02 +0000 Received: from mail-oi0-f65.google.com ([209.85.218.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fG39e-00086X-TG for linux-arm-kernel@lists.infradead.org; Tue, 08 May 2018 13:59:48 +0000 Received: by mail-oi0-f65.google.com with SMTP id y15-v6so28415892oia.13 for ; Tue, 08 May 2018 06:59:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7dOE9DBL1tR9+G69xq0pr6oOCigN6SO4Gb4Lm892t70=; b=j1/zoT8ijfiYZ+ZFOaW4DE7D9GfWQCt8CjA2Ad3fCR9AQ+p1z4wsri4QOO6KWJyHX3 p+mH+aQTjYcGZRqFNjQy880OH3EB84M67720h/AvOIHgG60ckf6GEzMloUL1IMx7/lnQ 7E5RaZnMUx64H/rzf1lmivyCG1dGuISvjYO8s1OMjfh7j0lARssARthAnGVFUUrZLRSA U5GFL6MoHSvk9/vgPyXaBCo+UhuvoIsac0c0Vzp9jHWAksykqT/Kcyx18y0+ReRye5yq GaZwlQ3TsdFjYr9WlHLudTWicLybDFsfmT949sGUspsiTq5Zqk4haR4XOicsYcYHwVvS ABdQ== X-Gm-Message-State: ALQs6tAOvRI9Qt1osihif6r+DTa4555Jmy6kFF9kNGNPtl7knHPaQAuQ X9jxMGQpZgZ5usfM9sF9tw== X-Google-Smtp-Source: AB8JxZplJbFFIcp1S5v4pv1DpBOcKdcBSo+63zrxP5xZarmujZ7nPtyhYhIjIU5t0KtHM+lCzvGd8g== X-Received: by 2002:aca:e308:: with SMTP id a8-v6mr27488111oih.237.1525787975744; Tue, 08 May 2018 06:59:35 -0700 (PDT) Received: from xps15.herring.priv (216-188-254-6.dyn.grandenetworks.net. [216.188.254.6]) by smtp.googlemail.com with ESMTPSA id l51-v6sm16534311otb.13.2018.05.08.06.59.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 May 2018 06:59:35 -0700 (PDT) From: Rob Herring To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] arm: dts: omap: fix OF graph in omap3-devkit8000 Date: Tue, 8 May 2018 08:59:29 -0500 Message-Id: <20180508135930.5768-5-robh@kernel.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180508135930.5768-1-robh@kernel.org> References: <20180508135930.5768-1-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180508_065946_983587_23CF76D4 X-CRM114-Status: GOOD ( 14.31 ) X-Spam-Score: 0.7 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (0.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [209.85.218.65 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.218.65 listed in wl.mailspike.net] 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (robherring2[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (robherring2[at]gmail.com) 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Lindgren , =?utf-8?q?Beno=C3=AEt_Cousson?= Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org omap3-devkit8000-common.dtsi defines a graph connection for DVI, but then omap3-devkit8000-lcd-common.dtsi overrides that with a graph connection for the LCD as the same output signals are used. This leaves an incomplete graph as the TFP410 output has only half a connection. The result is the following warning: arch/arm/boot/dts/omap3-devkit8000-lcd70.dtb: Warning (graph_endpoint): /encoder0/ports/port@0/endpoint: graph connection to node '/ocp@68000000/dss@48050000/port/endpoint' is not bidirectional Fix this by defining multiple endpoints which is the correct way to show a 1 to many connection. Cc: "Benoît Cousson" Cc: Tony Lindgren Signed-off-by: Rob Herring --- arch/arm/boot/dts/omap3-devkit8000-common.dtsi | 9 ++++++++- arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi | 5 ++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi index 0c0bb1b01b0b..746a658e84b6 100644 --- a/arch/arm/boot/dts/omap3-devkit8000-common.dtsi +++ b/arch/arm/boot/dts/omap3-devkit8000-common.dtsi @@ -349,10 +349,17 @@ vdda_dac-supply = <&vdac>; port { - dpi_dvi_out: endpoint { + #address-cells = <1>; + #size-cells = <0>; + dpi_dvi_out: endpoint@0 { + reg = <0>; remote-endpoint = <&tfp410_in>; data-lines = <24>; }; + + endpoint@1 { + reg = <1>; + }; }; }; diff --git a/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi b/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi index 2d64bcffaaa8..1093387259e2 100644 --- a/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi +++ b/arch/arm/boot/dts/omap3-devkit8000-lcd-common.dtsi @@ -30,7 +30,10 @@ &dss { port { - dpi_lcd_out: endpoint { + #address-cells = <1>; + #size-cells = <0>; + dpi_lcd_out: endpoint@1 { + reg = <1>; remote-endpoint = <&lcd_in>; data-lines = <24>; };