From patchwork Sun Nov 3 00:32:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005602 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=U75Rb/WB; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwbS5BDyz1xwF for ; Sun, 3 Nov 2024 11:34:43 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B469089058; Sun, 3 Nov 2024 01:34:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="U75Rb/WB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6ED6E89080; Sun, 3 Nov 2024 01:34:39 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 365D688F50 for ; Sun, 3 Nov 2024 01:34:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-20cdb889222so30108465ad.3 for ; Sat, 02 Nov 2024 17:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594075; x=1731198875; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u581EJX4sUW51bS4jbnPZtdZVoeef+vK0be1S3L7EUo=; b=U75Rb/WBvzxZclgF3xpN+dan+x5uSljMbEA7HeuhZ2Q1Zl8t+W+7pQzZNuBu3d09mq E7SDEUSQ+jYH57wZYpgLnVvsEQEU4WwAYQWEiVXa5KBolugTfyeseNNSOl8C+1HHSULo y9OGNVmJM1W5uOxekOmQGM3+nRgjG1bK/nk4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594075; x=1731198875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u581EJX4sUW51bS4jbnPZtdZVoeef+vK0be1S3L7EUo=; b=U8W+sSXlBZRwsWsMT0n1/cb46SMZKw28okqWUO1pFQGQ9DKUxhmVwMnp7Hq6hfEw46 4tqqWWRFb1s2xjD2zjALokrlTYrFw5GLDVPzRbseJ8Qa5CfGvTv56hygKyc2Nw5xv/7u jgJyRaIsQH/uD7cz76OuASDoPf73wjIGNaP5y9cJqj4wg7ggGGi4s/hRA0DRC3ddXuM2 +Nnt0BB/eGtDSpNG5CHUeWbPAufpbE8/6sBo4lBuY9qK2U25Ik3wgNH5QAqEK2oIcqvF +SPAS9zOFfGtANVXpol8E0j1drlITfb1JstemGdwXQDBpsh/cxY34cIs6bN67AD+rW/R uN3Q== X-Gm-Message-State: AOJu0YyTmN7vth91UyeoPDzlf0wc/Gs4a2LSDL0zjCid8+/xIrWC5wX3 MUvZK2ld+OllxnTcBTHqYOB2UMSJ22NYRuWeIiXQjXKrfPPHA3R2FodsB3nYPWNH6MvMHWwnaRF dKg== X-Google-Smtp-Source: AGHT+IEHTK+hfqqE1+NBSAwaQtiUfpdlbOC306UU+AqaZpkQ8nnA7K40j2J/zzr8ct0HD40NsQWIgg== X-Received: by 2002:a17:902:c40c:b0:20c:7d4c:64db with SMTP id d9443c01a7336-21103c7bfafmr152995755ad.49.1730594075007; Sat, 02 Nov 2024 17:34:35 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:34:34 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Jens Scharsig , Marek Vasut Subject: [PATCH v3 01/25] eb_cpu5282: Drop status-LED code and enable LED Date: Sat, 2 Nov 2024 18:32:53 -0600 Message-ID: <20241103003322.626036-2-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Drop this old code. Swtich the LED options to use the new approach, in the same commit, to maintain build-bisectability. Both eb_cpu5282 and eb_cpu5282_internal are done together, since they share code. Signed-off-by: Simon Glass --- Changes in v3: - Update commit message Changes in v2: - Combine code-removal and defconfig changes board/BuS/eb_cpu5282/eb_cpu5282.c | 20 -------------------- configs/eb_cpu5282_defconfig | 8 ++------ configs/eb_cpu5282_internal_defconfig | 8 ++------ include/configs/eb_cpu5282.h | 6 ------ 4 files changed, 4 insertions(+), 38 deletions(-) diff --git a/board/BuS/eb_cpu5282/eb_cpu5282.c b/board/BuS/eb_cpu5282/eb_cpu5282.c index c254da62bf4..cdd862c57d2 100644 --- a/board/BuS/eb_cpu5282/eb_cpu5282.c +++ b/board/BuS/eb_cpu5282/eb_cpu5282.c @@ -14,7 +14,6 @@ #include #include #include -#include #include /*---------------------------------------------------------------------------*/ @@ -160,25 +159,6 @@ int misc_init_r(void) return 1; } -void __led_toggle(led_id_t mask) -{ - MCFGPTA_GPTPORT ^= (1 << 3); -} - -void __led_init(led_id_t mask, int state) -{ - __led_set(mask, state); - MCFGPTA_GPTDDR |= (1 << 3); -} - -void __led_set(led_id_t mask, int state) -{ - if (state == CONFIG_LED_STATUS_ON) - MCFGPTA_GPTPORT |= (1 << 3); - else - MCFGPTA_GPTPORT &= ~(1 << 3); -} - /*---------------------------------------------------------------------------*/ /* EOF EB+MCF-EV123.c */ diff --git a/configs/eb_cpu5282_defconfig b/configs/eb_cpu5282_defconfig index 271dbdf4dbb..c51a5db262e 100644 --- a/configs/eb_cpu5282_defconfig +++ b/configs/eb_cpu5282_defconfig @@ -35,12 +35,8 @@ CONFIG_SYS_FAULT_ECHO_LINK_DOWN=y CONFIG_SYS_RX_ETH_BUFFER=8 CONFIG_DM_I2C=y CONFIG_SYS_I2C_FSL=y -CONFIG_LED_STATUS=y -CONFIG_LED_STATUS0=y -CONFIG_LED_STATUS_BIT=8 -CONFIG_LED_STATUS_BOOT_ENABLE=y -CONFIG_LED_STATUS_BOOT=0 -CONFIG_LED_STATUS_CMD=y +CONFIG_LED=y +CONFIG_LED_BOOT=y CONFIG_MTD=y CONFIG_MTD_NOR_FLASH=y CONFIG_FLASH_CFI_DRIVER=y diff --git a/configs/eb_cpu5282_internal_defconfig b/configs/eb_cpu5282_internal_defconfig index 89a7925dffa..3627d25b990 100644 --- a/configs/eb_cpu5282_internal_defconfig +++ b/configs/eb_cpu5282_internal_defconfig @@ -33,12 +33,8 @@ CONFIG_SYS_FAULT_ECHO_LINK_DOWN=y CONFIG_SYS_RX_ETH_BUFFER=8 CONFIG_DM_I2C=y CONFIG_SYS_I2C_FSL=y -CONFIG_LED_STATUS=y -CONFIG_LED_STATUS0=y -CONFIG_LED_STATUS_BIT=8 -CONFIG_LED_STATUS_BOOT_ENABLE=y -CONFIG_LED_STATUS_BOOT=0 -CONFIG_LED_STATUS_CMD=y +CONFIG_LED=y +CONFIG_LED_BOOT=y CONFIG_MTD=y CONFIG_MTD_NOR_FLASH=y CONFIG_FLASH_CFI_DRIVER=y diff --git a/include/configs/eb_cpu5282.h b/include/configs/eb_cpu5282.h index 26e4ade34ee..a4d1338c8fa 100644 --- a/include/configs/eb_cpu5282.h +++ b/include/configs/eb_cpu5282.h @@ -14,12 +14,6 @@ #define CFG_SYS_UART_PORT (0) -/*----------------------------------------------------------------------* - * Options * - *----------------------------------------------------------------------*/ - -#define STATUS_LED_ACTIVE 0 - /*----------------------------------------------------------------------* * Configuration for environment * * Environment is in the second sector of the first 256k of flash * From patchwork Sun Nov 3 00:32:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005603 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=P4Oeu9Lh; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwbb2XVPz1xwF for ; Sun, 3 Nov 2024 11:34:51 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 25F3A890D9; Sun, 3 Nov 2024 01:34:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="P4Oeu9Lh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 75839890FE; Sun, 3 Nov 2024 01:34:47 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3089F89109 for ; Sun, 3 Nov 2024 01:34:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2114214c63eso1569595ad.3 for ; Sat, 02 Nov 2024 17:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594082; x=1731198882; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lAn85OAkLGDECvFRGhP/lDR01d13zdnILV570yMhkzo=; b=P4Oeu9Lh7Tk3fabcz3BnKTXNn7+QuQmWjnzaxVBX4silwtqijGxzUZO+Sk4Dc3DvxP ALpwQFKon9ldeUPTH59V547hWJMVUNIVPZc4DbQaE3Ig8brDPlGWYB2sb7GAFX6qBUKg bxfwJljwv6Xj+BLTItIVlyuX1boWmd27AuR0A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594082; x=1731198882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lAn85OAkLGDECvFRGhP/lDR01d13zdnILV570yMhkzo=; b=byjYa3eRmHO/mrZaaKZfDj3dtkF59Ab8dgmr4RrHlXzwpbmVP2GZxBZrlxkSOvyXfs TBZ1iinsqpUgjr/xhNdVcjdvOVIjEQl6eWShjAlfi0H9VIn1iYAIiFUJUSJSt0y1czjA XyslTGsv+ON7yeWoegVRDXZPJne1E0G1eUMOXg7WN9926OUXPdnpAClC4GBlW191kqYT Uow1OX7Ts2gV7Rzki/D2vdFY7pMmv4oiSrSE/+MMOJJf7GPgkr4tI+nrjHhIrCTrYddP nsxcSJaYOYCPKh+Yu/UbgwIVAvRPabsAtrpPhj9KcgqqaaTcYz0n/zK5TwFXHpqRPvE8 y4Nw== X-Gm-Message-State: AOJu0Yzci61QEUlEW6VnHeS0+7SQdBGaSzfElhUj1LUHJzLrkxGVJFj6 XDuWiw0OZFvgqiUHX4ziujeoelqGTt7jfKnIJMcLTWeRAcoKgbKQT8NTHNoqHLmbGiEWbtB7EzV PEQ== X-Google-Smtp-Source: AGHT+IF+5mFR5ioUz9bX9gpxDNY2BoVMXM00gjGw8FKdDa462o8CPCR1DPdB0yYLp/NokxOYlYMGLA== X-Received: by 2002:a17:903:234c:b0:20c:6f6f:afe5 with SMTP id d9443c01a7336-210c6c5ce4dmr339786485ad.50.1730594081909; Sat, 02 Nov 2024 17:34:41 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.34.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:34:41 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Marek Vasut Subject: [PATCH v3 02/25] vining_fpga: Drop status-LED code and use LED Date: Sat, 2 Nov 2024 18:32:54 -0600 Message-ID: <20241103003322.626036-3-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used anymore, so drop it. Enable LED and LED_BOOT instead, since this is the new way to access the LED functionality. Signed-off-by: Simon Glass --- Changes in v3: - Combine removal and enable patches board/softing/vining_fpga/socfpga.c | 4 ---- configs/socfpga_vining_fpga_defconfig | 13 ++----------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/board/softing/vining_fpga/socfpga.c b/board/softing/vining_fpga/socfpga.c index ec2c7ea3631..700184cc575 100644 --- a/board/softing/vining_fpga/socfpga.c +++ b/board/softing/vining_fpga/socfpga.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include @@ -26,9 +25,6 @@ int board_late_init(void) const unsigned int usb_nrst_gpio = 35; int ret; - status_led_set(1, CONFIG_LED_STATUS_ON); - status_led_set(2, CONFIG_LED_STATUS_ON); - /* Address of boot parameters for ATAG (if ATAG is used) */ gd->bd->bi_boot_params = CFG_SYS_SDRAM_BASE + 0x100; diff --git a/configs/socfpga_vining_fpga_defconfig b/configs/socfpga_vining_fpga_defconfig index 094e9186fca..94018752b40 100644 --- a/configs/socfpga_vining_fpga_defconfig +++ b/configs/socfpga_vining_fpga_defconfig @@ -77,17 +77,8 @@ CONFIG_SYS_DFU_DATA_BUF_SIZE=0x1000000 CONFIG_DWAPB_GPIO=y CONFIG_DM_I2C=y CONFIG_SYS_I2C_DW=y -CONFIG_LED_STATUS=y -CONFIG_LED_STATUS_GPIO=y -CONFIG_LED_STATUS0=y -CONFIG_LED_STATUS_BIT=48 -CONFIG_LED_STATUS1=y -CONFIG_LED_STATUS_BIT1=53 -CONFIG_LED_STATUS2=y -CONFIG_LED_STATUS_BIT2=54 -CONFIG_LED_STATUS3=y -CONFIG_LED_STATUS_BIT3=65 -CONFIG_LED_STATUS_CMD=y +CONFIG_LED=y +CONFIG_LED_BOOT=y CONFIG_MISC=y CONFIG_I2C_EEPROM=y CONFIG_SYS_I2C_EEPROM_ADDR=0x50 From patchwork Sun Nov 3 00:32:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005604 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=X2+xfQuX; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwbl2sN2z1xwF for ; Sun, 3 Nov 2024 11:34:59 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 81F9889110; Sun, 3 Nov 2024 01:34:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="X2+xfQuX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DC2CC8917E; Sun, 3 Nov 2024 01:34:53 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B66928910E for ; Sun, 3 Nov 2024 01:34:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-20cbcd71012so36010325ad.3 for ; Sat, 02 Nov 2024 17:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594090; x=1731198890; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3Tm6eWpdGGVlV/kjE3UzE3xt3/x2Y71r8b+cLnzd1O4=; b=X2+xfQuXAdTvaOyMC0zkBVq7KgzpZ1FzOpk+lNceR3K4pk8RWkvWeD/Y5Rlw26OjBp CuYkAsNyqkc82ri0ouS3e3+MXMr49fxPrvv2x4wXnZHKYFfrmVd/wjdwtEtBLd7fy4J5 JKO4fRCeOjlCpc7xnGikXdwqaPl/fLTkb2qxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594090; x=1731198890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3Tm6eWpdGGVlV/kjE3UzE3xt3/x2Y71r8b+cLnzd1O4=; b=lOjNcc95J3VJF/l+zokBm9zUfLDoWX32YhIc9eVR9X+yKbjzesWia5MpnKOOkIA+PA 4TfEELabChQ6VMkqeHb8M3tccI7OeLjF5Tty7jUkTemCs4Ig0bxGSiWESXA1PWC3iEfM 0RmUSbXGtR948rfCf4ArYUUWJ6aoGY6EtaW3PCBYEh8c9QCWNPiC5H76RjwrnFhLwyzH cjAmslkqAxgoBsxge+usFchhL+vZlNNG3YWTTKIBKGckqyOFXRG8NyXz29H0zoDgoo2U DqPsWheNjwo/9LxYZYXPcTAZ/G+j1g3d3EEVUmYHYxSndz1OM4ZQv3c4GR8YRsk4c29+ D0Og== X-Gm-Message-State: AOJu0Yx8lSJFxID1XZT29hZOskENYu7Vv6r+xrxidOahwd7mEl+qBlED L5snmgmCd+DZjv/P4CCDVEtlIQ6aKCgQbsm4YmEUF0+FSD+SyNxTy7MM/qG6kfE7Oe+hJh8FQ2p NEQ== X-Google-Smtp-Source: AGHT+IG19gTV5zfE+kWonpextnAWM+C1Dsu1RKyVnKJ9a/mwNb8gqi10fTGg8M7xdV6GbuufdKgzig== X-Received: by 2002:a17:902:d2c4:b0:20c:8331:cb6e with SMTP id d9443c01a7336-2111aee4561mr109326985ad.19.1730594089662; Sat, 02 Nov 2024 17:34:49 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:34:49 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Marek Vasut Subject: [PATCH v3 03/25] mx23_olinuxino: Drop status-LED code and use LED Date: Sat, 2 Nov 2024 18:32:55 -0600 Message-ID: <20241103003322.626036-4-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Enable LED and LED_BOOT instead, since this is the new way to access the LED functionality. Signed-off-by: Simon Glass --- Changes in v3: - Combine removal and enable patches board/olimex/mx23_olinuxino/mx23_olinuxino.c | 7 ------- configs/mx23_olinuxino_defconfig | 10 ++-------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/board/olimex/mx23_olinuxino/mx23_olinuxino.c b/board/olimex/mx23_olinuxino/mx23_olinuxino.c index b2bb6678c23..78136c1620a 100644 --- a/board/olimex/mx23_olinuxino/mx23_olinuxino.c +++ b/board/olimex/mx23_olinuxino/mx23_olinuxino.c @@ -13,9 +13,6 @@ #include #include #include -#ifdef CONFIG_LED_STATUS -#include -#endif #include DECLARE_GLOBAL_DATA_PTR; @@ -61,9 +58,5 @@ int board_init(void) /* Adress of boot parameters */ gd->bd->bi_boot_params = PHYS_SDRAM_1 + 0x100; -#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT_ENABLE) - status_led_set(CONFIG_LED_STATUS_BOOT, CONFIG_LED_STATUS_STATE); -#endif - return 0; } diff --git a/configs/mx23_olinuxino_defconfig b/configs/mx23_olinuxino_defconfig index 3016f750e64..c1319077891 100644 --- a/configs/mx23_olinuxino_defconfig +++ b/configs/mx23_olinuxino_defconfig @@ -39,14 +39,8 @@ CONFIG_USE_BOOTFILE=y CONFIG_BOOTFILE="uImage" CONFIG_VERSION_VARIABLE=y CONFIG_MXS_GPIO=y -CONFIG_LED_STATUS=y -CONFIG_LED_STATUS_GPIO=y -CONFIG_LED_STATUS0=y -CONFIG_LED_STATUS_BIT=778 -CONFIG_LED_STATUS_STATE=2 -CONFIG_LED_STATUS_BOOT_ENABLE=y -CONFIG_LED_STATUS_BOOT=0 -CONFIG_LED_STATUS_CMD=y +CONFIG_LED=y +CONFIG_LED_BOOT=y CONFIG_MMC_MXS=y CONFIG_CONS_INDEX=0 CONFIG_DM_SERIAL=y From patchwork Sun Nov 3 00:32:56 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005605 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Vf801pI1; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwbx38Cyz1xwV for ; Sun, 3 Nov 2024 11:35:09 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 33D8A89137; Sun, 3 Nov 2024 01:35:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Vf801pI1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 299D889157; Sun, 3 Nov 2024 01:35:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C4F58910E for ; Sun, 3 Nov 2024 01:34:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-20cb47387ceso29985935ad.1 for ; Sat, 02 Nov 2024 17:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594095; x=1731198895; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UqcGr2HQBaHTpFA41xPMR3mQ5RKUGrYCbqTQW9Ba9TA=; b=Vf801pI1PU/oeKPfSDbu60J95VLbnTPpl4vzphXIokZMewdlfnGbA9yNdIJnr1PmR/ 4rgteK2sm5lwQavTar4FCNphM2EfQlLdem8qSUsOCkbM+uLOzTqPIs1gA9nnVAyILyvC GoZByh1L6lCjNAZqaXrlEUWLoBEmrlhlqSRYo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594095; x=1731198895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UqcGr2HQBaHTpFA41xPMR3mQ5RKUGrYCbqTQW9Ba9TA=; b=T/ezs7vpM9ZOicqWfrBd1e1bw8pP9mkONYs10VwsCPDz0/s1knMGmWnOS9OddkDhG/ 2OzaxxhY08RS5I05NsG/n7WOr5Uflms1mGe//kU2Qa1MBxUjgfyYzHRSrRVup0GiZAfS uvzTE3P+NJffPzn+oHUkK0slBFYU4yiplw57EeVyNrvw/2l3Gja2cr25E+9DXphc1T4+ nTVWM3WHwADi0c4Cb+X52Xn1k84mT30etG2ZoTm2gGEr6VyRDclsEdSoOT2EdOwYqHfc pPsNRC40GpkcjZTkSQE90gDwEusYBldFvcMaRneBvl5k9ad49MZePHWfj7dIL9QDe0QU r4rg== X-Gm-Message-State: AOJu0Ywa8a8SGn5UM7da7kTLQJxSLeN//qIOT2jfkroQuMCDvyjSnadX o2PworAOwdZSAI4bHirBFDheVETyvllz5IlX+x6igBDJj1L8ys3XZsNQ6LjQGUAKLj6831z8qaU slQ== X-Google-Smtp-Source: AGHT+IGAYrnpfiu/S5p6SXZHIv5fg56cq4EaZ+CY5eW4XFxa/zOaZ9lKSW7cDm1RrzVnUXUHKvoqcQ== X-Received: by 2002:a17:902:ecc5:b0:20c:7181:51cb with SMTP id d9443c01a7336-210c6892b62mr395281765ad.18.1730594095474; Sat, 02 Nov 2024 17:34:55 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:34:54 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Samuel Holland Subject: [PATCH v3 04/25] pinephone: Drop status-LED code and use LED Date: Sat, 2 Nov 2024 18:32:56 -0600 Message-ID: <20241103003322.626036-5-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Drop the STATUS_LED options and enable LED and LED_BOOT instead, since this is the new way to access the LED functionality. Signed-off-by: Simon Glass --- Changes in v3: - Combine removal and enable patches Changes in v2: - Add a patch to enable LED and LED_BOOT for these boards configs/pinephone_defconfig | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig index 9d39204a439..272fce1c1a4 100644 --- a/configs/pinephone_defconfig +++ b/configs/pinephone_defconfig @@ -11,8 +11,5 @@ CONFIG_MMC_SUNXI_SLOT_EXTRA=2 CONFIG_PINEPHONE_DT_SELECTION=y # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_OF_LIST="sun50i-a64-pinephone-1.1 sun50i-a64-pinephone-1.2" -CONFIG_LED_STATUS=y -CONFIG_LED_STATUS_GPIO=y -CONFIG_LED_STATUS0=y -CONFIG_LED_STATUS_BIT=114 -CONFIG_LED_STATUS_STATE=2 +CONFIG_LED=y +CONFIG_LED_BOOT=y From patchwork Sun Nov 3 00:32:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005606 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=oXIVPBDN; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwc76VPDz1xwV for ; Sun, 3 Nov 2024 11:35:18 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A6D488928C; Sun, 3 Nov 2024 01:35:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="oXIVPBDN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 70A0F8924F; Sun, 3 Nov 2024 01:35:11 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 19FB389058 for ; Sun, 3 Nov 2024 01:35:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-20c8c50fdd9so27402755ad.0 for ; Sat, 02 Nov 2024 17:35:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594107; x=1731198907; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KUqrnha8r/+ll18/Hs3mg5HiovtfGf/ibQh4Ztzq/7I=; b=oXIVPBDNTh9fN+NIm9eKYR/aP7EMk8zaXbo2mKWlm7+xaAJIox82i9YByZf10ZAj9E BNc9Ai2vezwilQHv0i+0e+CJKVN83DRNasYxkk35X9YGy+XnivL50M9zqia8tt/0KOa/ UxbkS5IaAQm47Iqs61aULCff1jsml/+cCUzU8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594107; x=1731198907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KUqrnha8r/+ll18/Hs3mg5HiovtfGf/ibQh4Ztzq/7I=; b=CoFaTXXxWFiRVvAWyYu59cWptVjFq8o9UnO9icDBu+Jv2LkBJAnnsjdlA791Yl0mPc qcSYTMlOKumjWH77Bg25UAap7SC4Pb5EAalpb3tj9F6B8wIjvEwm5uliPFrKGM3TnfA5 xzolc+u8nV5AFiQS8ffffnmEr0qdIYm199Jc+DH5xw3BzfaAacksAVGLdHE1266slem9 K2msUhbWdnfQzkunnRMX2hUzNSSw/cXmEepDDxg0shCLSD0b1VbN+9SjhFxGGmI1dGwM 0FlnF81ua2YJ7b8G3WGEGj5PBUTI8tQQduQBonf14L/3ubnUqi9wClH6NOAcDQX5MWys gVjg== X-Gm-Message-State: AOJu0YyNxKo31Tm9fomBhsSM50URvXGMIaDIhx24w3Dc8Rt0MVRoe7kx q9oLfIpNCZ3Ele1hn8qkyGoiL+TAvLPquJUw+MNC+in8C70DUsPAX+4tq0PrjxdMOagv+D/DlWu hHA== X-Google-Smtp-Source: AGHT+IED34ClQ99CufBGfwOlN8N63VbkJVPXxPpxyXU1117OF6cRgiZV8PjvXGFYoDBea+0CM54mxw== X-Received: by 2002:a17:903:18b:b0:210:e760:77e with SMTP id d9443c01a7336-211056b22d2mr179057915ad.7.1730594106966; Sat, 02 Nov 2024 17:35:06 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.34.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:35:05 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Christian Marangi , Doug Zobel , Michael Polyntsov , Mikhail Kshevetskiy , Rasmus Villemoes Subject: [PATCH v3 05/25] led: Drop LED_STATUS_BOARD_SPECIFIC Date: Sat, 2 Nov 2024 18:32:57 -0600 Message-ID: <20241103003322.626036-6-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used by any board and there is a driver model version of LEDs. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) cmd/legacy_led.c | 40 ---------------------------------------- drivers/led/Kconfig | 6 ------ include/status_led.h | 13 +------------ 3 files changed, 1 insertion(+), 58 deletions(-) diff --git a/cmd/legacy_led.c b/cmd/legacy_led.c index 50de7e89d8f..ef2135e0dba 100644 --- a/cmd/legacy_led.c +++ b/cmd/legacy_led.c @@ -24,26 +24,6 @@ struct led_tbl_s { typedef struct led_tbl_s led_tbl_t; static const led_tbl_t led_commands[] = { -#ifdef CONFIG_LED_STATUS_BOARD_SPECIFIC -#ifdef CONFIG_LED_STATUS0 - { "0", CONFIG_LED_STATUS_BIT, NULL, NULL, NULL }, -#endif -#ifdef CONFIG_LED_STATUS1 - { "1", CONFIG_LED_STATUS_BIT1, NULL, NULL, NULL }, -#endif -#ifdef CONFIG_LED_STATUS2 - { "2", CONFIG_LED_STATUS_BIT2, NULL, NULL, NULL }, -#endif -#ifdef CONFIG_LED_STATUS3 - { "3", CONFIG_LED_STATUS_BIT3, NULL, NULL, NULL }, -#endif -#ifdef CONFIG_LED_STATUS4 - { "4", CONFIG_LED_STATUS_BIT4, NULL, NULL, NULL }, -#endif -#ifdef CONFIG_LED_STATUS5 - { "5", CONFIG_LED_STATUS_BIT5, NULL, NULL, NULL }, -#endif -#endif #ifdef CONFIG_LED_STATUS_GREEN { "green", CONFIG_LED_STATUS_GREEN, green_led_off, green_led_on, NULL }, #endif @@ -148,26 +128,6 @@ int do_legacy_led(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) U_BOOT_CMD( led, 4, 1, do_legacy_led, "[" -#ifdef CONFIG_LED_STATUS_BOARD_SPECIFIC -#ifdef CONFIG_LED_STATUS0 - "0|" -#endif -#ifdef CONFIG_LED_STATUS1 - "1|" -#endif -#ifdef CONFIG_LED_STATUS2 - "2|" -#endif -#ifdef CONFIG_LED_STATUS3 - "3|" -#endif -#ifdef CONFIG_LED_STATUS4 - "4|" -#endif -#ifdef CONFIG_LED_STATUS5 - "5|" -#endif -#endif #ifdef CONFIG_LED_STATUS_GREEN "green|" #endif diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig index c98cbf92fab..268118a6c3a 100644 --- a/drivers/led/Kconfig +++ b/drivers/led/Kconfig @@ -166,12 +166,6 @@ config LED_STATUS_GPIO The status LED can be connected to a GPIO pin. In such cases, the gpio_led driver can be used as a status LED backend implementation. -config LED_STATUS_BOARD_SPECIFIC - bool "Specific board" - default y - help - LED support is only for a specific board. - comment "LEDs parameters" config LED_STATUS0 diff --git a/include/status_led.h b/include/status_led.h index 1282022253e..59cf9f89956 100644 --- a/include/status_led.h +++ b/include/status_led.h @@ -61,23 +61,12 @@ static inline void status_led_boot_blink(void) * ADVICE: Define in your board configuration file rather than * filling this file up with lots of custom board stuff. */ - -#elif defined(CONFIG_LED_STATUS_BOARD_SPECIFIC) -/* led_id_t is unsigned long mask */ -typedef unsigned long led_id_t; - -extern void __led_toggle (led_id_t mask); -extern void __led_init (led_id_t mask, int state); -extern void __led_set (led_id_t mask, int state); -void __led_blink(led_id_t mask, int freq); #else # error Status LED configuration missing #endif /************************************************************************/ -#ifndef CONFIG_LED_STATUS_BOARD_SPECIFIC -# include -#endif +#include #else From patchwork Sun Nov 3 00:32:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005607 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=gfPE3x02; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwcJ2bvkz1xwV for ; Sun, 3 Nov 2024 11:35:28 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 11D908910E; Sun, 3 Nov 2024 01:35:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="gfPE3x02"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B252089118; Sun, 3 Nov 2024 01:35:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7F2E289058 for ; Sun, 3 Nov 2024 01:35:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-7ee11ff7210so2272296a12.1 for ; Sat, 02 Nov 2024 17:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594114; x=1731198914; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jdss8yE2/awIEEy86I7YaeWMYJdbjKgylXCFi3piogU=; b=gfPE3x02e5mnxczl1m5306sLVG8QQa5nsLeDWVX0Ucl5C5OPDpMZCt2qmaUgqSbe3i G4qkPDldIhf2NsYNoGw+Hpr0sq+WSc4ojiN2DzeSIdoX0NLi5rAG/yRz3/DU74HuqNrr fXdugPM+xDdkC0thNgbRwPDhDmZOlt58IYiIY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594114; x=1731198914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jdss8yE2/awIEEy86I7YaeWMYJdbjKgylXCFi3piogU=; b=hRcs/QUYp4cyvhfRmoo3wNdyi07EFi19qAQP4KOq8C92IDJHWBlq1zgdOhCHJt+cvu LANvEMAEWg3AsUVrBXgBQdC2ntg/le9BtCnFiwNj56NyPWNUP5T0wj2K5TpC7JEODy74 yepMu6/c4kFEM7Qm0Zt8yK0Kolcubo4vH/p/QhNcr7utjZeQ2hTXy954NVmsHgmV6x5Q K/NIsV1CRmQ/RVxB7ObiHo0K387XJJRIahbaIj7pramF6JpCM2/c0HybdLvJY6tqK4wY 94DRikWJBkkp2yPJrzTgY71+Rvt25Ggiyv9QuUgYMS8w6LFMxDt+RZekiB1N5vwn3Br1 /EBQ== X-Gm-Message-State: AOJu0YxXsQ8khf4nfd2EFa+cfFldK5xKECLAhpn5qXqy4Def7vckuDa1 ZPMOYwa0+x66XWsCKJnPyWpvTzWF4ZYCbuA5677J8bvH2s7UyvCFGJiTySEV16qGfmnXarrQY+R tJw== X-Google-Smtp-Source: AGHT+IH3JD9SwKJlpKaZwEIoL+67l39Jw901S05ulgcle3FytjDshIXBl4dvCeoi9wnJj/XUSOBLnQ== X-Received: by 2002:a17:902:d481:b0:20b:6918:30b5 with SMTP id d9443c01a7336-2111af5a6bcmr102263155ad.41.1730594114470; Sat, 02 Nov 2024 17:35:14 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:35:13 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Albert Aribaud Subject: [PATCH v3 06/25] arm: Drop old LED support Date: Sat, 2 Nov 2024 18:32:58 -0600 Message-ID: <20241103003322.626036-7-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This has been replaced with a new LED framework, so drop this old code. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/lib/crt0.S | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm/lib/crt0.S b/arch/arm/lib/crt0.S index 3e4906e273d..a691d844847 100644 --- a/arch/arm/lib/crt0.S +++ b/arch/arm/lib/crt0.S @@ -185,10 +185,6 @@ here: movne r9, r0 # endif -#if ! defined(CONFIG_XPL_BUILD) - bl coloured_LED_init - bl red_led_on -#endif /* call board_init_r(gd_t *id, ulong dest_addr) */ mov r0, r9 /* gd_t */ ldr r1, [r9, #GD_RELOCADDR] /* dest_addr */ From patchwork Sun Nov 3 00:32:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005608 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Co3urrx1; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwcW0GRnz1xwV for ; Sun, 3 Nov 2024 11:35:38 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6D3B989145; Sun, 3 Nov 2024 01:35:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Co3urrx1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4A26589145; Sun, 3 Nov 2024 01:35:34 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5109D8924F for ; Sun, 3 Nov 2024 01:35:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-20c7edf2872so31895615ad.1 for ; Sat, 02 Nov 2024 17:35:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594129; x=1731198929; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hojl3y2jvSmNhP3fWupBFOmaeCkHm++KHdwhJaoLDps=; b=Co3urrx1M5EtZyAeijEXvuEaHA3FiXtHZOb5FMFh3yPH7r0b+K3h4syLcN6QWJJ2qn Ja72YNS+FNVSPi3o4+cVYdGUu4DEHV0y3qdCCiH+JaBcBqdVEukoAxUPClLdQx3w91O7 /XJO62Cy9Mf/LlFJky4rNNLD3MjbxHnW89nYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594129; x=1731198929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hojl3y2jvSmNhP3fWupBFOmaeCkHm++KHdwhJaoLDps=; b=FOXEU+BnJD6Rex1k8LtgXFXVfXflyedB0WqRQ0qC4sEGeYwcpbXqAqFr0Z1qONdZiO TRDY01/OAx6w1LoLktQcooRz48sAAYSddTdMjN/z5V+GUwtRajbPty2l32dXacq1Bm+m kIhx5g2ffJhVONxdAU4/CU82qLIO5xKJytLueSD2U+n14NT7NJZQiYjQXIRSbVPoFQDE 17pmMyyST7iu0gUWwJK7TaPJ/GIw2FB9YQiVZ2xnqZEE1AvUcqMDZ0vDRtiXta2Ndew+ MjzTXdKz2aHM35TEaMvaiAb56jaWXEnaZc+mLVo8lXg44oQSV/wMwFBC8oY1RLpfLDMo rE2g== X-Gm-Message-State: AOJu0YzMF1RfLaxFBnXf7nm3WNYtJtz9ZZ6PLhdDcKSQVX53FVegI8qp gmbR9iLthpewfQLVJAHX0Ioa6i61suGY7dyB4XCCzfsnmjupj3ksbQ/kiToPHIO7GYtRiLzuTnb g0g== X-Google-Smtp-Source: AGHT+IHfae2azD6RPC3PhJBIU9S1WfTSTP6ZiKnQyDWSPwqNGbca3irWXukqEsxXFapHrIrwP+tOGA== X-Received: by 2002:a17:902:fc85:b0:211:3363:8c8d with SMTP id d9443c01a7336-21133638d85mr59609875ad.20.1730594129222; Sat, 02 Nov 2024 17:35:29 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.35.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:35:28 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Devarsh Thakkar , Ilias Apalodimas , Jonas Karlman , Raymond Mao , Richard Weinberger , This contributor prefers not to receive mails Subject: [PATCH v3 07/25] common: doc: Drop old LED support Date: Sat, 2 Nov 2024 18:32:59 -0600 Message-ID: <20241103003322.626036-8-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This has been replaced with a new LED framework, so drop this old code and documentation. Signed-off-by: Simon Glass --- (no changes since v1) common/board_f.c | 22 -------------- doc/README.LED | 77 ------------------------------------------------ 2 files changed, 99 deletions(-) delete mode 100644 doc/README.LED diff --git a/common/board_f.c b/common/board_f.c index 98dc2591e1d..b110a15278b 100644 --- a/common/board_f.c +++ b/common/board_f.c @@ -36,7 +36,6 @@ #include #include #include -#include #include #include #include @@ -53,27 +52,6 @@ DECLARE_GLOBAL_DATA_PTR; -/* - * TODO(sjg@chromium.org): IMO this code should be - * refactored to a single function, something like: - * - * void led_set_state(enum led_colour_t colour, int on); - */ -/************************************************************************ - * Coloured LED functionality - ************************************************************************ - * May be supplied by boards if desired - */ -__weak void coloured_LED_init(void) {} -__weak void red_led_on(void) {} -__weak void red_led_off(void) {} -__weak void green_led_on(void) {} -__weak void green_led_off(void) {} -__weak void yellow_led_on(void) {} -__weak void yellow_led_off(void) {} -__weak void blue_led_on(void) {} -__weak void blue_led_off(void) {} - /* * Why is gd allocated a register? Prior to reloc it might be better to * just pass it around to each function in this file? diff --git a/doc/README.LED b/doc/README.LED deleted file mode 100644 index c21c9d53ec3..00000000000 --- a/doc/README.LED +++ /dev/null @@ -1,77 +0,0 @@ -Status LED -======================================== - -This README describes the status LED API. - -The API is defined by the include file include/status_led.h - -The first step is to enable CONFIG_LED_STATUS in menuconfig: -> Device Drivers > LED Support. - -If the LED support is only for specific board, enable -CONFIG_LED_STATUS_BOARD_SPECIFIC in the menuconfig. - -Status LEDS 0 to 5 are enabled by the following configurations at menuconfig: -CONFIG_STATUS_LED0, CONFIG_STATUS_LED1, ... CONFIG_STATUS_LED5 - -The following should be configured for each of the enabled LEDs: -CONFIG_STATUS_LED_BIT -CONFIG_STATUS_LED_STATE -CONFIG_STATUS_LED_FREQ -Where is an integer 1 through 5 (empty for 0). - -CONFIG_STATUS_LED_BIT is passed into the __led_* functions to identify which LED -is being acted on. As such, the value choose must be unique with with respect to -the other CONFIG_STATUS_LED_BIT's. Mapping the value to a physical LED is the -reponsiblity of the __led_* function. - -CONFIG_STATUS_LED_STATE is the initial state of the LED. It should be set to one -of these values: CONFIG_LED_STATUS_OFF or CONFIG_LED_STATUS_ON. - -CONFIG_STATUS_LED_FREQ determines the LED blink frequency. -Values range from 2 to 10. - -Some other LED macros ---------------------- - -CONFIG_STATUS_LED_BOOT is the LED to light when the board is booting. -This must be a valid LED number (0-5). - -CONFIG_STATUS_LED_RED is the red LED. It is used to signal errors. This must be -a valid LED number (0-5). Other similar color LED's macros are -CONFIG_STATUS_LED_GREEN, CONFIG_STATUS_LED_YELLOW and CONFIG_STATUS_LED_BLUE. - -General LED functions ---------------------- -The following functions should be defined: - -__led_init is called once to initialize the LED to CONFIG_STATUS_LED_STATE. -One time start up code should be placed here. - -__led_set is called to change the state of the LED. - -__led_toggle is called to toggle the current state of the LED. - -Colour LED -======================================== - -Colour LED's are at present only used by ARM. - -The functions names explain their purpose. - -coloured_LED_init -red_LED_on -red_LED_off -green_LED_on -green_LED_off -yellow_LED_on -yellow_LED_off -blue_LED_on -blue_LED_off - -These are weakly defined in arch/arm/lib/board.c to noops. Where applicable, define -these functions in the board specific source. - -TBD : Describe older board dependent macros similar to what is done for - -TBD : Describe general support via asm/status_led.h From patchwork Sun Nov 3 00:33:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005609 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=MrTr76zb; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwcg3b5Hz1xwV for ; Sun, 3 Nov 2024 11:35:47 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB1F189169; Sun, 3 Nov 2024 01:35:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="MrTr76zb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D4809891AD; Sun, 3 Nov 2024 01:35:43 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D27BD89157 for ; Sun, 3 Nov 2024 01:35:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-210e5369b7dso30764265ad.3 for ; Sat, 02 Nov 2024 17:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594137; x=1731198937; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W6lPGYgtc+6jQZ9TUbI9+VQGxMBaV4EQW1fljF9RDRo=; b=MrTr76zbDDnkuvbB5pOuofrGZISfLO1PHWbZ95r1z6X5NjHNeokB5CpOHPHQm5xM9F TvKRIuT98/0wXCmjLYUgKJiC6s0CQQ3qK7WChWvMXQwOSYH63podRRRxcYFHh6LxpLTQ FMZ4uH/LXTxLIV3jDCBNd6gQDOgDRMs6NDvdc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594137; x=1731198937; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W6lPGYgtc+6jQZ9TUbI9+VQGxMBaV4EQW1fljF9RDRo=; b=UCcjRDRQLkQOALUE0iuxtEFn93Z9Q+noRBZ40PyV7++R9V/IC2XR/Y02tidKR1/Grq HInn3XNz/xjCJ3wjqijwNw/3xvV/5xIWWySe6rZPeN7vrqE6Ccz/QhZqOAIFozL2NVY4 R7b3cODC7xOJnSfNF/2Y4r97q6rcUcxwoK/HmZzOpZLnX+xeYDYUPXH+Yym9sc844Fuh 2wHkobpCzZAtxan8dx7lYRl/dSWcZBVmP7okabxMFBC6EHVyj9s+lFl6iJEvw7fYNL+k 3J4gDTRJrOMY+IdrlFbJ5G71IcL+1vzt+Js+vcadchrGvsIOtIIvsyIhUkDEyH40Qwdf E/tQ== X-Gm-Message-State: AOJu0YypIFQZoFrInSwB8GWt91p3BiaD4ESuXtBGLx/yN4bUm2kDNPtu 2FKVe2OzX0m07ceR5ZpoF2+kww7aTd7+oSyQ822p2IGj8CrR1QXIUxcSAFJxUTgJ2FgOGpU5RHv mzg== X-Google-Smtp-Source: AGHT+IGkWLuX6ippWlPvGf7rzjNsydx0g+auB/UGfJgLHATHjnp55nyEiEjLO6m1BQYLH+cunXKlZw== X-Received: by 2002:a17:903:2350:b0:20f:5443:9ec1 with SMTP id d9443c01a7336-2111af6c144mr109929445ad.33.1730594137424; Sat, 02 Nov 2024 17:35:37 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:35:36 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Kamil Lulko , Patrice Chotard , Patrick Delaunay , uboot-stm32@st-md-mailman.stormreply.com Subject: [PATCH v3 08/25] st: stm32f429: Drop old LED code Date: Sat, 2 Nov 2024 18:33:00 -0600 Message-ID: <20241103003322.626036-9-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This predates the LED framework, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) board/st/stm32f429-discovery/Makefile | 1 - board/st/stm32f429-discovery/led.c | 39 --------------------------- 2 files changed, 40 deletions(-) delete mode 100644 board/st/stm32f429-discovery/led.c diff --git a/board/st/stm32f429-discovery/Makefile b/board/st/stm32f429-discovery/Makefile index 6b02c0fddec..233eafdad3d 100644 --- a/board/st/stm32f429-discovery/Makefile +++ b/board/st/stm32f429-discovery/Makefile @@ -7,4 +7,3 @@ # Kamil Lulko, obj-y := stm32f429-discovery.o -obj-y += led.o diff --git a/board/st/stm32f429-discovery/led.c b/board/st/stm32f429-discovery/led.c deleted file mode 100644 index 4b8038341b9..00000000000 --- a/board/st/stm32f429-discovery/led.c +++ /dev/null @@ -1,39 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* - * (C) Copyright 2015 - * Kamil Lulko, - */ - -#include -#include - -#define RED_LED 110 -#define GREEN_LED 109 - -void coloured_LED_init(void) -{ - gpio_request(RED_LED, "red led"); - gpio_direction_output(RED_LED, 0); - gpio_request(GREEN_LED, "green led"); - gpio_direction_output(GREEN_LED, 0); -} - -void red_led_off(void) -{ - gpio_set_value(RED_LED, 0); -} - -void green_led_off(void) -{ - gpio_set_value(GREEN_LED, 0); -} - -void red_led_on(void) -{ - gpio_set_value(RED_LED, 1); -} - -void green_led_on(void) -{ - gpio_set_value(GREEN_LED, 1); -} From patchwork Sun Nov 3 00:33:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005610 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=J8kkwQGZ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwcs4GyNz1xwV for ; Sun, 3 Nov 2024 11:35:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3E04E8926F; Sun, 3 Nov 2024 01:35:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="J8kkwQGZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2536989137; Sun, 3 Nov 2024 01:35:54 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DBB888928C for ; Sun, 3 Nov 2024 01:35:51 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-20cf6eea3c0so24820225ad.0 for ; Sat, 02 Nov 2024 17:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594150; x=1731198950; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ycrp9IOzXJ+/Tg69wI5pj6r6RKyG4SYJ8FcKJR7XiqY=; b=J8kkwQGZOUn8ZT3grCLFJ5KGnH6eRmhaVGJFl2OAVczHMW0bUZw6SrwQdK9eQdhStg 7XNjMpe2tNkVyXMYe9A4gH3K7+1LoZDaIg4ylSf8ItXEZem4UfoUUsdRpKBVT7rkQz9d 9/hyTQa1w2V1w1gopqeQMY44GpSugcfAuOpGg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594150; x=1731198950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ycrp9IOzXJ+/Tg69wI5pj6r6RKyG4SYJ8FcKJR7XiqY=; b=APLe/VQa9LRStS1PWCYEywA7fH1T48yAkboxHGzhGooHGJR7xJknAWAPNuA2wsS/yu uYln4tEC3MX8laxydNNRQI+cDe8UTmQMb+hq02TP0EqMojDHDiAanSdSf6kRkfDUB9nd tuUrhiIHacfj51EY5F3RwRUiiYRzP2LmhHU5TiV185Tvm7zrInHNguAFydJlZmRXZxhP Yx+xv/9euO6jTDrFjGpcACOviP4wrSjEz4l64rSvLJ3/UadASAFChbZB525vc0SG5vMl AsQMar2WqOV4DmC2tVen3ElIsSPQNmHcXTk2iW4KSHXNdqXmHIbkI+L6bhS0wRkGhOke ILJA== X-Gm-Message-State: AOJu0YxTfYXGp/iRt/XmApMl8J3NF1W3YOchyrtgbXfmHpfdA2ErVDUS EmLfq8BKCu0iADqmlS6FucK01AG9WdP8Sa2uUuiPeqH/M8qISqXKtjJoh6+NmoZBjG+UlMbCfII /VQ== X-Google-Smtp-Source: AGHT+IH4Oj92+iexBLGM5OIniDnC1s1JFcOFCIyfA4rs6kotVf5PdHbvJCme5ZT0EJuhKhZ6myBchw== X-Received: by 2002:a17:902:f543:b0:20b:a5b5:b89 with SMTP id d9443c01a7336-210c6b0171emr351404675ad.35.1730594149765; Sat, 02 Nov 2024 17:35:49 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:35:48 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Christian Marangi , Doug Zobel , Michael Polyntsov , Mikhail Kshevetskiy , Rasmus Villemoes Subject: [PATCH v3 09/25] led: Make the LED config common Date: Sat, 2 Nov 2024 18:33:01 -0600 Message-ID: <20241103003322.626036-10-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Use an if...endif construct to avoid needing to make everything depend on LED. Make SPL_LED depend on LED since that seems reasonable. Signed-off-by: Simon Glass --- (no changes since v1) drivers/led/Kconfig | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig index 268118a6c3a..789113a92b5 100644 --- a/drivers/led/Kconfig +++ b/drivers/led/Kconfig @@ -9,6 +9,8 @@ config LED can provide access to board-specific LEDs. Use of the device tree for configuration is encouraged. +if LED + config LED_BOOT bool "Enable LED boot support" help @@ -35,7 +37,7 @@ config LED_ACTIVITY config LED_BCM6328 bool "LED Support for BCM6328" - depends on LED && ARCH_BMIPS + depends on ARCH_BMIPS help This option enables support for LEDs connected to the BCM6328 LED HW controller accessed via MMIO registers. @@ -46,7 +48,7 @@ config LED_BCM6328 config LED_BCM6358 bool "LED Support for BCM6358" - depends on LED && ARCH_BMIPS + depends on ARCH_BMIPS help This option enables support for LEDs connected to the BCM6358 LED HW controller accessed via MMIO registers. @@ -54,28 +56,28 @@ config LED_BCM6358 config LED_BCM6753 bool "LED Support for BCM6753" - depends on LED && BCM6855 + depends on BCM6855 help This option enables support for LEDs connected to the BCM6753 HW has blinking and fading capabilities and up to 32 LEDs can be controlled. config LED_BCM6858 bool "LED Support for BCM6858" - depends on LED && (BCM6856 || BCM6858 || BCM63158) + depends on BCM6856 || BCM6858 || BCM63158 help This option enables support for LEDs connected to the BCM6858 HW has blinking capabilities and up to 32 LEDs can be controlled. config LED_CORTINA bool "LED Support for Cortina Access CAxxxx SoCs" - depends on LED && (CORTINA_PLATFORM) + depends on CORTINA_PLATFORM help This option enables support for LEDs connected to the Cortina Access CAxxxx SOCs. config LED_LP5562 bool "LED Support for LP5562" - depends on LED && DM_I2C + depends on DM_I2C help This option enables support for LEDs connected to the TI LP5562 4 channel I2C LED controller. Driver fully supports blink on the @@ -83,14 +85,13 @@ config LED_LP5562 config LED_PWM bool "LED PWM" - depends on LED && DM_PWM + depends on DM_PWM help Enable support for LEDs connected to PWM. Linux compatible ofdata. config LED_BLINK bool "Support hardware LED blinking" - depends on LED help Some drivers can support automatic blinking of LEDs with a given period, without needing timers or extra code to handle the timing. @@ -99,7 +100,6 @@ config LED_BLINK config LED_SW_BLINK bool "Support software LED blinking" - depends on LED select CYCLIC help Turns on led blinking implemented in the software, useful when @@ -122,7 +122,7 @@ config SPL_LED config LED_GPIO bool "LED support for GPIO-connected LEDs" - depends on LED && DM_GPIO + depends on DM_GPIO help Enable support for LEDs which are connected to GPIO lines. These GPIOs may be on the SoC or some other device which provides GPIOs. @@ -136,6 +136,8 @@ config SPL_LED_GPIO This option is an SPL-variant of the LED_GPIO option. See the help of LED_GPIO for details. +endif # LED + config LED_STATUS bool "Enable status LED API" help From patchwork Sun Nov 3 00:33:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005611 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=mTw+zYon; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwd75B5Dz1xwV for ; Sun, 3 Nov 2024 11:36:11 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A02D4892CF; Sun, 3 Nov 2024 01:36:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mTw+zYon"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A2DD89145; Sun, 3 Nov 2024 01:36:08 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 787BF89157 for ; Sun, 3 Nov 2024 01:36:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-20c7ee8fe6bso28398385ad.2 for ; Sat, 02 Nov 2024 17:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594163; x=1731198963; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dpmhzd4cwnqvo5o5lCifZV+3oRAHCEtFw6tykX1rN40=; b=mTw+zYonckbK3F6PaYY3NW73pHRd/+DFehBiwirZHOiwUDmogUc0cf1y3343q3V2Su 1lxyDVzmd+NvIpKqJM8CrZvOqxj33Dck1ZcHDtmjqIm0qx3gjHHW9GUlPManhlyt7AVm S1xmFq49U9WkPudCNFerrSTnKidgIPMasFcNQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594163; x=1731198963; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dpmhzd4cwnqvo5o5lCifZV+3oRAHCEtFw6tykX1rN40=; b=okYdQPbqBIlG/U8bJYkeI+o2ZrQU2WllGpyshA8TwNi7fLzQkSjCZUGYrxVIIe0RIG /TMdQ1Pk4Mz2FV6RjYQ5xQfFc+A76O2wC+i/bUm5cRHV5Z7UEQbSaNTE9s5amad3slHE 8uhPUU4h+l9WtIEgJXG8hbw9btWCTl0RRj4xCkQ4th5eyjE1bB+AvmAV2UvZqKXSYKke s5hfU3jR3zl7mG5iwG7x3I1nbmc8oPwLYCpvEWs1ykKHOidw65EtYVCUwqLMC6mGkVI6 sNz35RzYSXB6UHKHKBknPRkIfliIFKEltT9cDfqAAww7Kkpxf7Zq9LmMaIc85/qy7Zo3 aoCg== X-Gm-Message-State: AOJu0YwE7UhD/Z/oAH6avTtqAmgEJlHtV5o0/HxT3lWf5XDvwYP61AWH IhXJVAKeelvmwCrIHdQT3mlVmBV4s/SPbwOFKexkPyVsw41Ogyz820NXaKCQ/SkNud4tuL8ySkV 4fw== X-Google-Smtp-Source: AGHT+IGw2aAS77OWF3yCW7ofxj4VogSDHHfunSX6cGL59EYH5FUreIV7aSL1MtH1XUD/wnCcl7t0hg== X-Received: by 2002:a17:903:22c5:b0:20b:a10c:9bdf with SMTP id d9443c01a7336-210c6c0c4a9mr403141445ad.32.1730594162271; Sat, 02 Nov 2024 17:36:02 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:36:01 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Christian Marangi , Doug Zobel , Michael Polyntsov , Mikhail Kshevetskiy , Rasmus Villemoes Subject: [PATCH v3 10/25] led: Drop LED_STATUS from Kconfig Date: Sat, 2 Nov 2024 18:33:02 -0600 Message-ID: <20241103003322.626036-11-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Drop all of these configs, which are now unused. Signed-off-by: Simon Glass --- (no changes since v1) drivers/led/Kconfig | 316 -------------------------------------------- 1 file changed, 316 deletions(-) diff --git a/drivers/led/Kconfig b/drivers/led/Kconfig index 789113a92b5..379b3ce49a5 100644 --- a/drivers/led/Kconfig +++ b/drivers/led/Kconfig @@ -138,320 +138,4 @@ config SPL_LED_GPIO endif # LED -config LED_STATUS - bool "Enable status LED API" - help - Allows common u-boot commands to use a board's leds to - provide status for activities like booting and downloading files. - -if LED_STATUS - -# Hidden constants - -config LED_STATUS_OFF - int - default 0 - -config LED_STATUS_BLINKING - int - default 1 - -config LED_STATUS_ON - int - default 2 - -# Hidden constants end - -config LED_STATUS_GPIO - bool "GPIO status LED implementation" - help - The status LED can be connected to a GPIO pin. In such cases, the - gpio_led driver can be used as a status LED backend implementation. - -comment "LEDs parameters" - -config LED_STATUS0 - bool "Enable status LED 0" - -if LED_STATUS0 - -config LED_STATUS_BIT - int "identification" - help - CONFIG_LED_STATUS_BIT is passed into the __led_* functions to identify - which LED is being acted on. As such, the chosen value must be unique - with respect to the other CONFIG_LED_STATUS_BIT's. Mapping the value - to a physical LED is the responsibility of the __led_* function. - -config LED_STATUS_STATE - int "initial state" - range LED_STATUS_OFF LED_STATUS_ON - default LED_STATUS_OFF - help - Should be set one of the following: - 0 - off - 1 - blinking - 2 - on - -config LED_STATUS_FREQ - int "blink frequency" - range 2 10 - default 2 - help - The LED blink period calculated from LED_STATUS_FREQ: - LED_STATUS_PERIOD = CONFIG_SYS_HZ/LED_STATUS_FREQ - Values range: 2 - 10 - -endif # LED_STATUS0 - -config LED_STATUS1 - bool "Enable status LED 1" - -if LED_STATUS1 - -config LED_STATUS_BIT1 - int "identification" - help - CONFIG_LED_STATUS_BIT1 is passed into the __led_* functions to - identify which LED is being acted on. As such, the chosen value must - be unique with respect to the other CONFIG_LED_STATUS_BIT's. Mapping - the value to a physical LED is the responsibility of the __led_* - function. - -config LED_STATUS_STATE1 - int "initial state" - range LED_STATUS_OFF LED_STATUS_ON - default LED_STATUS_OFF - help - Should be set one of the following: - 0 - off - 1 - blinking - 2 - on - -config LED_STATUS_FREQ1 - int "blink frequency" - range 2 10 - default 2 - help - The LED blink period calculated from LED_STATUS_FREQ1: - LED_STATUS_PERIOD1 = CONFIG_SYS_HZ/LED_STATUS_FREQ1 - Values range: 2 - 10 - -endif # LED_STATUS1 - -config LED_STATUS2 - bool "Enable status LED 2" - -if LED_STATUS2 - -config LED_STATUS_BIT2 - int "identification" - help - CONFIG_LED_STATUS_BIT2 is passed into the __led_* functions to - identify which LED is being acted on. As such, the chosen value must - be unique with respect to the other CONFIG_LED_STATUS_BIT's. Mapping - the value to a physical LED is the responsibility of the __led_* - function. - -config LED_STATUS_STATE2 - int "initial state" - range LED_STATUS_OFF LED_STATUS_ON - default LED_STATUS_OFF - help - Should be set one of the following: - 0 - off - 1 - blinking - 2 - on - -config LED_STATUS_FREQ2 - int "blink frequency" - range 2 10 - default 2 - help - The LED blink period calculated from LED_STATUS_FREQ2: - LED_STATUS_PERIOD2 = CONFIG_SYS_HZ/LED_STATUS_FREQ2 - Values range: 2 - 10 - -endif # LED_STATUS2 - -config LED_STATUS3 - bool "Enable status LED 3" - -if LED_STATUS3 - -config LED_STATUS_BIT3 - int "identification" - help - CONFIG_LED_STATUS_BIT3 is passed into the __led_* functions to - identify which LED is being acted on. As such, the chosen value must - be unique with respect to the other CONFIG_LED_STATUS_BIT's. Mapping - the value to a physical LED is the responsibility of the __led_* - function. - -config LED_STATUS_STATE3 - int "initial state" - range LED_STATUS_OFF LED_STATUS_ON - default LED_STATUS_OFF - help - Should be set one of the following: - 0 - off - 1 - blinking - 2 - on - -config LED_STATUS_FREQ3 - int "blink frequency" - range 2 10 - default 2 - help - The LED blink period calculated from LED_STATUS_FREQ3: - LED_STATUS_PERIOD3 = CONFIG_SYS_HZ/LED_STATUS_FREQ3 - Values range: 2 - 10 - -endif # LED_STATUS3 - -config LED_STATUS4 - bool "Enable status LED 4" - -if LED_STATUS4 - -config LED_STATUS_BIT4 - int "identification" - help - CONFIG_LED_STATUS_BIT4 is passed into the __led_* functions to - identify which LED is being acted on. As such, the chosen value must - be unique with respect to the other CONFIG_LED_STATUS_BIT's. Mapping - the value to a physical LED is the responsibility of the __led_* - function. - -config LED_STATUS_STATE4 - int "initial state" - range LED_STATUS_OFF LED_STATUS_ON - default LED_STATUS_OFF - help - Should be set one of the following: - 0 - off - 1 - blinking - 2 - on - -config LED_STATUS_FREQ4 - int "blink frequency" - range 2 10 - default 2 - help - The LED blink period calculated from LED_STATUS_FREQ4: - LED_STATUS_PERIOD4 = CONFIG_SYS_HZ/LED_STATUS_FREQ4 - Values range: 2 - 10 - -endif # LED_STATUS4 - -config LED_STATUS5 - bool "Enable status LED 5" - -if LED_STATUS5 - -config LED_STATUS_BIT5 - int "identification" - help - CONFIG_LED_STATUS_BIT5 is passed into the __led_* functions to - identify which LED is being acted on. As such, the chosen value must - be unique with respect to the other CONFIG_LED_STATUS_BIT's. Mapping - the value to a physical LED is the responsibility of the __led_* - function. - -config LED_STATUS_STATE5 - int "initial state" - range LED_STATUS_OFF LED_STATUS_ON - default LED_STATUS_OFF - help - Should be set one of the following: - 0 - off - 1 - blinking - 2 - on - -config LED_STATUS_FREQ5 - int "blink frequency" - range 2 10 - default 2 - help - The LED blink period calculated from LED_STATUS_FREQ5: - LED_STATUS_PERIOD5 = CONFIG_SYS_HZ/LED_STATUS_FREQ5 - Values range: 2 - 10 - -endif # LED_STATUS5 - -config LED_STATUS_BOOT_ENABLE - bool "Enable BOOT LED" - help - Enable to turn an LED on when the board is booting. - -if LED_STATUS_BOOT_ENABLE - -config LED_STATUS_BOOT - int "LED to light when the board is booting" - help - Valid enabled LED device number. - -endif # LED_STATUS_BOOT_ENABLE - -config LED_STATUS_RED_ENABLE - bool "Enable red LED" - help - Enable red status LED. - -if LED_STATUS_RED_ENABLE - -config LED_STATUS_RED - int "Red LED identification" - help - Valid enabled LED device number. - -endif # LED_STATUS_RED_ENABLE - -config LED_STATUS_YELLOW_ENABLE - bool "Enable yellow LED" - help - Enable yellow status LED. - -if LED_STATUS_YELLOW_ENABLE - -config LED_STATUS_YELLOW - int "Yellow LED identification" - help - Valid enabled LED device number. - -endif # LED_STATUS_YELLOW_ENABLE - -config LED_STATUS_BLUE_ENABLE - bool "Enable blue LED" - help - Enable blue status LED. - -if LED_STATUS_BLUE_ENABLE - -config LED_STATUS_BLUE - int "Blue LED identification" - help - Valid enabled LED device number. - -endif # LED_STATUS_BLUE_ENABLE - -config LED_STATUS_GREEN_ENABLE - bool "Enable green LED" - help - Enable green status LED. - -if LED_STATUS_GREEN_ENABLE - -config LED_STATUS_GREEN - int "Green LED identification" - help - Valid enabled LED device number (0-5). - -endif # LED_STATUS_GREEN_ENABLE - -config LED_STATUS_CMD - bool "Enable status LED commands" - -endif # LED_STATUS - endmenu From patchwork Sun Nov 3 00:33:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005612 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=PjHOjMbl; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwdM0Lz3z1xwV for ; Sun, 3 Nov 2024 11:36:21 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F1B9E89157; Sun, 3 Nov 2024 01:36:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="PjHOjMbl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8A19889145; Sun, 3 Nov 2024 01:36:17 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7378D892ED for ; Sun, 3 Nov 2024 01:36:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-7ee020ec76dso2665121a12.3 for ; Sat, 02 Nov 2024 17:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594171; x=1731198971; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=thpjTUOyhnWd/nVJlybJ+mXy6F74da8sVLfOMNC+AKc=; b=PjHOjMblPkHDiY8IkBaTiHeZbokZwixPrut+w8P0ajLUHHVDWf4YhzU/18pFc5QGBb HE9HonPMK8DHugSu1RM2ALvRj58brUINVyPMTTXKkjYMuJIJRu1C9wJfId70e9XfIU80 HhJma8soweZ/oQbJnQpVIfuwJQXhNUhFWOeGE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594171; x=1731198971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=thpjTUOyhnWd/nVJlybJ+mXy6F74da8sVLfOMNC+AKc=; b=vkai3zgp27ggHX1uVwJhmzeU+YcPIORYxUs418Ub+zoMt8dSvCgrvW7yLZaMN62Z75 jFlEyFMg3MVYoBIitC4EZNqZfiMWloP4oJWGQD72tIYQT1jt3hvjyXHcOPzdkF7kB4Li UGJVAABUlaBxRmyOf/I94+oDSdaPXTRLfXbqMcH9eL4mqcrWeivY8J/lw5W/XWUBKTUy ceTlXvEvgdxz/joYUhiF8XQa95FEgNie+u92/4GXuDkYwMuW6v6Eh/fbTnvZjqa8rpZ0 iEftu4w/2gPj6UGv2oANQudt0sLpblfXeKOuNeGDlE+pjVDd/37r/lPQJCCdD5Ivczb2 OJog== X-Gm-Message-State: AOJu0YxSTXqXZ+gYv9jz1Bd+cRTL3NrYf/0426lfTHWCw6zrcUKfFogp 4b7lsa4i0mtuMI2UU8x8KQ7am6Zs0aFnsJMCc+AFe5Ske2nw9eC1+wkbd3Su6sFbPV+uLRec47O /JQ== X-Google-Smtp-Source: AGHT+IGrdfag2sHXPfrK635W8WkXKHHCd9qdsZkifzJUNvtqUJsV8OwDvrGv0FUtY5JY3tIthAMMDA== X-Received: by 2002:a17:902:e890:b0:20c:8abc:733a with SMTP id d9443c01a7336-210c6ca8b77mr384551575ad.53.1730594171201; Sat, 02 Nov 2024 17:36:11 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.36.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:36:10 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Francis Laniel , Heinrich Schuchardt , Ilias Apalodimas , Jerome Forissier Subject: [PATCH v3 11/25] led: Drop the legacy LED command Date: Sat, 2 Nov 2024 18:33:03 -0600 Message-ID: <20241103003322.626036-12-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used by any board. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) cmd/Makefile | 1 - cmd/legacy_led.c | 145 ----------------------------------------------- 2 files changed, 146 deletions(-) delete mode 100644 cmd/legacy_led.c diff --git a/cmd/Makefile b/cmd/Makefile index d1f369deec0..6052c1dd096 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -101,7 +101,6 @@ obj-$(CONFIG_CMD_IRQ) += irq.o obj-$(CONFIG_CMD_ITEST) += itest.o obj-$(CONFIG_CMD_JFFS2) += jffs2.o obj-$(CONFIG_CMD_CRAMFS) += cramfs.o -obj-$(CONFIG_LED_STATUS_CMD) += legacy_led.o obj-$(CONFIG_CMD_LED) += led.o obj-$(CONFIG_CMD_LICENSE) += license.o obj-y += load.o diff --git a/cmd/legacy_led.c b/cmd/legacy_led.c deleted file mode 100644 index ef2135e0dba..00000000000 --- a/cmd/legacy_led.c +++ /dev/null @@ -1,145 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* - * (C) Copyright 2010 - * Jason Kridner - * - * Based on cmd_led.c patch from: - * http://www.mail-archive.com/u-boot@lists.denx.de/msg06873.html - * (C) Copyright 2008 - * Ulf Samuelsson - */ - -#include -#include -#include - -struct led_tbl_s { - char *string; /* String for use in the command */ - led_id_t mask; /* Mask used for calling __led_set() */ - void (*off)(void); /* Optional function for turning LED off */ - void (*on)(void); /* Optional function for turning LED on */ - void (*toggle)(void);/* Optional function for toggling LED */ -}; - -typedef struct led_tbl_s led_tbl_t; - -static const led_tbl_t led_commands[] = { -#ifdef CONFIG_LED_STATUS_GREEN - { "green", CONFIG_LED_STATUS_GREEN, green_led_off, green_led_on, NULL }, -#endif -#ifdef CONFIG_LED_STATUS_YELLOW - { "yellow", CONFIG_LED_STATUS_YELLOW, yellow_led_off, yellow_led_on, - NULL }, -#endif -#ifdef CONFIG_LED_STATUS_RED - { "red", CONFIG_LED_STATUS_RED, red_led_off, red_led_on, NULL }, -#endif -#ifdef CONFIG_LED_STATUS_BLUE - { "blue", CONFIG_LED_STATUS_BLUE, blue_led_off, blue_led_on, NULL }, -#endif - { NULL, 0, NULL, NULL, NULL } -}; - -enum led_cmd { LED_ON, LED_OFF, LED_TOGGLE, LED_BLINK }; - -enum led_cmd get_led_cmd(char *var) -{ - if (strcmp(var, "off") == 0) - return LED_OFF; - if (strcmp(var, "on") == 0) - return LED_ON; - if (strcmp(var, "toggle") == 0) - return LED_TOGGLE; - if (strcmp(var, "blink") == 0) - return LED_BLINK; - - return -1; -} - -/* - * LED drivers providing a blinking LED functionality, like the - * PCA9551, can override this empty weak function - */ -void __weak __led_blink(led_id_t mask, int freq) -{ -} - -int do_legacy_led(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) -{ - int i, match = 0; - enum led_cmd cmd; - int freq; - - /* Validate arguments */ - if ((argc < 3) || (argc > 4)) - return CMD_RET_USAGE; - - cmd = get_led_cmd(argv[2]); - if (cmd < 0) { - return CMD_RET_USAGE; - } - - for (i = 0; led_commands[i].string; i++) { - if ((strcmp("all", argv[1]) == 0) || - (strcmp(led_commands[i].string, argv[1]) == 0)) { - match = 1; - switch (cmd) { - case LED_ON: - if (led_commands[i].on) - led_commands[i].on(); - else - __led_set(led_commands[i].mask, - CONFIG_LED_STATUS_ON); - break; - case LED_OFF: - if (led_commands[i].off) - led_commands[i].off(); - else - __led_set(led_commands[i].mask, - CONFIG_LED_STATUS_OFF); - break; - case LED_TOGGLE: - if (led_commands[i].toggle) - led_commands[i].toggle(); - else - __led_toggle(led_commands[i].mask); - break; - case LED_BLINK: - if (argc != 4) - return CMD_RET_USAGE; - - freq = dectoul(argv[3], NULL); - __led_blink(led_commands[i].mask, freq); - } - /* Need to set only 1 led if led_name wasn't 'all' */ - if (strcmp("all", argv[1]) != 0) - break; - } - } - - /* If we ran out of matches, print Usage */ - if (!match) { - return CMD_RET_USAGE; - } - - return 0; -} - -U_BOOT_CMD( - led, 4, 1, do_legacy_led, - "[" -#ifdef CONFIG_LED_STATUS_GREEN - "green|" -#endif -#ifdef CONFIG_LED_STATUS_YELLOW - "yellow|" -#endif -#ifdef CONFIG_LED_STATUS_RED - "red|" -#endif -#ifdef CONFIG_LED_STATUS_BLUE - "blue|" -#endif - "all] [on|off|toggle|blink] [blink-freq in ms]", - "[led_name] [on|off|toggle|blink] sets or clears led(s)" -); From patchwork Sun Nov 3 00:33:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005613 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Magzt/CP; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwdW1fGqz1xwV for ; Sun, 3 Nov 2024 11:36:31 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8FCA4891AD; Sun, 3 Nov 2024 01:36:28 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Magzt/CP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B0DFA892E5; Sun, 3 Nov 2024 01:36:27 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B05CA892FD for ; Sun, 3 Nov 2024 01:36:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-21145812538so422745ad.0 for ; Sat, 02 Nov 2024 17:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594182; x=1731198982; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=89VitzKhAPiQLFUpFVgGy85iUm85mQAsEP/iKY8QS5w=; b=Magzt/CP7VlaPE3YqZpeD+Kwu/J0GXiaNtQfK2/7csEcxULg5gXvK81mX2e02+351h 2+gsvRZf/5fFBfS3xB7/8vhyQ/Y4OPda1vXfvwauVRpLUHC5s25XE6muAaoAH52csr+/ pizSguPVsoTCIqmU8U09yzf81IZ52+RPqmkR8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594182; x=1731198982; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=89VitzKhAPiQLFUpFVgGy85iUm85mQAsEP/iKY8QS5w=; b=NuabXmQg8hGy+aPt6CSV6hkHcxyQMbm4/pTrJwGY1gki57uysKEx8oSOcgVuHY/IH9 DNOAB/q+9nxLll0rjjEkYHvdwUHzWSuUlvCqFGFMDgNPay0NfH5uV0kGJrtND4iBHTLH a+ZE5T+6MkY+0LcUTAuj+CfXXGSR+X1XCVsTgUMvatLH72Uh8mF0TBqJsoIKrW52A9+6 d3LljEqHr8hcXBKYNcjo6wh4bPE0tuvPMdOJ0Va/x8IgGpegeLiUqWJFxgyJQOXFbqDE d+WbjUqDUXZm8dYhJ3tC8bukzXZu/iImQtwena6pd+767zsv5KKIj28mYX9agoTaRAl6 dNuw== X-Gm-Message-State: AOJu0YwxL2G7INz5c2fnMtbIt1l/707fEqwwkwAryRDGM5YpMjiLSQy9 lMIAt3d5sKXisX0nEui0rwWNMBTs1hjviaf/w9X+NsVyN+QMPE4X/pdnc3MthhwSjdIe+SG6Mrd lCw== X-Google-Smtp-Source: AGHT+IERyV3XqmUYSiMA28n9iErRKdFmB+SqDMGK+DpUx/uohoOKxo1+JQQ8IxP2FThDSLbBrICbrA== X-Received: by 2002:a17:903:2442:b0:20c:5cdd:a9e with SMTP id d9443c01a7336-210c6c02482mr347884335ad.28.1730594181879; Sat, 02 Nov 2024 17:36:21 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.36.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:36:21 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Caleb Connolly , Heinrich Schuchardt , Jonas Karlman , =?utf-8?q?Marek_Beh=C3=BAn?= , Tien Fong Chee , Wan Yee Lau Subject: [PATCH v3 12/25] misc: Drop gpio_led driver Date: Sat, 2 Nov 2024 18:33:04 -0600 Message-ID: <20241103003322.626036-13-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used anymore, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/misc/Makefile | 1 - drivers/misc/gpio_led.c | 106 ---------------------------------------- 2 files changed, 107 deletions(-) delete mode 100644 drivers/misc/gpio_led.c diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index dac805e4cdd..b7332587faa 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -49,7 +49,6 @@ obj-$(CONFIG_IHS_FPGA) += ihs_fpga.o obj-$(CONFIG_IMX8) += imx8/ obj-$(CONFIG_IMX_ELE) += imx_ele/ obj-$(CONFIG_LED_STATUS) += status_led.o -obj-$(CONFIG_LED_STATUS_GPIO) += gpio_led.o obj-$(CONFIG_MPC83XX_SERDES) += mpc83xx_serdes.o obj-$(CONFIG_$(PHASE_)LS2_SFP) += ls2_sfp.o obj-$(CONFIG_$(XPL_)MXC_OCOTP) += mxc_ocotp.o diff --git a/drivers/misc/gpio_led.c b/drivers/misc/gpio_led.c deleted file mode 100644 index e63689967a7..00000000000 --- a/drivers/misc/gpio_led.c +++ /dev/null @@ -1,106 +0,0 @@ -/* - * Status LED driver based on GPIO access conventions of Linux - * - * Copyright (C) 2010 Thomas Chou - * Licensed under the GPL-2 or later. - */ - -#include -#include - -#ifndef CFG_GPIO_LED_INVERTED_TABLE -#define CFG_GPIO_LED_INVERTED_TABLE {} -#endif - -static led_id_t gpio_led_inv[] = CFG_GPIO_LED_INVERTED_TABLE; - -static int gpio_led_gpio_value(led_id_t mask, int state) -{ - int i, gpio_value = (state == CONFIG_LED_STATUS_ON); - - for (i = 0; i < ARRAY_SIZE(gpio_led_inv); i++) { - if (gpio_led_inv[i] == mask) - gpio_value = !gpio_value; - } - - return gpio_value; -} - -void __led_init(led_id_t mask, int state) -{ - int gpio_value; - - if (gpio_request(mask, "gpio_led") != 0) { - printf("%s: failed requesting GPIO%lu!\n", __func__, mask); - return; - } - - gpio_value = gpio_led_gpio_value(mask, state); - gpio_direction_output(mask, gpio_value); -} - -void __led_set(led_id_t mask, int state) -{ - int gpio_value = gpio_led_gpio_value(mask, state); - - gpio_set_value(mask, gpio_value); -} - -void __led_toggle(led_id_t mask) -{ - gpio_set_value(mask, !gpio_get_value(mask)); -} - -#ifdef CONFIG_GPIO_LED_STUBS - -/* 'generic' override of colored LED stubs, to use GPIO functions instead */ - -#ifdef CONFIG_LED_STATUS_RED -void red_led_on(void) -{ - __led_set(CONFIG_LED_STATUS_RED, CONFIG_LED_STATUS_ON); -} - -void red_led_off(void) -{ - __led_set(CONFIG_LED_STATUS_RED, CONFIG_LED_STATUS_OFF); -} -#endif - -#ifdef CONFIG_LED_STATUS_GREEN -void green_led_on(void) -{ - __led_set(CONFIG_LED_STATUS_GREEN, CONFIG_LED_STATUS_ON); -} - -void green_led_off(void) -{ - __led_set(CONFIG_LED_STATUS_GREEN, CONFIG_LED_STATUS_OFF); -} -#endif - -#ifdef CONFIG_LED_STATUS_YELLOW -void yellow_led_on(void) -{ - __led_set(CONFIG_LED_STATUS_YELLOW, CONFIG_LED_STATUS_ON); -} - -void yellow_led_off(void) -{ - __led_set(CONFIG_LED_STATUS_YELLOW, CONFIG_LED_STATUS_OFF); -} -#endif - -#ifdef CONFIG_LED_STATUS_BLUE -void blue_led_on(void) -{ - __led_set(CONFIG_LED_STATUS_BLUE, CONFIG_LED_STATUS_ON); -} - -void blue_led_off(void) -{ - __led_set(CONFIG_LED_STATUS_BLUE, CONFIG_LED_STATUS_OFF); -} -#endif - -#endif /* CONFIG_GPIO_LED_STUBS */ From patchwork Sun Nov 3 00:33:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005614 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=hOJg9PRE; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwdn0hQBz1xwV for ; Sun, 3 Nov 2024 11:36:40 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0FBF4892EA; Sun, 3 Nov 2024 01:36:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="hOJg9PRE"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B370892ED; Sun, 3 Nov 2024 01:36:37 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9285389300 for ; Sun, 3 Nov 2024 01:36:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-20c8c50fdd9so27404595ad.0 for ; Sat, 02 Nov 2024 17:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594192; x=1731198992; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UoKVjYTaokoC06XTEbnI0rWMNIaMByupWKue3WgPWqg=; b=hOJg9PREZgOW1LGAzTHK4wd2dPxZgZP2nWloZ/+qsITG+nDwzpVQqk5dt+KeSEz6+2 NMEROPNbgAVeQ8Krcbf7PtnyQIYI8RYrTdbSaKZpZs30MlYExNgHx056qPsX3Rlmg1u9 nE3eSlo0yl4PCVzKv6IQkZtLoPZzTU6AGZR1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594192; x=1731198992; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UoKVjYTaokoC06XTEbnI0rWMNIaMByupWKue3WgPWqg=; b=rLmhgYF6OWNShkZf0NsvQ6ZDZxwHMkh/jLGFsSFUoADXf86R75FglERpNJo1mfhYcK aK0Ie5YkTYLcNiZo3r4y1qO5yNxHyzlHPDpjC4SH4TicFwvaGm6K5W5iQjz85yY4l5pK 2F/bgEUEerYBRhgJ+4U7T1exguCWlWnGQacw89+1tnzOiEj3bBMZ4LJfs5a9F98/HqYu BXoTeYKNG8LbAnub++++9XOgdK5hP3Rkv/xvMLxIkvpdHlCa7ZX/EhHharUaHwJDcFJg hOHhA+6ImH6PmN4LDILCyHXZsK9nzvN2nOtR3JHfpg1Qivd3EgY3XAIIvF4R7g4Db+DV CQeA== X-Gm-Message-State: AOJu0YyhOHZ+knxjNngC43if4zvUfqwOd80p6CiTh/5JNNGCQVyBrwsL ayn3f1yLsYNqGwijhGG7cL3BcFhxxaZlSYSPOKu0Qfh3hIaR8XeVarZh3xkUN+DV9+WdlZxsEqe fFQ== X-Google-Smtp-Source: AGHT+IEhOAD/N3panq5ZqRiFN7yGv2/CeaAmLmIpex/HZTeMZJIkIu8MBV+RGSIol7j+r+P6sDgT4A== X-Received: by 2002:a17:902:ec8e:b0:211:2fb2:6a6 with SMTP id d9443c01a7336-2112fb206e3mr65595945ad.24.1730594192382; Sat, 02 Nov 2024 17:36:32 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:36:31 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Alexander Gendin , Caleb Connolly , Heinrich Schuchardt , Jonas Karlman , =?utf-8?q?Marek_Beh=C3=BAn?= , Stefan Roese , Wan Yee Lau Subject: [PATCH v3 13/25] pca9551_led: Delete driver Date: Sat, 2 Nov 2024 18:33:05 -0600 Message-ID: <20241103003322.626036-14-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This driver is not used anymore. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/misc/Kconfig | 13 --- drivers/misc/Makefile | 1 - drivers/misc/pca9551_led.c | 170 ------------------------------------- 3 files changed, 184 deletions(-) delete mode 100644 drivers/misc/pca9551_led.c diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 6009d55f400..23eb509d974 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -446,19 +446,6 @@ config SPL_PWRSEQ device. When the device is started up, its power sequence can be initiated. -config PCA9551_LED - bool "Enable PCA9551 LED driver" - help - Enable driver for PCA9551 LED controller. This controller - is connected via I2C. So I2C needs to be enabled. - -config PCA9551_I2C_ADDR - hex "I2C address of PCA9551 LED controller" - depends on PCA9551_LED - default 0x60 - help - The I2C address of the PCA9551 LED controller. - config STM32MP_FUSE bool "Enable STM32MP fuse wrapper providing the fuse API" depends on ARCH_STM32MP && MISC diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index b7332587faa..e8f48228084 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -57,7 +57,6 @@ obj-$(CONFIG_NPCM_OTP) += npcm_otp.o obj-$(CONFIG_NPCM_HOST) += npcm_host_intf.o obj-$(CONFIG_NUVOTON_NCT6102D) += nuvoton_nct6102d.o obj-$(CONFIG_P2SB) += p2sb-uclass.o -obj-$(CONFIG_PCA9551_LED) += pca9551_led.o obj-$(CONFIG_$(XPL_)PWRSEQ) += pwrseq-uclass.o ifdef CONFIG_QFW obj-y += qfw.o diff --git a/drivers/misc/pca9551_led.c b/drivers/misc/pca9551_led.c deleted file mode 100644 index 040d0d5cf48..00000000000 --- a/drivers/misc/pca9551_led.c +++ /dev/null @@ -1,170 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* - * Copyright (C) 2015 Stefan Roese - */ - -#include -#include -#include - -#ifndef CONFIG_PCA9551_I2C_ADDR -#error "CONFIG_PCA9551_I2C_ADDR not defined!" -#endif - -#define PCA9551_REG_INPUT 0x00 /* Input register (read only) */ -#define PCA9551_REG_PSC0 0x01 /* Frequency prescaler 0 */ -#define PCA9551_REG_PWM0 0x02 /* PWM0 */ -#define PCA9551_REG_PSC1 0x03 /* Frequency prescaler 1 */ -#define PCA9551_REG_PWM1 0x04 /* PWM1 */ -#define PCA9551_REG_LS0 0x05 /* LED0 to LED3 selector */ -#define PCA9551_REG_LS1 0x06 /* LED4 to LED7 selector */ - -#define PCA9551_CTRL_AI (1 << 4) /* Auto-increment flag */ - -#define PCA9551_LED_STATE_ON 0x00 -#define PCA9551_LED_STATE_OFF 0x01 -#define PCA9551_LED_STATE_BLINK0 0x02 -#define PCA9551_LED_STATE_BLINK1 0x03 - -struct pca9551_blink_rate { - u8 psc; /* Frequency preescaler, see PCA9551_7.pdf p. 6 */ - u8 pwm; /* Pulse width modulation, see PCA9551_7.pdf p. 6 */ -}; - -static int freq_last = -1; -static int mask_last = -1; -static int idx_last = -1; -static int mode_last; - -static int pca9551_led_get_state(int led, int *state) -{ - unsigned int reg; - u8 shift, buf; - int ret; - - if (led < 0 || led > 7) { - return -EINVAL; - } else if (led < 4) { - reg = PCA9551_REG_LS0; - shift = led << 1; - } else { - reg = PCA9551_REG_LS1; - shift = (led - 4) << 1; - } - - ret = i2c_read(CONFIG_PCA9551_I2C_ADDR, reg, 1, &buf, 1); - if (ret) - return ret; - - *state = (buf >> shift) & 0x03; - return 0; -} - -static int pca9551_led_set_state(int led, int state) -{ - unsigned int reg; - u8 shift, buf, mask; - int ret; - - if (led < 0 || led > 7) { - return -EINVAL; - } else if (led < 4) { - reg = PCA9551_REG_LS0; - shift = led << 1; - } else { - reg = PCA9551_REG_LS1; - shift = (led - 4) << 1; - } - mask = 0x03 << shift; - - ret = i2c_read(CONFIG_PCA9551_I2C_ADDR, reg, 1, &buf, 1); - if (ret) - return ret; - - buf = (buf & ~mask) | ((state & 0x03) << shift); - - ret = i2c_write(CONFIG_PCA9551_I2C_ADDR, reg, 1, &buf, 1); - if (ret) - return ret; - - return 0; -} - -static int pca9551_led_set_blink_rate(int idx, struct pca9551_blink_rate rate) -{ - unsigned int reg; - int ret; - - switch (idx) { - case 0: - reg = PCA9551_REG_PSC0; - break; - case 1: - reg = PCA9551_REG_PSC1; - break; - default: - return -EINVAL; - } - reg |= PCA9551_CTRL_AI; - - ret = i2c_write(CONFIG_PCA9551_I2C_ADDR, reg, 1, (u8 *)&rate, 2); - if (ret) - return ret; - - return 0; -} - -/* - * Functions referenced by cmd_led.c or status_led.c - */ -void __led_init(led_id_t id, int state) -{ -} - -void __led_set(led_id_t mask, int state) -{ - if (state == CONFIG_LED_STATUS_OFF) - pca9551_led_set_state(mask, PCA9551_LED_STATE_OFF); - else - pca9551_led_set_state(mask, PCA9551_LED_STATE_ON); -} - -void __led_toggle(led_id_t mask) -{ - int state = 0; - - pca9551_led_get_state(mask, &state); - pca9551_led_set_state(mask, !state); -} - -void __led_blink(led_id_t mask, int freq) -{ - struct pca9551_blink_rate rate; - int mode; - int idx; - - if ((freq == freq_last) || (mask == mask_last)) { - idx = idx_last; - mode = mode_last; - } else { - /* Toggle blink index */ - if (idx_last == 0) { - idx = 1; - mode = PCA9551_LED_STATE_BLINK1; - } else { - idx = 0; - mode = PCA9551_LED_STATE_BLINK0; - } - - idx_last = idx; - mode_last = mode; - } - freq_last = freq; - mask_last = mask; - - rate.psc = ((freq * 38) / 1000) - 1; - rate.pwm = 128; /* 50% duty cycle */ - - pca9551_led_set_blink_rate(idx, rate); - pca9551_led_set_state(mask, mode); -} From patchwork Sun Nov 3 00:33:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005615 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=ZbgYpOe+; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwdv5Vc8z1xxN for ; Sun, 3 Nov 2024 11:36:51 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 714EA89145; Sun, 3 Nov 2024 01:36:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ZbgYpOe+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF3C28911A; Sun, 3 Nov 2024 01:36:48 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 30CB0892FD for ; Sun, 3 Nov 2024 01:36:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x533.google.com with SMTP id 41be03b00d2f7-7d4fa972cbeso2347262a12.2 for ; Sat, 02 Nov 2024 17:36:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594203; x=1731199003; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d0RWAbjFH6JwbiIniusRi0ZpMAwp3s8KBSo0/2SQ2qw=; b=ZbgYpOe+hOwRTGUHcpesXz/7Hxdy4KNmA1+WEOF8HEGkNzlXu4w1SD80jkYJhnYjqm Ts1mehstRgZCLag0tQbjatLgcwX+3BgRY7xiRwtYYeQWrROwj53S27wF76Tm8EnRvx0+ bP+MS+zvvn6+0UkvF801Di2LRa+iAEW71issY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594203; x=1731199003; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d0RWAbjFH6JwbiIniusRi0ZpMAwp3s8KBSo0/2SQ2qw=; b=njkltlRyVTnIxYYeN4ngch40p0URAmEHol1dRId/sDH1Mz9VWIvRszP+O6oHiFYTFB I7YoxU4caBCTZBhzQB0MwZDdg6RVe4jGpBqIIFkyMKcxqzND5mOIH5xeK+TxVOXg5LyN h308hxEYyR6nnFbKKEr+2ttZ0n23o7gtlRVekw7WOxFY+YQ2UwkwCHH1QjiO9U+RZea/ MgXB9Gx4T2/Ofpi5MWJWW3MwU1yVihFRPgEWvOCl4i3c7Vzj2F6kXkE4y+XDBRYLdsbV uQfFlcfIJwgAkzHu/c+//EUbfFmHUwUlpQpmw2Wp524LRqis6DRDr7sDMsgONH/vJtj+ zB7w== X-Gm-Message-State: AOJu0YwOV5HzFWqs53mMTL+nPAEZ9Ed2hWb80qiQlpBne0HgGWCNmsuQ alBcU6I+TrE54ZDxEWRNvL8MB1G9GBMSXUXraEVW44dV2BvekjITKhP1cdUWQUJUxTkaP0/xLJ+ ULg== X-Google-Smtp-Source: AGHT+IGRrCKI+6J9mTeibn2LE02WJQuFZs/DVmwef+DRlvbOvRabeOemBlqGyF08L76kObudbnfz5Q== X-Received: by 2002:a17:902:d543:b0:20c:7661:dcbf with SMTP id d9443c01a7336-210c6c95170mr317293115ad.55.1730594203602; Sat, 02 Nov 2024 17:36:43 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:36:42 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Caleb Connolly , Heinrich Schuchardt , Ilias Apalodimas , =?utf-8?q?Marek_Beh=C3=BAn?= , Stefan Roese , Wan Yee Lau Subject: [PATCH v3 14/25] misc: status_led: Delete driver Date: Sat, 2 Nov 2024 18:33:06 -0600 Message-ID: <20241103003322.626036-15-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This driver is not used anymore. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/misc/Makefile | 1 - drivers/misc/status_led.c | 124 -------------------------------------- 2 files changed, 125 deletions(-) delete mode 100644 drivers/misc/status_led.c diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index e8f48228084..e975559fd75 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -48,7 +48,6 @@ obj-$(CONFIG_$(XPL_)I2C_EEPROM) += i2c_eeprom.o obj-$(CONFIG_IHS_FPGA) += ihs_fpga.o obj-$(CONFIG_IMX8) += imx8/ obj-$(CONFIG_IMX_ELE) += imx_ele/ -obj-$(CONFIG_LED_STATUS) += status_led.o obj-$(CONFIG_MPC83XX_SERDES) += mpc83xx_serdes.o obj-$(CONFIG_$(PHASE_)LS2_SFP) += ls2_sfp.o obj-$(CONFIG_$(XPL_)MXC_OCOTP) += mxc_ocotp.o diff --git a/drivers/misc/status_led.c b/drivers/misc/status_led.c deleted file mode 100644 index 3b1baa4f840..00000000000 --- a/drivers/misc/status_led.c +++ /dev/null @@ -1,124 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0+ -/* - * (C) Copyright 2000-2003 - * Wolfgang Denk, DENX Software Engineering, wd@denx.de. - */ - -#include -#include - -/* - * The purpose of this code is to signal the operational status of a - * target which usually boots over the network; while running in - * U-Boot, a status LED is blinking. As soon as a valid BOOTP reply - * message has been received, the LED is turned off. The Linux - * kernel, once it is running, will start blinking the LED again, - * with another frequency. - */ - -/* ------------------------------------------------------------------------- */ - -typedef struct { - led_id_t mask; - int state; - int period; - int cnt; -} led_dev_t; - -led_dev_t led_dev[] = { - { CONFIG_LED_STATUS_BIT, - CONFIG_LED_STATUS_STATE, - LED_STATUS_PERIOD, - 0, - }, -#if defined(CONFIG_LED_STATUS1) - { CONFIG_LED_STATUS_BIT1, - CONFIG_LED_STATUS_STATE1, - LED_STATUS_PERIOD1, - 0, - }, -#endif -#if defined(CONFIG_LED_STATUS2) - { CONFIG_LED_STATUS_BIT2, - CONFIG_LED_STATUS_STATE2, - LED_STATUS_PERIOD2, - 0, - }, -#endif -#if defined(CONFIG_LED_STATUS3) - { CONFIG_LED_STATUS_BIT3, - CONFIG_LED_STATUS_STATE3, - LED_STATUS_PERIOD3, - 0, - }, -#endif -#if defined(CONFIG_LED_STATUS4) - { CONFIG_LED_STATUS_BIT4, - CONFIG_LED_STATUS_STATE4, - LED_STATUS_PERIOD4, - 0, - }, -#endif -#if defined(CONFIG_LED_STATUS5) - { CONFIG_LED_STATUS_BIT5, - CONFIG_LED_STATUS_STATE5, - LED_STATUS_PERIOD5, - 0, - }, -#endif -}; - -#define MAX_LED_DEV (sizeof(led_dev)/sizeof(led_dev_t)) - -static int status_led_init_done = 0; - -void status_led_init(void) -{ - led_dev_t *ld; - int i; - - for (i = 0, ld = led_dev; i < MAX_LED_DEV; i++, ld++) - __led_init (ld->mask, ld->state); - status_led_init_done = 1; -} - -void status_led_tick(ulong timestamp) -{ - led_dev_t *ld; - int i; - - if (!status_led_init_done) - status_led_init(); - - for (i = 0, ld = led_dev; i < MAX_LED_DEV; i++, ld++) { - - if (ld->state != CONFIG_LED_STATUS_BLINKING) - continue; - - if (++ld->cnt >= ld->period) { - __led_toggle (ld->mask); - ld->cnt -= ld->period; - } - - } -} - -void status_led_set(int led, int state) -{ - led_dev_t *ld; - - if (led < 0 || led >= MAX_LED_DEV) - return; - - if (!status_led_init_done) - status_led_init(); - - ld = &led_dev[led]; - - ld->state = state; - if (state == CONFIG_LED_STATUS_BLINKING) { - ld->cnt = 0; /* always start with full period */ - state = CONFIG_LED_STATUS_ON; /* always start with LED _ON_ */ - } - __led_set (ld->mask, state); -} From patchwork Sun Nov 3 00:33:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005616 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=P+pd7T1s; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwfP05STz1xwV for ; Sun, 3 Nov 2024 11:37:14 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4A4D2892EF; Sun, 3 Nov 2024 01:37:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="P+pd7T1s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AD91A892EF; Sun, 3 Nov 2024 01:37:07 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 92A8B892FD for ; Sun, 3 Nov 2024 01:37:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-20c8b557f91so31880325ad.2 for ; Sat, 02 Nov 2024 17:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594223; x=1731199023; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gIXCGkn24D5NedgufXfJ/+lgpVoclNjfjstmsmoRbh8=; b=P+pd7T1szVRUkHIRHvlWCZLuOakufGW1MvlCJ4bIbNjhGue/5z5ebr8Oo4A2opGSQM bIFN4AjuOXMNJ/Zpb/IdKu8P5utDl6Cu/snz1XAwPwYqfGj+ESgPf9ecw7WTE/dlpjVI LXXY7bIiuqJquOaSLrRmu6WivI6XWb0ovLrSU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594223; x=1731199023; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gIXCGkn24D5NedgufXfJ/+lgpVoclNjfjstmsmoRbh8=; b=YSrZ4C+SyneoOQj1E1TckmzyXe+xOubz8BJPsBenyp+KV0Da+4mwhUm6oEtzaZXRWL dzp7dpbHrOSsaq6dq7pY/icC05YTFwKzes8HdLGFhMzJkRzcWmfazYDBJKxfsLj8uj8D 2RniwcBglXhkgE1IoNggLTwh9HWfOEC3YtdPSte6fSGlEX8PhD7WmmQinCEMqFfVJ/dj SiFwUoOGesrWJqbNa9Jgq0TKYoF2Cx8pvtwGPWkopHIbWCAUFqUv3pI70j1D2lDuK5f2 +tT8MVd0PQbxa+HBTyZ97NpGRvFoNWO3Zr/TP15jVlvJ5JCUXWgnfgB2aL6sg+/kN3o5 XKSg== X-Gm-Message-State: AOJu0YyNtAhrRuS6gEoXPhaN7HdBmcVkIg799pinw7I1tgH9C6Q5Bme7 qKoCYNxBitTtHb/dXUYKEDfi7G36++50KOggZwLshvBw0KWm0DqsNQjANnt0M4g3DP6fH7aRLdD Unw== X-Google-Smtp-Source: AGHT+IHvmv70uFdZvfzeynXi6syQofj2SZViRvQYVJLI/YQ6kC57lsB93DLemnaUqllExKvBIUZ3UA== X-Received: by 2002:a17:902:c94c:b0:20c:d93c:440 with SMTP id d9443c01a7336-210c6c1f28emr366510785ad.35.1730594223455; Sat, 02 Nov 2024 17:37:03 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:37:02 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Alison Wang , Angelo Dureghello , Angelo Dureghello , Ilias Apalodimas , Sughosh Ganu Subject: [PATCH v3 15/25] m68k: Drop unused status_led.h header file Date: Sat, 2 Nov 2024 18:33:07 -0600 Message-ID: <20241103003322.626036-16-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This header file is not used, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/m68k/lib/bootm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/m68k/lib/bootm.c b/arch/m68k/lib/bootm.c index 3dcff8076e3..1fa112f8dbf 100644 --- a/arch/m68k/lib/bootm.c +++ b/arch/m68k/lib/bootm.c @@ -15,9 +15,6 @@ #include #include #include -#ifdef CONFIG_SHOW_BOOT_PROGRESS -# include -#endif DECLARE_GLOBAL_DATA_PTR; From patchwork Sun Nov 3 00:33:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005617 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Y460WEBs; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwfk4vHbz1xxN for ; Sun, 3 Nov 2024 11:37:34 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 60E428880B; Sun, 3 Nov 2024 01:37:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Y460WEBs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6A90C88C86; Sun, 3 Nov 2024 01:37:31 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 45FF8887D1 for ; Sun, 3 Nov 2024 01:37:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-20c714cd9c8so31825925ad.0 for ; Sat, 02 Nov 2024 17:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594247; x=1731199047; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QHcwj0rObk3fxVh33XzqEPzdZsBSzjoKUA3Y30a3bIY=; b=Y460WEBshNevHK0bqxUzXX+Xcr+Jv5AqLXNbGUCrgfdin4SwoHce5AjOo78RvScR/3 +WfYwLlNagvLQXsEujfUlT0DL+EVLwSgu0Zj9mv4Rf5tRKu9UeTirH5Sg3azdaSONZDr WvT57DLgaDiFOg7tJ9nm1ZTgfwLVCiM/6QfQQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594247; x=1731199047; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QHcwj0rObk3fxVh33XzqEPzdZsBSzjoKUA3Y30a3bIY=; b=C30PcLcysEOLwlD8x/HKhkddtyyJjguOn9eSHyKi3ehw+I3SWRLDIW0g8CyU3/4VjJ MiVEuAIG7wfr3UK2MWtZC0jEGxjl93Wi6LMwm36jndkeqjJzu+MFIIf/Wyqti5DowvMT xAy53e5uqB/MjMRq+oW8fqEZy6zVzxUhRD8Z3VjVTripBcIUJOLgGgvwZ3r+n6i2E0YS jLYkbefOBk70qZkvor7B7S0LY8i1rdwurd6fEC5TCIx2ZWHzbINNEhhLsBKqVR865qQj lu+v32i6mtgxGImGjSRc+gq5b8UcJEfD66s4AbUjJYUc4qz5sOIg5PnfqX8HcdKonReo Ckig== X-Gm-Message-State: AOJu0Yyr2yOscOBcuTN7Kz8cKnRiXqY74A1UR2rTJST3bVtEiIyYsH/k /lh/JSTgWY/VMt5BHibHtt5YDQHFI5HdHyXZ14JWSO8yNMPN8vU7DDCAfHcAvuwpAkMW1zGQ6mi 6zA== X-Google-Smtp-Source: AGHT+IE9uohMwwpdzPYikLK/+0kyHT4PvfvCh0FFZDfTtbQk6IDE5kxjAYuspXrdcJXjZvwTccS4Bw== X-Received: by 2002:a17:903:187:b0:211:31ac:89eb with SMTP id d9443c01a7336-21131ac8e59mr49756525ad.11.1730594246763; Sat, 02 Nov 2024 17:37:26 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.37.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:37:26 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Andy Fleming , Marek Vasut , Mario Six , Priyanka Jain , Stefan Roese , Wolfgang Denk Subject: [PATCH v3 16/25] powerpc: Drop status-LED code Date: Sat, 2 Nov 2024 18:33:08 -0600 Message-ID: <20241103003322.626036-17-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used anymore, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/powerpc/lib/interrupts.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/arch/powerpc/lib/interrupts.c b/arch/powerpc/lib/interrupts.c index 46208ae4c71..a2e7101a9d1 100644 --- a/arch/powerpc/lib/interrupts.c +++ b/arch/powerpc/lib/interrupts.c @@ -11,9 +11,6 @@ #include #include #include -#ifdef CONFIG_LED_STATUS -#include -#endif #include #ifndef CONFIG_MPC83XX_TIMER @@ -83,9 +80,6 @@ void timer_interrupt(struct pt_regs *regs) schedule(); #endif /* CONFIG_WATCHDOG || CONFIG_HW_WATCHDOG */ -#ifdef CONFIG_LED_STATUS - status_led_tick(timestamp); -#endif /* CONFIG_LED_STATUS */ } ulong get_timer (ulong base) From patchwork Sun Nov 3 00:33:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005618 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=d+ON/O3f; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwg10dz2z1xwV for ; Sun, 3 Nov 2024 11:37:49 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C6534890DF; Sun, 3 Nov 2024 01:37:46 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="d+ON/O3f"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 232CC89119; Sun, 3 Nov 2024 01:37:46 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 069DE8908F for ; Sun, 3 Nov 2024 01:37:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-20caccadbeeso32898915ad.2 for ; Sat, 02 Nov 2024 17:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594262; x=1731199062; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WPjKigl4EG0qwFglAgJBQm00iJMytKBfGab7aZpEBZ8=; b=d+ON/O3f3yX8wB8QFoQ4GP2Ue8Cpgs0CVwulKNMnkcZiE6JGKRgcl2HvP4AmhNo24n A8KQjn4KrI2pEU+1CZyzXzQNe8nii25Vo71GDNf2dEpzcwvVpapDSU7wHMMJ8iZHcvjS IbtsgNCd3m9TI3zK2IXSeEvle4nETxUpcQurE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594262; x=1731199062; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WPjKigl4EG0qwFglAgJBQm00iJMytKBfGab7aZpEBZ8=; b=jGEBSo2lt4XUi9iAWo+rEDYuM44tFHiVOWMZom7pydoNlejMU3XTYqlZRTnBVUdkMx zg5O3xY3fZYxHbpm+aOp1yHgsqWFlyx/6UR7UG4RtfEIn7JMguIrsGBI9gYsCQH2TS1x kGGepO0tvFbuZOvQuVar/Lh/6dJx9Xqu8pKdqC8aKmFQOovE5+haMeelLG1u4nuHz+d9 fo7ATvilIYucOpTVFY0SynPyvRiLd6Ulsv7UTBzp6mqFK1zDgkUO1U2rJOCg5pz3pJOI QJ9+DzeT+IhFYw6S5n9FbPOUZ4OpOCy7ikpK7ftJxQ6U+nVBzbvNrBRW5MEXGiqOJ6/D RobQ== X-Gm-Message-State: AOJu0YzNUUc7BX/zmgr4BLDX7fj5kKs7VaIqKT0jyTD8KT6UHSjNAeS9 CybGVJPen6rXArMRVpjn3F8eo1LJlpiovE7p9v01JXfFml170Mq672TGW/jxlFsLppIMKabXid5 1Mg== X-Google-Smtp-Source: AGHT+IEYl4wvx5H/3g2lwasoXiaC++4h9sOJl/uojb0/0yR6d/K44yASYHeFHJpqMLCDZmlsqD4HaQ== X-Received: by 2002:a17:902:ec85:b0:20c:e6e4:9d9f with SMTP id d9443c01a7336-21103c5a332mr148976025ad.40.1730594261980; Sat, 02 Nov 2024 17:37:41 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.37.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:37:41 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Javier Martinez Canillas , Enric Balletbo i Serra Subject: [PATCH v3 17/25] igep00x0: Drop unused status_led.h header file Date: Sat, 2 Nov 2024 18:33:09 -0600 Message-ID: <20241103003322.626036-18-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This header file is not used, so drop it. Signed-off-by: Simon Glass Reviewed-by: Javier Martinez Canillas --- (no changes since v1) board/isee/igep00x0/igep00x0.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c index a35a7cd3b1f..35bb8c55806 100644 --- a/board/isee/igep00x0/igep00x0.c +++ b/board/isee/igep00x0/igep00x0.c @@ -8,7 +8,6 @@ #include #include #include -#include #include #include #include From patchwork Sun Nov 3 00:33:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005619 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=LOJ/USza; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwgP57Slz1xwV for ; Sun, 3 Nov 2024 11:38:09 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 649E98908F; Sun, 3 Nov 2024 01:38:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LOJ/USza"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5DC08890F8; Sun, 3 Nov 2024 01:38:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3A54C8908F for ; Sun, 3 Nov 2024 01:38:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-7ea9739647bso2243707a12.0 for ; Sat, 02 Nov 2024 17:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594281; x=1731199081; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PPEFC5UuvFfHW/m5jiHYWWxLBS9DLPYeUD5NuPr2exU=; b=LOJ/USzaxJg7CBOBJEmuRmA4kNbGyoYyUttsuOPC20rDAeci5vuYz81VdDVAA4pl1M MlHwa5Xd/2ToI0BtF/DEElpHx3qTPOB11yh60qbwr50jn7TaZ7vWiuRgui9V+2QInaES Krxc+ZPTdqPV4ZOoTzyPOepKZAZY0Mj+sS2Hg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594281; x=1731199081; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PPEFC5UuvFfHW/m5jiHYWWxLBS9DLPYeUD5NuPr2exU=; b=YcR8H4qOfUXI5OweeJNR7lDVVVMsQgDPBiQLFbb5wpL+pccsJjNlBEfbD6v6KG56ec LoUkleWi9e0wKkXriqgk2/Bw4eSnPlc5Fja08VNY9ZtcoiI/qd4J1WiZ6hncG67fYstl QBzvWe19QY7uEa9rz+KUF2ST3FGkWZh7ipFCzO9rgrUiuyOa48S7Dx9INyLprDjuQyC3 wP/4Qo/LGlP0X9AVDxKjYMiyc3G6QQ8tEt21ULqJIMhIW4+3xnjaNdVy+UI5OMplKgdR HIcIURWKgfVkCZJwO4f3zblGWo9kHQYCSgYaAGQeDfSI9HEJCt6p91R+u/2TL1RwWBR0 oukw== X-Gm-Message-State: AOJu0YyzTphQ4hkV59/ft2KHyEWG+aN57z6o8lggG6EiTNz+PYSI/xli 4goeJF6FsFHaB/o3E7D41fcfc9HUEVJB2OkoA2/fRa7YTHKjLQoFomBokRffv+Dl1wxO3xI6pyf h4Q== X-Google-Smtp-Source: AGHT+IH8mdbwfrJKMwckdipsndK+INFZd3ytDE0ET+7xNbgX9cYLs+8AfNXXGiLYuBcSj+Z99jgelg== X-Received: by 2002:a17:903:32c8:b0:20c:e2ff:4a50 with SMTP id d9443c01a7336-210c68786dfmr357898005ad.9.1730594281526; Sat, 02 Nov 2024 17:38:01 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:38:00 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Andre Przywara , Hans de Goede , Heinrich Schuchardt , Jagan Teki , Jernej Skrabec Subject: [PATCH v3 18/25] sunxi: Drop status-LED code Date: Sat, 2 Nov 2024 18:33:10 -0600 Message-ID: <20241103003322.626036-19-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used anymore, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) board/sunxi/board.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/board/sunxi/board.c b/board/sunxi/board.c index 824c322a0dc..cff7b8eb247 100644 --- a/board/sunxi/board.c +++ b/board/sunxi/board.c @@ -49,7 +49,6 @@ #include #include #include -#include DECLARE_GLOBAL_DATA_PTR; @@ -550,11 +549,6 @@ void sunxi_board_init(void) { int power_failed = 0; -#ifdef CONFIG_LED_STATUS - if (IS_ENABLED(CONFIG_SPL_DRIVERS_MISC)) - status_led_init(); -#endif - #ifdef CONFIG_SY8106A_POWER power_failed = sy8106a_set_vout1(CONFIG_SY8106A_VOUT1_VOLT); #endif From patchwork Sun Nov 3 00:33:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005620 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=P44R7obA; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwgc0XXLz1xwV for ; Sun, 3 Nov 2024 11:38:20 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C1D6288C86; Sun, 3 Nov 2024 01:38:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="P44R7obA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E493A890C1; Sun, 3 Nov 2024 01:38:16 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BE06E88C86 for ; Sun, 3 Nov 2024 01:38:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-20cbca51687so29213065ad.1 for ; Sat, 02 Nov 2024 17:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594293; x=1731199093; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vBxNnzLMJWYC9vtI5BNUtoeWvQmYv36CW8LIgAwwRFM=; b=P44R7obAGgALOu6gby7RGEXFcAubiw+20kJjwPOzf+Xq/qElOZldgRLy7OIkV+1NpO K20uU5uFT/alcscY17vElcnnm3PUVq8zEbW7XSZHzIWz0jHYDoW4XrkTCtRcUnXfcsZb V3xauODQ05DGGJeAa6gCgMKgy/03cdXk/H4Sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594293; x=1731199093; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vBxNnzLMJWYC9vtI5BNUtoeWvQmYv36CW8LIgAwwRFM=; b=tkLX8yMlxatvtd/2V+8J6bhvrO3+JGhU+n2K98SrMu+r5Ln7GPsfIm4MXT3v1Y7c/k Y1mqY/4TQ/HefsaUaccU2uziZufXiwS02qLT6GCN8ipVkTmYyQPuDzLquhlfgZJCrzhk CMtpz64OC6tbkq9SUyILU9JGZfcROobNeVMMdal9AibSlmYL6zod14W3jWTNMV/2q486 7t3SfYUgLjam9ZbMpxNYwB0D/StbaJs/RB7hJlIQj5y1Fg3wGUbVEhFE9e9uFm0b61jn +8+ABKm/avU59nnoU2YQmFUyO6mS5/EiyPvSzejFXWkWaHof+ola+7106MigwjTo0s2z oXzg== X-Gm-Message-State: AOJu0Yx2/w7DVByuOnzii5LBB+U+GdHIn616cf0P/PL1uUDvl7KBXM40 dsTesAN/zSjPlkJ4Ek8QRLgmbZIA1X8kDnJ4SIFqdvGZOsC2otQLEPIkjozNFYSVrJ/w3OmPfkt TTA== X-Google-Smtp-Source: AGHT+IGo2XPV+9SDxacweB+aXSMQOrg9nDpJ1fSImQja0cgI9IZb7ZH6jRuLrE8dONJ2mzLGObXzfw== X-Received: by 2002:a17:902:e80a:b0:20c:8907:902 with SMTP id d9443c01a7336-2111af6eac9mr96299635ad.49.1730594292596; Sat, 02 Nov 2024 17:38:12 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.38.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:38:11 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Christian Marangi , Ilias Apalodimas , Jerome Forissier , Peter Robinson , Rasmus Villemoes , Sughosh Ganu Subject: [PATCH v3 19/25] common: Drop status-LED code in board_r Date: Sat, 2 Nov 2024 18:33:11 -0600 Message-ID: <20241103003322.626036-20-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used anymore, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) common/board_r.c | 27 --------------------------- 1 file changed, 27 deletions(-) diff --git a/common/board_r.c b/common/board_r.c index 62228a723e1..caac092c8e7 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -53,7 +53,6 @@ #include #include #include -#include #include #include #include @@ -459,29 +458,6 @@ static int initr_malloc_bootparams(void) } #endif -static int initr_status_led(void) -{ - status_led_init(); - - return 0; -} - -static int initr_boot_led_blink(void) -{ - status_led_boot_blink(); - - led_boot_blink(); - - return 0; -} - -static int initr_boot_led_on(void) -{ - led_boot_on(); - - return 0; -} - #if defined(CONFIG_CMD_NET) static int initr_net(void) { @@ -735,8 +711,6 @@ static init_fnc_t init_sequence_r[] = { #if defined(CONFIG_MICROBLAZE) || defined(CONFIG_M68K) timer_init, /* initialize timer */ #endif - initr_status_led, - initr_boot_led_blink, /* PPC has a udelay(20) here dating from 2002. Why? */ #ifdef CONFIG_BOARD_LATE_INIT board_late_init, @@ -759,7 +733,6 @@ static init_fnc_t init_sequence_r[] = { #if defined(CFG_PRAM) initr_mem, #endif - initr_boot_led_on, run_main_loop, }; From patchwork Sun Nov 3 00:33:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005621 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=QmBYCJxC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwgq3CzQz1xwV for ; Sun, 3 Nov 2024 11:38:31 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 326A7892FD; Sun, 3 Nov 2024 01:38:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="QmBYCJxC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 471F88880B; Sun, 3 Nov 2024 01:38:28 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 01F7A892FD for ; Sun, 3 Nov 2024 01:38:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-20cceb8d8b4so19598225ad.1 for ; Sat, 02 Nov 2024 17:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594304; x=1731199104; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fG7DQm52zMxSmpbncGSfKzGCEjPWHAYUm6UlhnnTSFo=; b=QmBYCJxCDGgNrIePkLCyKODlikT0f6reooFSdoCT3CK3BimJjTmad27GF2lUT9kDC4 xbUWG4AyCeg0AR1juA3E6zorVT96B2PeTmC1LPqNTj6dhUUcNuiF3WWLQZjNGmo5PmfY bi8tyfZX8k7A8eJUR5Sh6f0BoKP+CZsQuzQNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594304; x=1731199104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fG7DQm52zMxSmpbncGSfKzGCEjPWHAYUm6UlhnnTSFo=; b=fekG4e11LalxX8KK9FVZ3MvsbBeD84Pr4VZAUmR/8gaoS95AP35xjGr74st7f+3//w fFT+80KR/ymdDYPr+P1czxcBHVgI3ElapTaJIG2KYWIvtzjsTQqfeY2uT5KzxDm74BJT 6OLpQXqnIMFiHuZH0y3CPJJf+2ou4jOkVF3c+IcNLPazsjuUPirDka+Npg2eagUxHY7Q hJbmCF2w6iPuQh9RWL6Gnj3ng1n8OqF6GjmQjfSN8Y9iVhZOoLVXD114pWke7W0N9GXw 5czWxTwhMbYCc/xmrNHwv/PeH8kx95/y7HnWX4JuOOyChKbZ6j+oeuiKiHu5Cc01cv61 5M0w== X-Gm-Message-State: AOJu0Yx0ig9Jxho1OtB1BU8tFMSBL9qD0X6O0mHGWXdFDVagyrzHOYux PKJDWFXHdppsfpZHYvoUMcx5EcCx1vqS4/VfXwEpqww7kMW5dadIT5cyjAdJ1+7olXNsrB+AIiR LSQ== X-Google-Smtp-Source: AGHT+IHbZgg3FnMk52xAIOgq+42mLF/iYTkuq+gICrI4YTkdAfQUcfNHAreQA5NSI9Mw/ykSjf8tVQ== X-Received: by 2002:a17:903:2cc:b0:20b:a409:329 with SMTP id d9443c01a7336-2111938ae9bmr113642595ad.5.1730594303922; Sat, 02 Nov 2024 17:38:23 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:38:23 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Igor Opaniuk , Ilias Apalodimas , Joe Hershberger , Marek Vasut , Mattijs Korpershoek , Maxim Moskalets , Raymond Mao Subject: [PATCH v3 20/25] image: Drop unused status_led.h header file Date: Sat, 2 Nov 2024 18:33:12 -0600 Message-ID: <20241103003322.626036-21-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This header file is not used, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) boot/image.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/boot/image.c b/boot/image.c index abac254e026..7bed8ba4b1f 100644 --- a/boot/image.c +++ b/boot/image.c @@ -15,10 +15,6 @@ #include #include -#ifdef CONFIG_SHOW_BOOT_PROGRESS -#include -#endif - #if CONFIG_IS_ENABLED(FIT) || CONFIG_IS_ENABLED(OF_LIBFDT) #include #include From patchwork Sun Nov 3 00:33:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005622 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=M+dRRSlQ; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwh02Tgpz1xwV for ; Sun, 3 Nov 2024 11:38:40 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 949B18908F; Sun, 3 Nov 2024 01:38:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="M+dRRSlQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 21AD08931F; Sun, 3 Nov 2024 01:38:34 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 06F7F89157 for ; Sun, 3 Nov 2024 01:38:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-20c9978a221so31403125ad.1 for ; Sat, 02 Nov 2024 17:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594310; x=1731199110; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=85Q4p/tg2lVNRIQ8pw3ubemw3XvvPUoiOZa3bsJDBGs=; b=M+dRRSlQDcQ33UH9Oc0xefikOV0D1SGIIAaa3oqzCrhm307GfpPY9BEhOwe9kbROHR ftFjO1aWX9mGc8ZV2yNHEihLOZCgZ0ohpthjn2hO6nXhpNSq78Oq5Ydem6pNMsCLIyQY NrM6UZVVEt2gsm+OMlCBZbixx0mvNDiWyLhrU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594310; x=1731199110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=85Q4p/tg2lVNRIQ8pw3ubemw3XvvPUoiOZa3bsJDBGs=; b=gWAJsm+GLrnXQKP9nmjXw0V62AEAGaVPrY07qfFJ3+6A8sq5BL1eh41cP0/wz+Y3GU fOFYzWaEm5xDir4vpp2WWn7OaXpMGnsIm6iz55yLmt5KyUzPeR+MaTEa/FllpoYwJ0y3 fLuh4rx9LWDvM3B+uHxi+meoS0tOArdKssPFxeDv8DiXT5Q4stCwuTQ7vscKE+c6Lv/g hXjoNCehwd3tOHyIAcDnUbmQVHUk7EpkugXY5+naE3U2qO3KvcH4/OmWvG36QXhXfDcT IaeshOl/eV5Acnbuapi0bboHGGGtUzv4rLbNVeya0P8F5BEsUztOV6gekJKoOWToBO9O I0Tg== X-Gm-Message-State: AOJu0Yy8+WuJldwXIsDMsuC4RG7vYVV6cDOBZ2GmJ0mh5tQcn1i1YW4P YZj5Q+UJ29ZoPB6TCPiRYSk4G9Dyvq8v0va0xNfSObK6FL1k92a7Gua5g8iu1O+bi0JTcruL/XI oNA== X-Google-Smtp-Source: AGHT+IHpJKpef+JHrKfcPj66ZCQp6JImm1cseMDb+vosbUkn0p+WHoyBTfsl4UnVO1yxaoHj+nd9xQ== X-Received: by 2002:a17:902:e804:b0:20c:d2e4:dc33 with SMTP id d9443c01a7336-210c68d3ffamr405301155ad.14.1730594309627; Sat, 02 Nov 2024 17:38:29 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.38.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:38:28 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass Subject: [PATCH v3 21/25] ide: Drop unused status_led.h header file Date: Sat, 2 Nov 2024 18:33:13 -0600 Message-ID: <20241103003322.626036-22-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This header file is not used, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) cmd/ide.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/cmd/ide.c b/cmd/ide.c index 036489fda97..be3078ae88b 100644 --- a/cmd/ide.c +++ b/cmd/ide.c @@ -22,10 +22,6 @@ #include #include -#ifdef CONFIG_LED_STATUS -# include -#endif - /* Current I/O Device */ static int curr_device; From patchwork Sun Nov 3 00:33:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005623 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=n9I55pMh; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwhB1Bhqz1xwV for ; Sun, 3 Nov 2024 11:38:50 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE55288C86; Sun, 3 Nov 2024 01:38:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="n9I55pMh"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B3EC18930D; Sun, 3 Nov 2024 01:38:39 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9663489157 for ; Sun, 3 Nov 2024 01:38:37 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-20cb47387ceso29994725ad.1 for ; Sat, 02 Nov 2024 17:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594315; x=1731199115; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fZzOaX3V6RF9iODDAdcA59OWl/P+shVJvLGGKdn0P6k=; b=n9I55pMhEQwc7ZzgvQLc81WlX1rCRv/LNUn9A0fSp8nMh4B2E2Vd08n5UK8Qps+x0y FdI4Jbj59Z0AEMyz3g/7Rc5oLCJtMdE7qW+jGivrryCcAhUSWCCvX09b2mMsGLY/hKgw GcgByz192Trp8cqhAWsATTjc2Dta1aiVG0l7o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594315; x=1731199115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fZzOaX3V6RF9iODDAdcA59OWl/P+shVJvLGGKdn0P6k=; b=FesQ/jkiN/IOO0sDQWRCgnYcrOLfwA/oTQTjGEAzcY9bzwTlJcNPO4vuTeNsrx5zkB X/LXdoDicHns/LEBA7D4K9y9jL28f+9IWZpGyoD96CPAsfWOHbXTb5W8gumZMrZL8B32 F6U6kImDpwQvnU4iw1mwyPizm8U1b6suapVV1b1KFE1lRXgEHA5JxTuR80lOdLFS+GC0 WLZ0xWknfF6BhkTRo+hK/MTsuK9gtKduCTc87dnB4RY5BwFQ6klSdm0InBLi8ZoQGyFK Hed4sPoKX6ooqblHFSmWV5or+M5kA8nn4mQYJPVfoYfzYJts0v3XtJAe4Ch5dVGqfz0u 79Pw== X-Gm-Message-State: AOJu0Yz7bPrkIlkQGrXr+VRl7e/W0IDmD1oF7ASDczqC1/7w/FyJBy/F 0PfZRZod6JaMxDDQhQdV/BjCv/rKvXOcNAyG1P4Q04j4dWp5nrvImqAFgaJXklkEbAKP9xh7YRJ ULQ== X-Google-Smtp-Source: AGHT+IG/ctB8f7abcWxSRSdaGtsNjWdacsUHphiSGPbi20YRhZEc4SCX4/2r2E5qpG6ELm6LEcAl1g== X-Received: by 2002:a17:902:db0f:b0:20c:cf39:fe3c with SMTP id d9443c01a7336-210c6c34824mr388085745ad.41.1730594315503; Sat, 02 Nov 2024 17:38:35 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.38.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:38:34 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Mario Six Subject: [PATCH v3 22/25] mpc83xx: Drop status-LED code Date: Sat, 2 Nov 2024 18:33:14 -0600 Message-ID: <20241103003322.626036-23-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used anymore, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/timer/mpc83xx_timer.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/timer/mpc83xx_timer.c b/drivers/timer/mpc83xx_timer.c index 9da74479aaa..aefc18898e9 100644 --- a/drivers/timer/mpc83xx_timer.c +++ b/drivers/timer/mpc83xx_timer.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #include #include @@ -178,10 +177,6 @@ void timer_interrupt(struct pt_regs *regs) if (CFG_SYS_WATCHDOG_FREQ && (priv->timestamp % (CFG_SYS_WATCHDOG_FREQ)) == 0) schedule(); #endif /* CONFIG_WATCHDOG || CONFIG_HW_WATCHDOG */ - -#ifdef CONFIG_LED_STATUS - status_led_tick(priv->timestamp); -#endif /* CONFIG_LED_STATUS */ } void wait_ticks(ulong ticks) From patchwork Sun Nov 3 00:33:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005624 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=gdr+XG/0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XgwhN320Lz1xwV for ; Sun, 3 Nov 2024 11:39:00 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5C079891AD; Sun, 3 Nov 2024 01:38:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="gdr+XG/0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2A36789312; Sun, 3 Nov 2024 01:38:56 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9CC2A8932C for ; Sun, 3 Nov 2024 01:38:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-20ce65c8e13so34753475ad.1 for ; Sat, 02 Nov 2024 17:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594331; x=1731199131; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=baaE2+Pgpt/p4p9R74oxiJtHpytGrov1+nWBQfFVDJ4=; b=gdr+XG/0csQ5qSbvqJ0theBZdSe+rw4dKcPW1z6t3MJ3hnOsW83kbgy70EnUSrtAco OGbDaIWwOZJxWNtQZKO29QkvjTK+KTM1Ty+ltDI88lAtsWMF+gO/6VPg1dfNY1of8CGh 1a1zW3R51KiMX36bB564FZZo+TLsjE32zMNsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594331; x=1731199131; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=baaE2+Pgpt/p4p9R74oxiJtHpytGrov1+nWBQfFVDJ4=; b=Z7Gi6B51BuyGr/70lgeKrzFPn5vIfBriZzxfqnjSCsZUX3UY4p7UArjqlToQAhZyQa a4R/IZFiYWkQhdvkWMBuHAKy+GabcCSjsEL4Ht1DeWJ2VRttRP2BM1e2HIaANqNsIOlp 4/70o4yT20ycxpnnw+wauoPAiDCJCy5ifrtdgNZSFF1ZXlzqs858bx10D2iIwGS7+HX+ ynb4ka9/Vfwd8vBE/dC9UPfvmHZu4Qd63kvMT+2+wXBUW4yI54FfSvrg/79AWYoC4BIo NGf66ufTDX4nAcPNidrtPbwVqxj14wAsRJlqdQx2dnUYk+PZPuaTS5c6dza+KOIF9hJB uqMg== X-Gm-Message-State: AOJu0Yzz3JNqgqRqcQgnE+zKKH5+NANUUNKt0VNISDurzPIXnTkAhAjT 8KY/4YrGNExSPE13n5h8BWndG7weL/XdFu44bQpzjxWwSHvwLH2hqt646sYLs0OPcS1njvtPVgR hGA== X-Google-Smtp-Source: AGHT+IEJUTx6zKbJIXfTaJBGdlRtCtv9X0IBHzjiDhaeAGJqgPQmmpyV+Z4meytDmrB+/r6WfAqq9A== X-Received: by 2002:a17:903:2443:b0:202:28b1:9f34 with SMTP id d9443c01a7336-21103caeba3mr175299175ad.56.1730594331535; Sat, 02 Nov 2024 17:38:51 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.38.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:38:50 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Caleb Connolly , Charles Hardin , Christian Marangi , Heinrich Schuchardt , Ilias Apalodimas , Jerome Forissier , Joe Hershberger , Marek Vasut , Ramon Fried , Sean Anderson , Sean Edmond Subject: [PATCH v3 23/25] net: Drop status-LED code Date: Sat, 2 Nov 2024 18:33:15 -0600 Message-ID: <20241103003322.626036-24-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not used anymore, so drop it. Signed-off-by: Simon Glass --- (no changes since v1) net/bootp.c | 7 ------- net/net.c | 33 --------------------------------- 2 files changed, 40 deletions(-) diff --git a/net/bootp.c b/net/bootp.c index afd5b48094a..42462afda3e 100644 --- a/net/bootp.c +++ b/net/bootp.c @@ -19,9 +19,6 @@ #include #include #include "bootp.h" -#ifdef CONFIG_LED_STATUS -#include -#endif #ifdef CONFIG_BOOTP_RANDOM_DELAY #include "net_rand.h" #endif @@ -370,10 +367,6 @@ static void bootp_handler(uchar *pkt, unsigned dest, struct in_addr sip, /* * Got a good BOOTP reply. Copy the data into our variables. */ -#if defined(CONFIG_LED_STATUS) && defined(CONFIG_LED_STATUS_BOOT_ENABLE) - status_led_set(CONFIG_LED_STATUS_BOOT, CONFIG_LED_STATUS_OFF); -#endif - store_net_params(bp); /* Store net parameters from reply */ /* Retrieve extended information (we must parse the vendor area) */ diff --git a/net/net.c b/net/net.c index f47e9fbe33a..fc869d8bd48 100644 --- a/net/net.c +++ b/net/net.c @@ -100,10 +100,6 @@ #include #endif #include -#if defined(CONFIG_LED_STATUS) -#include -#include -#endif #include #include #include @@ -614,19 +610,6 @@ restart: break; } -#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) -#if defined(CONFIG_SYS_FAULT_ECHO_LINK_DOWN) && \ - defined(CONFIG_LED_STATUS) && \ - defined(CONFIG_LED_STATUS_RED) - /* - * Echo the inverted link state to the fault LED. - */ - if (miiphy_link(eth_get_dev()->name, CONFIG_SYS_FAULT_MII_ADDR)) - status_led_set(CONFIG_LED_STATUS_RED, CONFIG_LED_STATUS_OFF); - else - status_led_set(CONFIG_LED_STATUS_RED, CONFIG_LED_STATUS_ON); -#endif /* CONFIG_SYS_FAULT_ECHO_LINK_DOWN, ... */ -#endif /* CONFIG_MII, ... */ #ifdef CONFIG_USB_KEYBOARD net_busy_flag = 1; #endif @@ -684,22 +667,6 @@ restart: ((get_timer(0) - time_start) > time_delta)) { thand_f *x; -#if defined(CONFIG_MII) || defined(CONFIG_CMD_MII) -#if defined(CONFIG_SYS_FAULT_ECHO_LINK_DOWN) && \ - defined(CONFIG_LED_STATUS) && \ - defined(CONFIG_LED_STATUS_RED) - /* - * Echo the inverted link state to the fault LED. - */ - if (miiphy_link(eth_get_dev()->name, - CONFIG_SYS_FAULT_MII_ADDR)) - status_led_set(CONFIG_LED_STATUS_RED, - CONFIG_LED_STATUS_OFF); - else - status_led_set(CONFIG_LED_STATUS_RED, - CONFIG_LED_STATUS_ON); -#endif /* CONFIG_SYS_FAULT_ECHO_LINK_DOWN, ... */ -#endif /* CONFIG_MII, ... */ debug_cond(DEBUG_INT_STATE, "--- net_loop timeout\n"); x = time_handler; time_handler = (thand_f *)0; From patchwork Sun Nov 3 00:33:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005625 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=CSSCohUG; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwhf75gsz1xwV for ; Sun, 3 Nov 2024 11:39:14 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 68E6B89321; Sun, 3 Nov 2024 01:39:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="CSSCohUG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CD2A18931D; Sun, 3 Nov 2024 01:39:08 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 77DC4890F8 for ; Sun, 3 Nov 2024 01:39:00 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-20ca1b6a80aso31742095ad.2 for ; Sat, 02 Nov 2024 17:39:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594338; x=1731199138; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y5QzRroI1fxjLrWf6GjSGLuOW6AEQb7cP0NT8mrh40o=; b=CSSCohUG02PP+XGI3qoAjMldK0KWXNo/Y3JnpDtoI9f173iYz8qz4ehcdGlTSr7uYw opOKHJ+oNDPzrc4SgfYDMJJAGrB1jQpqbt8gzXdKUL+fapb0repaF1aP8V3mdoUf+42O VdVNfV+dgBzfElNL+ptbvEYK2SpR7YO2sju4A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594338; x=1731199138; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y5QzRroI1fxjLrWf6GjSGLuOW6AEQb7cP0NT8mrh40o=; b=MNomm0Ew77dJD1R7WX9wUF1Sgpn50eWlWen5EiQrlq3Ve4LyJAXJSYGKbGpXnnVE6l 3K53PiO77RVXZFa2mpXMZpppdjEbfFUkOwdZxG2Pt7DknZF3WdoXf9rad5g5971xBy2B nkR33/lR/XGJ+XWHx339Jq6JVCfKz2uwwZEV+22aCr004jFBw4t8IVm2l7XlRecQiweK /x39O1cx5j6M78kVyRY/Vrdei7jAYV5XdZAhaoj+cMtPCfBPnBf+vvf8Wl/8oEhR14MF Ak+zoGYbW4S98kklEI6LOeXYTYbwH5Z71mYtcAkrI92QeQCOg3bi1q39VJqQFwOD0hvG KwNQ== X-Gm-Message-State: AOJu0Yx9vxRVffZ3ssOddNK7vB14SI6rAgR1UNXQhH3febK95RvTdmZ8 jZ7ak6tGMWGySfJJoQo3vTOtjM25/clpmLb3bvH+PirNOLF5OkMiGMmEgzKX5vn8XO4PVG2OX6L PXg== X-Google-Smtp-Source: AGHT+IESmWOc/AEjLThSfhiy81Q4t/tFzT7zJmER8JItM3zrp4pw0G71uh+ytK+yCz4xr6z3wQLwmQ== X-Received: by 2002:a17:902:d2d0:b0:20c:ca83:31c7 with SMTP id d9443c01a7336-2111b00fe2emr121284215ad.54.1730594338430; Sat, 02 Nov 2024 17:38:58 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:38:57 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Christian Marangi Subject: [PATCH v3 24/25] led: Drop status_led header file Date: Sat, 2 Nov 2024 18:33:16 -0600 Message-ID: <20241103003322.626036-25-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This is not needed anymore. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) include/status_led.h | 104 ------------------------------------------- 1 file changed, 104 deletions(-) delete mode 100644 include/status_led.h diff --git a/include/status_led.h b/include/status_led.h deleted file mode 100644 index 59cf9f89956..00000000000 --- a/include/status_led.h +++ /dev/null @@ -1,104 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0+ */ -/* - * (C) Copyright 2000-2004 - * Wolfgang Denk, DENX Software Engineering, wd@denx.de. - */ - -/* - * The purpose of this code is to signal the operational status of a - * target which usually boots over the network; while running in - * PCBoot, a status LED is blinking. As soon as a valid BOOTP reply - * message has been received, the LED is turned off. The Linux - * kernel, once it is running, will start blinking the LED again, - * with another frequency. - */ - -#ifndef _STATUS_LED_H_ -#define _STATUS_LED_H_ - -#ifdef CONFIG_LED_STATUS - -#define LED_STATUS_PERIOD (CONFIG_SYS_HZ / CONFIG_LED_STATUS_FREQ) -#ifdef CONFIG_LED_STATUS1 -#define LED_STATUS_PERIOD1 (CONFIG_SYS_HZ / CONFIG_LED_STATUS_FREQ1) -#endif /* CONFIG_LED_STATUS1 */ -#ifdef CONFIG_LED_STATUS2 -#define LED_STATUS_PERIOD2 (CONFIG_SYS_HZ / CONFIG_LED_STATUS_FREQ2) -#endif /* CONFIG_LED_STATUS2 */ -#ifdef CONFIG_LED_STATUS3 -#define LED_STATUS_PERIOD3 (CONFIG_SYS_HZ / CONFIG_LED_STATUS_FREQ3) -#endif /* CONFIG_LED_STATUS3 */ -#ifdef CONFIG_LED_STATUS4 -#define LED_STATUS_PERIOD4 (CONFIG_SYS_HZ / CONFIG_LED_STATUS_FREQ4) -#endif /* CONFIG_LED_STATUS4 */ -#ifdef CONFIG_LED_STATUS5 -#define LED_STATUS_PERIOD5 (CONFIG_SYS_HZ / CONFIG_LED_STATUS_FREQ5) -#endif /* CONFIG_LED_STATUS5 */ - -void status_led_init(void); -void status_led_tick(unsigned long timestamp); -void status_led_set(int led, int state); - -static inline void status_led_boot_blink(void) -{ -#ifdef CONFIG_LED_STATUS_BOOT_ENABLE - status_led_set(CONFIG_LED_STATUS_BOOT, CONFIG_LED_STATUS_BLINKING); -#endif -} - -/***** MVS v1 **********************************************************/ -#if (defined(CONFIG_MVS) && CONFIG_MVS < 2) -# define STATUS_LED_PAR im_ioport.iop_pdpar -# define STATUS_LED_DIR im_ioport.iop_pddir -# undef STATUS_LED_ODR -# define STATUS_LED_DAT im_ioport.iop_pddat - -# define STATUS_LED_ACTIVE 1 /* LED on for bit == 1 */ - -/***** Someone else defines these *************************************/ -#elif defined(STATUS_LED_PAR) - /* - * ADVICE: Define in your board configuration file rather than - * filling this file up with lots of custom board stuff. - */ -#else -# error Status LED configuration missing -#endif -/************************************************************************/ - -#include - -#else - -static inline void status_led_init(void) { } -static inline void status_led_set(int led, int state) { } -static inline void status_led_boot_blink(void) { } - -#endif /* CONFIG_LED_STATUS */ - -/* - * Coloured LEDs API - */ -#ifndef __ASSEMBLY__ -void coloured_LED_init(void); -void red_led_on(void); -void red_led_off(void); -void green_led_on(void); -void green_led_off(void); -void yellow_led_on(void); -void yellow_led_off(void); -void blue_led_on(void); -void blue_led_off(void); -#else - .extern LED_init - .extern red_led_on - .extern red_led_off - .extern yellow_led_on - .extern yellow_led_off - .extern green_led_on - .extern green_led_off - .extern blue_led_on - .extern blue_led_off -#endif - -#endif /* _STATUS_LED_H_ */ From patchwork Sun Nov 3 00:33:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 2005626 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=cn3By+fi; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xgwhr2DXRz1xwV for ; Sun, 3 Nov 2024 11:39:24 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 169C789300; Sun, 3 Nov 2024 01:39:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="cn3By+fi"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C6C28931D; Sun, 3 Nov 2024 01:39:12 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C64A88932F for ; Sun, 3 Nov 2024 01:39:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-20cb47387ceso29995705ad.1 for ; Sat, 02 Nov 2024 17:39:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1730594344; x=1731199144; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7vXbVwOj+F+HJd/E/fENquLsJiyYrxOhliRgRd5Ckjg=; b=cn3By+fi0mZzQxc/kRo/fFYI4Lu2t62Lny30REqe80aA+y2oMYOjvZVGG8c8k+KrQk pDtPQgLN+hbT/s3d7RHrY/vkErm4CJyxvmXMqHl9ib0IphUbe1D6LOtJ8oiLkCfhEq3c lFuJhRyKLBWdA+8LckGvweoBcZfOm5KfX4PiM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730594344; x=1731199144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7vXbVwOj+F+HJd/E/fENquLsJiyYrxOhliRgRd5Ckjg=; b=EC07eHmUaKAQ43e/oabGMcdCW+6r6moasJ8ZIYK6NAo3xYMN3AZTJP/aJpzo+RmHDa LVTVvI7zRnRvTsQ6c45+kmWAMdH5zUGElnNLXgKGtB+nvrP65gJV/CZEmXoMz8FXfJBW BPUfCsTj15Lz1X7EmdmNNV0B9Ow/AvzhP63MvHFnR+LDsqKTwOhcSV/geuM2llAwseYJ C6Vbo604WcZ7WCH6/bSGR5uySZjPonp/Jx6qepfS5LSRSwxrWmViUVDUeSSBjDp23G1u m5+59eG9AOR3FciViZRmCico4OL1bO4WnoEVWMptdvhvGj8tkBg4/dLz7l2JPXDbZjwm f6sw== X-Gm-Message-State: AOJu0YyGkQgS3hHFPnOWJfda9k7NTxFg86vAGTIII7fCgErNK08Bf3Aa HBT97WZ8gMRlvIOaiKw1p+IKQsj6zZo5X7DylDaYSIPmhXFwOnLnd1Yw5pv8i3b31lrQ2PqxdF6 7JA== X-Google-Smtp-Source: AGHT+IEAq7BR8cfMhKmDQGkv0L5qwJdDwPeDHh7R18dpsqn8YQfWX+7ZdPj31Bq0Fg5Z/u+DfWERsg== X-Received: by 2002:a17:903:228b:b0:20b:fd73:32bb with SMTP id d9443c01a7336-210c6872da0mr374289515ad.2.1730594344125; Sat, 02 Nov 2024 17:39:04 -0700 (PDT) Received: from chromium.org ([205.220.129.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211057a63f2sm38987995ad.168.2024.11.02.17.38.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2024 17:39:03 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass Subject: [PATCH v3 25/25] doc: Add devicetree bindings for options Date: Sat, 2 Nov 2024 18:33:17 -0600 Message-ID: <20241103003322.626036-26-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241103003322.626036-1-sjg@chromium.org> References: <20241103003322.626036-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Some of U-Boot's options have made it upstream, so bring in the binding file. This is taken from dt-schema commit c9b4797 Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Enable LED on the 5 affected platforms - Reorder patches for bisectability - Add dt-schema bindings for LED doc/device-tree-bindings/options.yaml | 79 +++++++++++ doc/device-tree-bindings/options/u-boot.yaml | 136 +++++++++++++++++++ 2 files changed, 215 insertions(+) create mode 100644 doc/device-tree-bindings/options.yaml create mode 100644 doc/device-tree-bindings/options/u-boot.yaml diff --git a/doc/device-tree-bindings/options.yaml b/doc/device-tree-bindings/options.yaml new file mode 100644 index 00000000000..d6f5bbb00db --- /dev/null +++ b/doc/device-tree-bindings/options.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-clause +# Copyright 2021 Google LLC +# + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/options.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: /options Node + +maintainers: + - Simon Glass + +description: | + The '/options' node does not represent a real device, but serves as a place + for passing data into and between firmware components, such as memory + mappings. Data in the '/options' node does not represent the hardware. It is + ignored by operating systems. + + Properties in this node should be common to (and used by) at least two + firmware projects, such as U-Boot and TF-A. Project-specific subnodes can be + used for properties which are specific to a single project. + + This is based on the precedent set by IEEE 1275-1994 IEEE Standard for Boot + (Initialization Configuration) Firmware: Core Requirements and Practices + at https://www.openfirmware.info/data/docs/of1275.pdf + + Purpose of '/options' node + -------------------------- + + A common problem with firmware is that many builds are needed to deal with the + slight variations between different, related models of the same hardware. For + example, one model may have a TPM and another may not. Devicetree provides an + excellent solution to this problem, in that the devicetree to actually use on + a platform can be injected in the factory based on which model is being + manufactured at the time. + + A related problem causing build proliferation is dealing with the differences + between development firmware, developer-friendly firmware (e.g. with all + security features present but with the ability to access the command line), + test firmware (which runs tests used in the factory), final production + firmware (before signing), signed firmware (where the signatures have been + inserted) and the like. Ideally all or most of these should use the same + firmware build, with just some options to determine the features available. + For example, being able to control whether the UART console or JTAG are + available, on any image, is a great debugging aid. + + When the firmware consists of multiple parts (various U-Boot phases, TF-A, + OP-TEE), it is helpful that all operate the same way at runtime, regardless of + how they were built. This can be achieved by passing the runtime configuration + (e.g. 'enable UART console', 'here are your public keys') along the chain + through each firmware stage. It is frustrating to have to replicate a bug on + production firmware which does not happen on developer firmware, because they + are completely different builds. + + The '/options' node provides useful functionality for this. It allows the + different controls to be 'factored out' of the firmware binaries, so they can + be controlled separately from the initial source-code build. The node can be + easily updated by a build or factory tool and can control various features in + the firmware binaries. It is similar in concept to a Kconfig option, except + that it can be changed after firmware binaries are built. + + The '/options' node is similar in concept to /chosen (see chosen.yaml) except + that it is for passing information *into* and *between*) firmware components, + instead of from firmware to the operating system. Also, while operating + systems typically have a (sometimes extremely long) command line, firmware + binaries typically do not support this. The devicetree provides a more + structured approach in any case. + +properties: + $nodename: + const: options + + "#address-cells": true + "#size-cells": true + +additionalProperties: + type: object diff --git a/doc/device-tree-bindings/options/u-boot.yaml b/doc/device-tree-bindings/options/u-boot.yaml new file mode 100644 index 00000000000..c9894ff5c48 --- /dev/null +++ b/doc/device-tree-bindings/options/u-boot.yaml @@ -0,0 +1,136 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright 2021 Google LLC + +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/options/u-boot.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: U-Boot configuration node + +maintainers: + - Simon Glass + +description: | + The u-boot,config node provides basic configuration information to U-Boot, + for use during its execution. It can be used to control U-Boot's behaviour + in various ways. + +properties: + $nodename: + const: u-boot + + compatible: + const: u-boot,config + + bootcmd: + $ref: /schemas/types.yaml#/definitions/string + description: | + Allows overwriting of the boot command used by U-Boot on startup. If + present, U-Boot uses this command instead. Note that this feature can + work even if loading the environment is disabled, e.g. for security + reasons. See also bootsecure. + + bootdelay-sec: + description: | + Allows selecting of the U-Boot bootdelay, to control whether U-Boot + waits on boot or for how long. This allows this option to be configured + by the build system or by a previous-stage binary. For example, if the + images is being packed for testing or a user holds down a button, it may + allow a delay, but disable it for production. + + If this property is not present, a default value is used instead. + + Note that this uses the 'sec' property unit, even though it allows a + negative value. + + Values: + + -1: no bootdelay and the user cannot interrupt boot + 0: no bootdelay but use user can still interrupt boot by holding down a + key, if enabled + >= 1: delay for this many seconds + + + bootsecure: + $ref: /schemas/types.yaml#/definitions/uint32 + default: 0 + maximum: 2 + description: | + Controls the execution of the boot command in U-Boot, e.g. selecting + between using a special function to run commands, or the normal CLI. This + can be used in production images, to restrict the amount of parsing done + or the options available, to cut back on the available surface for + security attacks. + + Values: + + 0: normal boot using CLI (default if not present) + 1: use secure boot mechanism instead to parse and run commands + other values are reserved for future use + 2: use simplified command line (e.g. avoid hush) + 3... reserved + + bootscr-address: + $ref: /schemas/types.yaml#/definitions/uint64 + default: 0x0 + description: + Holds the full address of the boot script file. It helps in making + automated flow easier by fetching the 64bit address directly from DT. + Value should be automatically copied to the U-Boot 'scriptaddr' variable. + When it is defined, bootscr-ram-offset property should be ignored. + Actually only one of them should be present in the DT. + + bootscr-ram-offset: + $ref: /schemas/types.yaml#/definitions/uint64 + default: 0x0 + description: + Holds the boot script file offset from the start of the ram base address. + Platforms with run-time RAM-detection algorithms should use this property + because it is not clear exactly where the script address should be placed. + Using it will provide the option to specify boot script offset from + detected RAM start. The U-Boot 'scriptaddr' variable should be composed as + detected RAM start plus value of bootscr-ram-offset property. + It should be used only when bootscr-address is not defined. + + silent-console: + $ref: /schemas/types.yaml#/definitions/uint32 + default: 0 + maximum: 2 + description: | + This allows the console to be silenced by default on boot. This can allow + easy disabling of console output on a production build, for example. When + suppressed, the console is still active. This feature only suppresses the + console output itself, on all output devices. + + Values: + + 0: console output appears as normal (default) + 1: console output is suppressed but console recording still operates (if + enabled) + 2: console output is suppressed and not recorded + +required: + - compatible + +if: + required: + - bootscr-address +then: + properties: + bootscr-ram-offset: false + +additionalProperties: false + +examples: + - | + options { + u-boot { + compatible = "u-boot,config"; + bootcmd = "vboot go auto"; + bootdelay-sec = <(-1)>; + bootsecure = <1>; + bootscr-address = /bits/ 64 <0x1000>; + silent-console = <1>; + }; + };