From patchwork Tue Oct 29 08:00:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 2003592 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WTdOrIBk; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=fWOiSYYe; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Xd2lH5HvYz1xwn for ; Tue, 29 Oct 2024 19:01:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=yjjOVYnFjo52qdOoVXb3K/2AlZKliu1imAZDpjkPHrA=; b=WTdOrIBkFxsNqD EWXEEFEbtgsfxgCfjfkk4oMd3G8vkFNoWuhJDiiuH2dwlagot3kWFsk/ZVWl4ERnFzJAOvn3WMcn4 XNP3EU+Q2VgoCUULdED5L59sLoLsw58CEilgr/d/3a6JecY1JrLZfGZOtan9VmJp9nC3Ce3LGb6XM G0j5Fq7wn5VPuBqPwgVwLs2RD+332XN80nAyb2Cb4L5m4IJU6K3IXI7rBDfg2KhhftTQeTCsP5Vjf RfbGXmKgtq97A2vL/lexI9g6n+22COk96zECoiGx705JEXUSQpiS5jO7Sypb1QbLSgTnTb9WA8G+G 4/Y70lddBO0WKUHVb7Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t5hA7-0000000DbaE-18fh; Tue, 29 Oct 2024 08:01:11 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t5h9q-0000000DbWI-3W0s for linux-mtd@lists.infradead.org; Tue, 29 Oct 2024 08:00:56 +0000 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-539ebb5a20aso5222805e87.2 for ; Tue, 29 Oct 2024 01:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730188853; x=1730793653; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4n4x9GYxa/84hlNl/zX8+weX12yrLQSNbbEjP2vC+SU=; b=fWOiSYYe9ZXFbObwwjRF0I33KvjOSFRPSsKpntzi84hDZGasMmAF/oUzOkoOihfvAC 4kSjKxxU8HCJKvFfX5utzi/smUlXQ2CWbPoCY4yN1WB3A8/uzSJT00H2QrVOmrRnvmyP JTxIYRLj5prbIU9AfHGThceCaDbPXd12vTbt2tTXRWA0viDtyqpCl9PoauJ0sHPNN/AU WiH59+bFY7sd0UjlEuZvsdSF3IL5dHB+Rbkx3DiVmnGqSxDXDq+adJbUwTzx5QMtfDPL XAd0YNjEmg1NokM2naKPufAEAH7bcqxE+ZD18UU/lFbFtZlSqBaVr6hzOCGw3zoe+rLn Q7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730188853; x=1730793653; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4n4x9GYxa/84hlNl/zX8+weX12yrLQSNbbEjP2vC+SU=; b=aqgeeysXJgFVQFVRle6StVZsd/lg2wVXwHE8pR+GRPk83XlDIpX7pH1Oco++U/cLua K8eBJvGH5iF20hN3c9FRthCg5GvThe5WcbDzNeRBDicgwVP3Fp0ZzM0wczuD/QnULvV3 LK/Sn/LGhbJ/FQe1Mm+toQjwf/hX385I27D8B49kbq8J4xcmyN8w1AjnjitpRrEn56Mn 9eQ6ipicgzrrhDhQBTbA1xXJBtmnPL6LTLiBsS+BUrhlvnf8aTZlT9CqoFOfDXMnyALB PocErPnztIT58cFLPhrNi0hRHHNVt+1iesPhkmoVx92Egb+sjuFXmwcciaKKbbwqLBJh yuEQ== X-Forwarded-Encrypted: i=1; AJvYcCWD1QyEsTFLql9eGyW0ozqlLOtqA5ifUtC5d4KkOv68hIzqhBKNNwkKaEW4IPkAFBBMfAlkL9i6mXs=@lists.infradead.org X-Gm-Message-State: AOJu0YyE28rT1ZsBjF0c9MG56g2l0lFDK5kWZBGJunYHEX4A3DFBGcDS xGjw8FegUSChS3PeGX3tkrWciUWNWsRql1apnwnrVl4YyuiCcWVKSSKKf7lJoSw= X-Google-Smtp-Source: AGHT+IFI0GQq8D7c2huksHpR4S4ZugunHxuqIU3GR4zlJi6+IR1gaYwVJZr1f3llj1rmrlrWDh05mg== X-Received: by 2002:a05:6512:2243:b0:539:de0d:1e35 with SMTP id 2adb3069b0e04-53b348c1ddemr4380499e87.1.1730188852659; Tue, 29 Oct 2024 01:00:52 -0700 (PDT) Received: from tudordana.roam.corp.google.com ([79.115.63.43]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431935a4b40sm135826265e9.24.2024.10.29.01.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 01:00:52 -0700 (PDT) From: Tudor Ambarus To: pratyush@kernel.org Cc: mwalle@kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Tudor Ambarus Subject: [PATCH] mtd: spi-nor: winbond: add "w/ and w/o SFDP" comment Date: Tue, 29 Oct 2024 08:00:49 +0000 Message-ID: <20241029080049.96679-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241029_010055_076872_014B2BDC X-CRM114-Status: GOOD ( 10.63 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Commit d35df77707bf ("mtd: spi-nor: winbond: fix w25q128 regression") upstream fixed a regression for flavors of 0xef4018 flash that don't define SFDP tables. Add a comment on the flash definition hig [...] Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:134 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org Commit d35df77707bf ("mtd: spi-nor: winbond: fix w25q128 regression") upstream fixed a regression for flavors of 0xef4018 flash that don't define SFDP tables. Add a comment on the flash definition highlighting that there are flavors of flashes with and without SFDP support. It spares developers searching the entire git log for when we'll better handle these cases. Signed-off-by: Tudor Ambarus --- drivers/mtd/spi-nor/winbond.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c index 9f7ce5763e71..8d0a00d69e12 100644 --- a/drivers/mtd/spi-nor/winbond.c +++ b/drivers/mtd/spi-nor/winbond.c @@ -129,6 +129,7 @@ static const struct flash_info winbond_nor_parts[] = { .no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, }, { .id = SNOR_ID(0xef, 0x40, 0x18), + /* Flavors w/ and w/o SFDP. */ .name = "w25q128", .size = SZ_16M, .flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,