From patchwork Thu Oct 17 13:09:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eelco Chaudron X-Patchwork-Id: 1998583 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hQ8P06l4; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XTp9K5lJZz1xth for ; Fri, 18 Oct 2024 00:10:28 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B727B404D4; Thu, 17 Oct 2024 13:10:24 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id wP_JnzrUZ4O4; Thu, 17 Oct 2024 13:10:20 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6434E4055F Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hQ8P06l4 Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6434E4055F; Thu, 17 Oct 2024 13:10:20 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 23133C08A6; Thu, 17 Oct 2024 13:10:20 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9AD5EC08A3 for ; Thu, 17 Oct 2024 13:10:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8254F4059E for ; Thu, 17 Oct 2024 13:10:18 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id IkNBxTjdlHTv for ; Thu, 17 Oct 2024 13:10:14 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=echaudro@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 6A1E14055F Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6A1E14055F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6A1E14055F for ; Thu, 17 Oct 2024 13:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729170612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SENO/OvTYwJgBdwpLXMXOgKFQpRcv84kYsfBPWMz2UM=; b=hQ8P06l4s3pCOPA3oLBFhUWWXKY5ppFyvrW2UnXUdNFjruuC9FWBNVadp4ivnqwyUjMvxd 2SQBmhSuUoxe2hKM0voWZGHXL1bA/4U+F+JTjgIasNml1mbjJ688oNGnb1VNb8VVDcfHSB zQGTzpolm3PTmUTBiKvCgSm+9ZXh2nM= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-h2RQ3bw-OFSfTOqh8aH9ag-1; Thu, 17 Oct 2024 09:10:11 -0400 X-MC-Unique: h2RQ3bw-OFSfTOqh8aH9ag-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D37A019371D9 for ; Thu, 17 Oct 2024 13:10:10 +0000 (UTC) Received: from ebuild.redhat.com (unknown [10.39.194.17]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 246CA19560AD for ; Thu, 17 Oct 2024 13:10:09 +0000 (UTC) From: Eelco Chaudron To: dev@openvswitch.org Date: Thu, 17 Oct 2024 15:09:21 +0200 Message-ID: <3ce872dfa0334278f81deb40e26018d0f81ab2fb.1729170562.git.echaudro@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH 1/2] dpdk: Fix dpdk logs being split over multiple lines. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" More recent versions of the vprintf() implementation in glibc are exhibiting this truncation behavior due to an internal buffer size change. According to the glibc developers, this is not considered a bug (see: https://sourceware.org/bugzilla/show_bug.cgi?id=31137). To prevent buffer truncation, remove the request for unbuffered output. Signed-off-by: Eelco Chaudron --- lib/dpdk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/dpdk.c b/lib/dpdk.c index 940c43c07..b7516257c 100644 --- a/lib/dpdk.c +++ b/lib/dpdk.c @@ -323,7 +323,6 @@ dpdk_init__(const struct smap *ovs_other_config) if (log_stream == NULL) { VLOG_ERR("Can't redirect DPDK log: %s.", ovs_strerror(errno)); } else { - setbuf(log_stream, NULL); rte_openlog_stream(log_stream); } From patchwork Thu Oct 17 13:09:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eelco Chaudron X-Patchwork-Id: 1998584 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M0UzvwAh; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XTp9P50LFz1xth for ; Fri, 18 Oct 2024 00:10:33 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8A37460671; Thu, 17 Oct 2024 13:10:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id XzgKftGzLtI6; Thu, 17 Oct 2024 13:10:23 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 53C05605D0 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=M0UzvwAh Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 53C05605D0; Thu, 17 Oct 2024 13:10:23 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 35D6DC08A6; Thu, 17 Oct 2024 13:10:23 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1857BC08A3 for ; Thu, 17 Oct 2024 13:10:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id EF227608B4 for ; Thu, 17 Oct 2024 13:10:21 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id s0CXbz8XOmpv for ; Thu, 17 Oct 2024 13:10:18 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=echaudro@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org B6C9D605D0 Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B6C9D605D0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id B6C9D605D0 for ; Thu, 17 Oct 2024 13:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729170616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/6AR6KEsQ9IhuqQgEA3nIW8C/IcqclsvY2hUWpNGVH0=; b=M0UzvwAhBLys5W0i+Jk9uYGTSbg6HArd5ypO/6HOmsJLIjjKPF1yVCwiM/Bt8kwL+RCag3 44+s+IMod2ZAonY41SXKROoJNVbhJ2axhCxKIVVjgI7fAkjD6IhXcrn1nUhGMw7UXDM3d8 h8UsS3KCUr+fA+PHVYpSko7UUiJrlP0= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-421-9-zaOZ_zMNuz2DixAErWAA-1; Thu, 17 Oct 2024 09:10:15 -0400 X-MC-Unique: 9-zaOZ_zMNuz2DixAErWAA-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 684F01954B04 for ; Thu, 17 Oct 2024 13:10:14 +0000 (UTC) Received: from ebuild.redhat.com (unknown [10.39.194.17]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B683C19560AD for ; Thu, 17 Oct 2024 13:10:13 +0000 (UTC) From: Eelco Chaudron To: dev@openvswitch.org Date: Thu, 17 Oct 2024 15:09:22 +0200 Message-ID: In-Reply-To: <3ce872dfa0334278f81deb40e26018d0f81ab2fb.1729170562.git.echaudro@redhat.com> References: <3ce872dfa0334278f81deb40e26018d0f81ab2fb.1729170562.git.echaudro@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH 2/2] ci: Update GitHub actions runner from Ubuntu 22.04 to 24.04. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This patch upgrades the Ubuntu runner to the latest LTS version. It also adds required packages and includes the runner image in the DPDK CI signature to ensure a fresh cache build. Signed-off-by: Eelco Chaudron --- .github/workflows/build-and-test.yml | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index 13a6bf3f2..96ea882f4 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -7,15 +7,21 @@ env: jobs: build-dpdk: + strategy: + matrix: + runner: [ubuntu-24.04] env: - dependencies: gcc libbpf-dev libnuma-dev libpcap-dev ninja-build pkgconf + dependencies: | + gcc libbpf-dev libnuma-dev libpcap-dev libsystemd-dev libxdp-dev \ + ninja-build pkgconf + CC: gcc DPDK_GIT: https://dpdk.org/git/dpdk-stable DPDK_VER: 23.11.1 name: dpdk gcc outputs: dpdk_key: ${{ steps.gen_dpdk_key.outputs.key }} - runs-on: ubuntu-22.04 + runs-on: ${{ matrix.runner }} timeout-minutes: 30 steps: @@ -33,7 +39,8 @@ jobs: # This also allows us to use cache from any branch as long as version # and a way we're building DPDK stays the same. run: | - cat .ci/dpdk-* > dpdk-ci-signature + echo ${{ matrix.runner }} > dpdk-ci-signature + cat .ci/dpdk-* >> dpdk-ci-signature grep -rwE 'DPDK_GIT|DPDK_VER' .github/ >> dpdk-ci-signature if [ "${DPDK_VER##refs/*/}" != "${DPDK_VER}" ]; then git ls-remote --heads $DPDK_GIT $DPDK_VER >> dpdk-ci-signature @@ -80,7 +87,7 @@ jobs: dependencies: | automake libtool gcc bc libjemalloc2 libjemalloc-dev libssl-dev \ llvm-dev libnuma-dev libpcap-dev selinux-policy-dev libbpf-dev \ - lftp libreswan + libsystemd-dev libxdp-dev lftp libreswan CC: ${{ matrix.compiler }} DPDK: ${{ matrix.dpdk }} DPDK_SHARED: ${{ matrix.dpdk_shared }} @@ -93,7 +100,7 @@ jobs: TEST_RANGE: ${{ matrix.test_range }} name: linux ${{ join(matrix.*, ' ') }} - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 30 strategy: @@ -280,12 +287,13 @@ jobs: env: dependencies: | automake bc clang-tools libbpf-dev libnuma-dev libpcap-dev \ - libunbound-dev libunwind-dev libssl-dev libtool llvm-dev + libunbound-dev libunwind-dev libssl-dev libtool libsystemd-dev \ + libxdp-dev llvm-dev CC: clang DPDK: dpdk CLANG_ANALYZE: true name: clang-analyze - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 30 steps: @@ -390,7 +398,7 @@ jobs: build-oss-fuzz: name: build oss-fuzz fuzzers - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 30 steps: @@ -458,7 +466,7 @@ jobs: DPDK: ${{ matrix.dpdk }} name: linux deb ${{ matrix.dpdk }} dpdk - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 30 strategy: