From patchwork Tue Oct 15 02:06:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 1997160 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=mVAgwSrm; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XSHXk2rKsz1xvK for ; Tue, 15 Oct 2024 13:07:02 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F647385AE43 for ; Tue, 15 Oct 2024 02:07:00 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id 47F203856DE3 for ; Tue, 15 Oct 2024 02:06:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47F203856DE3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 47F203856DE3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728957996; cv=none; b=hRc7MtV9I8reRGMCRR/a4o8x4uHiQpXu54shThhG3FIBXhAbrOZRYudSs8Qf7iB0iTwBFlqMG1J8IIPv3S1j5eAeJtH5v2M8yChPHv5jkRg8c/CRVk+yes/3WROtAxMprD6Ya4r1CCZe5L3NRDkm1cvC8etBae53qD6Y3B2pr1E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728957996; c=relaxed/simple; bh=hhSaZqaF7XyBSbsnNGcLVOeCCkGnw5rnDWFWMaWTguc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=BFsgQbS/VHrez7hwE+IaLv/AK/gY6Zva1CTT3TyNBm/aEyA0wngtyNMKpVucPC3+bOp6L9IETXthkaxCCa/BFQWIclZzBgRnQUmnDhOcAM5Ph24J83Galvu8+zqQzapfhMJ8v2MfSOmJG6d+7oHINsgONPw8XvZ0Zjs6sb8H3Lw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49F1fThP028527 for ; Tue, 15 Oct 2024 02:06:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=DsLtBtCq6XR+hntb8Gb+IW dewOyhqN4GGWZPvbGlbFc=; b=mVAgwSrm6fzCEKW5dKyliE4enJXHqLDGn+N0l9 W0ATFt/Ey54LNaiSrGfNwJnuNHXXm4+BLnro26u0thQvCosrm5fKAFlcMgqXnOPE T65tclyOnVTtFKA9fQvObI2k1uPrkwu3dfAOcPSFWID3iOEvpwQVlZH0WyzjmOfB d4oavVYh74CLGg2hO6h3ZX4h0YX88DdwptKGz4HcfEabf7hoKU/ywTk9Nqg1hdld CYlHWxnAaTIHkTruKhbKgh8y/XL9KZFJDtDfjXnK60HtwaOx9bog3eIF8exvh6qx YYs4rK9myZ+kdxUJrhe7GRCBk4Tg00vBVQsvZauqB4YESXXQ== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 429exw01gy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 15 Oct 2024 02:06:33 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 49F26Whw024476 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 15 Oct 2024 02:06:32 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 14 Oct 2024 19:06:32 -0700 From: Andrew Pinski To: CC: Andrew Pinski Subject: [PATCH] dce: Remove FIXME that has not been true for years Date: Mon, 14 Oct 2024 19:06:19 -0700 Message-ID: <20241015020619.1558485-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: CrPuI2Ym4dWy3pWoOdRfPgmA5vHoZnMV X-Proofpoint-GUID: CrPuI2Ym4dWy3pWoOdRfPgmA5vHoZnMV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=911 bulkscore=0 malwarescore=0 spamscore=0 impostorscore=0 mlxscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2410150013 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org This FIXME: FIXME: Aggressive mode before PRE doesn't work currently because the dominance info is not invalidated after DCE1. Has not been true since at least r0-104723-g5ac60b564faa85 which added a call to calculate_dominance_info. Plus we run agressive mode before PRE since r0-89162-g11b08ee9118d10 too. And since r0-95499-gb5b8b0ac643d31, dominance information was required even for non-agressive mode. Also we have been verifying dominance information is correct and not needing to invalidate since ssa branch was merged so this comment has been out of date even before it was merged in. gcc/ChangeLog: * tree-ssa-dce.cc (perform_tree_ssa_dce): Remove FIXME note. Signed-off-by: Andrew Pinski --- gcc/tree-ssa-dce.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/gcc/tree-ssa-dce.cc b/gcc/tree-ssa-dce.cc index 3075459e25f..015c17984e1 100644 --- a/gcc/tree-ssa-dce.cc +++ b/gcc/tree-ssa-dce.cc @@ -1965,13 +1965,7 @@ make_forwarders_with_degenerate_phis (function *fn) In conservative mode, we ignore control dependence and simply declare all but the most trivially dead branches necessary. This mode is fast. In aggressive mode, control dependences are taken into account, which - results in more dead code elimination, but at the cost of some time. - - FIXME: Aggressive mode before PRE doesn't work currently because - the dominance info is not invalidated after DCE1. This is - not an issue right now because we only run aggressive DCE - as the last tree SSA pass, but keep this in mind when you - start experimenting with pass ordering. */ + results in more dead code elimination, but at the cost of some time. */ static unsigned int perform_tree_ssa_dce (bool aggressive)