From patchwork Mon Oct 14 15:28:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Jambor X-Patchwork-Id: 1997043 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=MgKNp5mK; dkim=pass header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QjKLbEkw; dkim=pass (1024-bit key) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa header.b=MgKNp5mK; dkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=QjKLbEkw; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XS1P14lV4z1xtb for ; Tue, 15 Oct 2024 02:29:24 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83FA9385AE63 for ; Mon, 14 Oct 2024 15:29:19 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 2D404385AE42 for ; Mon, 14 Oct 2024 15:28:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D404385AE42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D404385AE42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728919741; cv=none; b=O558vd0d6O9WwG9aTswvx9305NJSO3+TkDwofWolCaAaKUc5KWCyoUDpQb7UqORMhZREbQajPN4YihmAuusgNZfJ3OvAr5c7c5AwcSwDEjcSqFRMG7UQEyLWZIFla6ZHI5MTusfH7OQxV9+ZubH5RoOu1W9mS4CxjHcVamB2YZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1728919741; c=relaxed/simple; bh=dNk+ShORGWN0fJrIhEm0NNhAjVxwx9TkOp4Up2oCA5M=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=T7PgjoNKr1jmJ3plCSFj4Ke6T/8QoRmS7PlTjSzp7Hdms9hc1BhpcXlVPbXlYXeZqqCDeF+YoGJP3LiSfI9UCSf1ZiJeBtgh+CG1yafC20JQazhwaFI0bBBhljAApzaAAhcsVIKtPH10Q+nfNLa5jKp5X5x4nxv4xPL/JJUfq6Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1A78F1F80B for ; Mon, 14 Oct 2024 15:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728919730; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=mcjNUgyhgbGJV56EqhIpzBINiEIKw/1LzUs/cgug3os=; b=MgKNp5mKnxKeEO5HMNYUgZ97IRzxFLtq5bQ1DaCNLKNjPpVl91OWO4elNYdXKk5BdX1fFG 00mxHbGnLGtF8C67CNT/77fb/V9+VVtcLK17KGJwDHUfdaWMJY2Y9HZxcwqYm9HZTiE2Lr kGsifIS9j6gTXkkNzg4Z6t/vMyxceV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728919730; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=mcjNUgyhgbGJV56EqhIpzBINiEIKw/1LzUs/cgug3os=; b=QjKLbEkwlXXXYlfLWOqYN045EJ1lnb/RIMnqBP8cZlfEIcipF4oH90vUbqY5zU53zc5pKH YPp1egrFjiOStPBg== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=MgKNp5mK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=QjKLbEkw DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1728919730; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=mcjNUgyhgbGJV56EqhIpzBINiEIKw/1LzUs/cgug3os=; b=MgKNp5mKnxKeEO5HMNYUgZ97IRzxFLtq5bQ1DaCNLKNjPpVl91OWO4elNYdXKk5BdX1fFG 00mxHbGnLGtF8C67CNT/77fb/V9+VVtcLK17KGJwDHUfdaWMJY2Y9HZxcwqYm9HZTiE2Lr kGsifIS9j6gTXkkNzg4Z6t/vMyxceV0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1728919730; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=mcjNUgyhgbGJV56EqhIpzBINiEIKw/1LzUs/cgug3os=; b=QjKLbEkwlXXXYlfLWOqYN045EJ1lnb/RIMnqBP8cZlfEIcipF4oH90vUbqY5zU53zc5pKH YPp1egrFjiOStPBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0D12A13A51 for ; Mon, 14 Oct 2024 15:28:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4ljvArI4DWc2egAAD6G6ig (envelope-from ) for ; Mon, 14 Oct 2024 15:28:50 +0000 From: Martin Jambor To: GCC Patches Subject: [PATCH] testsuite: Add necessary dejagnu directives to pr115815_0.c User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Emacs/29.4 (x86_64-suse-linux-gnu) Date: Mon, 14 Oct 2024 17:28:45 +0200 Message-ID: MIME-Version: 1.0 X-Rspamd-Queue-Id: 1A78F1F80B X-Spam-Score: -4.51 X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.cz:email,suse.cz:dkim]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; DKIM_TRACE(0.00)[suse.cz:+] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Hi, I have received an email from the Linaro infrastructure that the test gcc.dg/lto/pr115815_0.c which I added is failing on arm-eabi and I realized that not only it is missing dg-require-effective-target global_constructor but actually any dejagnu directives at all, which means it is unnecessarily running both at -O0 and -O2 and there is an unnecesary run test too. All fixed by this patch. I have not actually verified that the failure goes away on arm-eabi but have very high hopes it will. I have verified that the test still checks for the bug and also that it passes by running: make -k check-gcc RUNTESTFLAGS="lto.exp=*pr115815*" OK for master (and than to be part of the backports which I still need to do)? Thanks, Martin gcc/testsuite/ChangeLog: 2024-10-14 Martin Jambor * gcc.dg/lto/pr115815_0.c: Add dejagu directives. --- gcc/testsuite/gcc.dg/lto/pr115815_0.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/testsuite/gcc.dg/lto/pr115815_0.c b/gcc/testsuite/gcc.dg/lto/pr115815_0.c index d938ae4c802..ade91def55b 100644 --- a/gcc/testsuite/gcc.dg/lto/pr115815_0.c +++ b/gcc/testsuite/gcc.dg/lto/pr115815_0.c @@ -1,3 +1,7 @@ +/* { dg-lto-options {{-O2 -flto}} } */ +/* { dg-lto-do link } */ +/* { dg-require-effective-target global_constructor } */ + int a; volatile int v; volatile int w;