From patchwork Fri Oct 11 19:43:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 1996280 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MzDSImMX; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ozlabs.org (client-ip=150.107.74.76; helo=mail.ozlabs.org; envelope-from=srs0=w7wh=rh=vger.kernel.org=linux-ext4+bounces-4572-patchwork-incoming=ozlabs.org@ozlabs.org; receiver=patchwork.ozlabs.org) Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XQHCr2dj2z1xv6 for ; Sat, 12 Oct 2024 06:45:27 +1100 (AEDT) Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4XQHCn4g0Xz4xN6 for ; Sat, 12 Oct 2024 06:45:25 +1100 (AEDT) Received: by gandalf.ozlabs.org (Postfix) id 4XQHCn4Y0Qz4xQq; Sat, 12 Oct 2024 06:45:25 +1100 (AEDT) Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: gandalf.ozlabs.org; arc=pass smtp.remote-ip=139.178.88.99 arc.chain=subspace.kernel.org ARC-Seal: i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1728675925; cv=pass; b=M5WgHbw3/peS7iT415y3NxXGsSYfwWg96zBI+9cUEZNkfAhiK/D+jNjerPe8fDGIBBUXHdHt67evA9FmY7a/nrQIBmld2Ermp5Nzl3zZpqzrjMpIDEBkT9ZbgT8XisffXqyTy9IYVQJJeorB45wV0t5C348XIj8xBexxD5iqoYBt5qJTmSPCwMGJTtXUUoH/Ep4CNm1IpKEPyAAMVEeJsCpuqzmOy79VzSitv/pHp74x1/+K1qUsrp2Np2XRyVVqyzX6gfbZZBJzgEBFMExJvkA5YwLKWFdPqz7+bmT5BZuxdPbw0AjBot0Vi8RexQXOPUTbSEJEOuFQr6iMDYZadQ== ARC-Message-Signature: i=2; a=rsa-sha256; d=ozlabs.org; s=201707; t=1728675925; c=relaxed/relaxed; bh=snxiN7FRdAtoQFX+9wj1Js2TBnmcNUFNjqb40Wms3JA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=mcJ4a15AKwBJ43m9ZC7eKe24RlpZeOqHBH7b7XUAjj1mUhFjP2iaLFJBo/YutxUaMqTrLtlOiAH7Ecu48n+ixnmcNYA55jWITtRu9akdFuNSya5s9DGowH7Urn/OlUumO5ETK5EKNRzLpwxgbJLTO02UL0Jj5iYILECr4lV6RtcMB+cz35t+17Par40NSoyXs/GvPMCwaHN84lhtSHlzG+ii7g9Mo4yOiTksWiDOsc4vzXbNC0PuxCHXnX7rgSk33UfVTkmNUByY+/fPpCzk7ORdJ0q8u6M/+tKDZotAn+ksiiJtBdcsJWv2SQRSonqwwsOd3pLD5x2OW0m8Zf0P/g== ARC-Authentication-Results: i=2; gandalf.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MzDSImMX; dkim-atps=neutral; spf=pass (client-ip=139.178.88.99; helo=sv.mirrors.kernel.org; envelope-from=linux-ext4+bounces-4572-patchwork-incoming=ozlabs.org@vger.kernel.org; receiver=ozlabs.org) smtp.mailfrom=vger.kernel.org Authentication-Results: gandalf.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: gandalf.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=MzDSImMX; dkim-atps=neutral Authentication-Results: gandalf.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=139.178.88.99; helo=sv.mirrors.kernel.org; envelope-from=linux-ext4+bounces-4572-patchwork-incoming=ozlabs.org@vger.kernel.org; receiver=ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [139.178.88.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by gandalf.ozlabs.org (Postfix) with ESMTPS id 4XQHCn2D83z4xN6 for ; Sat, 12 Oct 2024 06:45:25 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E919F28B13E for ; Fri, 11 Oct 2024 19:45:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1DAD1D27B8; Fri, 11 Oct 2024 19:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MzDSImMX" X-Original-To: linux-ext4@vger.kernel.org Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D7F21D0DF0 for ; Fri, 11 Oct 2024 19:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728675831; cv=none; b=MhwtlQ79R26VY7KQlE3GmnDfsAyRZ4srg1W4uy9fB8mEs9ngp65N2QpcXW/P4TcQJyHL8cFpJJvmhGQMRKBbKl28l19qRE1G3tN51v2NTOLk+mGkalnlnhx6A+Z9EY/v6z6/YZQ+pi/YKprLiEYqFPcKsAAl6UOuLo/jvAEMWuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728675831; c=relaxed/simple; bh=HiP2jOYwlaN68o8fGVOSlLIUh0g94c1H626IWPYeMaA=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=kM9hJViMmdcIs1ptiY0C8KaeAxS+hq+RTXg8j2qqvWCpVnT86dYLw1h+5NH/RjpXqNBbfPPTfc3hj9ADM6KZeGosnC1SIkiz+YAAZqR3yrLluC+6EQcZxpc+UI0sYqoMhRDsmxw3XhL3JZMwZA8j6v6/NsNpV/6DEdoyncpiN0Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MzDSImMX; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-37cea34cb57so1447394f8f.0 for ; Fri, 11 Oct 2024 12:43:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728675828; x=1729280628; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=snxiN7FRdAtoQFX+9wj1Js2TBnmcNUFNjqb40Wms3JA=; b=MzDSImMXLs6LaRdCpvtEeqnd735C5Go/xkpg+mTtaUjmqjMFMPugGnq2YKPerU2pRb buVoZD+42JuYLgbIbHvJ3XQixjS2z+DPmtWC3ZbNSR813efLU3eLdeT/ckwgXOJePJe7 IKZ0KozpYIN2iYH3C8rRaQTxN2lRXkInYKbh+ibc8bKliCm6FFfRh16+1Q9r58F2rsMI FaOBimBwPp+ELhBOsQyQuf3gyFTAh5vpBY2Zv4EP7tzrDZjCreTrGr/gQp4KCyg2C4Sk mWj2Jj/BQhsWynTgRV3lglYQUtxTVTMxkIL2h5gm4CRsGcsxy3EkRVtYsgm80ORJTmcr bu9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728675828; x=1729280628; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=snxiN7FRdAtoQFX+9wj1Js2TBnmcNUFNjqb40Wms3JA=; b=sUK0QAE2iRTB2QXvzyrOhFgjE2OHVgnDwtyfjws0p335cJIqMLkb6QAJKq7RuL4SfK qDXZBHfTLFpLt0XXs2yEOf10qTuLIFoENDNBw/MljZ+gBDgbJlORdNrgny7tD4+/LyAC W8mBoZfexKpvSXAZJn8M6ge4rzUl483li6aiJmjZDYGTgLQg9D4WJz5BrDwVgtiIznBT 6G7tUe4XKwxB00AL+s34e0iZ9Aa78kXdTkydQU/I/Z7WotfKi88iI/I1xqtFpNbbwUtn A4uJYMCv9/boT5tLwHXlMMxlgX8StB01a5mR/2VtgGy+48alHZ8VDKAVGOpPfZzZhq7d aUsQ== X-Forwarded-Encrypted: i=1; AJvYcCXRMrGIXWmngDdLn9Has1f1LOy9ls3WlLLmhUUJzBJysAEEJoBn2e7aXnbUtuGyvIXT7j+BhA4r1NEL@vger.kernel.org X-Gm-Message-State: AOJu0YxjIt6VbkEb/tlR2MQNOwEN8qZYaWO3XwAwSVkQ4lp08TKZ9b2Q mGKc7+ZW5Mc6LSlMml3N+z7LCWN3IAhXvCyTuPSUg0NIEraHAnUsJiQ/Ey0OUGs= X-Google-Smtp-Source: AGHT+IGqnlRZZDSw4G70Cr1FwcKYeBF9aBQnwl7GGMEcvuGtDm0ChmM83BRDyWQouKHv719pFKBvZg== X-Received: by 2002:a05:6000:18a7:b0:374:c92e:f6b1 with SMTP id ffacd0b85a97d-37d551b9788mr3103211f8f.23.1728675828472; Fri, 11 Oct 2024 12:43:48 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-430d748d885sm83769715e9.46.2024.10.11.12.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Oct 2024 12:43:47 -0700 (PDT) Date: Fri, 11 Oct 2024 22:43:44 +0300 From: Dan Carpenter To: Theodore Ts'o , Ritesh Harjani Cc: Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] ext4: cleanup variable name in ext4_fc_del() Message-ID: <96008557-8ff4-44cc-b5e3-ce242212f1a3@stanley.mountain> Precedence: bulk X-Mailing-List: linux-ext4@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding The variables "&EXT4_SB(inode->i_sb)->s_fc_lock" and "&sbi->s_fc_lock" are the same lock. This function uses a mix of both, which is a bit unsightly and confuses Smatch. Signed-off-by: Dan Carpenter --- fs/ext4/fast_commit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c index b33664f6ce2a..e4cb1356e9b6 100644 --- a/fs/ext4/fast_commit.c +++ b/fs/ext4/fast_commit.c @@ -291,9 +291,9 @@ void ext4_fc_del(struct inode *inode) return; restart: - spin_lock(&EXT4_SB(inode->i_sb)->s_fc_lock); + spin_lock(&sbi->s_fc_lock); if (list_empty(&ei->i_fc_list) && list_empty(&ei->i_fc_dilist)) { - spin_unlock(&EXT4_SB(inode->i_sb)->s_fc_lock); + spin_unlock(&sbi->s_fc_lock); return; }