From patchwork Fri Sep 20 07:24:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987698 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=LfRlDPZz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93nN48ZNz1y27 for ; Fri, 20 Sep 2024 17:25:12 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B01F1893AC; Fri, 20 Sep 2024 09:25:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="LfRlDPZz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C60D3893AB; Fri, 20 Sep 2024 09:25:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DFA7C8931A for ; Fri, 20 Sep 2024 09:24:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-42cb9a0c300so14420505e9.0 for ; Fri, 20 Sep 2024 00:24:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817098; x=1727421898; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3OX0vrWofXUX3tDwqNLSoX0fY8kyAyXd0nLgHqZRKqE=; b=LfRlDPZz6pCCuVTUrhmKEKEhXfMmcWNEsLLuevBxp4KEuLTl+bgtfb7Pu7EK5/RcaF VzVs6Qzd5tcJ/sguqPvnHyVwqmI9pJEuE1+uf8ovTaYi/bP7ovQplr49vrXVjD5iYxkA n4EWrepgSY6FOGL7YVZDLiG8pf+xGmueYrOQk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817098; x=1727421898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3OX0vrWofXUX3tDwqNLSoX0fY8kyAyXd0nLgHqZRKqE=; b=mCG6sBq5UsIq6yQt2L+VdE5/meB/lNao98e0viDDnAZocQO6959csn+h9rNOcI2D4g xwzgA3TrNgY8bT2Q1IEpkqraPHgzpDgY/XLnQ7A7/K23MhclUFJZ64uJTDUT/82L9ibB 7Zmj0O9ZkVvQMxIvg/DzSouqEMD9dZaNs1gpdcO/TPOTMID86c2lFsmlbP4u5Sb5ByB8 mOAZ418yap2spKlImaG4arDNhIt0X2JoGTCgybJOPvakeGY7T6L/+xrTsRb88IzUSHgo F1FrNfnwVwv+pj6FxiwpYqBoXxlqmdn+Kiiysb9wlCeVCdhhtx23Pe54DIAMj7xsdVfM PzWQ== X-Gm-Message-State: AOJu0YwDj5eoBMzlmYkx+8zo3lgRQXCDGkfegVSkX/xz9W3HBx5V/Ct2 OFnjF6GjaLoFDVf5coA1I6by5qZhaTxSUrbO9Gg2xgFCaZty+zeaVhIJ24BHLg2OO2R5kCUShUd sUK1/ X-Google-Smtp-Source: AGHT+IHvMPQXjux4QZgmVEtecUTt110wZ28s3WqT0lQ6XoRbTY/so82Wlmmjdgb5W3tzAdI5O89kBg== X-Received: by 2002:a05:600c:1d29:b0:42c:b309:8d18 with SMTP id 5b1f17b1804b1-42e7ac23136mr11840945e9.19.1726817098129; Fri, 20 Sep 2024 00:24:58 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:24:57 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Tom Rini Subject: [PATCH v2 01/18] sandbox: Add missing header file Date: Fri, 20 Sep 2024 09:24:25 +0200 Message-ID: <20240920072444.134997-2-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This file uses __aligned so should include the header which defines that. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/include/asm/sections.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sandbox/include/asm/sections.h b/arch/sandbox/include/asm/sections.h index 88837bb35c8..5e1577419b0 100644 --- a/arch/sandbox/include/asm/sections.h +++ b/arch/sandbox/include/asm/sections.h @@ -10,6 +10,7 @@ #define __SANDBOX_SECTIONS_H #include +#include struct sandbox_cmdline_option; From patchwork Fri Sep 20 07:24:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987699 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=fR6P834J; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93nZ6kg0z1y27 for ; Fri, 20 Sep 2024 17:25:22 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DD02E893BE; Fri, 20 Sep 2024 09:25:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="fR6P834J"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 463DE893B5; Fri, 20 Sep 2024 09:25:02 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D34DD89325 for ; Fri, 20 Sep 2024 09:24:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-42cb6f3a5bcso20397855e9.2 for ; Fri, 20 Sep 2024 00:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817099; x=1727421899; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bIGoR+CyRXutjDnSN6AF+1wfyfBLN/4tYx//54TReYQ=; b=fR6P834J7bulTJj9qIFhXq0uA341Gl6S0xQberhVaU2hgKyJJBQxqnJXjfS67VhufL zGK0yhh4tulc1B79varaQE6x8rTd0fIogLwPXvbNRTRTa+WjyN2YIlQGNlH3UI5nlse2 GBRPqh2hdiZI5bNla0SNxrNTIFBk9ZyQOo74s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817099; x=1727421899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bIGoR+CyRXutjDnSN6AF+1wfyfBLN/4tYx//54TReYQ=; b=BSegmKMtJIB4L5e6zjWXpgEA/gpCzgT6dQr457ChnC6/T824xnx9PeBEi7WMQOBTE9 1nKhHEDOrqqQjhZ/BUXVvvjac674AuJVsUrhF+QI/wB0IazpoeZYQ21DiYUF/GxgWrN3 CY8k5e7SKoR0JItxdKlRypl+Ct3ylAAPcuOOk+5+EhqULka2kFyEGqKf3aci/CxyMowZ s0WbL9KsRWwLaxUINBVKw7wmMSIgKzFQsf+TBKn3gcjo15hkhWzSi4W6aDGxYBp1k8MD vl7MR2CkpKiHyiXScp1Ap8bc/3w0iPGRGdX1wbLzYjMsIC6/8krIhKDqRSoEU/1Y4jjm X38A== X-Gm-Message-State: AOJu0YyZ61HyFVqLq8dLL7IWNiDEUfvL1Qq8BV6hE8Lu/oBpnlJ3/nAv jGFtZm//ALWKJDNahNXJ9gCUUmLa9UO3KstZ+KPEa7uFnm6x+pax4v64mBIuyS2IK8PCRFodoJ/ 2ddq8 X-Google-Smtp-Source: AGHT+IFjAuPlAKJGeEAxnW3kLtv0i7f5tt9HHpZOQO75jJCgtUfZ04+U6HQ+pUMrG+X0X3GxgmjMxQ== X-Received: by 2002:a05:600c:4fcd:b0:42c:b508:750e with SMTP id 5b1f17b1804b1-42e7ac1dd5fmr17263845e9.11.1726817099143; Fri, 20 Sep 2024 00:24:59 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:24:58 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Ilias Apalodimas , Tom Rini , Tony Dinh Subject: [PATCH v2 02/18] bootstd: Add stub for bootdev_setup_for_sibling_blk() Date: Fri, 20 Sep 2024 09:24:26 +0200 Message-ID: <20240920072444.134997-3-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean When bootstd is not enabled, bootdevs should not be set up. Add a static inline function to see to this. Signed-off-by: Simon Glass --- (no changes since v1) include/bootdev.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/bootdev.h b/include/bootdev.h index 2cee8832d26..ad4af0d1310 100644 --- a/include/bootdev.h +++ b/include/bootdev.h @@ -395,6 +395,7 @@ int bootdev_next_prio(struct bootflow_iter *iter, struct udevice **devp); */ int bootdev_setup_for_dev(struct udevice *parent, const char *drv_name); +#if CONFIG_IS_ENABLED(BOOTSTD) /** * bootdev_setup_for_sibling_blk() - Bind a new bootdev device for a blk device * @@ -409,6 +410,13 @@ int bootdev_setup_for_dev(struct udevice *parent, const char *drv_name); * Return: 0 if OK, -ve on error */ int bootdev_setup_for_sibling_blk(struct udevice *blk, const char *drv_name); +#else +static int bootdev_setup_for_sibling_blk(struct udevice *blk, + const char *drv_name) +{ + return 0; +} +#endif /** * bootdev_get_sibling_blk() - Locate the block device for a bootdev From patchwork Fri Sep 20 07:24:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987700 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=OTdA+Nrn; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93nn0FVwz1y27 for ; Fri, 20 Sep 2024 17:25:33 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7AE3B893CC; Fri, 20 Sep 2024 09:25:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="OTdA+Nrn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E3599893BF; Fri, 20 Sep 2024 09:25:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AEC41893AB for ; Fri, 20 Sep 2024 09:25:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-42cb6f3a5bcso20398305e9.2 for ; Fri, 20 Sep 2024 00:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817101; x=1727421901; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y7V8MtCNfi1sqs2E0277b0DCcPf7rgxDJ9fxRTh1I1E=; b=OTdA+NrnfIA52KIxbQ2jA7dck0FK3QNe4ObpYEPw66QZi/IZvehFUSl3aS3bjl6XAv 8Rj302hFqZ6cGMVGEt5yyGUSPRXdRbMDE5IRdWxGFaeelmDXOu9hZGMk0AuyLB/Xfpzd VIq6RfDSj9HxUZQb4KRWKPx2fyoZGbxn1KGlw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817101; x=1727421901; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y7V8MtCNfi1sqs2E0277b0DCcPf7rgxDJ9fxRTh1I1E=; b=YTV/kUfG/0/xer+b23salYK9CIIf6E3ZX/mZlcDbFLzElKBAAi0I//xaIL6OMPw1j/ 0GluqRkFfiOOVQ+oVm95P5/8xTHq4t7+aOXx2/aEucket+upuZm9hdAXhlPC2IDkeUVO icOFdcIKVqYwAcA6PoOwpZtcpdRIllZcWIm2T9banyJOWF3ECpuqP7orwtyYbzRz48uW /1iY5G5uH9rlEcUhl2mDcPw0TN2ZeAjVFeyXU/f+mVj2ZjqrCqmpbdtHJkpSEQ7Orfgf fSka3I0IAWsrOmr8wbI8qUlRRFrWJWGx6h5jrkDwWEGLO7OKLuF/I+J/aH1ZpzyEVMOD NYFg== X-Gm-Message-State: AOJu0YxASyaQ/+Of2YrhwDoTizQ+ogbUiuFw/KBF8U3Nfikhjxq3zAey 2+c31Zh3cnfpHHA3UyGmr6f1D8p0QTXoVTH3B9sfKFU2rKuPtQVurjU50IAhBEYrfemeOdmT04R z06vX X-Google-Smtp-Source: AGHT+IEYXt44Ql30qPHsZcB7LU6Xrff1e7J5saTob+ZQS2gCDACO0zagbiZWmVjnAyRHTUgjC3+/Vw== X-Received: by 2002:a05:600c:c16:b0:42c:b802:47bc with SMTP id 5b1f17b1804b1-42e7adf9486mr16232235e9.34.1726817100951; Fri, 20 Sep 2024 00:25:00 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:24:59 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Tom Rini Subject: [PATCH v2 03/18] gzip: Correct function comment for gunzip() Date: Fri, 20 Sep 2024 09:24:27 +0200 Message-ID: <20240920072444.134997-4-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This doesn't describe the length parameter correctly. Fix it and zunzip() too. Signed-off-by: Simon Glass --- (no changes since v1) include/gzip.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/gzip.h b/include/gzip.h index 5e0d0ec07fb..304002ffc42 100644 --- a/include/gzip.h +++ b/include/gzip.h @@ -28,7 +28,8 @@ int gzip_parse_header(const unsigned char *src, unsigned long len); * @dst: Destination for uncompressed data * @dstlen: Size of destination buffer * @src: Source data to decompress - * @lenp: Returns length of uncompressed data + * @lenp: On entry, length of data at @src. On exit, number of bytes used from + * @src * Return: 0 if OK, -1 on error */ int gunzip(void *dst, int dstlen, unsigned char *src, unsigned long *lenp); @@ -39,7 +40,8 @@ int gunzip(void *dst, int dstlen, unsigned char *src, unsigned long *lenp); * @dst: Destination for uncompressed data * @dstlen: Size of destination buffer * @src: Source data to decompress - * @lenp: On entry, length data at @src. On exit, number of bytes used from @src + * @lenp: On entry, length of data at @src. On exit, number of bytes used from + * @src * @stoponerr: 0 to continue when a decode error is found, 1 to stop * @offset: start offset within the src buffer * Return: 0 if OK, -1 on error From patchwork Fri Sep 20 07:24:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987701 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Vdkx0RVD; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93nz0nLjz1y27 for ; Fri, 20 Sep 2024 17:25:43 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0CB48893CF; Fri, 20 Sep 2024 09:25:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Vdkx0RVD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 013018939A; Fri, 20 Sep 2024 09:25:04 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E04D88939A for ; Fri, 20 Sep 2024 09:25:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-42cae4eb026so15601055e9.0 for ; Fri, 20 Sep 2024 00:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817102; x=1727421902; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6e0o/F7aq2nC/vaU8+aHr3OBAvwMXQ7qD5FTGSoV6TM=; b=Vdkx0RVDKUuyBA6vXWB6NJwd6OES2Vo3PK0vvymkMTJjGLtiMJfdzU9vwfmgDBf3UB dZTFw8ZXt/pWRb1+LlVsNm5ZSW2dZxOZenix0X3RrC7VaHiaakiWVzFbAhqEVDuPv3J1 n9wEMjlCtH2UAw7K2QErSbMQZRkkQVvFjyykE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817102; x=1727421902; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6e0o/F7aq2nC/vaU8+aHr3OBAvwMXQ7qD5FTGSoV6TM=; b=LYizwFtqT/hAzkJt/QWsswqNj1Vx4fjuNOxHDcrOiMBJoPoun6FQVp4Ldrm9OKGW1+ TyM6CV/gsJFiTZet+eD5LF6FNjua3neUMuHBwc1HIpbAMuGe9W8Dp5o/ICrWHU+ef0Ul lI3Mpcui7MW8XML+bVUsvuNbE2M76QkrwJSD3ohVeiGJZAvjc+144qeJYT8df7+NApl5 u+LQ2iWAfGoXC00tHwrnOUhy69Tsyv65iA40CY9fuwWnywZTj4ZQRE2zEl+sSJXh1eK2 amBazZPR85BedsVWtrFnWT/QL94GDc7z8eQb/JJ0b58wHChITKOUsCpYwZQE83tY6KEm uDBw== X-Gm-Message-State: AOJu0YwG06yI722XQenR7wlRzEjfH4CfcBz4ooYua17pIUs6K9k9Bl/h o165zp5fr69ZNEeB+2Ep7MBXi7sNIuFuWBImgQeSX6MWs8JCNjKtBB7WEvl45DnUtxKY8Z5qNLC zEHtZ X-Google-Smtp-Source: AGHT+IExF2q0G2b93OHNsKDQeip6cQQfx5DWiL5xPBeRUW6jdtyoOEADS6mDHzPlry8Zn+H11OPd7A== X-Received: by 2002:a05:600c:4705:b0:428:f0c2:ef4a with SMTP id 5b1f17b1804b1-42e7c1640aamr10939065e9.13.1726817102123; Fri, 20 Sep 2024 00:25:02 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:01 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Ilias Apalodimas , Marek Vasut , Raymond Mao , Tom Rini Subject: [PATCH v2 04/18] fdtdec: Support separate BSS for all XPL builds Date: Fri, 20 Sep 2024 09:24:28 +0200 Message-ID: <20240920072444.134997-5-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Adjust the condition so that separate BSS can be deselected for TPL and VPL. Signed-off-by: Simon Glass --- (no changes since v1) lib/fdtdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/fdtdec.c b/lib/fdtdec.c index 5edc8dd2f9f..106bb406365 100644 --- a/lib/fdtdec.c +++ b/lib/fdtdec.c @@ -1232,7 +1232,7 @@ static void *fdt_find_separate(void) #ifdef CONFIG_SPL_BUILD /* FDT is at end of BSS unless it is in a different memory region */ - if (IS_ENABLED(CONFIG_SPL_SEPARATE_BSS)) + if (CONFIG_IS_ENABLED(SEPARATE_BSS)) fdt_blob = (ulong *)_image_binary_end; else fdt_blob = (ulong *)__bss_end; From patchwork Fri Sep 20 07:24:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987702 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=OiljHBC0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93p8696Rz1y27 for ; Fri, 20 Sep 2024 17:25:52 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8C60B893D7; Fri, 20 Sep 2024 09:25:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="OiljHBC0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C4EF8893CF; Fri, 20 Sep 2024 09:25:06 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 859C1893AB for ; Fri, 20 Sep 2024 09:25:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-42cbc38a997so10629565e9.1 for ; Fri, 20 Sep 2024 00:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817104; x=1727421904; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yVuC+btv1ynKm1nlD+gPhEXMetVG6avPIPo7AET1HKw=; b=OiljHBC063mdWSycI3f3cvOZEK9iKA3YPXQX7TOopgcpY09dpd1OIxWNmqCWPn4OwD KbUbWfkWXYiE0HdTigjxZyIR0567wceRSSRvJtGUbOM9Y3j1sLr2fMvP5IeXIDV4tAof imbGWkadbLIXI4LHzYtETQ0JvaRryGnghsWjU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817104; x=1727421904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yVuC+btv1ynKm1nlD+gPhEXMetVG6avPIPo7AET1HKw=; b=P8mtjR3e8GjyKCiEM7tizuhBtciEH3WI5c26s+tMc+CJLe4KtQWGGmtAD08cnXvbJb q7fH2GJbh4zfEVJnLwWsZc91hmXNfEROQq3jF/ZUWlW5/NgkZC9hjoYrmSNRtIT8n+pU INbm8dhxPIVO923BRzwfsUdWAXW8tR6YjD3b/Z2C529ckHwQJf0wG4kkmnoIjS/2cFI/ 5roWiWlvtI0Wd+I5g07A+BaY+QEw5D28XWSm7PUZ0vShaWhoPRsgGN68bqPIJF++yCDK bhlUXVtDQfVwdEGTirupANnSopQ458bpF0NgTawzWM/2vvh55lmm40KZcSN6VYBtiYto pw8g== X-Gm-Message-State: AOJu0YxD2uDDDpD61InnyrxNMY0UNgMVWBwxs7fc5yer72PuOxkT6Ccc sRga5hXM4+/F4WkuI0j0Jb6CW/h6VNfdobbXqOyaSKFJco8GgfQ8GVc7nwghTFO5tCV6BiUDNmS J1mI/ X-Google-Smtp-Source: AGHT+IGPvM0nuposlWiyZNrqFkl02koD/TYGZUlFDVzRnMxEi3ZCI/p4IdQlm+tSoNXGGQ1EaJJ/XQ== X-Received: by 2002:a05:600c:524f:b0:42c:b697:a62c with SMTP id 5b1f17b1804b1-42e74406528mr35462155e9.5.1726817103661; Fri, 20 Sep 2024 00:25:03 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:03 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Tom Rini Subject: [PATCH v2 05/18] tiny-printf: Correct return values Date: Fri, 20 Sep 2024 09:24:29 +0200 Message-ID: <20240920072444.134997-6-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean The sprintf() etc. functions are supposed to return the length of the string written, but do not. Fix this by checking the amount of buffer space used. Signed-off-by: Simon Glass --- (no changes since v1) lib/tiny-printf.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/lib/tiny-printf.c b/lib/tiny-printf.c index 9a70c6095b3..64dee779c4a 100644 --- a/lib/tiny-printf.c +++ b/lib/tiny-printf.c @@ -365,16 +365,15 @@ int sprintf(char *buf, const char *fmt, ...) { struct printf_info info; va_list va; - int ret; va_start(va, fmt); info.outstr = buf; info.putc = putc_outstr; - ret = _vprintf(&info, fmt, va); + _vprintf(&info, fmt, va); va_end(va); *info.outstr = '\0'; - return ret; + return info.outstr - buf; } #if CONFIG_IS_ENABLED(LOG) @@ -382,14 +381,13 @@ int sprintf(char *buf, const char *fmt, ...) int vsnprintf(char *buf, size_t size, const char *fmt, va_list va) { struct printf_info info; - int ret; info.outstr = buf; info.putc = putc_outstr; - ret = _vprintf(&info, fmt, va); + _vprintf(&info, fmt, va); *info.outstr = '\0'; - return ret; + return info.outstr - buf; } #endif @@ -398,16 +396,15 @@ int snprintf(char *buf, size_t size, const char *fmt, ...) { struct printf_info info; va_list va; - int ret; va_start(va, fmt); info.outstr = buf; info.putc = putc_outstr; - ret = _vprintf(&info, fmt, va); + _vprintf(&info, fmt, va); va_end(va); *info.outstr = '\0'; - return ret; + return info.outstr - buf; } void print_grouped_ull(unsigned long long int_val, int digits) From patchwork Fri Sep 20 07:24:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987703 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=kL3X8ev5; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93pM3N8rz1y27 for ; Fri, 20 Sep 2024 17:26:03 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 09041893B8; Fri, 20 Sep 2024 09:25:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="kL3X8ev5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1C523893C0; Fri, 20 Sep 2024 09:25:11 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 748C0893CA for ; Fri, 20 Sep 2024 09:25:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-42cbbb1727eso14197715e9.2 for ; Fri, 20 Sep 2024 00:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817106; x=1727421906; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1cAqMOdVkPXMZkqYPqQrvePRcBkZSMjsPsIe0sheqGs=; b=kL3X8ev5ixtlnbuvKaK2wz2Z9J2DhPHy3HngtopcARL/ra6Z9lKDU/FuRvxHOwk+Qv +RjoCoybIYOQqdJi85yZlv552RsufQnsBwDvuXIcKTKpJu1bO7P5gmV6s8yWzEZE+gi+ mcvxPdvzTfHRZ7uBfaiAhUxUYwNIusBmYpV+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817106; x=1727421906; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1cAqMOdVkPXMZkqYPqQrvePRcBkZSMjsPsIe0sheqGs=; b=QoWQqUd6dLngsl9+aeegQ4Kxw1rtUG9wf/qMtXNV2Te4ktdvMxtvlCRZfwWf051zR/ fTFTjIprY6FwhzA/umn0ylxv5LUQa/w9vQIBbFqm3MsFbVmV2dOi8/xo+F3NVdGVR2DI QLtqRLlnl5zYUBgJatWDzdyaJUgetxLwrusTZV79N1mbQ41BBgy/1E2vYeg2hR+0weKW o2Q99bkX534JvKG3ruh3qorXCLBfcXxzgbiwzb9PO8wFPc+4dFkv1z3WHek9D0QYjbfN prpT8b5qfTfJmaWvy+mO8bzZD0mVzdSgIMLoE+NbnMcXPFwv3BjcgkS6FWkaKum0LL2N OShw== X-Gm-Message-State: AOJu0YxjnPz+F4SDB5Xb8W5uKczXZOeowTWHnK7bsKbKkU7yHVtVbs/0 nHol91kGyYODP8XMfirVeAhGlDh/K1P1e+DOmD9Aj4enpDvj/Ru7xNbL/+8lqWih/OfNTRNPq3P uG78u X-Google-Smtp-Source: AGHT+IGh1dWRCgI04WrehEA/F1XtqLR9EO0q2CpDCvotJHea0gbZV0apLA5+xQWJn2/y9mel3VYkBw== X-Received: by 2002:a05:600c:548e:b0:42c:b7e2:3bc3 with SMTP id 5b1f17b1804b1-42e7ac244f3mr11714665e9.19.1726817105361; Fri, 20 Sep 2024 00:25:05 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:04 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , "Gaskell, Oliver" , Heinrich Schuchardt , Igor Opaniuk , Quentin Schulz , Svyatoslav Ryhel , Tom Rini Subject: [PATCH v2 06/18] tpl: Support numbered aliases in device tree Date: Fri, 20 Sep 2024 09:24:30 +0200 Message-ID: <20240920072444.134997-7-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Add an option so that this feature can be enabled in TPL for boards which need it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/Kconfig | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index c39abe3bc94..6b4330fe4ea 100644 --- a/drivers/core/Kconfig +++ b/drivers/core/Kconfig @@ -152,6 +152,14 @@ config SPL_DM_SEQ_ALIAS numbered devices (e.g. serial0 = &serial0). This feature can be disabled if it is not required, to save code space in SPL. +config TPL_DM_SEQ_ALIAS + bool "Support numbered aliases in device tree in TPL" + depends on TPL_DM + help + Most boards will have a '/aliases' node containing the path to + numbered devices (e.g. serial0 = &serial0). This feature can be + disabled if it is not required, to save code space in SPL. + config VPL_DM_SEQ_ALIAS bool "Support numbered aliases in device tree in VPL" depends on VPL_DM From patchwork Fri Sep 20 07:24:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987704 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=mK8Es3x0; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93pZ2rBTz1y27 for ; Fri, 20 Sep 2024 17:26:14 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 69FEA893C8; Fri, 20 Sep 2024 09:25:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="mK8Es3x0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F989893C8; Fri, 20 Sep 2024 09:25:12 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E7D5A893D5 for ; Fri, 20 Sep 2024 09:25:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-42cb5b3c57eso15798835e9.2 for ; Fri, 20 Sep 2024 00:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817107; x=1727421907; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UY+wRxRfvVmR2T6YEMz0afy8CnUDEOnhWpYjiXZ1CCs=; b=mK8Es3x0Or6tDhdELEPaf7uNFRYOOzF1MME5BtrVfJAwYA2BA6+iP4uUfye/jgu7TI DEVnv58Se/L21/6qiGfkF/A9VH27Q5cfbBDi+yWJNKxyJ8Zlvh6hZRCd6x/CxcmebhXq ltRsHSDR5BdUt0pVgRKZzATL8ruhlOswWkX+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817107; x=1727421907; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UY+wRxRfvVmR2T6YEMz0afy8CnUDEOnhWpYjiXZ1CCs=; b=Yvmi3HouVqe/rPPKDwzvn2TFy4YGmO5FuhsyqWxKKmpmothaGortJoIxg4oOnq3LNm /3fdjdCGuAUuOSZ1Kglo8Z6XEcBfT7L5jxit5QqswOD41WtjCyetxqH1J7kleVzPjBhl GTjRswF8XNkZBz550IG4/R/Jqu7lITHIXaVTAwsaZyRdCvAgHqo9VIclnmZRlSuHjNi1 E4sV9iEUI46P5BXrGOYFDDfpbdJV1tJs8cR9iwYSkXZ3jG0XIzmMJA4b3ibh+uxRZnL/ 8GQwxMvw5iDbAgMOBy0xCgoDsOQdgH89TZyl0sZ10LhOYKKTZoP7nUqHv96CWzH+zwMo XVxg== X-Gm-Message-State: AOJu0YyKQbkCNnTGZnDOjduNJnmlZVOAZZJKxvvlIEv+Hl0a33MgWXIf PYI51QHSOsSxcsiasjbcyN9tC1mwvxhXGtBInmwZKNWqffdwMcY3GXar9RXMWlgmJeO3ykPzo1Y /v0Kb X-Google-Smtp-Source: AGHT+IFBt0sEPodkAJXUV6yCE+tt8X8PmBeInvrsXB0d6J8KtPzXfL5Kjw9fXQ5J5lQ2+74fn1i87g== X-Received: by 2002:a05:600c:1c87:b0:42c:b7f9:4bbd with SMTP id 5b1f17b1804b1-42e7c19bb93mr10571395e9.26.1726817107070; Fri, 20 Sep 2024 00:25:07 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:06 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Andre Przywara , Apurva Nandan , Bryan Brattlof , Dasnavis Sabiya , Jayesh Choudhary , Neha Malcom Francis , Tom Rini Subject: [PATCH v2 07/18] ram: Support driver model in VPL Date: Fri, 20 Sep 2024 09:24:31 +0200 Message-ID: <20240920072444.134997-8-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Some boards want to use RAM in VPL so add an option for that. Signed-off-by: Simon Glass --- Changes in v2: - Update this to say VPL instead of TPL drivers/ram/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/ram/Kconfig b/drivers/ram/Kconfig index a64d2dff68d..f7e357f24da 100644 --- a/drivers/ram/Kconfig +++ b/drivers/ram/Kconfig @@ -26,6 +26,15 @@ config TPL_RAM TPL, enable this option. It might provide a cleaner interface to setting up RAM (e.g. SDRAM / DDR) within TPL. +config VPL_RAM + bool "Enable RAM support in VPL" + depends on RAM && VPL + help + The RAM subsystem adds a small amount of overhead to the image. + If this is acceptable and you have a need to use RAM drivers in + VPL, enable this option. It might provide a cleaner interface to + setting up RAM (e.g. SDRAM / DDR) within VPL. + config STM32_SDRAM bool "Enable STM32 SDRAM support" depends on RAM From patchwork Fri Sep 20 07:24:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987705 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=KCbX3EmC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93pp0l7Vz1y27 for ; Fri, 20 Sep 2024 17:26:26 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA731893E0; Fri, 20 Sep 2024 09:25:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="KCbX3EmC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AAED9893E4; Fri, 20 Sep 2024 09:25:15 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9433C893BF for ; Fri, 20 Sep 2024 09:25:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-42cb7a2e4d6so14382835e9.0 for ; Fri, 20 Sep 2024 00:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817109; x=1727421909; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OdUM5/PpGXJKSGe7/bTQ0CTAdx3pUTNrp7nLeXQXz8A=; b=KCbX3EmCn4oG4wfxkP1T6cIsDxfR6nuvFP+Pm+YPhVcUKXAGiF+FdWyZGeyUiyNXCH 7pQLyAV5AdLMclTqWyU/CGPD3yWJUb2qpxgQI642jXiMQyrvjJMSBvM4Nxk2vnGwSrnj 97uQL/jM1Jkrn8nZXp/AZ+IKyalSGxhVVGQ9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817109; x=1727421909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OdUM5/PpGXJKSGe7/bTQ0CTAdx3pUTNrp7nLeXQXz8A=; b=dwoHnPoVjuK4ARe2tuN+wf4cLuJyKn0SHYUmJqDAE/kZ2bJUe199z+n31k0CiXxvng w24zdE8Qe54HpzNmM+Et7OklSwPv2g00Ci45kugkPw7L7L/V947HPL0Oa1Xly6EcGHwQ iiOBTka8YeCMf7QWRzel3Xo7VngpNEtFxg37kE+M9j3x037BfCtlH7G84niisCqscL38 NMLyfDuLEYZ64My7kh0bFLzsQF+Vy35wG3sLctRbpo4GJ1Ci5GwB+N74JJOVAWu8buvx c2K78NH9G6RPj71ykMVeIGHEqJnHHHRDksBUQVa8P345VAgFXfLijcIbVjzbuDVJwWX7 9yrQ== X-Gm-Message-State: AOJu0YxjWuG3oqxGALCdKkjTrJ9mNGm241QEesku7bdIvo43TfS5ecGr am8nMbTAn6bTsxp0UHNmGvhukRkYMvWjk/HkUUVSKsk71SBWSsgBqk2l6aLeUzxqsH68kJrPf/k 85Zhd X-Google-Smtp-Source: AGHT+IFJgwP7MqVGgQvi8MgBgiM4+zFBR+Gw2Inpgs5Vw7l3FY1OJ6rXoQqeoMaS3Gj6xPqXg0kFYg== X-Received: by 2002:a05:600c:1c84:b0:428:e866:3933 with SMTP id 5b1f17b1804b1-42e7ad880ddmr13652085e9.22.1726817108717; Fri, 20 Sep 2024 00:25:08 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:08 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Algapally Santosh Sagar , Caleb Connolly , Jiaxun Yang , Marek Vasut , Michal Simek , Robert Marko , Tom Rini , Venkatesh Yadav Abbarapu Subject: [PATCH v2 08/18] serial: Support debug UART in TPL Date: Fri, 20 Sep 2024 09:24:32 +0200 Message-ID: <20240920072444.134997-9-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Some boards want to use the debug UART in TPL so add an option for that. Signed-off-by: Simon Glass --- (no changes since v1) drivers/serial/Kconfig | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 3a1e5a6f287..8b27ad9a77e 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -539,6 +539,13 @@ config TPL_DEBUG_UART_BASE help This is the base address of your UART for memory-mapped UARTs for TPL. +config VPL_DEBUG_UART_BASE + hex "Base address of UART for VPL" + depends on VPL && DEBUG_UART + default DEBUG_UART_BASE + help + This is the base address of your UART for memory-mapped UARTs for VPL. + config DEBUG_UART_CLOCK int "UART input clock" depends on DEBUG_UART From patchwork Fri Sep 20 07:24:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987710 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=g/BDjMc8; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93qZ2MvQz1y27 for ; Fri, 20 Sep 2024 17:27:06 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AC262893E3; Fri, 20 Sep 2024 09:25:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="g/BDjMc8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 98EDB893E8; Fri, 20 Sep 2024 09:25:19 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 803F0893E1 for ; Fri, 20 Sep 2024 09:25:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-42cb806623eso14235385e9.2 for ; Fri, 20 Sep 2024 00:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817110; x=1727421910; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3OwixvFz10aZ8S3Ea9+iNARHXLqM7Ve08vWOKPqm+9o=; b=g/BDjMc88M1C5R3gOHcdPHSZophT/lBgGmYocIL0VyvNAhT3vwJTRR60XQgjUV5fBt 5bJ88Q6nMiwCvlu0aa+NFIxWJQBhyShAKkAYL4sASzmBfGxnhHtxibikTBMluf/8npd3 Agq2yOp02Ak6Cpiwn34+hy7wAQm1QLoJDDSRs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817110; x=1727421910; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3OwixvFz10aZ8S3Ea9+iNARHXLqM7Ve08vWOKPqm+9o=; b=RA+mQH7copZ0SUGJc9+PHrLGJkp59eu5IwrGPca7OP1pm4WaBfN0BMr2PJCYvr3Bnh 3xAr6nlBaM9LK2lYDd5ED/1U52vd14flTKLJqhFl4kc+JA8jcfbuBIHe1wb7PamuWxe2 67sgeuqxSrZtqb2B2aLnUOcMxng9s6ZcMPfTUFhMVcsLGPjPDVGTg8/6I+/MFPTKq205 wIMGXPfs1dD2ObOhuTbk2huLG0bEsscs3/acCKyuSaaEzAESeqX3KgnfYWSUHHrAdgCG 8jCk63cmx/ZAI5/dNGcvGz4Ye+QrzPv3tqYhZbFCRPBVw+vUKltEvssLDsJds76hhxvU PrFA== X-Gm-Message-State: AOJu0YyAC0mYw6hgihGlqp0312WmRp8kNlH64YFGcGU9Pl6LrkuQFaiV cIasSLwuKVgqUdaK3Rj1PKCEKF5UzAJINnLT8n97smHOcMYYbGFP69W1IYkBVa783u8K1HRXXYe eW1sL X-Google-Smtp-Source: AGHT+IGMStWQc6w7dVjiFrGlLeiWPMRnm9Ike/ZhBunBcil/zuJ1g+VshNUH4d5nW+I8lp3FwoZU3g== X-Received: by 2002:a05:600c:35ce:b0:42c:bfd6:9d4d with SMTP id 5b1f17b1804b1-42e7abe03cdmr12529375e9.2.1726817109606; Fri, 20 Sep 2024 00:25:09 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:09 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Ilias Apalodimas , Richard Henderson , Tom Rini Subject: [PATCH v2 09/18] armv8: Support not having separate BSS Date: Fri, 20 Sep 2024 09:24:33 +0200 Message-ID: <20240920072444.134997-10-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Separate BSS is current mandatory on armv8 but this is not useful for early boot phases. Add support for the combined BSS. Use an #ifdef to avoid using CONFIG_SPL_BSS_START_ADDR which is not valid in this case. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/cpu/armv8/u-boot-spl.lds | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/cpu/armv8/u-boot-spl.lds b/arch/arm/cpu/armv8/u-boot-spl.lds index 215cedd69a8..fed69644b55 100644 --- a/arch/arm/cpu/armv8/u-boot-spl.lds +++ b/arch/arm/cpu/armv8/u-boot-spl.lds @@ -13,8 +13,10 @@ MEMORY { .sram : ORIGIN = IMAGE_TEXT_BASE, LENGTH = IMAGE_MAX_SIZE } +#ifdef CONFIG_SPL_SEPARATE_BSS MEMORY { .sdram : ORIGIN = CONFIG_SPL_BSS_START_ADDR, LENGTH = CONFIG_SPL_BSS_MAX_SIZE } +#endif OUTPUT_FORMAT("elf64-littleaarch64", "elf64-littleaarch64", "elf64-littleaarch64") OUTPUT_ARCH(aarch64) @@ -56,12 +58,22 @@ SECTIONS _end = .; _image_binary_end = .; +#ifdef CONFIG_SPL_SEPARATE_BSS .bss : { __bss_start = .; *(.bss*) . = ALIGN(8); __bss_end = .; } >.sdram +#else + .bss (NOLOAD) : { + __bss_start = .; + *(.bss*) + . = ALIGN(8); + __bss_end = .; + } >.sram +#endif + __bss_size = __bss_end - __bss_start; /DISCARD/ : { *(.rela*) } /DISCARD/ : { *(.dynsym) } From patchwork Fri Sep 20 07:24:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987706 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=ns4AQwjg; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93q069B7z1y27 for ; Fri, 20 Sep 2024 17:26:36 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 346FE893E9; Fri, 20 Sep 2024 09:25:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ns4AQwjg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B57A9893DE; Fri, 20 Sep 2024 09:25:15 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D24BD893CA for ; Fri, 20 Sep 2024 09:25:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-42cba6cdf32so14273385e9.1 for ; Fri, 20 Sep 2024 00:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817112; x=1727421912; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8s1QELf7MweKbuaPXhfoRtb2JnDuypZTg3BlvQmhKO8=; b=ns4AQwjgnq+5R9ccpC8Exg9t1paPVJBQp7bO6VcyauOuMwCbDn1niRh2/ZKct52aQw V1lak7vQivOpECasqseiuWgESvG8dNICdfZWZQd22MsZlB1o5lLKsz5q31Ha5rF8nGBi CzjaEHnMUHCV6c3pan7LSqaJt6Br3ORkgpXaQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817112; x=1727421912; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8s1QELf7MweKbuaPXhfoRtb2JnDuypZTg3BlvQmhKO8=; b=DBuw5+eLBwkTp6IJKegEPX8aUevLMW/uAAQ4Vhgt61s+k4cQT9siM/8A5KjLEuRKoj 20PZXNwEWV7tMGHCxdFZJexpEmW1w+clUw4INRq6G5+l5jmqfoFGMzA0qATy2Be49BW8 FrL6t1UuxoxAf3hapLYt8o9lMIoXJufp5ZizBtdDvtW2maoC2wm9DXa++N91IbCkrd6T YS5yUTMkQ9TlZbsk5v2VrDp2uZjbew8V5xt8naPABKitD10T75Iy5eqPcyv3O0Xlzs4O wWyV6x/bf6jVmFpccq4bPXjypwfISrRoh54DNIkXZ9HlJuixB6VReeqz0ObTbU8B5qWa vlkQ== X-Gm-Message-State: AOJu0YxSsMdzath51CVuzys1Fvf482/TvWl39EjaWX2gcIsOQodg+S4h abVtsFwyVqAN+JmLZ7V4ESps28PN3SNa6mDJ086fbYxn5PvOeLFEIYSxqeDksXyxXBr42ipAsSj k+VnP X-Google-Smtp-Source: AGHT+IHCOlIAS9kn5yMs11qZVB9x+U8YoSB7ofy+hXuI3/1IJnVvpVRHiUgWDxpfAY/a2STnC+jziQ== X-Received: by 2002:a05:600c:34c9:b0:42c:b22e:fc3e with SMTP id 5b1f17b1804b1-42e7abfb808mr11122405e9.15.1726817112005; Fri, 20 Sep 2024 00:25:12 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:10 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Tom Rini Subject: [PATCH v2 10/18] arm: cache: Drop a stale comment Date: Fri, 20 Sep 2024 09:24:34 +0200 Message-ID: <20240920072444.134997-11-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This header includes more than just dummy functions, so drop this comment. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/lib/cache.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/lib/cache.c b/arch/arm/lib/cache.c index b2ae74a59f1..648edf308f6 100644 --- a/arch/arm/lib/cache.c +++ b/arch/arm/lib/cache.c @@ -4,8 +4,6 @@ * Wolfgang Denk, DENX Software Engineering, wd@denx.de. */ -/* for now: just dummy functions to satisfy the linker */ - #include #include #include From patchwork Fri Sep 20 07:24:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987708 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Uzjbf1bl; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93q96q6Cz1y27 for ; Fri, 20 Sep 2024 17:26:45 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E7608893D9; Fri, 20 Sep 2024 09:25:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Uzjbf1bl"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B50C5893C6; Fri, 20 Sep 2024 09:25:16 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7A2E4893D1 for ; Fri, 20 Sep 2024 09:25:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-42cbaf9bfdbso14852605e9.0 for ; Fri, 20 Sep 2024 00:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817114; x=1727421914; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2ZBPM2XQxBdGTxjB4IkB4Nr9qxPkuDIsCjn3rEuh5lY=; b=Uzjbf1blND4M3Z+f5TP28R0LLsV7mmVGVSABqa1NjJXlj90aEgVO6jE7XRbKEtx4m4 10Z9WQQ22Xeae64zOwSnnQZXuBOqLkRPBuchBOf3usMQFiA+H8t0AWkLoGmThHP+xPku A+jHexllNyntz015ps7+zNnVtIsYA1osk7Yw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817114; x=1727421914; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ZBPM2XQxBdGTxjB4IkB4Nr9qxPkuDIsCjn3rEuh5lY=; b=uEfPwreyKr+jHfMGE/4GDFWZNY1ulCCE9BHrcjoSr4rKb4s5Z06vDGvJirt3KKeESq Wu4a1SN8Ff+PBZjBx+ihH3cFz/OSSJ8yi+6qzQj+qJaZSN9nAiv+99yGAaFAf42yfa2K YGgnB0gOEfB7TO2n8hzXy4nyRPnkiBLod0AZBEvsWwkQPdTj801ZsAYIU2Aqx1AThHMt FQ4oCywnd+F/w0/4rVHdD0bRTWdOiOVbGPP1k/atvDED6EInX7waDukGXO6v8XlPQNSn rq/xmvc3hgRIZC8HjDDBJ67DlUwMLLNQhHAaAjPV+QU6+elf2mcbu+a26tzKf5yIkKYk tCqA== X-Gm-Message-State: AOJu0YzCISB0SXKZCV3iAYkaKQIj05o5LcupTAjIPokQ5Id2t2zgGGV6 KZ18nlUTwEPPdmtvMWGSaDGtDmLTktFrGO2Wg6eCX6hUaKlsRtqHrOIku79xqEvFD3dqF5cUfXb XAqP7 X-Google-Smtp-Source: AGHT+IF49l7Hwx7/7FjUbmE0hFuZ2JP9R0gZn5rUDgqtnxFYcSzROnjUfoKiEMn8osuVlKmatELwjQ== X-Received: by 2002:a05:600c:1d98:b0:42c:bf94:f9a6 with SMTP id 5b1f17b1804b1-42e7ad92602mr13135235e9.26.1726817113645; Fri, 20 Sep 2024 00:25:13 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:13 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Ilias Apalodimas , Richard Henderson , Sam Edwards , Tom Rini Subject: [PATCH v2 11/18] arm: Fix up a stale comment in sections.c Date: Fri, 20 Sep 2024 09:24:35 +0200 Message-ID: <20240920072444.134997-12-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean There are currently four symbols here, so drop the word 'two'. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/lib/sections.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/lib/sections.c b/arch/arm/lib/sections.c index 07efabaa7dc..8955aa6111c 100644 --- a/arch/arm/lib/sections.c +++ b/arch/arm/lib/sections.c @@ -5,7 +5,7 @@ #include /** - * These two symbols are declared in a C file so that the linker + * These symbols are declared in a C file so that the linker * uses R_ARM_RELATIVE relocation, rather than the R_ARM_ABS32 one * it would use if the symbols were defined in the linker file. * Using only R_ARM_RELATIVE relocation ensures that references to From patchwork Fri Sep 20 07:24:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987709 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Nss5sCwX; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93qN1G8Lz1y27 for ; Fri, 20 Sep 2024 17:26:56 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4FBAE893DE; Fri, 20 Sep 2024 09:25:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Nss5sCwX"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8CCC3893EF; Fri, 20 Sep 2024 09:25:17 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ABD82893BF for ; Fri, 20 Sep 2024 09:25:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-42e5e1e6d37so15783305e9.3 for ; Fri, 20 Sep 2024 00:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817115; x=1727421915; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LwBkOs9bDu7Hw+se9VudOUbKN6FDGhNYn8RcAN9fPrA=; b=Nss5sCwXfewB6ZzqOaqk18pWfy03GJqbnO5A0QKd4mTtCf+BC9bDJStQ4XnJkVVEmt SmCRkAU/bDkYDnoHkjQCF8/seTGUwbRajzHjjHIZV1LXZ5ttUgbV2yHpo+v8st68JGs3 H7qYLBLq0sG5+fn1QfKlK4liYJiu4habTdjZ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817115; x=1727421915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LwBkOs9bDu7Hw+se9VudOUbKN6FDGhNYn8RcAN9fPrA=; b=Xsf2HU1x7k8sSB5njX/ZJtoFnNbWyYtsZOaEBjAb3skFV9SG9+Or2LZNUi5FIYXBVe 6NYbnRJz2xARyrcu8KbfbY1mD+lFZejBXtnotOlmlwyIUardDkDKMzMWDIVTIeaZsEvY 0Lrpxe9/3s8UQZx9BP056ud8LquHeKitHmYkp4AsHyvzd8/6JanyPcehOVO5Lp0Rkjjy 5kenxz+4ELqhWQfh4b9DpyNA2ARM94Es/sJTZwctQ7NWFO15k+CB9agQzVIHF2Dif8px xmDyebBMlM4S+EyIC8rXnENlIpF7tFdgwESwLVk3EWK7fruaEpM8Bl8umG9eP6oSGDQ8 aJng== X-Gm-Message-State: AOJu0Yw3mvxAHoTXPv/oqEHyXMhqFb+5agUJxLj6ZvHoQhOAC8r1QKRb WtG7CTah+pLko39mkOTd2JSRZLMw0aC0VnYXlfzORwVHV92Hz9fqKPfL94sqQ5siDAX+eVgJvfP Sy15t X-Google-Smtp-Source: AGHT+IEqVRGSqLhKpTFXa/8QCRa7IJvjIHcx7eYbem8/4kJIslChMffvqghWFSSCE2jnvHYKIw2g5A== X-Received: by 2002:a05:600c:5359:b0:42b:af52:2525 with SMTP id 5b1f17b1804b1-42e7d143601mr7533315e9.16.1726817114841; Fri, 20 Sep 2024 00:25:14 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:14 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Greg Malysa , Heinrich Schuchardt , Jaehoon Chung , Jonas Karlman , Kongyang Liu , Marek Vasut , Oleksandr Suvorov , Paul Barker , Peng Fan , Tom Rini Subject: [PATCH v2 12/18] mmc: Support driver model in TPL Date: Fri, 20 Sep 2024 09:24:36 +0200 Message-ID: <20240920072444.134997-13-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Some boards want to use DM_MMC in TPL so add an option for that. Signed-off-by: Simon Glass --- Changes in v2: - Default this option to off to avoid TPL-code-size increases drivers/mmc/Kconfig | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig index 982e84dc3bc..22c65681f0a 100644 --- a/drivers/mmc/Kconfig +++ b/drivers/mmc/Kconfig @@ -61,6 +61,17 @@ config SPL_DM_MMC appear as block devices in U-Boot and can support filesystems such as EXT4 and FAT. +config TPL_DM_MMC + bool "Enable MMC controllers using Driver Model in TPL" + depends on TPL_DM && DM_MMC + select TPL_BLK + help + This enables the MultiMediaCard (MMC) uclass which supports MMC and + Secure Digital I/O (SDIO) cards. Both removable (SD, micro-SD, etc.) + and non-removable (e.g. eMMC chip) devices are supported. These + appear as block devices in U-Boot and can support filesystems such + as EXT4 and FAT. + if MMC config MMC_SDHCI_ADMA_HELPERS From patchwork Fri Sep 20 07:24:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987713 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=nCDiiXtO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93r83YXlz1y27 for ; Fri, 20 Sep 2024 17:27:36 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B9C4893F7; Fri, 20 Sep 2024 09:25:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="nCDiiXtO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1C007893BF; Fri, 20 Sep 2024 09:25:22 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 366B9893EA for ; Fri, 20 Sep 2024 09:25:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-42cb8dac900so15379885e9.3 for ; Fri, 20 Sep 2024 00:25:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817116; x=1727421916; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JbTIGpC+evrLANuDqrcssj6YExlsFZCF39qeWy98Sdc=; b=nCDiiXtOcALZPoUK2C7fUSMyYIgpNaGdjVBpaov8oOBayZazrOJIzr9+6SOt2xvsAu eHJkulgZMDlp4ryxR1CFFe44+Z/9YkW26uxSgMyUym2U4mn3V2HGnSFtHf5y0hMPOmzr mAFIensb0Z7fram6S7qrsKQ53cTxv+tJ0wA04= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817116; x=1727421916; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JbTIGpC+evrLANuDqrcssj6YExlsFZCF39qeWy98Sdc=; b=J8bRalDpoAyXpDCfkfxp3jixmf1EAXvT1Ip4jzJI9/mwRx0XTbAYY5HCpSt8OpAeug /71fMKgPOktEULBGrvGguihzzx8pO5M2ruwTSwkKEDD/Ru+36YHNe1d2LLNoFMXcpaSK VK26c1Qt1qw3IIEW5mXXrYDSgNsVNQtEsU4XpcFsIFH7M47+tSYvCDI6e5vmoDRjelaW OU+xOLa6zmcXFLoWiND5G6msrljlWmJVeBeSo8wueK7LlG5T1n8HPsSxH1BL0INeZceE uLbGl7nV3NIwgJc+51atrd5xS+TeOqdEzHkSB4POLL9ZmjO961Xy9x4LFIA0FmKX9zYT GSXQ== X-Gm-Message-State: AOJu0Yzgg6Efr9m7ojux2Q6LKeaaWHR8QCkWRoJTqRv6SELRPEQ6CwYj Ue428iBIafVbQ8v0unp3YerG3BdHpgCYE3G+5fcnSwHeOgRBbcAM6unK3Pk3NDorSBVnwUQqZxJ GMkb4 X-Google-Smtp-Source: AGHT+IFm8vKtdVErPJUGnKLCTIECv7GooNp2AUHl0j/82XVgTGECjB8bUEd+kPLnSRruPccT6dIDeA== X-Received: by 2002:a05:600c:8718:b0:42c:b4f2:7c30 with SMTP id 5b1f17b1804b1-42e7c1a2e78mr9794785e9.23.1726817116483; Fri, 20 Sep 2024 00:25:16 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:15 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Jaehoon Chung , Marek Vasut , Peng Fan , Quentin Schulz , Sean Anderson , Tom Rini Subject: [PATCH v2 13/18] mmc: Add more debugging for SPL Date: Fri, 20 Sep 2024 09:24:37 +0200 Message-ID: <20240920072444.134997-14-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean When MMC booting fails it is sometimes hard to figure out what went wrong as there is no error code. It isn't even clear which MMC device was chosen, since SPL can have its own numbering. Add some debugging to help with this. Signed-off-by: Simon Glass --- Changes in v2: - Drop the unnecessary interior check for CONFIG_IS_ENABLED(DM_MMC) common/spl/spl_mmc.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/common/spl/spl_mmc.c b/common/spl/spl_mmc.c index 1337596eca0..1f696593216 100644 --- a/common/spl/spl_mmc.c +++ b/common/spl/spl_mmc.c @@ -50,6 +50,7 @@ int mmc_load_image_raw_sector(struct spl_image_info *spl_image, ret = spl_load(spl_image, bootdev, &load, 0, sector << bd->log2blksz); if (ret) { puts("mmc_load_image_raw_sector: mmc block read error\n"); + log_debug("(error=%d)\n", ret); return ret; } @@ -76,6 +77,12 @@ static int spl_mmc_find_device(struct mmc **mmcp, int mmc_dev) int ret; #if CONFIG_IS_ENABLED(DM_MMC) + struct udevice *dev; + struct uclass *uc; + + log_debug("Selecting MMC dev %d; seqs:\n", mmc_dev); + uclass_id_foreach_dev(UCLASS_MMC, dev, uc) + log_debug("%d: %s\n", dev_seq(dev), dev->name); ret = mmc_init_device(mmc_dev); #else ret = mmc_initialize(NULL); @@ -91,6 +98,9 @@ static int spl_mmc_find_device(struct mmc **mmcp, int mmc_dev) mmc_dev, ret); return ret; } +#if CONFIG_IS_ENABLED(DM_MMC) + log_debug("mmc %d: %s\n", mmc_dev, (*mmcp)->dev->name); +#endif return 0; } @@ -342,6 +352,8 @@ int spl_mmc_load(struct spl_image_info *spl_image, /* Perform peripheral init only once for an mmc device */ mmc_dev = spl_mmc_get_device_index(bootdev->boot_device); + log_debug("boot_device=%d, mmc_dev=%d\n", bootdev->boot_device, + mmc_dev); if (!mmc || spl_mmc_get_mmc_devnum(mmc) != mmc_dev) { ret = spl_mmc_find_device(&mmc, mmc_dev); if (ret) From patchwork Fri Sep 20 07:24:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987711 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=YIJyvwym; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93qn2S37z1y27 for ; Fri, 20 Sep 2024 17:27:17 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 29E4B893DA; Fri, 20 Sep 2024 09:25:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="YIJyvwym"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 84AF4893E4; Fri, 20 Sep 2024 09:25:20 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 51D1A893C4 for ; Fri, 20 Sep 2024 09:25:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-42cae4eb026so15603985e9.0 for ; Fri, 20 Sep 2024 00:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817117; x=1727421917; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jH8F43frAIKheMZkYQWkw5X3N1NQoQ9h0liNmv9e5OI=; b=YIJyvwym14oL9FrcATpxF26DEtQTawhB5ua9bTH3zgNF+ILt6J3w1wWKL2aNziAZYK NvFUxMJWtzdCm9dqcsFiqvCFN+rITYSilq30/Zu+EJlidg7Y8pldjmJoOQDTM8iZaxNL 7mmmkASc6GlLM+IZ7kDAsPWkN19gjooKCuvus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817117; x=1727421917; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jH8F43frAIKheMZkYQWkw5X3N1NQoQ9h0liNmv9e5OI=; b=PH5JIacGdclu7n+jPrPlHnya442ybVW3Ezrm1ZokGaBTGaNx91BVNxjGHIG5y3r0++ uKjfh8HqUY61jZGVXmUEmTDfdYmqwI8CpbTWxHBXxy0wrwjAvMuu3YSOJPWY93sO04zn Jzo2PjvOKZR2bfaUYhShH/M081rSZ6AL1u1GnH9sO2lzEUT3IvJKYjXNmjTGgcnuBmlL bAoUcbBsy5Qlla0xV0c7HWj6+0vlQghtN4ZFcpker+miGMmf23E11MRGuHZ/7+i1hQV1 fsGvwYK+citC/7jqopyfgTFY2R+202P6AKN67XBMgeYXxfqt8P7mJCssJDU6N6AZL7c1 kUxA== X-Gm-Message-State: AOJu0Yx1t6HDXHd6fum6jusPIIucnz1EBONTMHRSD/3lBUM2XaRsIV0d 29FkByms6XCOK8EJgowRCAyY7YfSJ4om6EJIUhzAeY2plKcVJlLsePZMoEnj/wfLDDotzVX63Th B+tHF X-Google-Smtp-Source: AGHT+IEcPKM/rY8pIzDW3rOCd2LkOW9Xp5o5wRDXSGy1PU2hKDlYadZBIZvk6T6bfdIjWUNMvxEgHQ== X-Received: by 2002:a05:600c:1d1a:b0:42c:b995:2100 with SMTP id 5b1f17b1804b1-42e7c159bf3mr9706725e9.6.1726817117510; Fri, 20 Sep 2024 00:25:17 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:17 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Heinrich Schuchardt , Jaehoon Chung , Marek Vasut , Peng Fan , Quentin Schulz , Sean Anderson , Tim Harvey , Tom Rini , Venkatesh Yadav Abbarapu Subject: [PATCH v2 14/18] mmc: Log the error when init fails Date: Fri, 20 Sep 2024 09:24:38 +0200 Message-ID: <20240920072444.134997-15-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Add an error-return log to the call in mmc_init_device() Signed-off-by: Simon Glass --- (no changes since v1) drivers/mmc/mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 7e702c3ae85..e8870e30689 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -3188,7 +3188,7 @@ int mmc_init_device(int num) if (uclass_get_device_by_seq(UCLASS_MMC, num, &dev)) { ret = uclass_get_device(UCLASS_MMC, num, &dev); if (ret) - return ret; + return log_msg_ret("ini", ret); } m = mmc_get_mmc_dev(dev); From patchwork Fri Sep 20 07:24:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987712 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=aYJyBwue; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93r00v8Rz1y27 for ; Fri, 20 Sep 2024 17:27:28 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AFEDE893F0; Fri, 20 Sep 2024 09:25:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="aYJyBwue"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9F28A893DA; Fri, 20 Sep 2024 09:25:21 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B556893E6 for ; Fri, 20 Sep 2024 09:25:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-42cacabd2e0so14223485e9.3 for ; Fri, 20 Sep 2024 00:25:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817119; x=1727421919; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=26a2u3uu2HaPtW1vw7xeUgajLlltcWbmx20ZLsqvECI=; b=aYJyBwuejo21nO0x+OcrjrI9yfoMLhUuHzjmG7+qW+4Uzalfpj5j7pW+f08XZHvNa0 k+OU5FPmOEXUCvtj67XsY1LJOV26bsETvX06y5Lgk674kxdZZIXqSX/B4H3zHsLiZwSG +s0QUmXYQnYHIeBqzTI7+uZ2633c8CnjfMAs8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817119; x=1727421919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=26a2u3uu2HaPtW1vw7xeUgajLlltcWbmx20ZLsqvECI=; b=Gv2MsgLbJHcYQiQgYZ8iMg/oYlm9vJPhLdqUlrbb2XzqCApIQUonUxMMPsEWHXurjw 3QE5Ny/Aky9tYsbCrsQ5pnrvw19EtGqbeJgImbza02iGCrOMbVn3gzKje4KR9K0rI8Ig uAYaXVpaP+rndNffmsh3JFRT17KpYX+FRkoXL9idETwWpkcJ6XAfEulWmIj+BfUEvVIg zk+1J9JGyelsr1pbuAVP3WLvX5kBQXdkph2B4twksgUOEBLPaPU6c7tP6gXb7ZvLfDfi WEecDBDqzH+hTRQTscOSeZS1a0ude+a7j6d4MzHe9W1Q0kr6FsmGm9XiF334CGquViay WBNA== X-Gm-Message-State: AOJu0YyvtaQ+PGCauJHK86cUkOd4tYJTY7xTJctrwEh4GltjB2NIVZ0f u0yysPpVqTiJFfFOUqk6Tzjv60SrqOxn/7HKsI68VSJQB604utSVXZ82zJeFckGPfC8U4CpGOqj 0ib0O X-Google-Smtp-Source: AGHT+IHGFCHzXUoTiCI0HWj7d7Az74zO7jcCebJCY3tHDQy9Ayj6Z5qhi6nKqc4FHWPjshRok3GasA== X-Received: by 2002:a05:600c:5127:b0:42c:b961:c902 with SMTP id 5b1f17b1804b1-42e7abe83a4mr9232215e9.12.1726817118676; Fri, 20 Sep 2024 00:25:18 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:18 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Ferass El Hafidi , Jaehoon Chung , Jonas Karlman , Kever Yang , Peng Fan , Peter Robinson , Philipp Tomsich , Philipp Tomsich , Sam Protsenko , Tom Rini Subject: [PATCH v2 15/18] mmc: rockchip: Log some error returns Date: Fri, 20 Sep 2024 09:24:39 +0200 Message-ID: <20240920072444.134997-16-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Add a little logging to some places in this driver, to aid debugging when something goes wrong. Signed-off-by: Simon Glass --- (no changes since v1) drivers/mmc/rockchip_dw_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c index fb77b049834..7e341665aa3 100644 --- a/drivers/mmc/rockchip_dw_mmc.c +++ b/drivers/mmc/rockchip_dw_mmc.c @@ -80,7 +80,7 @@ static int rockchip_dwmmc_of_to_plat(struct udevice *dev) priv->fifo_depth = dev_read_u32_default(dev, "fifo-depth", 0); if (priv->fifo_depth < 0) - return -EINVAL; + return log_msg_ret("rkp", -EINVAL); priv->fifo_mode = dev_read_bool(dev, "fifo-mode"); #ifdef CONFIG_SPL_BUILD @@ -96,7 +96,7 @@ static int rockchip_dwmmc_of_to_plat(struct udevice *dev) int val = dev_read_u32_default(dev, "max-frequency", -EINVAL); if (val < 0) - return val; + return log_msg_ret("rkc", val); priv->minmax[0] = 400000; /* 400 kHz */ priv->minmax[1] = val; From patchwork Fri Sep 20 07:24:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987716 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=VaHx2vig; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93rm5tm1z1y27 for ; Fri, 20 Sep 2024 17:28:08 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F2C2893FE; Fri, 20 Sep 2024 09:25:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="VaHx2vig"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7CE3789402; Fri, 20 Sep 2024 09:25:39 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3CB6A893D1 for ; Fri, 20 Sep 2024 09:25:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-42cbaf9bfdbso14853505e9.0 for ; Fri, 20 Sep 2024 00:25:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817120; x=1727421920; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HiGZqNy5JACrg4auQhNxNzfpuIuwXcvj6OAp1Au8vfs=; b=VaHx2viga723WxLu6hY5gwCvPPoDXILJMyb5gIgF5woDANnKpUBwXodGMsKKsPh0Su CAY1Xke0yisDAF5fdId4IbrR75jwMrDaj/ECz80omYfjzn/ZglhbI7pc+20rt+ypl5xg hZNbUpU6mQQpzOkdwlx3j6aYOT4JbpUsogeqo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817120; x=1727421920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HiGZqNy5JACrg4auQhNxNzfpuIuwXcvj6OAp1Au8vfs=; b=i6pdhKjBMXUNn4wGwWXzeHxgQtpKnxf62gMxq/7P3IODBmdY0YRg02qWyaooagWDVR 9S8PTZOiKlX+1UltU5o8SlBxXQ4dKLHK6HOrXTSATFbN+/VTKyznhxQq/Aky8UF+Ymwu VRyVlAIOaVsQx5q65lpaw11yf9O1KWgYk6d1cYMEaJHmQDf6A/sPEPuS4YIuewYTFoIb 15rY2RWotzTVeRgDZDh6qFihOb+Ww+kqPrKWHj71SJr3NILhGtH1EiIwx9P58X6CgFi5 h3ir/C8z3iqNXozpIZVq47AaLpXwpsHVd+wvFqNiMlCY98N6r/8c4ImuKrsLkOI9dEKm ImKA== X-Gm-Message-State: AOJu0YxuHfiLSptjHevAjp3EPK3o263gCpmem7o51BCKYR0WN6n2wvi8 QdvH9JBGHqyTe5UUzrEnP/E5KC6XS3zllOskO2lorDCXbn0F5Pd9SpT9kVtuID56/Ie851RNkdY bkSWL X-Google-Smtp-Source: AGHT+IFMg37jzTMYt+pRpMgqYwPviTXVZr1UuMhQ1hZAOAvjD0ej+jO56Qnt+FEJEgI5nJMqSwbU6Q== X-Received: by 2002:a05:600c:1987:b0:42c:b9b1:8342 with SMTP id 5b1f17b1804b1-42e7ac2deb9mr12835005e9.19.1726817120409; Fri, 20 Sep 2024 00:25:20 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:19 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Jaehoon Chung , Jonas Karlman , Kever Yang , Minkyu Kang , Neil Armstrong , Peng Fan , Peter Robinson , Philipp Tomsich , Philipp Tomsich , Sam Protsenko , Tom Rini Subject: [PATCH v2 16/18] mmc: rockchip: Allow clocks to be missing Date: Fri, 20 Sep 2024 09:24:40 +0200 Message-ID: <20240920072444.134997-17-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Allow MMC init when clock support is not enabled in a particular phase. Refactor the setting of priv->emmc_clk so it is a bit clearer. Signed-off-by: Simon Glass --- (no changes since v1) drivers/mmc/rockchip_dw_mmc.c | 6 ++---- drivers/mmc/rockchip_sdhci.c | 9 ++++----- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/rockchip_dw_mmc.c b/drivers/mmc/rockchip_dw_mmc.c index 7e341665aa3..5ba99d68b7d 100644 --- a/drivers/mmc/rockchip_dw_mmc.c +++ b/drivers/mmc/rockchip_dw_mmc.c @@ -131,13 +131,11 @@ static int rockchip_dwmmc_probe(struct udevice *dev) priv->minmax[1] = dtplat->max_frequency; ret = clk_get_by_phandle(dev, &dtplat->clocks[1], &priv->clk); - if (ret < 0) - return ret; #else ret = clk_get_by_index(dev, 1, &priv->clk); - if (ret < 0) - return ret; #endif + if (ret < 0 && ret != -ENOSYS) + return log_msg_ret("clk", ret); host->fifo_depth = priv->fifo_depth; host->fifo_mode = priv->fifo_mode; diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index 35667b86b50..15b4a39770a 100644 --- a/drivers/mmc/rockchip_sdhci.c +++ b/drivers/mmc/rockchip_sdhci.c @@ -571,20 +571,19 @@ static int rockchip_sdhci_probe(struct udevice *dev) struct rockchip_sdhc *priv = dev_get_priv(dev); struct mmc_config *cfg = &plat->cfg; struct sdhci_host *host = &priv->host; - struct clk clk; + struct clk *clk = &priv->emmc_clk; int ret; host->max_clk = cfg->f_max; - ret = clk_get_by_index(dev, 0, &clk); + ret = clk_get_by_index(dev, 0, clk); if (!ret) { - ret = clk_set_rate(&clk, host->max_clk); + ret = clk_set_rate(clk, host->max_clk); if (IS_ERR_VALUE(ret)) printf("%s clk set rate fail!\n", __func__); - } else { + } else if (ret != -ENOSYS) { printf("%s fail to get clk\n", __func__); } - priv->emmc_clk = clk; priv->dev = dev; if (data->get_phy) { From patchwork Fri Sep 20 07:24:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987715 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=OjRMadWe; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93rZ5Y03z1y27 for ; Fri, 20 Sep 2024 17:27:58 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EC377893BF; Fri, 20 Sep 2024 09:25:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="OjRMadWe"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3081089378; Fri, 20 Sep 2024 09:25:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3BFFC893BF for ; Fri, 20 Sep 2024 09:25:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-42cd46f3a26so14653075e9.2 for ; Fri, 20 Sep 2024 00:25:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817121; x=1727421921; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Cw+z0SGM+G6uLjeGZXVJ2g9ettneXpGkiE9qTJm63TE=; b=OjRMadWeEhTSjgTYGVK42846MlQHFx4plVakY6SYGCyJVglXDK7d8QeKfbzXQPWOml TQpgBn3qMPu/99S+YTbowm6OctNc02ZCG//83ntCxErEEmW534MZuo5TDs42RU4JQeJs 5juCkeUDPe1GIw4iRYV7Y0VLOwr+M1mas+2hk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817121; x=1727421921; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cw+z0SGM+G6uLjeGZXVJ2g9ettneXpGkiE9qTJm63TE=; b=Mls07UxwFzY5d+MHea9MQCwvz4v+ov/MZT0lwFZJq/0cAxrOp9wGDxRfFXnobtnd0+ jiPGjYHQsRe8/bHQEO6exBb/JLnCM5wQm8GKM7uH4fEeW5lycZ68x8HHagWA2fISYzIh PkrgSyyRMOzX4YEtMJOh9A8nIDINSkD5Cw2dZmcsv1FSvZKwE/v8bWx4TlxlefMoGWn8 2z52axStvRDSYis1zGaMnTfp/nsS+pQ52vLnR0iKzb/6PCvkQ/l68byybqCeyeus7rEO rWve+5IcyGCFTwzNiNBRw5iAmXp4dfk3Z4FovCuW5GhmMM5Fha9FMUfAnoF3dG1Me+/U tuDA== X-Gm-Message-State: AOJu0Ywr4lOtk3os8Pgjibs0sBXm2N9MxkGqgSJrl8GcM9mMuu2j8rGl 5Sb9rAThPJfXQOu7w0sciur1pNKQvHYs4rfuqhCfKX/H18nMRG97ifEH+nJLUHo3I91LNSvixNh nF+/J X-Google-Smtp-Source: AGHT+IHNsikTDe+1i7iJWxbKtyC0ih7jiaZUkWEVGnRva0TfS3aRQmnakD0rGhJnlq718ULzU/TviQ== X-Received: by 2002:a05:600c:1d08:b0:42c:bad0:6c16 with SMTP id 5b1f17b1804b1-42e7abe21c2mr13646865e9.2.1726817121412; Fri, 20 Sep 2024 00:25:21 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:21 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Jaehoon Chung , Jonas Karlman , Kever Yang , Peng Fan , Peter Robinson , Philipp Tomsich , Philipp Tomsich , Tom Rini Subject: [PATCH v2 17/18] rockchip: mmc: Fix a missing colon and newline Date: Fri, 20 Sep 2024 09:24:41 +0200 Message-ID: <20240920072444.134997-18-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Add a missing colon and newline in rk3399_emmc_get_phy(). Signed-off-by: Simon Glass --- Changes in v2: - Update subject to mention that a newline is added too drivers/mmc/rockchip_sdhci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c index 15b4a39770a..4ea3307ed9c 100644 --- a/drivers/mmc/rockchip_sdhci.c +++ b/drivers/mmc/rockchip_sdhci.c @@ -230,7 +230,7 @@ static int rk3399_emmc_get_phy(struct udevice *dev) grf_base = syscon_get_first_range(ROCKCHIP_SYSCON_GRF); if (IS_ERR_OR_NULL(grf_base)) { - printf("%s Get syscon grf failed", __func__); + printf("%s: Get syscon grf failed\n", __func__); return -ENODEV; } grf_phy_offset = ofnode_read_u32_default(phy_node, "reg", 0); From patchwork Fri Sep 20 07:24:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1987714 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=jIjWoN9r; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X93rP3Nbtz1y2j for ; Fri, 20 Sep 2024 17:27:49 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 820F089404; Fri, 20 Sep 2024 09:25:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="jIjWoN9r"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1062C893FE; Fri, 20 Sep 2024 09:25:26 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1BDA3893F8 for ; Fri, 20 Sep 2024 09:25:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-42cae6bb895so15877555e9.1 for ; Fri, 20 Sep 2024 00:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1726817123; x=1727421923; darn=lists.denx.de; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d29BkdPrvKyzClMPjptVHKsxAbJLRmzXt9pDDl85+4M=; b=jIjWoN9reECLHS4vtXETQMfQGlZ21mc+V3Jdd9pXiOBXJrjtjXgcY5X9ERjiuLYpZX gbJef33V3xuuytbm1Q/I8zfhyNHVL+3QR0K1rHWF9xv+lVcGR//X7VcmETudMsiwnPG3 Bd+JafYE+NXjZCzAUzB15NlziVkm5ACpMG/t0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726817123; x=1727421923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d29BkdPrvKyzClMPjptVHKsxAbJLRmzXt9pDDl85+4M=; b=jXhhV0O2FNEcv1tAuhNWSgtdw61uC2RSiqhqz9AAQ3tpKY63eI9LiiZ4eSHZgEfXEk 3m4ctZlCKcWPefBOU7A4cYXEoD0zpgP88ZpNYLlB+h7M8vQwbtfzqBTJXJI0ZlM9Fki1 Mjtlaqpjx65CAYMLlGepkvMTXhLa02H1C05lK28FlP+IGGFG33a2Wu2ElLwdc/pP5Bo9 t7Xhzb+qbEDJbeGQLIAbQp8U6kGIRul9sGOA/CMB4a0diZEAaeBYvTMMkc5aGEQvhreN qAuH5cmoE95hDr4k7dNDijkfPllxghBjhP9RwAP7/6Bmpo5+tkgkY8C/QwCWWPp+7eCJ MuKA== X-Gm-Message-State: AOJu0YylJ2TZhe86bw8Z1i+bnO/ZBwpBE8ON8KVeZjx2t54AlIs91yPX uSzCI/OBz7hzdqJ8vztw5Jc3m8zEEPSPQSmKk17avNYrJrKw+WJ3md6slUlbimXD6uPE6czbEUF vEeZO X-Google-Smtp-Source: AGHT+IEV+Vgcf766VSkRZ4+ksyvgo+QrLaBiE1YGCDrjk5+QV+i/htWsFylE+AtNoYxdEJegiqsC6Q== X-Received: by 2002:a5d:6251:0:b0:367:8ff5:5858 with SMTP id ffacd0b85a97d-37a431be8a3mr777436f8f.56.1726817123234; Fri, 20 Sep 2024 00:25:23 -0700 (PDT) Received: from chromium.org ([185.44.53.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42e7540e32fsm41504535e9.9.2024.09.20.00.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Sep 2024 00:25:22 -0700 (PDT) From: Simon Glass To: u-boot@lists.denx.de Cc: Simon Glass , Caleb Connolly , Heinrich Schuchardt , Ilias Apalodimas , Jonas Karlman , Kever Yang , =?utf-8?q?Marek_Beh=C3=BAn?= , Philipp Tomsich , Stefan Roese , Tom Rini , Wan Yee Lau Subject: [PATCH v2 18/18] rockchip: Provided SPL control over efuse presence Date: Fri, 20 Sep 2024 09:24:42 +0200 Message-ID: <20240920072444.134997-19-sjg@chromium.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240920072444.134997-1-sjg@chromium.org> References: <20240920072444.134997-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This driver should not generally be present in SPL, even if misc devices are enabled. Update the Makefile rule accordingly. Signed-off-by: Simon Glass --- (no changes since v1) drivers/misc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index e53d52c47b3..ff984d7b191 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -68,7 +68,7 @@ obj-$(CONFIG_QFW_MMIO) += qfw_mmio.o obj-$(CONFIG_QFW_SMBIOS) += qfw_smbios.o obj-$(CONFIG_SANDBOX) += qfw_sandbox.o endif -obj-$(CONFIG_ROCKCHIP_EFUSE) += rockchip-efuse.o +obj-$(CONFIG_$(SPL_TPL_)ROCKCHIP_EFUSE) += rockchip-efuse.o obj-$(CONFIG_ROCKCHIP_OTP) += rockchip-otp.o obj-$(CONFIG_$(SPL_TPL_)ROCKCHIP_IODOMAIN) += rockchip-io-domain.o obj-$(CONFIG_SANDBOX) += syscon_sandbox.o misc_sandbox.o