From patchwork Thu Sep 19 14:05:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Schulze Frielinghaus X-Patchwork-Id: 1987462 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=u18IejGV; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X8cl668Xqz1y1m for ; Fri, 20 Sep 2024 00:06:42 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F32B33858C50 for ; Thu, 19 Sep 2024 14:06:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F32B33858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1726754801; bh=MvfXpAw6u5hj35TV2e7FIVx0l+QQNmlXQ0SX8Fo51Sc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=u18IejGVEC1freoSwCSsVbEOYssVH7dKVypK4Ud/+isCc+WqiDdLIEWprnADOAoZH XRM++ZB1LO2pfT8/ZLfE5UdfJyGUwJeQxUbVH4A77d2blKsblJp2oY5/D5xY5+k3iw UEC3N8v5NLhZEdxor8GJrbvgysDlt1mYZO4MuoDE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 28E043858D28; Thu, 19 Sep 2024 14:06:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 28E043858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 28E043858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726754770; cv=none; b=vodZD0M77lqmqa9B6+/2adq9tUZhLZ6ZogZhxod4x0mRn/qo1DsC9jK2JHqqpelkehOOL/6b0QUrpE9KmqnjgWi5T/eAUMtmGnAORodKH5FV8sQF7axpqS6sJej0dDJLpayUhcpNRxmOS72KYwphi1wRuVfZzmOgE5CfPcH002A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726754770; c=relaxed/simple; bh=PyIifn/1QEgjfmYlJQ39kZ9bcfUSAk4v3RFqMQOK8n0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=YG+j0hjRed4Ad+Pmjxwht6rCdM2HysmXZUCCOLCmV0UhWF4SMpCTCDW9bBzjYimlUYE6CVjnKJKRH5Yx+9wIh5KbBzmfZyr06LXTVyr3yOLsmqFwZY9lzXpOK19bBccb7HIrZt7Ew7iIYA3qqBVI2i/oB09rJnC59zcz/YUlvsw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48JDolU1012273; Thu, 19 Sep 2024 14:06:05 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41n3ujm64p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 14:06:04 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48JBOP9I001871; Thu, 19 Sep 2024 14:06:04 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 41nqh41fk3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 14:06:04 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48JE5wfE22872562 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Sep 2024 14:05:58 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 06FAE2004E; Thu, 19 Sep 2024 14:05:58 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D658D2004B; Thu, 19 Sep 2024 14:05:57 +0000 (GMT) Received: from a8345010.lnxne.boe (unknown [9.152.108.100]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 19 Sep 2024 14:05:57 +0000 (GMT) From: Stefan Schulze Frielinghaus To: krebbel@linux.ibm.com, gcc-patches@gcc.gnu.org Cc: Stefan Schulze Frielinghaus Subject: [PATCH] s390: Remove -m{,no-}lra option Date: Thu, 19 Sep 2024 16:05:43 +0200 Message-ID: <20240919140543.3583217-1-stefansf@gcc.gnu.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240919081617.3557525-1-stefansf@gcc.gnu.org> References: <20240919081617.3557525-1-stefansf@gcc.gnu.org> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: O0qOZJN41UMrzLkuTgC4JjNkHIyvh755 X-Proofpoint-GUID: O0qOZJN41UMrzLkuTgC4JjNkHIyvh755 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-19_10,2024-09-19_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 clxscore=1034 bulkscore=0 suspectscore=0 mlxscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409190093 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org I have been missing the two test cases and removed them since they depend on -mno-lra. -- 8< -- Since the old reload pass is about to be removed and we defaulted to LRA for over a decade, remove option -m{,no-}lra. PR target/113953 gcc/ChangeLog: * config/s390/s390.cc (s390_lra_p): Remove. (TARGET_LRA_P): Remove. * config/s390/s390.opt (mlra): Remove. * config/s390/s390.opt.urls (mlra): Remove. gcc/testsuite/ChangeLog: * gcc.target/s390/TI-constants-nolra.c: Removed. * gcc.target/s390/pr79895.c: Removed. --- gcc/config/s390/s390.cc | 10 ---- gcc/config/s390/s390.opt | 4 -- gcc/config/s390/s390.opt.urls | 2 - .../gcc.target/s390/TI-constants-nolra.c | 47 ------------------- gcc/testsuite/gcc.target/s390/pr79895.c | 9 ---- 5 files changed, 72 deletions(-) delete mode 100644 gcc/testsuite/gcc.target/s390/TI-constants-nolra.c delete mode 100644 gcc/testsuite/gcc.target/s390/pr79895.c diff --git a/gcc/config/s390/s390.cc b/gcc/config/s390/s390.cc index c9172d1153a..25d43ae3e13 100644 --- a/gcc/config/s390/s390.cc +++ b/gcc/config/s390/s390.cc @@ -11342,13 +11342,6 @@ s390_can_change_mode_class (machine_mode from_mode, return true; } -/* Return true if we use LRA instead of reload pass. */ -static bool -s390_lra_p (void) -{ - return s390_lra_flag; -} - /* Return true if register FROM can be eliminated via register TO. */ static bool @@ -18444,9 +18437,6 @@ s390_c_mode_for_floating_type (enum tree_index ti) #undef TARGET_LEGITIMATE_CONSTANT_P #define TARGET_LEGITIMATE_CONSTANT_P s390_legitimate_constant_p -#undef TARGET_LRA_P -#define TARGET_LRA_P s390_lra_p - #undef TARGET_CAN_ELIMINATE #define TARGET_CAN_ELIMINATE s390_can_eliminate diff --git a/gcc/config/s390/s390.opt b/gcc/config/s390/s390.opt index a5b5aa95a12..23ea4b8232d 100644 --- a/gcc/config/s390/s390.opt +++ b/gcc/config/s390/s390.opt @@ -229,10 +229,6 @@ Set the branch costs for conditional branch instructions. Reasonable values are small, non-negative integers. The default branch cost is 1. -mlra -Target Var(s390_lra_flag) Init(1) Save -Use LRA instead of reload. - mpic-data-is-text-relative Target Var(s390_pic_data_is_text_relative) Init(TARGET_DEFAULT_PIC_DATA_IS_TEXT_RELATIVE) Assume data segments are relative to text segment. diff --git a/gcc/config/s390/s390.opt.urls b/gcc/config/s390/s390.opt.urls index ab1e761efa8..bc772d2ffc7 100644 --- a/gcc/config/s390/s390.opt.urls +++ b/gcc/config/s390/s390.opt.urls @@ -74,8 +74,6 @@ UrlSuffix(gcc/S_002f390-and-zSeries-Options.html#index-mzarch) ; skipping UrlSuffix for 'mbranch-cost=' due to finding no URLs -; skipping UrlSuffix for 'mlra' due to finding no URLs - ; skipping UrlSuffix for 'mpic-data-is-text-relative' due to finding no URLs ; skipping UrlSuffix for 'mindirect-branch=' due to finding no URLs diff --git a/gcc/testsuite/gcc.target/s390/TI-constants-nolra.c b/gcc/testsuite/gcc.target/s390/TI-constants-nolra.c deleted file mode 100644 index b9948fc4aa5..00000000000 --- a/gcc/testsuite/gcc.target/s390/TI-constants-nolra.c +++ /dev/null @@ -1,47 +0,0 @@ -/* { dg-do compile { target int128 } } */ -/* { dg-options "-O3 -mno-lra" } */ - -/* 2x lghi */ -__int128 a() { - return 0; -} - -/* 2x lghi */ -__int128 b() { - return -1; -} - -/* 2x lghi */ -__int128 c() { - return -2; -} - -/* lghi + llilh */ -__int128 d() { - return 16000 << 16; -} - -/* lghi + llihf */ -__int128 e() { - return (unsigned long long)80000 << 32; -} - -/* lghi + llihf */ -__int128 f() { - return (unsigned __int128)80000 << 96; -} - -/* llihf + llihf - this is handled via movti_bigconst pattern */ -__int128 g() { - return ((unsigned __int128)80000 << 96) | ((unsigned __int128)80000 << 32); -} - -/* Literal pool */ -__int128 h() { - return ((unsigned __int128)80000 << 32) | 1; -} - -/* Literal pool */ -__int128 i() { - return (((unsigned __int128)80000 << 32) | 1) << 64; -} diff --git a/gcc/testsuite/gcc.target/s390/pr79895.c b/gcc/testsuite/gcc.target/s390/pr79895.c deleted file mode 100644 index 02374e4b8a8..00000000000 --- a/gcc/testsuite/gcc.target/s390/pr79895.c +++ /dev/null @@ -1,9 +0,0 @@ -/* { dg-do compile { target int128 } } */ -/* { dg-options "-O1 -mno-lra" } */ - -unsigned __int128 g; -void -foo () -{ - g = (unsigned __int128)1 << 127; -}