From patchwork Thu Sep 19 08:16:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Schulze Frielinghaus X-Patchwork-Id: 1987282 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=B4BeceOY; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X8Szk2kz0z1y1g for ; Thu, 19 Sep 2024 18:17:06 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 85AD63858C50 for ; Thu, 19 Sep 2024 08:17:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85AD63858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1726733824; bh=Nhv6yAj/vU7SnpfqTlhOt54ibTxSsL+orbsHRQgwIjo=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=B4BeceOY7Bh70bClHXNaEc8mHwcOZLBEQDYxA395Ug/CPR5aItNNz4Z6NM8XcoJ7h ABEjqD1JQ+5lUF662AKhLAHbCvnJw9l20tDtlzIlDWR3sBeR1Nte3wPpPoVE4F272U vfg79leo74Sg9pBECFV53S6sxlrRdLnFA1qWuI0Q= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B72ED3858D39; Thu, 19 Sep 2024 08:16:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B72ED3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B72ED3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726733795; cv=none; b=qqN25/FRPAZSJmeeNFg3EOF3HANbZ90nk14NWmZXHIlsetofy8FYZHhuWNUMqlZY10oDKGMCTcc9C+ZkqH4XCuiXR6Li7TQ6KIJnU7pyJ1hp7Zf7SFKdCFMltOQOXMWfW1U9OC/h5ALdQLeTIXR2LMpdoeeOh1kVasMS918b9dY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1726733795; c=relaxed/simple; bh=NpOqoCJbHcTSiY+6OicD2jGiB1RxONvHRLEXSe0proo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=idoFci1FDcoI9h02xEfnC3wc4l1JgoXzPe170+6XCVAjoJIsJIwdcY1LR2Vz6qL/VK34uD4gk8lyaiXRDr6T+p80TqBEQoee80UG8q877bGh+FiRWX7mfr4pC1w/+v2QCbKHVFt5hrGSyg49jddHmpzp+EkamDzsG9QGh31OYbQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48J6KNQG000899; Thu, 19 Sep 2024 08:16:32 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 41n3vdtkhd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 08:16:32 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 48J7S6CQ025033; Thu, 19 Sep 2024 08:16:31 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 41nq1n7xb4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 19 Sep 2024 08:16:31 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 48J8GRKG43581768 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 19 Sep 2024 08:16:27 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B08EB20049; Thu, 19 Sep 2024 08:16:27 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8CB6420040; Thu, 19 Sep 2024 08:16:27 +0000 (GMT) Received: from a8345010.lnxne.boe (unknown [9.152.108.100]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 19 Sep 2024 08:16:27 +0000 (GMT) From: Stefan Schulze Frielinghaus To: krebbel@linux.ibm.com, gcc-patches@gcc.gnu.org Cc: Stefan Schulze Frielinghaus Subject: [PATCH] s390: Remove -m{,no-}lra option Date: Thu, 19 Sep 2024 10:16:17 +0200 Message-ID: <20240919081617.3557525-1-stefansf@gcc.gnu.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 4JQs5Armnyt2y9ms6Mb4EZHCiqzi7pIe X-Proofpoint-GUID: 4JQs5Armnyt2y9ms6Mb4EZHCiqzi7pIe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-19_05,2024-09-18_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 clxscore=1034 mlxscore=0 malwarescore=0 mlxlogscore=999 priorityscore=1501 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409190051 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Since the old reload pass is about to be removed and we defaulted to LRA for over a decade, remove option -m{,no-}lra. PR target/113953 gcc/ChangeLog: * config/s390/s390.cc (s390_lra_p): Remove. (TARGET_LRA_P): Remove. * config/s390/s390.opt (mlra): Remove. * config/s390/s390.opt.urls (mlra): Remove. --- Assuming that bootstrap and regtest (which are still running) finish successful, ok for mainline? gcc/config/s390/s390.cc | 10 ---------- gcc/config/s390/s390.opt | 4 ---- gcc/config/s390/s390.opt.urls | 2 -- 3 files changed, 16 deletions(-) diff --git a/gcc/config/s390/s390.cc b/gcc/config/s390/s390.cc index c9172d1153a..25d43ae3e13 100644 --- a/gcc/config/s390/s390.cc +++ b/gcc/config/s390/s390.cc @@ -11342,13 +11342,6 @@ s390_can_change_mode_class (machine_mode from_mode, return true; } -/* Return true if we use LRA instead of reload pass. */ -static bool -s390_lra_p (void) -{ - return s390_lra_flag; -} - /* Return true if register FROM can be eliminated via register TO. */ static bool @@ -18444,9 +18437,6 @@ s390_c_mode_for_floating_type (enum tree_index ti) #undef TARGET_LEGITIMATE_CONSTANT_P #define TARGET_LEGITIMATE_CONSTANT_P s390_legitimate_constant_p -#undef TARGET_LRA_P -#define TARGET_LRA_P s390_lra_p - #undef TARGET_CAN_ELIMINATE #define TARGET_CAN_ELIMINATE s390_can_eliminate diff --git a/gcc/config/s390/s390.opt b/gcc/config/s390/s390.opt index a5b5aa95a12..23ea4b8232d 100644 --- a/gcc/config/s390/s390.opt +++ b/gcc/config/s390/s390.opt @@ -229,10 +229,6 @@ Set the branch costs for conditional branch instructions. Reasonable values are small, non-negative integers. The default branch cost is 1. -mlra -Target Var(s390_lra_flag) Init(1) Save -Use LRA instead of reload. - mpic-data-is-text-relative Target Var(s390_pic_data_is_text_relative) Init(TARGET_DEFAULT_PIC_DATA_IS_TEXT_RELATIVE) Assume data segments are relative to text segment. diff --git a/gcc/config/s390/s390.opt.urls b/gcc/config/s390/s390.opt.urls index ab1e761efa8..bc772d2ffc7 100644 --- a/gcc/config/s390/s390.opt.urls +++ b/gcc/config/s390/s390.opt.urls @@ -74,8 +74,6 @@ UrlSuffix(gcc/S_002f390-and-zSeries-Options.html#index-mzarch) ; skipping UrlSuffix for 'mbranch-cost=' due to finding no URLs -; skipping UrlSuffix for 'mlra' due to finding no URLs - ; skipping UrlSuffix for 'mpic-data-is-text-relative' due to finding no URLs ; skipping UrlSuffix for 'mindirect-branch=' due to finding no URLs