From patchwork Wed Sep 18 14:30:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rosemarie O'Riorden X-Patchwork-Id: 1986838 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dVwI2gmk; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4X81KM2m0Mz1y1m for ; Thu, 19 Sep 2024 00:30:45 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 89306841A4; Wed, 18 Sep 2024 14:30:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 2FeAGjf6IpO1; Wed, 18 Sep 2024 14:30:41 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7406484172 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dVwI2gmk Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7406484172; Wed, 18 Sep 2024 14:30:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 43C82C0012; Wed, 18 Sep 2024 14:30:41 +0000 (UTC) X-Original-To: ovs-dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id CFA98C0011 for ; Wed, 18 Sep 2024 14:30:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A798841A3E for ; Wed, 18 Sep 2024 14:30:39 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 7MMP6zCq8NuW for ; Wed, 18 Sep 2024 14:30:38 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=rosemarie@redhat.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7EE45419A4 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7EE45419A4 Authentication-Results: smtp4.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=dVwI2gmk Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7EE45419A4 for ; Wed, 18 Sep 2024 14:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726669837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QbTk1b6bD89dBe2gDgb8AIdxixHV03JEzJsqBF0G/sk=; b=dVwI2gmkin2BMgQ6gQBx9CQLuJkar0BgoMz4DhZQdxv9AiBhepSxo2XdKUcCMQjBQ99Xag EKRr5iDZ9NJj2KPmVYbdl1L2PQJuZs0p7cM2FXdawbf94t5oIlHgsv3iElIJ6bDuh5dAAp 2BcdCtuOd8a2YuyCt6zuB0pD5LyoJyo= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611--W7KXV2uOImxK5aZnUxsCw-1; Wed, 18 Sep 2024 10:30:36 -0400 X-MC-Unique: -W7KXV2uOImxK5aZnUxsCw-1 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A0D15195608A for ; Wed, 18 Sep 2024 14:30:34 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.22.65.207]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 761E5195605A; Wed, 18 Sep 2024 14:30:33 +0000 (UTC) From: Rosemarie O'Riorden To: ovs-dev@openvswitch.org Cc: rosemarie@redhat.com, dceara@redhat.com Date: Wed, 18 Sep 2024 10:30:30 -0400 Message-ID: <20240918143030.806136-1-rosemarie@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH ovn] northd: Log router name in "no path" next-hop warnings. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" This patch fixes ambiguous logs and provides context about which router has a route configuration error. Now instead of just referring to routes by their IP address, the router they're on is also listed. Reported-at: https://issues.redhat.com/browse/FDP-777 Signed-off-by: Rosemarie O'Riorden Acked-by: Ales Musil --- northd/northd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/northd/northd.c b/northd/northd.c index a267cd5f8..61f4f27ec 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -10695,8 +10695,8 @@ get_outport_for_routing_policy_nexthop(struct ovn_datapath *od, } static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); - VLOG_WARN_RL(&rl, "No path for routing policy priority %d; next hop %s", - priority, nexthop); + VLOG_WARN_RL(&rl, "No path for routing policy priority %d on router %s; " + "next hop %s", priority, od->nbr->name, nexthop); return NULL; } @@ -11433,8 +11433,8 @@ find_static_route_outport(struct ovn_datapath *od, const struct hmap *lr_ports, if (!out_port || !lrp_addr_s) { /* There is no matched out port. */ static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); - VLOG_WARN_RL(&rl, "No path for static route %s; next hop %s", - route->ip_prefix, route->nexthop); + VLOG_WARN_RL(&rl, "No path for static route %s on router %s; next hop" + " %s", route->ip_prefix, od->nbr->name, route->nexthop); return false; } if (p_out_port) {