From patchwork Wed Sep 20 22:19:14 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Julien Fortin X-Patchwork-Id: 816534 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="Od9AS5Sr"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xyDgK0qwGz9sBZ for ; Thu, 21 Sep 2017 08:19:25 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751681AbdITWTX (ORCPT ); Wed, 20 Sep 2017 18:19:23 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:43413 "EHLO mail-pf0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbdITWTW (ORCPT ); Wed, 20 Sep 2017 18:19:22 -0400 Received: by mail-pf0-f172.google.com with SMTP id y29so2228925pff.0 for ; Wed, 20 Sep 2017 15:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=klobf/R51pS707gVTj0+Gs/9HYq/bBtzEUCdQ8lEfu4=; b=Od9AS5Srq2fTYbpie5bttPXe5V/Ut3kntFnoL07hGAirqmq1FPnkp3O5gGUP1VhS67 QcDeVx6ANDKKyJpzLAUiD4bz3Ii3MvykANde66zcwNFWnAeo91W1hIpttcM8hDlkGAI+ A6Rvlq5RDoVjaAzd9cIVFBva6e2wLKPyFxD4E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=klobf/R51pS707gVTj0+Gs/9HYq/bBtzEUCdQ8lEfu4=; b=IEecAbhoTmXMLgko4YJsvBtR/0YaHG/w5yqww5+ofbgEkK/BYcxAIad4fKn3DrMNBZ L68/T3aH7GxiCBJyF8e1tqEcagXcIf/Fawr2ycac1wmnebOVtop3NLd9NYeWyclMIP6O ULYmMSAxjU737tH2UF4Ta49i7Lj4+CO2kJ7PZpKxoGhT7PCgSunrU8fTWm+XDsxMPBoW +KyormprWIz4GB2HP8BWchlu7TboPBNZD6I30Z6iM5Xe3G8CfBgQSRe8vSmrm6ZJGKhu LPNwuk2IQjqxT5xzx7RwdSKCpS5OWAlnBzSq0tcf9nzYoyrhQWjDHuJJw3uYiZurI4ki 84/w== X-Gm-Message-State: AHPjjUgZY2wae0zC9F0PJ7KuK4IM53D08krzfsYFBTl8wlxvJmhBHtc8 nE5pz5QCFQ44NbTAmPwy1LUVwOM= X-Google-Smtp-Source: AOwi7QD3I6VCAIBMHWxWTCQi6cDqRQ39CCWsb76OSeerrUhq3/uDHin7Al2+VjI+0/B0qPFlqFqIEA== X-Received: by 10.84.235.139 with SMTP id p11mr3528042plk.46.1505945961268; Wed, 20 Sep 2017 15:19:21 -0700 (PDT) Received: from JFK.dana.cumulusnetworks.com (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id d8sm9845980pfh.159.2017.09.20.15.19.20 (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 20 Sep 2017 15:19:20 -0700 (PDT) From: Julien Fortin X-Google-Original-From: Julien Fortin To: netdev@vger.kernel.org Cc: roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, dsa@cumulusnetworks.com, Julien Fortin Subject: [PATCH 1/1] ip: ip_print: if no json obj is initialized default fp is stdout Date: Wed, 20 Sep 2017 15:19:14 -0700 Message-Id: <20170920221914.92740-1-julien@cumulusnetworks.com> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Julien Fortin The ip monitor didn't call `new_json_obj` (even for in non json context), so the static FILE* _fp variable wasn't initialized, thus raising a SIGSEGV in ipaddress.c. This patch should fix this issue for good, new paths won't have to call `new_json_obj`. $ ip -t mon label link fmt=fmt@entry=0x45460d “%d: “, value=) at ip_print.c:132 #3 0x000000000040ccd2 in print_int (value=, fmt=0x45460d “%d: “, key=0x4545fc “ifindex”, t=PRINT_ANY) at ip_common.h:189 #4 print_linkinfo (who=, n=0x7fffffffa380, arg=0x7ffff77a82a0 <_IO_2_1_stdout_>) at ipaddress.c:1107 #5 0x0000000000422e13 in accept_msg (who=0x7fffffff8320, ctrl=0x7fffffff8310, n=0x7fffffffa380, arg=0x7ffff77a82a0 <_IO_2_1_stdout_>) at ipmonitor.c:89 #6 0x000000000044c58f in rtnl_listen (rtnl=0x672160 , handler=handler@entry=0x422c70 , jarg=0x7ffff77a82a0 <_IO_2_1_stdout_>) at libnetlink.c:761 #7 0x00000000004233db in do_ipmonitor (argc=, argv=0x7fffffffe5a0) at ipmonitor.c:310 #8 0x0000000000408f74 in do_cmd (argv0=0x7fffffffe7f5 “mon”, argc=3, argv=0x7fffffffe588) at ip.c:116 #9 0x0000000000408a94 in main (argc=4, argv=0x7fffffffe580) at ip.c:311 Traceback can be seen when running the following command in a new terminal. $ ip link add dev br0 type bridge Fixes: 6377572f ("ip: ip_print: add new API to print JSON or regular format output") Reported-by: David Ahern Reviewed-by: David Ahern Signed-off-by: Julien Fortin --- ip/ip_print.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/ip/ip_print.c b/ip/ip_print.c index 4cd6a0bc..8cce2011 100644 --- a/ip/ip_print.c +++ b/ip/ip_print.c @@ -23,6 +23,11 @@ static FILE *_fp; #define _IS_JSON_CONTEXT(type) ((type & PRINT_JSON || type & PRINT_ANY) && _jw) #define _IS_FP_CONTEXT(type) (!_jw && (type & PRINT_FP || type & PRINT_ANY)) +static inline FILE* _get_fp(void) +{ + return _fp ? _fp : stdout; +}; + void new_json_obj(int json, FILE *fp) { if (json) { @@ -91,7 +96,7 @@ void open_json_array(enum output_type type, const char *str) jsonw_name(_jw, str); jsonw_start_array(_jw); } else if (_IS_FP_CONTEXT(type)) { - fprintf(_fp, "%s", str); + fprintf(_get_fp(), "%s", str); } } @@ -105,7 +110,7 @@ void close_json_array(enum output_type type, const char *str) jsonw_end_array(_jw); jsonw_pretty(_jw, true); } else if (_IS_FP_CONTEXT(type)) { - fprintf(_fp, "%s", str); + fprintf(_get_fp(), "%s", str); } } @@ -126,7 +131,7 @@ void close_json_array(enum output_type type, const char *str) else \ jsonw_##type_name##_field(_jw, key, value); \ } else if (_IS_FP_CONTEXT(t)) { \ - color_fprintf(_fp, color, fmt, value); \ + color_fprintf(_get_fp(), color, fmt, value); \ } \ } _PRINT_FUNC(int, int); @@ -149,7 +154,7 @@ void print_color_string(enum output_type type, else jsonw_string_field(_jw, key, value); } else if (_IS_FP_CONTEXT(type)) { - color_fprintf(_fp, color, fmt, value); + color_fprintf(_get_fp(), color, fmt, value); } } @@ -170,7 +175,7 @@ void print_color_bool(enum output_type type, else jsonw_bool(_jw, value); } else if (_IS_FP_CONTEXT(type)) { - color_fprintf(_fp, color, fmt, value ? "true" : "false"); + color_fprintf(_get_fp(), color, fmt, value ? "true" : "false"); } } @@ -189,7 +194,7 @@ void print_color_0xhex(enum output_type type, snprintf(b1, sizeof(b1), "%#x", hex); print_string(PRINT_JSON, key, NULL, b1); } else if (_IS_FP_CONTEXT(type)) { - color_fprintf(_fp, color, fmt, hex); + color_fprintf(_get_fp(), color, fmt, hex); } } @@ -208,7 +213,7 @@ void print_color_hex(enum output_type type, else jsonw_string(_jw, b1); } else if (_IS_FP_CONTEXT(type)) { - color_fprintf(_fp, color, fmt, hex); + color_fprintf(_get_fp(), color, fmt, hex); } } @@ -228,6 +233,6 @@ void print_color_null(enum output_type type, else jsonw_null(_jw); } else if (_IS_FP_CONTEXT(type)) { - color_fprintf(_fp, color, fmt, value); + color_fprintf(_get_fp(), color, fmt, value); } }