From patchwork Thu May 3 09:09:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bo YU X-Patchwork-Id: 907903 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="TmFN8AA5"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40c8Tm1RYdz9s47 for ; Thu, 3 May 2018 19:09:15 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751128AbeECJJL (ORCPT ); Thu, 3 May 2018 05:09:11 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:45866 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbeECJJK (ORCPT ); Thu, 3 May 2018 05:09:10 -0400 Received: by mail-pf0-f195.google.com with SMTP id c10so14181889pfi.12; Thu, 03 May 2018 02:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mail-followup-to:mime-version :content-disposition:user-agent; bh=+93qj/jWJNHcmrKkKEfZZHccs3gfPE7qQaE/KWoMBzY=; b=TmFN8AA5OkrFy9GjBwals9NS1yD0oe1CpU/AYGZfhaWbfP/nuMgZX7+ZJnY2rewVFO 39szlOwr6SH1+pNVnmiOS2zpbJBrUoEzhvoN87Hxq1cwafYTelLLN+e/0JsIZvFT7IWH +89i1d/MeOcmQL9BDPKgFHu4nm24dYMgdtWPq4DPHh5vLUK+Pg51IosSMuOW2O0Zk9Pb pfF1ZExhHTdeIrVGW65hSq2s/dzgHKNnUqYhlBXqFNVgXVlPy1ScGycDFN6wWeXK6NF0 LKk42F8LltV0RP5neFRD61bsqq7EkJTjv8wtwS/cgJgwU5n7g6PkqpX5QyW6DeRctgvd sa6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:mime-version:content-disposition:user-agent; bh=+93qj/jWJNHcmrKkKEfZZHccs3gfPE7qQaE/KWoMBzY=; b=ZIBz1rK44MhNCNg0n7V97S268kEBKuk9kUWDds/2d1pLBHTvH8xBK/qy1GGlp7kkyq MZ8tw+46sL6h0nIONQIsQEMINo3IQUjjW+i9FPD+tS+T5TeqILTy0/9H8o/YkZp4seSW Vi1xSDFWJNnE4LcaJ+LMOKvIuGPvUs3VjTvX0bXLxI055mJiIDrQ13ZUkI5iH34Imome Kt2DA/WEvoRntWUx0awkk8kWZpofQTU+joqzu2YtuzZN3+iQk2WqtmB9junnqKj0TtiJ da7HdoJ1cBFXawtWLJ4+W/+qT3JHFR/M/U5sXtZDXVDELDCFXsh7lyavg1jNHAlBF9F7 ZibA== X-Gm-Message-State: ALQs6tDgfSwyhtel2xfLd9GOcXaGuZtVKoqRt8+o6nCwSBx7omSktkCB zwhkPJH6ld499c9fdN7gIgU= X-Google-Smtp-Source: AB8JxZrTFAA+iE+P+hfeFbCAx0zT9vusj6Wx3ALjHyWYqIHahwg3Eo2Ec1xbH6BpYCtG7WnVosrzBw== X-Received: by 2002:a63:887:: with SMTP id 129-v6mr18344682pgi.17.1525338549390; Thu, 03 May 2018 02:09:09 -0700 (PDT) Received: from debian ([2001:250:582a:5:1d6a:c7d:bc8e:5cb3]) by smtp.gmail.com with ESMTPSA id u86sm30304829pfg.71.2018.05.03.02.09.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 May 2018 02:09:08 -0700 (PDT) Date: Thu, 3 May 2018 05:09:04 -0400 From: YU Bo To: davem@davemloft.net, xiyou.wangcong@gmail.com, yuzibode@126.com, tsu.yubo@gmail.com Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH V2] net/netlink: optimize seq_puts and seq_printf in af_netlink.c Message-ID: <20180503090901.35bxgzs2tjsl7bqr@debian> Mail-Followup-To: davem@davemloft.net, xiyou.wangcong@gmail.com, yuzibode@126.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20180323-188-b583e9 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Before the patch, the command `cat /proc/net/netlink` will output like: https://clbin.com/BojZv After the patch: https://clbin.com/lnu4L The optimization will make convenience for using `cat /proc/net/netlink` But,The checkpatch will give a warning: WARNING: quoted string split across lines Signed-off-by: Bo YU --- Changes in v2: Do not break the indentation of the code line --- net/netlink/af_netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.11.0 diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 55342c4d5cec..2e2dd88fc79f 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file *seq, void *v) { if (v == SEQ_START_TOKEN) { seq_puts(seq, - "sk Eth Pid Groups " - "Rmem Wmem Dump Locks Drops Inode\n"); + "sk Eth Pid Groups " + "Rmem Wmem Dump Locks Drops Inode\n"); } else { struct sock *s = v; struct netlink_sock *nlk = nlk_sk(s); - seq_printf(seq, "%pK %-3d %-6u %08x %-8d %-8d %d %-8d %-8d %-8lu\n", + seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8d %-8lu\n", s, s->sk_protocol, nlk->portid,