From patchwork Wed Sep 4 09:54:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larysa Zaremba X-Patchwork-Id: 1980562 X-Patchwork-Delegate: anthony.l.nguyen@intel.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256 header.s=default header.b=QKm/GqZN; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org (client-ip=140.211.166.137; helo=smtp4.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WzHsR0pQJz1yfv for ; Wed, 4 Sep 2024 19:54:51 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id A1A67403C1; Wed, 4 Sep 2024 09:54:49 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 0LZinCtoMzlw; Wed, 4 Sep 2024 09:54:48 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org C350F40351 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1725443688; bh=WC8bbiXg+vH5J8X+E9ZX6z3IVLVFjx2K5KdOt4oVdyA=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=QKm/GqZNC36BNOG0QyO/2k4A3VSX6oeNvaQ0w5d2vALqOI6PrQZ2gMqqN8VmWJ341 acV8/wQvSXkoMWuGPEw+9MkBupe3FC41Xx+U7/0m2bHOmvb1jYODJ0De3xYyux72m3 tn1r+IaavTvnrCO1LBLAazElPz5JHKKNRIPRxJGMK1gJec05MkS1YCw3tHCPhfcHRx 82nZYXrk3AgVy6HRBh/8kzcXODriWzI2INdFO3zSmjcbt0xYydwL8EVU/kVR5Gt63a e/s2vpvqcfaUT4MRZLX1Ey8HtARvqO5O+4mq6SChZr3h/hgYYecVnYbKYK1dN1tARV SYnSl1YUIWBAg== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id C350F40351; Wed, 4 Sep 2024 09:54:48 +0000 (UTC) X-Original-To: intel-wired-lan@lists.osuosl.org Delivered-To: intel-wired-lan@lists.osuosl.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 3AEF71BF577 for ; Wed, 4 Sep 2024 09:54:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 27E8040340 for ; Wed, 4 Sep 2024 09:54:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id sKirvQdRp8jL for ; Wed, 4 Sep 2024 09:54:46 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.11; helo=mgamail.intel.com; envelope-from=larysa.zaremba@intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org E57A3402FF DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E57A3402FF Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by smtp4.osuosl.org (Postfix) with ESMTPS id E57A3402FF for ; Wed, 4 Sep 2024 09:54:45 +0000 (UTC) X-CSE-ConnectionGUID: cVJyxuq4TI6UPnL0J4jZlQ== X-CSE-MsgGUID: 1BdqzyB8SP2ZO/inWEgWoA== X-IronPort-AV: E=McAfee;i="6700,10204,11184"; a="34664473" X-IronPort-AV: E=Sophos;i="6.10,201,1719903600"; d="scan'208";a="34664473" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2024 02:54:44 -0700 X-CSE-ConnectionGUID: YwwdvXlxSQu8VWPsqwJ44Q== X-CSE-MsgGUID: 2cjHcJE3RoOhPTSsDAyR3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,201,1719903600"; d="scan'208";a="69618113" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by fmviesa005.fm.intel.com with ESMTP; 04 Sep 2024 02:54:41 -0700 Received: from mglak.igk.intel.com (mglak.igk.intel.com [10.237.112.146]) by irvmail002.ir.intel.com (Postfix) with ESMTP id D6B0427BD9; Wed, 4 Sep 2024 10:54:39 +0100 (IST) From: Larysa Zaremba To: intel-wired-lan@lists.osuosl.org, Tony Nguyen Date: Wed, 4 Sep 2024 11:54:17 +0200 Message-ID: <20240904095418.6426-1-larysa.zaremba@intel.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725443686; x=1756979686; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=A8jBBEU4JmlCS2iIUWpGULpUfjnILI4ZQFsy022HtJM=; b=jcksETBak4va8F8p4UjF2w/KKI8EDk1iigi2mbqA/Vn52peldVR8TUP5 aJCs7F/N2TmVld2jcZio5OjmpQfD67cOLrldtftEule9pEzDIrcpOve/s ACYHG1kglFSWwnsbrktnHrj9HQdPtYh66jGi1N7azKc9RhKzsB4PYEEnq DI0Y5PSmnmwNw0m9xR8NFw/ozl5VNoQOfl6mnDNBHVSbsCE4KScQ6Y72G 97n/w8R8yKQPEKuL4wDKGWaN4yvODhXCObKnOeR57KbIZoKzCQGwI233h GLRivO/pkB+8F4KpxbHW+7T99kbOjYXkw0yJwX/6gyDbFa5Id3FwV4wJv A==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=jcksETBa Subject: [Intel-wired-lan] [PATCH iwl-net] idpf: deinit virtchnl transaction manager after vport and vectors X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Tantilov, Emil S" , Larysa Zaremba , Przemek Kitszel , Joshua Hay , linux-kernel@vger.kernel.org, Igor Bagnucki , Alexander Lobakin , Eric Dumazet , Michal Kubiak , Alan Brady , netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" When the device is removed, idpf is supposed to make certain virtchnl requests e.g. VIRTCHNL2_OP_DEALLOC_VECTORS and VIRTCHNL2_OP_DESTROY_VPORT. However, this does not happen due to the referenced commit introducing virtchnl transaction manager and placing its deinitialization before those messages are sent. Then the sending is impossible due to no transactions being available. Lack of cleanup can lead to the FW becoming unresponsive from e.g. unloading-loading the driver and creating-destroying VFs afterwards. Move transaction manager deinitialization to after other virtchnl-related cleanup is done. Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager") Reviewed-by: Przemek Kitszel Signed-off-by: Larysa Zaremba Tested-by: Krishneil Singh --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c index a5f9b7a5effe..f18f490dafd8 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c @@ -3040,9 +3040,9 @@ void idpf_vc_core_deinit(struct idpf_adapter *adapter) if (!test_bit(IDPF_VC_CORE_INIT, adapter->flags)) return; - idpf_vc_xn_shutdown(adapter->vcxn_mngr); idpf_deinit_task(adapter); idpf_intr_rel(adapter); + idpf_vc_xn_shutdown(adapter->vcxn_mngr); cancel_delayed_work_sync(&adapter->serv_task); cancel_delayed_work_sync(&adapter->mbx_task);