From patchwork Fri Aug 30 10:46:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1978903 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dkc31zx/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nutOyuLA; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dkc31zx/; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=nutOyuLA; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WwFGt3cMLz1yfX for ; Fri, 30 Aug 2024 20:47:50 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7B9883858435 for ; Fri, 30 Aug 2024 10:47:48 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 2F0353857340 for ; Fri, 30 Aug 2024 10:46:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2F0353857340 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2F0353857340 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725014812; cv=none; b=BqUq5mJF23SmQzUWdQ5yL6h5wsqI4/0MBnE5zzFdT4lR+SDVy53TbXe8S/UAMV+gFp/Sp+XNO5N1iqA8Nc2Itg4JfWaHscVm0GtwmJv/FsofoUF/giH598/GV+LHGyOxrcrWXV8OiwZOi083KUkXLIeOuaLDU0snyZnkXNV7pf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1725014812; c=relaxed/simple; bh=YDUwR/Q8Tc6IyBr41CXtq9WqlX/imh4ScHaup5W+WIA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=ionp727+gkjdFnycaNV2AJH/CvdCAWtsCTe9/duBJ450wFzlyWVP5KrNlJ7+0OqCVeuEwKiYSzLbFCfBGbHbC4YwtymNmPqIVET30Pads/BCpx796kWUOxNsg000Iw+Jz5DOPz6ra2tnCnSuYT97MGkE109uTZSP/oz+a19X1CM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 48AFF21A20 for ; Fri, 30 Aug 2024 10:46:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725014810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=37UgeMIsaXByIeG3PcOjLkEkkYlz3jONdGP14jWIToQ=; b=dkc31zx/xU2pSnt7CSxulqinz6zp4QVtDa7Djgc8O0BgB7sLEuSZXFSPgAytEta8lLEnj9 zwBNri5YWQbi8pLPEVVmD0cgbaVpWdynUxNs7ADlBzH8clmNqbGp8U0GbiZO6f5G4LPGrk eghM1ba6vWzgWuyn18svSbixb/FL9U4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725014810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=37UgeMIsaXByIeG3PcOjLkEkkYlz3jONdGP14jWIToQ=; b=nutOyuLAYIpVy6pMuLZSBjQXUO6e620L/WZ/9SbmprLLgar5Keo+maWjI+rk34PBcB0TQm hEkZxlxmrzKT6sAA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1725014810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=37UgeMIsaXByIeG3PcOjLkEkkYlz3jONdGP14jWIToQ=; b=dkc31zx/xU2pSnt7CSxulqinz6zp4QVtDa7Djgc8O0BgB7sLEuSZXFSPgAytEta8lLEnj9 zwBNri5YWQbi8pLPEVVmD0cgbaVpWdynUxNs7ADlBzH8clmNqbGp8U0GbiZO6f5G4LPGrk eghM1ba6vWzgWuyn18svSbixb/FL9U4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1725014810; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=37UgeMIsaXByIeG3PcOjLkEkkYlz3jONdGP14jWIToQ=; b=nutOyuLAYIpVy6pMuLZSBjQXUO6e620L/WZ/9SbmprLLgar5Keo+maWjI+rk34PBcB0TQm hEkZxlxmrzKT6sAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 29B1813A3D for ; Fri, 30 Aug 2024 10:46:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id vfZ5Bhqj0WY5IwAAD6G6ig (envelope-from ) for ; Fri, 30 Aug 2024 10:46:50 +0000 Date: Fri, 30 Aug 2024 12:46:41 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] Do not bother with reassociation in SLP discovery for single-lane MIME-Version: 1.0 Message-Id: <20240830104650.29B1813A3D@imap1.dmz-prg2.suse.org> X-Spam-Score: -4.30 X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[tree-vect-slp.cc:url] X-Spam-Level: X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org It just clutters the dump files and takes up compile-time. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * tree-vect-slp.cc (vect_build_slp_tree_2): Disable SLP reassociation for single-lane. --- gcc/tree-vect-slp.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 2aedba61a4e..5a65a99d61e 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -2099,6 +2099,8 @@ vect_build_slp_tree_2 (vec_info *vinfo, slp_tree node, for matching as we can succeed by means of builds from scalars and have no good way to "cost" one build against another. */ else if (is_a (vinfo) + /* Do not bother for single-lane SLP. */ + && group_size > 1 /* ??? We don't handle !vect_internal_def defs below. */ && STMT_VINFO_DEF_TYPE (stmt_info) == vect_internal_def /* ??? Do not associate a reduction, this will wreck REDUC_IDX