From patchwork Tue Aug 27 20:11:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 1977457 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=dvS0RwMo; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WtdxJ4mbCz1yYl for ; Wed, 28 Aug 2024 06:12:04 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32B93385EC39 for ; Tue, 27 Aug 2024 20:12:02 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id AFB06385DDFC for ; Tue, 27 Aug 2024 20:11:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFB06385DDFC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFB06385DDFC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724789504; cv=none; b=GhkyeZ4qXH7HgyQ7mKRxsHeL7y0kgOiKBeB943j8fEpAtobmTsaRLxlQWj67rjllYEXHwOvXgPlEHcxWMSudKR/xSdGNFhhWjso3vJd8kCUH/l5SHqZAlNpN0/HcrQkatLLd6x2ENrPuIra4Aeo1Y3HNMJCcWlMEjJj+SvLE8Wk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724789504; c=relaxed/simple; bh=Ed67mxcZFUtd3uulsiO1hPgDwQ7Vv5Om55kGpYo4DS4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=h7iCQx3KG+bWe2/7PqET1tzz9dYPUndgCFmwU8vSSpYBZtdDDjdRH4qEyOHAcYeaPfwII78CXYZRu30na87Ge7H8MF16KKAzL6W1vGx+leVRe+LhFpWxE13aCKqj42/t2v9Rp2Hdk9JtL4q0USf3cFyEPQMRbf+pJD9SREuY3YY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-2025031eb60so52170905ad.3 for ; Tue, 27 Aug 2024 13:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724789501; x=1725394301; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TZqo9w+vKbG7f2rvPIEn6IyYZQEdXP+2DGy5zVF9ixE=; b=dvS0RwMou1sszX+eeeHH3hClqQaA/l0ifw6+x21TT9gpm/rmQtU4f9mb7TZT+lXXb/ pbGMyXIaNp9ZySXcDr0fumed5CJd4lpHuos9R/0Ca8vxBPPC6hp7XkI2keDAAHct1NRG NXZzFNdYENOQGI94kvbAH34O2LHPpualjXWY40cUz+yJB/cR4tx2lZt1bchrmSOIfKQr xL5tFrWZP/ZUY0Q9rvy0LBkex7a8nbcbGS5vP9onlAAIyksEbgH07iPqkoKIdE3VzYdh 5cI499HGzR+bJV2z8eQ2PIFpK2PDKUGFsqpBOASwRwGYbxiAWZ1gFSrOnR4/1V07gPey eikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724789501; x=1725394301; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TZqo9w+vKbG7f2rvPIEn6IyYZQEdXP+2DGy5zVF9ixE=; b=SGsnmaUzhmJIambDdmgxrtNqKoaaiWENxHPk3B+RpTCYqfPsvQ299fhLRzfj/jaEm7 5SwZ9cfSEeV15wqEvKnm8JDvNios2fAgaaJdLirqz6MGPGRnflUEKBeE/i2wdjnWtVEF kMKmRJxcFRFHcks3Q5OnduUas6jOcxXkubZQKYKxm0CbHGDnKVL67mH2IgGhLCVrG3Km vQr2HBn7+gVR4VS4MfyJUrj/qAruz7F+q1mCxpwt9MXR3IoCdkvi8ATNKB5ccIW3hbZk +IfnimkFx62TDOiRRlBGMin7GcktuZNyFsho6Ua8I6R3LsVWn/Dnn1AnJ1icg0OKtzZ+ LtZg== X-Gm-Message-State: AOJu0YxPbInmqsk6/ZIc91G4f1ubd2ggPQWymu9GDU89jQLDsNBt9XOR 7UKweQjLJ0Tm2K3oH3ay7vkK0yJeEegTzl7ylkIZEU4EZX8y/VSzh+dxYvf/ X-Google-Smtp-Source: AGHT+IGsOY3WLk74Q+aoIIGKsoqcR762jYcV7cyA7szDe+EyWUTdNzzxKwq8tw6KLbd1EoWRPsJMwQ== X-Received: by 2002:a17:903:22cb:b0:203:a034:c2e with SMTP id d9443c01a7336-203a0340c9cmr163162035ad.21.1724789501142; Tue, 27 Aug 2024 13:11:41 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.59.129.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20385565468sm87488035ad.11.2024.08.27.13.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 13:11:40 -0700 (PDT) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id 93C1F74043A; Tue, 27 Aug 2024 13:11:39 -0700 (PDT) From: "H.J. Lu" To: gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz Subject: [PATCH] ipa: Don't disable function parameter analysis for fat LTO streaming Date: Tue, 27 Aug 2024 13:11:39 -0700 Message-ID: <20240827201139.163536-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Update analyze_parms not to disable function parameter analysis for -ffat-lto-objects. Tested on x86-64, there are no differences in zstd with "-O2 -flto=auto" -g "vs -O2 -flto=auto -g -ffat-lto-objects". PR ipa/116410 * ipa-modref.cc (analyze_parms): Always analyze function parameter for LTO streaming. Signed-off-by: H.J. Lu --- gcc/ipa-modref.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/ipa-modref.cc b/gcc/ipa-modref.cc index 59cfe91f987..9275030c254 100644 --- a/gcc/ipa-modref.cc +++ b/gcc/ipa-modref.cc @@ -2975,7 +2975,7 @@ analyze_parms (modref_summary *summary, modref_summary_lto *summary_lto, summary->arg_flags.safe_grow_cleared (count, true); summary->arg_flags[parm_index] = EAF_UNUSED; } - else if (summary_lto) + if (summary_lto) { if (parm_index >= summary_lto->arg_flags.length ()) summary_lto->arg_flags.safe_grow_cleared (count, true); @@ -3034,7 +3034,7 @@ analyze_parms (modref_summary *summary, modref_summary_lto *summary_lto, summary->arg_flags.safe_grow_cleared (count, true); summary->arg_flags[parm_index] = flags; } - else if (summary_lto) + if (summary_lto) { if (parm_index >= summary_lto->arg_flags.length ()) summary_lto->arg_flags.safe_grow_cleared (count, true);