From patchwork Tue Aug 27 17:16:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 1977373 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WtZ3p1t21z1yXd for ; Wed, 28 Aug 2024 03:17:26 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 670D0385DDCA for ; Tue, 27 Aug 2024 17:17:24 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 2ECEE385DDCA for ; Tue, 27 Aug 2024 17:17:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2ECEE385DDCA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2ECEE385DDCA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724779023; cv=none; b=vlG6d1ar4AaJs6+d0ECuo9EYfevrqron2Bj2AE4fa+97ilztFfl/L5TjKuvVdTjVKE4auDwPdQJKVmVVpUbqk8UWnbgOCG4JhSqUolcPw1CGKAWfabCZ9k7xYjPHvJwn9/gLojslxZd5CkQw3TX297etXu4BsBZDWj+aLVW3L5s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724779023; c=relaxed/simple; bh=OuEaEGMvBm9ZhfgXIQDQzmiv70i+kVDiyj0FAPHu9Fo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=tVmbqn3+4zmFXP/qm+zcGjyGAbJC5SPODhbW5213OLHceIefrvTgZF8CdGWTLweY5wEl068xDNLLFQtatDHCPmWaB2IC9Ltz8I7u+Xy135F1QPCT0zycu0VsVlzgH37sCIKuAcbN8Gv7tFDp8PYTfnefPIxjdz33yn0LNLh4wIo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A963DA7 for ; Tue, 27 Aug 2024 10:17:27 -0700 (PDT) Received: from localhost (e121540-lin.manchester.arm.com [10.32.110.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F0273F66E for ; Tue, 27 Aug 2024 10:17:00 -0700 (PDT) From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: [PATCH] Tweak documentation of ASM_INPUT_P Date: Tue, 27 Aug 2024 18:16:59 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Spam-Status: No, score=-18.8 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org The documentation of ASM_INPUT_P implied that the flag has no effect on ASM_EXPRs that have operands (and which therefore must be extended asms). In fact we require ASM_INPUT_P to be false for all extended asms. Tested on aarch64-linux-gnu. OK to install? Richard gcc/ * tree.h (ASM_INPUT_P): Fix documentation. --- gcc/tree.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gcc/tree.h b/gcc/tree.h index 5dcbb2fb5dd..c501019717f 100644 --- a/gcc/tree.h +++ b/gcc/tree.h @@ -1428,8 +1428,9 @@ class auto_suppress_location_wrappers #define ASM_INPUTS(NODE) TREE_OPERAND (ASM_EXPR_CHECK (NODE), 2) #define ASM_CLOBBERS(NODE) TREE_OPERAND (ASM_EXPR_CHECK (NODE), 3) #define ASM_LABELS(NODE) TREE_OPERAND (ASM_EXPR_CHECK (NODE), 4) -/* Nonzero if we want to create an ASM_INPUT instead of an - ASM_OPERAND with no operands. */ +/* Nonzero if the asm is a basic asm, zero if it is an extended asm. + Basic asms use a plain ASM_INPUT insn pattern whereas extended asms + use an ASM_OPERANDS insn pattern. */ #define ASM_INPUT_P(NODE) (ASM_EXPR_CHECK (NODE)->base.static_flag) #define ASM_VOLATILE_P(NODE) (ASM_EXPR_CHECK (NODE)->base.public_flag) /* Nonzero if we want to consider this asm as minimum length and cost