From patchwork Wed May 2 09:54:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bo YU X-Patchwork-Id: 907432 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FWGPDJxV"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40bYXj1RgDz9s0n for ; Wed, 2 May 2018 19:54:45 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751645AbeEBJym (ORCPT ); Wed, 2 May 2018 05:54:42 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:51680 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbeEBJy1 (ORCPT ); Wed, 2 May 2018 05:54:27 -0400 Received: by mail-it0-f67.google.com with SMTP id n202-v6so16069132ita.1; Wed, 02 May 2018 02:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=wSwrYL61rHPg5v/a4cZTmZ9frjmDjIjU6xfdFjsjsqI=; b=FWGPDJxVYYP+zsIVfk5lQfqWdVbw+tTIY1pcCpeantlSLigldwxqSjkQTMDiQPYBgA 2qqN+olhlKOYcmyjO033bUgWY+Z5LR4kQMzSqv9un2ecmzmXBwpXaS2+g90cMVlm9S58 mRCL4I1JQMzMrUeys/jpvzW9RjQHipOU8zZFvkj6eEZIgLWHZ973InvStBKLvry7YAVz ZVom6p1EmiGMDiiuhWkaQpz0cCoUDZQ9djTOdxvpXHqjKbNxcsKJQR4+mdIvk4ODAtcN ISkxRRsxmiZrYQn0LkNgWuWnahS5lILkgXGgj8xSj0xfpoaYX4tjdDoz4+/rOBEOPkVZ Nrlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=wSwrYL61rHPg5v/a4cZTmZ9frjmDjIjU6xfdFjsjsqI=; b=EvGFwVItBNiN9TJzzdsY2ZuntVeMFccD10BG7nvTcXebjAut0L7RokHPMhID2Vvgr4 XeLfgOvOBEQuPG/dCH3OH++0nA3/OeWMAMnox7/k3LdijE8Uw28gEJH/YGitVGziAlud mzqrAnWpo8V0zu5FftIbjRYOEqrr75sUaw3WTWGCiadpUIMlouK0H7RqK8IgY7tmzRP0 ZI0AQ/+fZY/+zF2vSTzq1NgBJpHMHbxmBB/HT6dV71HnmVPYcqOBp7mnxmqfEw+gQvyc r93CgaFBP0Theo4+hDsSjEBp9q8E5yOEBXZVQCvUSJr8VSfMzb5P9tnoTsMGqxPrHGEX tnGA== X-Gm-Message-State: ALQs6tAOMjthMWJRQbOcB4z0CDKAJ2NG+j6+TNhQtAs/ddX8hsQaD3Z+ 3nR7RCrnOFwxOyVEW3fabH0= X-Google-Smtp-Source: AB8JxZoGyKN9sMKaDoyUtiig7CHbcSDpMCr/24kqRcd5LQOYFzk5V10GyW70ljIHuLvL/vlYYPPVzA== X-Received: by 2002:a24:70d0:: with SMTP id f199-v6mr4184011itc.2.1525254866987; Wed, 02 May 2018 02:54:26 -0700 (PDT) Received: from yubo-2 ([191.101.9.198]) by smtp.gmail.com with ESMTPSA id u2-v6sm1617021ioc.8.2018.05.02.02.54.26 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 02 May 2018 02:54:26 -0700 (PDT) Date: Wed, 2 May 2018 05:54:24 -0400 From: Bo YU To: davem@davemloft.net, Wang , yuzibode@126.com Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c Message-ID: <20180502095421.GA15014@yubo-2> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Optimization of command output: `cat /proc/net/netlink` After the patch, we will get: https://clbin.com/lnu4L Signed-off-by: Bo YU --- net/netlink/af_netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.11.0 diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 55342c4d5cec..2e2dd88fc79f 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file *seq, void *v) { if (v == SEQ_START_TOKEN) { seq_puts(seq, - "sk Eth Pid Groups " - "Rmem Wmem Dump Locks Drops Inode\n"); + "sk Eth Pid Groups " + "Rmem Wmem Dump Locks Drops Inode\n"); } else { struct sock *s = v; struct netlink_sock *nlk = nlk_sk(s); - seq_printf(seq, "%pK %-3d %-6u %08x %-8d %-8d %d %-8d %-8d %-8lu\n", + seq_printf(seq, "%pK %-3d %-10u %08x %-8d %-8d %-5d %-8d %-8d %-8lu\n", s, s->sk_protocol, nlk->portid,