From patchwork Sat Aug 24 10:36:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1976371 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WrYK16jsnz1yNm for ; Sat, 24 Aug 2024 20:36:51 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 2FD3440132; Sat, 24 Aug 2024 10:36:47 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DolYP2SE5_fQ; Sat, 24 Aug 2024 10:36:46 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org EBC12401F6 Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id EBC12401F6; Sat, 24 Aug 2024 10:36:45 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 9E8911BF288 for ; Sat, 24 Aug 2024 10:36:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8D6EA6061C for ; Sat, 24 Aug 2024 10:36:44 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5dGpxle1HOJd for ; Sat, 24 Aug 2024 10:36:43 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::52f; helo=mail-ed1-x52f.google.com; envelope-from=dario.binacchi@amarulasolutions.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 5C47D60619 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5C47D60619 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5C47D60619 for ; Sat, 24 Aug 2024 10:36:43 +0000 (UTC) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5bf068aebe5so3857326a12.0 for ; Sat, 24 Aug 2024 03:36:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724495801; x=1725100601; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SWNRg6t+eLXu/bemjcsoAj7cKLvdNka83lM2gp1Ry20=; b=fnQ03R+vsgNvLRwybRU08XcAJy8WKIkZLqFejZTuvbkV9w8eta7C0Mu6vs9Bu9xqHR YOEq4FSwuKNokkJ21bLynaY0hyYSrBFaIqJ3XoxsdzUqTRbCr2/a3Dao2Y7CrfQd3ctu H3xToUMEdWRGvvMLhRd3tpndVLRNL0MtgdXrASMX6Hp5W5CU+lE5jX978reXk8SJIz/b uprKZ8dhKOEda6tPtNBqcO5iB94xAaiFRv/i1Ob9ljImCvydr57CLkWS10SGkjPCVxoq S5V1xca71wtMB9p4DuKsE6kglJFa2R9P4dA9zkzaiIXClhDgYA8qIjs2tTnP4KbotGip MG3Q== X-Gm-Message-State: AOJu0YzycxKwHS2DcuXCkU6PmwNJCoikbDQYjfOSuk3LJ72hhZiaSX3T dMCOKhH16DJPbAOoKh4gGIhzCBMmz/RFdZYvoboOJgbG9MJAe7ejdc9SFasZUcbFUOOxc9wqmfj LX7k= X-Google-Smtp-Source: AGHT+IGM9wBKJbkGHA9wGwh/sdWlb6P+4H4OqXUeZgEsSbWzOFzG5df9xGup2vEpVsBpGlDoeQtiiQ== X-Received: by 2002:a17:907:e269:b0:a86:6858:8a8f with SMTP id a640c23a62f3a-a86a519cb57mr380520066b.26.1724495800987; Sat, 24 Aug 2024 03:36:40 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-25-99-149.retail.telecomitalia.it. [79.25.99.149]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f4378e4sm381883866b.109.2024.08.24.03.36.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2024 03:36:40 -0700 (PDT) From: Dario Binacchi To: buildroot@buildroot.org Date: Sat, 24 Aug 2024 12:36:33 +0200 Message-ID: <20240824103634.1955431-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1724495801; x=1725100601; darn=buildroot.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=SWNRg6t+eLXu/bemjcsoAj7cKLvdNka83lM2gp1Ry20=; b=JV+fXiRu57HNzr/TH0sf8HX+Os/BUbe5Kv9f1B2in2pKY4S8AayXUht4uTqi1WiYVy j4zoC+8857pQmyeac1EMdzSCN/637dxUSzTK7JSdIbcb1JeU+BaiAxUbQ5B7v4RR6X8D xNzpbNJInb2qbkF9vXu7YfNUr/bmmfSOFxP6Q= X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=JV+fXiRu Subject: [Buildroot] [PATCH RFC 1/2] package/pkg-download: set BR_NO_CHECK_HASH_FOR properly X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dario Binacchi , linux-amarula@amarulasolutions.com, "Yann E . MORIN" Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" The hash check failure highlighted by test [1] reveals that BR_NO_CHECK_HASH_FOR in package/pkg-download.mk is not correctly set when the BR2_DOWNLOAD_FORCE_CHECK_HASHES option is enabled. The test output shows that an attempt is made to perform a hash check on the enterprise-numbers.txt file even though the ipmitool package has excluded it from such verification: ... IPMITOOL_EXTRA_DOWNLOADS += $(IPMITOOL_PEN_REG_URI) BR_NO_CHECK_HASH_FOR += $(notdir $(IPMITOOL_PEN_REG_URI)) ... The setting of BR_NO_CHECK_HASH_FOR used by support/download/dl-wrapper cannot be overridden by BR2_DOWNLOAD_FORCE_CHECK_HASHES because it represents an exception that is required even when forcing hash checks on all packages. Applying this patch shows that in the specific test, the hash check is performed for ipmitool-1_8_19.tar.gz but not for enterprise-numbers.txt [1] http://autobuild.buildroot.org/results/5ae5ee948d99679cd50d1115a7d46f4368347b4f Signed-off-by: Dario Binacchi --- package/pkg-download.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-download.mk b/package/pkg-download.mk index ca01ff67a59e..a41bd9d4c0ad 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -118,7 +118,7 @@ define DOWNLOAD $(Q)$(DOWNLOAD_SET_UMASK) $(EXTRA_ENV) \ $($(PKG)_DL_ENV) \ TAR="$(TAR)" \ - BR_NO_CHECK_HASH_FOR="$(if $(BR2_DOWNLOAD_FORCE_CHECK_HASHES),,$(BR_NO_CHECK_HASH_FOR))" \ + BR_NO_CHECK_HASH_FOR="$(BR_NO_CHECK_HASH_FOR)" \ flock $($(PKG)_DL_DIR)/.lock $(DL_WRAPPER) \ -c '$($(PKG)_DL_VERSION)' \ -d '$($(PKG)_DL_DIR)' \ From patchwork Sat Aug 24 10:36:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 1976372 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WrYK458ZXz1yNm for ; Sat, 24 Aug 2024 20:36:56 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 457604022B; Sat, 24 Aug 2024 10:36:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id XXf5HV4vPmDj; Sat, 24 Aug 2024 10:36:49 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A3576402A8 Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id A3576402A8; Sat, 24 Aug 2024 10:36:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id F32361BF288 for ; Sat, 24 Aug 2024 10:36:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E18184022B for ; Sat, 24 Aug 2024 10:36:46 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id b4pXBpX-_DaA for ; Sat, 24 Aug 2024 10:36:46 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::236; helo=mail-lj1-x236.google.com; envelope-from=dario.binacchi@amarulasolutions.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org DEB1140132 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org DEB1140132 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by smtp2.osuosl.org (Postfix) with ESMTPS id DEB1140132 for ; Sat, 24 Aug 2024 10:36:45 +0000 (UTC) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2f3e9fb6ee9so31825591fa.3 for ; Sat, 24 Aug 2024 03:36:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724495803; x=1725100603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fYU3Xth++oFPt++rZHQq6zu3Z7nkxKsX1D17LjK4TGs=; b=wbUUap9+T9VHNt7hNIFSrV8wh5l+2PwvHjSMha42r+JVG3Zpu/85BB7OGISsGlOwOG MJAhlS428ZytDcemek53u8+fIrstVvM3bSbwZAQl0QdrYTLpLPWjxTjNSfjb2pEK0AD6 z9lB3okGTRxjIdP5n7flJXAO15obkaF0IsYo7EupOB5vKk5znWRrzYGg/ZHQvFnslVAt eWrlB9uuSFoKsNxwJFnMpR1Oq/XfAtdS5AOE/Z03IE0UqgKTG5d7a0ENCReB86dfj4d7 9vo41tUwQXkd4kuBbvvscaVxK96lu4iyb3oSh5Fnph+LwiNQhxC5pdpijij9lrgzo/KI FwIQ== X-Gm-Message-State: AOJu0YzmMEkRWSu6ODJUWeR0b4oh4eS5b3HBIU29o1W78PLL68yZNhuG yIp02Nx7YravueKvJJ8EAz7NSy0bQDCIYK1UsuXoeCve3NoSIwEarQnAzft9f1Dg6NDgImTsXYq qr80= X-Google-Smtp-Source: AGHT+IEp2W1gqQ+KLDvmpm+3A32BzB0qOKF0MUaq9AGIBORMLkRhQTInWD3kkLeri1Wqipm/4lahGw== X-Received: by 2002:a05:6512:1048:b0:533:1cb8:ec6e with SMTP id 2adb3069b0e04-534387858b2mr3957876e87.33.1724495802807; Sat, 24 Aug 2024 03:36:42 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-25-99-149.retail.telecomitalia.it. [79.25.99.149]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a868f4378e4sm381883866b.109.2024.08.24.03.36.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Aug 2024 03:36:42 -0700 (PDT) From: Dario Binacchi To: buildroot@buildroot.org Date: Sat, 24 Aug 2024 12:36:34 +0200 Message-ID: <20240824103634.1955431-2-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240824103634.1955431-1-dario.binacchi@amarulasolutions.com> References: <20240824103634.1955431-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1724495803; x=1725100603; darn=buildroot.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fYU3Xth++oFPt++rZHQq6zu3Z7nkxKsX1D17LjK4TGs=; b=gtK6IvKr8uQ/88z4yIvnUMpqogCinfTRy3D0OT3uZCuVdFKUtpfyqQPBO9kxFKyHAv HquKnc6YLQO1odqIcbGZ8KmXdco11DY/FVvWMKqv4XM9P9hfh2RPhMHUB92SJfi41tXa SuMvobjTtn/F+i2n6YrP5PfNer7A0dRS3WKbk= X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.a=rsa-sha256 header.s=google header.b=gtK6IvKr Subject: [Buildroot] [PATCH RFC 2/2] support/download/check-hash: warn when an hash check is skipped X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dario Binacchi , linux-amarula@amarulasolutions.com, "Yann E . MORIN" Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" This highlights that the hash check for a file has been intentionally skipped. Signed-off-by: Dario Binacchi --- support/download/check-hash | 1 + 1 file changed, 1 insertion(+) diff --git a/support/download/check-hash b/support/download/check-hash index d18ec8b134e8..173df8fc6fa4 100755 --- a/support/download/check-hash +++ b/support/download/check-hash @@ -108,6 +108,7 @@ if [ ${nb_checks} -eq 0 ]; then case " ${BR_NO_CHECK_HASH_FOR} " in *" ${base} "*) # File explicitly has no hash + printf "WARNING: Skipping hash check for %s\n" "${base}" >&2 exit 0 ;; esac