From patchwork Fri Aug 23 11:08:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yan Zhen X-Patchwork-Id: 1976000 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QrsXB5JV; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=vivo.com header.i=@vivo.com header.a=rsa-sha256 header.s=selector2 header.b=c2MhwvtK; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Wqy4p6Ygqz1yXY for ; Fri, 23 Aug 2024 21:09:12 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KgW91FwMC3FtFgMisMG2QsO/I52fbUIQzpe3jMKIvMI=; b=QrsXB5JVoCAGZL +wUttp///tQahbp4JWwF5ElUMfaLiVk5mWTQ7yhRQWKPDtkAsp5tlNb7nz7pp1/26lC3QkpA/oopw OKievMmeoFUvraKZx+eqWm7bxtZvfXdoMsNUvn8gXUs0ocL7OlD681HA9yS5wi5weEw6GBnSVmaUO jW3XEKl8+ogtdrG8TPwg9fSaapLvWfVCdIeE00LuXV3p53aKfNhK78H2223vrNIIEkre2V/pcvZoB R66Jea/9b5EdioAU8fBlRSJPp50Xd71qVQGrmQ722HeOZtyHGEZi+qU70XJt+8ltckuEEhngEvvJD cqylzECsw/cjNXiQg7Ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1shSA1-0000000GTXl-1vo8; Fri, 23 Aug 2024 11:08:53 +0000 Received: from mail-tyzapc01on20611.outbound.protection.outlook.com ([2a01:111:f403:2011::611] helo=APC01-TYZ-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1shS9y-0000000GTXO-2vjp for linux-mtd@lists.infradead.org; Fri, 23 Aug 2024 11:08:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IkBrPQjrTNrUf43lvNnTng5S+YC+ISneR3cAe6EU4Ump2F4ZUidSw9xfDR2+MRXSkmKvZUr5HKNvzxVAqnu/uYXDQoYxk7K9V5LySMdv97a8rRWExvFFLXI8fI3CfRHSyEXle5HpluVjBeTNOQ+eTv0ZzzyEP4dBPSnQWNtMp/UxbMoomNPRfUPu2ZcqyhAzDnDhc2qCHASBzbB6fb+8ltBX7OroMmDrU9/6eijReTAMzR846XPOP1fesD6dLRB8znu35WHu9nokD6vYz7EFVCMC0vcssjK8fPsKedx7e/IEV+UsTyhPU3Nt56kz1Bc8emivod8y9BoQyukJrsxUPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qhPTkf6yCtN5HuY2CMsD/5hHPrGs8gNORC553GgtcLE=; b=XnahZ5ouq93j8pliuncP+4PvhPpTDhbdiOK3kZNABdUVHM3vsaGNGH0UPwausw6RbcYZyjWO1i5yyYQjOwXwT3sFfBBp93Nz2Iidu1WPdQf7Zuvj8xTIgUQ+BltfbC3lFzr/txBe9mvv/7T5B5XwcMZUn6BW3cTEhxZmhA5rCE4yxGYQzb+O6ZdpSIGxqDjSL9zEBYFe+cySppevFHXmSSNaMWMPZPesuXfxXoiHP422VKHv7hzXjkPEfc1kDXIG0cBWMWAKcjhgsRPi3G7MDOr8cNhuvZxZ05isIRH6tU8BgsP5moBk9LHbWPgd8msAg2zCEBqGtHCZdna671NF7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qhPTkf6yCtN5HuY2CMsD/5hHPrGs8gNORC553GgtcLE=; b=c2MhwvtKEdw8eUs+GwbyR5a/IaIKbr3uaPn3wetlW8gAb9etKxC0lS68YhFm+cot0p4WGX6rvNH5hqsGTLmT2QvWV48Yk2oLpn+OguNL1HuBW0UUL6N3TGit9NHHncScPVzmt24Eeu3rLi7JVASgnYP5fuodrJMO0e/nzkJW4BCk953TfcCWjL51e1/ysnm7/Kht1DrAxDOSrVm60HkfRa0PqL4s1d3PlawRH+KVFDhcQ1QjP2RkCAfiVISdPq0mgfA9ZYM+TqN4jZSf8bp1s3eWUjA9mKl5nmtQoYpvwgY5yxk1SD5ssaTEQ6JEtAsLRd+MIJ++WnEFvbpDV/3T1A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from KL1PR0601MB4113.apcprd06.prod.outlook.com (2603:1096:820:31::7) by SEYPR06MB7043.apcprd06.prod.outlook.com (2603:1096:101:1d8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.25; Fri, 23 Aug 2024 11:08:42 +0000 Received: from KL1PR0601MB4113.apcprd06.prod.outlook.com ([fe80::7e85:dad0:3f7:78a1]) by KL1PR0601MB4113.apcprd06.prod.outlook.com ([fe80::7e85:dad0:3f7:78a1%4]) with mapi id 15.20.7897.014; Fri, 23 Aug 2024 11:08:42 +0000 From: Yan Zhen To: vigneshr@ti.com, miquel.raynal@bootlin.com, richard@nod.at Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com, Yan Zhen Subject: [PATCH v2] mtd: concat: Use kmemdup_array instead of kmemdup for multiple allocation Date: Fri, 23 Aug 2024 19:08:24 +0800 Message-Id: <20240823110824.3895787-1-yanzhen@vivo.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SG2PR03CA0120.apcprd03.prod.outlook.com (2603:1096:4:91::24) To KL1PR0601MB4113.apcprd06.prod.outlook.com (2603:1096:820:31::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: KL1PR0601MB4113:EE_|SEYPR06MB7043:EE_ X-MS-Office365-Filtering-Correlation-Id: 0f0a89c9-3708-4041-ce48-08dcc363f2c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: gcGBr2+f8nw8QH8OmI9MB/ZI7OfigQ4f8pFKrqVVS0UkPf9KvX2dlrUqiEdOwcdAsM6o+JhqhirPAkHZuV5wrjC2L/jdsQyFkKMLzr8RcWul2cVZBkyQwBqfUxsgjMTABTn5ZEPKUEAHsOA6i42yw9Ds2PFI0H22FNmjsDrrFexIqJ4eDt+UM8NsM9qUHtcc2xWhkTUW1YCyG87n1rRCgKfWNODGNppQBrw+id3/BiF69UuPoiX/lsgzDIMnzDMJDi+VnQO5A6tqfOHesR8EmD9d/L/Ctev5IrfbYbu7mdSzZh7V793N0u7uUQgCzDAJILY0MNCYgdpGRFuTLptLbh/6akEk+BaOfOCtegkpeBfjaM/lZAn+XeAs2dpm2d+QrcKKMjWBN3ksWnJLOzmZoldZhlFBBtmyYzS9KWAP8ZdLSkXNXYEF/04KhtpF3Ybw1PZqLU+5ru+buNxHxosO3/uWnGwyKwQTsSnIILBRLQ6De/AjSSwe5xWDsGJrcaZik5QtYlqNC/haaNw0SBu10pmhZ1Jl7bymr7o6J8pWsmxJL/ez7I2NHD+mPLmcEOeJqzQAiSzab1Xs/XH4IoSGT5+/o8YdyLAGO7RG0vZ7NTPOxyeS13i8DXAUQhiVOzx4kA3V0mJeWuoxONVrvbHv/cZnYfEiqqg3ET7Pv/REjjjpYp5QEmRkQEh+aYBkiqjDb8/dIRxh3Jgdw04isEAonAW71Rj6ASnGQXTn0DNPkfbUfjJFbZCEBWY00HK94vxiL+4pEw8hvHHqbWxj2k4LB7GqnxE52mUiq+r10qVw7gw+LciPMPlfFgXxUq9unZ2S/cWezVm6tnZak8jU0aeS3Z3FKmX3EpHZmWbZH9qMzSWdI22RZcyKsrC5IeuGoqUPFH/RwXKhwTf1hKOBgxHe4KbaegNDf43YWMlyfbm9Nk4WGlytod7jBf9C1B0KNzl4o/dDOu+i0zVPpbN+tj5cNVJvhnBbfbglLyvzpWDQYLi66z/bpFBK17154KnY/HTrDu1ywTCr1CvqxrRkhmLdPB7IFG4cwBDrjlPaBy0+Jro62F+UVkSyKnFSo/k2c5mpaGbH6ysgUHOArZ/3h7848j5TnqKpgpZ+USlp+5w7llFyHE19gUoXVOUqnJepy6u7xCTOznGkE9OvpMpC55mgW30/wEIRgX3UaJXTcGXjuAhsGafPfZl/CZbOBOWQKqnuoQ347N4xGkKr6IBwiLUQNFYw9AJ+Acriwek0BMyP92o7Uoe8IDls18/2ruRpqhh/wFVrUFMK7gsuWaRBm5RRB6D1LZyUVqedf+L0fU/fZsk18zxe7ZCD0523f7lMJUdtSYryJ5nmvLJkg9EdnetIDgLt79POB1HBRq6njmkZ1vAtlbSQRZtjhoLJP7cEwB7I9q+4Tm+T07iR+n6+bhKNSg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:KL1PR0601MB4113.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: jtYBHmg7u4ZPjaU+pABgSPmxPYUvBM7t6z5HzH8pls2VNo5/TOVF8GI7khjf1pn5RLYhJ7fCmUMYhoDr3CuhErkTvsg1hNkTd5SOwMQzqkvLad7RL/OSPn5c2Whr4Y/a1YDamRRdi8zk9UEQSGtCu5YnC6UrnAelP9DhgxGTdqKI/K2JIDtln20g5uY9YiLDXqbENN6KZW3rBqipDlstATfpBofi7VOlNE19TvwqLDtExIJ6B4bQhCAgsRcK4WcM4kgsxFXOfID2/N1xG/kNHmnvTOHhwe+Y4qjRtCXUoXV6xKctZ51FoWMAe4p6BpyKMnHjkNEM+IoiB15sTDbt6Tr49sAgakntEGv492KVGfJpGERSyoXBu/ldcRlzRekTdxzz8Vfbm0pe+/KFvFBmsvNEzJ/g14aycro5NCwTw27pHKf/wQ2gPnCKe2InN58ZpN0L7eCYsXFFH9e5UHPJ96j8+HZaapcb1dV6sdOaE25eb7GO5QQnVLBq92IqmokStXJCDQDCV2v4E2OBhpz+CqUNBTcUvcoi91iiAjFKAgFCOwDoh1M3NOWmMBgw3zMBOh+nXOjqKikIPbrdTA36FWzN66q2KNlUZK7e7PjGevwfCNJKs3LSxjB/EOHaDjo/JmSEqnLIhOGCctamBBp/OpemnG5IcSi506uAEs79N8RyIH9x6ncva4UFgAfkfgynr3HFJ+jD4Bzp6DNxPJc7tI8cRkAAHKY+4sbDhnD6Sjq0uaoxejJ8bPOnL0JVjXs13o/WrJs2XVPb7lnw5DcEI2xfcSLpjkqCPMmkjNlKFNVjW6HLW3NjFuV/WEDQ7ZXgI4QifCivDdZmCoHG9Iqpi305Atbeh+ZiyoGfl2DhW4hwn+2XRVmiPQ6WkJXQ6eywZCw+DJbLh6XWTSb+Euc1YnKn6lZM+pDfo8rdEtF7VaoQCZ6swAnYL/ToILFZXi+Op9agfIKvy2OuPtsdWJw4/EOka+lJko3+YNhsjjS1TnZIwX2udcuJseClUgmBYdFF6vcJNnmHz6kyFrzaYMNopAk5WzD8DbRrYAP1JxS8FujCBk1WvP7ITT7C6T1usSxRpNba5NtGya010x/IsNup8Co4IWy7NGHst8oVvO9RT3rZp8CKDiogqOilCGmxghpoyf/iYKoB0TstNo87RzMJBrgmRjqyySsOzdqrRkGfmnOd9Q0wncTrz2t7p31cLBX3RGhEWrm1lf2pajEJ0uTeTKz8XtUW9zsCUBe+CpJdY96H4WoSN+dAi0H7GcsyivoSJ6bNw8MSBXzjMzlEdab4IsBWKDg4iVm6PR/rOFs1RMplRfiU1/h1X1XjOQr8qQPha6M4QiCZSwhFaE9ClXqotDpGBDA5/SlCMnVxZ2Z87O3aF4Fk+bQDN+iVoduqcnMuEequEQ7TRrplf3vyaoQjSihry5MMr6Ej9811ZlVA6UM4IDudUtdnA8aEv7Cv9K6rtfCq16gfZgRAi4puNZjY/rqV5rC+9h/13F8L/Sh9i8a3kyQBXxe8DaA61rMJePth2IyxxwML8lIhW5SPREl+YdJpvrsiEnLl5IYzZNNBOf41sLENIKnMIYjTJ8dsfFc3 X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f0a89c9-3708-4041-ce48-08dcc363f2c0 X-MS-Exchange-CrossTenant-AuthSource: KL1PR0601MB4113.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2024 11:08:42.2887 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6JRjYG9mohbm+KT+DJNYtAFiTFAYExFFbbizGDOJcVmPuZBL5TQ6JqkXaZsfMk1lmsS/XhHg0VUSnLXoxFec7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB7043 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240823_040850_760737_92BD64A6 X-CRM114-Status: GOOD ( 11.75 ) X-Spam-Score: -2.1 (--) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: When we are allocating an array, using kmemdup_array() to take care about multiplication and possible overflows. Also it makes auditing the code easier. Signed-off-by: Yan Zhen --- Content analysis details: (-2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 ARC_SIGNED Message has a ARC signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.0 ARC_VALID Message has a valid ARC signature -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 T_SCC_BODY_TEXT_LINE No description available. X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org When we are allocating an array, using kmemdup_array() to take care about multiplication and possible overflows. Also it makes auditing the code easier. Signed-off-by: Yan Zhen --- Changes in v2: - Rewrite the patch title and the patch description drivers/mtd/mtdconcat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/mtdconcat.c b/drivers/mtd/mtdconcat.c index 193428de6a4b..f56f44aa8625 100644 --- a/drivers/mtd/mtdconcat.c +++ b/drivers/mtd/mtdconcat.c @@ -204,7 +204,7 @@ concat_writev(struct mtd_info *mtd, const struct kvec *vecs, } /* make a copy of vecs */ - vecs_copy = kmemdup(vecs, sizeof(struct kvec) * count, GFP_KERNEL); + vecs_copy = kmemdup_array(vecs, count, sizeof(struct kvec), GFP_KERNEL); if (!vecs_copy) return -ENOMEM;