From patchwork Wed Aug 21 10:17:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Vehreschild X-Patchwork-Id: 1974810 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=vehre@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=QO6Q1IFy; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Wpj2x2w2vz1yf6 for ; Wed, 21 Aug 2024 20:18:17 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 86E6F3865498 for ; Wed, 21 Aug 2024 10:18:15 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id E5D79385C6C9; Wed, 21 Aug 2024 10:17:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5D79385C6C9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmx.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E5D79385C6C9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724235474; cv=none; b=kN+oSIjFyT0CQ6d/nyiwtGLhSejccvZ/hU5Yn8Bcg2hYxhJmbGQwj9jXWQB5/BklTgWZ1WmWM507KVjEXq/nYao6HEkjFJK93Z6YaSVAnOZUvj8rQzQxiiNDvMEZJTHMlCvkamrx/6wmQl4a9cRn/AwKSEqRdfWyB0lJlU2PuyY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724235474; c=relaxed/simple; bh=Y/1kFZcmRWjIQOrtsYmT3V4baYu1RBlKSDoe9m5p2F4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=dW0Zbl9XCMKpXqGpTpzgYeyChbcISdLbtC4egH9FgYmaB5QQxcLMlHmbyLHQ6CXgbLOYbtcZz7nMxfVNCHr4rJOaqQ9RkbXKsoyvbNcYmCRdbH/k/tlVaSy+CVjXWhHlxY11WNmPfVPUIlcfDUv1mM4h2GGeZJQ/hGPgnLo9KPg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1724235469; x=1724840269; i=vehre@gmx.de; bh=thtKQB2v8vjjdk7uF7R5g++vqwoWf6RgC0V+cKXDwWA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:Message-ID:In-Reply-To: References:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=QO6Q1IFykFod7tYF2ynBTlYIEXojuBWPzCaqQSyptyK0wc7WVjczCG0C4x1qhNuN 4kpP0r51BwyhCI9iC/H4Tq3WbwnPB4A8cDnGckQfAEiMtIBr0tFV1OoidbfcLU+nB s7LHcPtzgdowaTetx/H9wvILTYYfMpNVgFqCDUflMIp4P9/Q/wqe+mN0nH+G8/V1+ A4Ah64Z+wi3qY3OcvveFzg6lUaw5yJQdrAe5Uy/TgGVMe7qzJ8pRxIjpmxvKOHY+i R8TU0bUG9rH01usuojLXclnyM/B9NLtVWrQJmUOz7vypYbMpxU7yFclmMo4+O/6gY 12jByDGy837/xaurXg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from vepi2 ([79.194.172.234]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBUm7-1sqqEE2OvH-00DnOp; Wed, 21 Aug 2024 12:17:49 +0200 Date: Wed, 21 Aug 2024 12:17:46 +0200 From: Andre Vehreschild To: Harald Anlauf Cc: GCC-Patches-ML , GCC-Fortran-ML Subject: [Fortran, Patch, PR86468, v1] Follow up: Remove obsolete VIEW_CONVERT Message-ID: <20240821121746.44d037a4@vepi2> In-Reply-To: <20240821111427.3a32c3af@vepi2> References: <20240820135248.6c4c93d1@vepi2> <61e9a8aa-0d61-4feb-8f74-858107234a7a@gmx.de> <20240821111427.3a32c3af@vepi2> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Provags-ID: V03:K1:czrg6ClOtl7LEtYOl1ENP3FRPNWcx1V9vN9tE6XFnFrk9UaLogB u4zhBVGeXnc7LsEZdeRasGDFGVNhv8vJTK0wPR4GgnQttDdk+mSXtj5Bvzw7ap367XNoK9Y D+e9Xj0eyyqzIpGmh5pXrM0ff1XC3Yo8ebGw/cfiDb/h9JIDitBstWwAP2CAYt5Itj4z/ki PlW5pypXfqV2GN6CcWKwQ== UI-OutboundReport: notjunk:1;M01:P0:y5S1LGO2EDI=;QigYkp7L9n9uxMSYGay9fjYi7zZ /S9oAIh5/Ed979VYgX4MekS9vDG8YqXRPWPrVFbBxqlNbEmxtPt8agkc8QEtGEf6o/AHqOWO2 /syS88kaK6iswwsjWOMpbdCFX2cCPs702dFylRPJQzCeHeQLPmwvJ8bRSjItF0b/D9xhk5it6 hdO4FiH/CNE+kcgmKsKav8A4zAYZS4kNTdh/LbCgDntIxY9fN9kUs9YKQU3nFGmYO8HIZ5XEe H/bWAATuWNgAJEmkRGIvYK86p4FfYHxDIoo/bLe2VInPaXnhQ2hQoVzu2VxO8suzjwOmzykSF WSrAoZQNborykbRVkIOwrgs9I5OZkqJaZk1Yqh40B8PSwZgwHguctn/KoSZz8yFg2AQxckPyd 5CZtlU/nazwNZ3hgRAqY+fpgnQD7XX3IhZXLP/vTFsY68SSOVhuzTqSjyllMsGo8we67I+5tm bRKxW8R4ZL/r7mJrxZbyi6+HCNA+ITe0ZS9YWpEsQFq+/ZaraAKMm9/0b/6D8j4kQJBJXjGLS 4Pj2sXHK4t3PTLMP+Q+ZYGGEO5WFrLClX9vmlAycn5F5kQf6WY7f4qakfU9ZR0eToaMoWj9Cd QUAKxiTZdfNiuNxYvbED1dccSgnj4RRISomkiiJ0RiHqZNUq9JN0qGTUqKXhLCvuiP4QT1Yml fvhWgwgTqxY8ecmsx600omW9Ib1A17/9EI1jli7NETrXqDM1FHrBJj6bi3IE/9Vh+aZd35d3n GYZWEwe94mSZMZE6OBje+K/wJVXFad8QUMNwbVolOYCjggYlSUJ2LHpwNVmqxmUgQ7kLxKvuv xry8jI5KJwvS7Z0E7XamktUQ== X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Hi all, attached small patch removes a VIEW_CONVERT that I erroneously inserted during patching pr110033. PR86468 fixes the (co-)rank computation and therefore this VIEW_CONVERT is IMO obsolete. I think it may cause hard to find runtime bugs in the future and therefore like to remove it. Regtests ok on x86_64-pc-linux-gnu. Ok for mainline? Regards, Andre --- Andre Vehreschild * Email: vehre ad gmx dot de From 3a83901e64568967600d5ba643723ae2ad80e0ac Mon Sep 17 00:00:00 2001 From: Andre Vehreschild Date: Wed, 21 Aug 2024 11:22:57 +0200 Subject: [PATCH] [Fortran] Remove unnecessary view_convert obsoleted by [PR86468]. This patch removes an unnecessary view_convert in trans_associate to prevent hard to find runtime errors in the future. The view_convert was erroneously introduced not understanding why ranks of the arrays to assign are different. The ranks are fixed by PR86468 now and the view_convert is obsolete. gcc/fortran/ChangeLog: PR fortran/86468 * trans-stmt.cc (trans_associate_var): Remove superfluous view_convert. --- gcc/fortran/trans-stmt.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/fortran/trans-stmt.cc b/gcc/fortran/trans-stmt.cc index 023b1739b85..d92ca6477e4 100644 --- a/gcc/fortran/trans-stmt.cc +++ b/gcc/fortran/trans-stmt.cc @@ -2031,9 +2031,7 @@ trans_associate_var (gfc_symbol *sym, gfc_wrapped_block *block) gfc_class_data_get (GFC_DECL_SAVED_DESCRIPTOR (tmp))); } else - gfc_add_modify (&se.pre, sym->backend_decl, - build1 (VIEW_CONVERT_EXPR, - TREE_TYPE (sym->backend_decl), se.expr)); + gfc_add_modify (&se.pre, sym->backend_decl, se.expr); if (unlimited) { -- 2.46.0