From patchwork Fri Aug 16 12:58:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= X-Patchwork-Id: 1973244 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256 header.s=selector1 header.b=wwHN5E8o; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WlhsL2ybTz1yfB for ; Fri, 16 Aug 2024 22:59:34 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED7B3385DDFE for ; Fri, 16 Aug 2024 12:59:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by sourceware.org (Postfix) with ESMTPS id C60E8385DDE6 for ; Fri, 16 Aug 2024 12:59:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C60E8385DDE6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=foss.st.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C60E8385DDE6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=91.207.212.93 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723813149; cv=none; b=EQd9PR+7wyqaIVlre9C8TapABnMXRENYJp94x5Y5ASbjkiUtAYGCZx9UCVaisj95aDoyk4DT1o64gI2otUCE5dGZ7h/GAZkO4qSPaoXTCdPzyPU54GFofvOp39jOIxmZ2yDb1OFE/as4CTgelePgtb/SlTPs10/wXw7JDS4QOZk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723813149; c=relaxed/simple; bh=W+eCYZUlN0XzWF5v6E51cQYwErPy2eZM4LiZTyPTgnw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=M8rAgv3DSmDOtTxRzT8S47qkDKQypyNLhsHezWxUKmk5yByEFxfQJEwH5Ful5/MdQzC92VEmQWzn2qxkAPF5LqkkOWewbpJK8+7pbfK15Zhy6BjxBtLLf2MmQj5w+VkBTipZZ7N8uZ0qvGGC1RAuUEDPG5vqQyg+3BNiB4ACT/c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47GB3eRj007644; Fri, 16 Aug 2024 14:59:02 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=selector1; bh=i3n9CdhyWKa23QNXrnPaWF WpQvt7Q4xgekUhBaVDHT8=; b=wwHN5E8o2m7AA3ZFzv5X/+ZflDrkN8gHEcYzqX E3UvpWYIiyQrUBGoXFFxzc3IvKQlaKaAA8orBy6OboT+uXfBY4zx0saWpEJJwfNn +dU0LV0WrWZN0fcS6xsIlrGfqnENLBQTqVuxNtqFWApCwJjvzDmkmmwY8kx0hsu/ VlBwO1Ti93HhpNdaQgu2DUDxP1FrNgjykM3iqQxRiJmDPYQLWcg9Qm+wGy/IB61I gPDmUIAkbJEKVBjfUdsjv592G9IQ9nZS7aMd/Psw2ySDp5ku5cuN0f+BKYBM/Z8s uzeW+Jom+v9/BHhkr707Dz0AEQ7ZpHei609hHG392lD3mK/A== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4121pns76n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 16 Aug 2024 14:59:02 +0200 (MEST) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 8453B4004B; Fri, 16 Aug 2024 14:58:57 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id DDED22596BE; Fri, 16 Aug 2024 14:58:43 +0200 (CEST) Received: from jkgcxl0004.jkg.st.com (10.74.22.255) by SHFDAG1NODE3.st.com (10.75.129.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Fri, 16 Aug 2024 14:58:43 +0200 From: =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= To: CC: , , , =?utf-8?q?Torbj=C3=B6rn_SVENSSON?= Subject: [PATCH] testsuite: Add -fshort-enums to pr33738.C Date: Fri, 16 Aug 2024 14:58:05 +0200 Message-ID: <20240816125804.2978072-1-torbjorn.svensson@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.74.22.255] X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE3.st.com (10.75.129.71) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-16_05,2024-08-16_01,2024-05-17_01 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Ok for trunk and releases/gcc-14? --- For some targets, like Cortex-M on arm-none-eabi, the -fshort-enums is enabled by default. For these targets, the test case fails as sizeof(Alpha) < sizeof(int). To make the test case bahave identical for targets that does enable -fshort-enums and those that does not, force the option in the test case and verify that the warning is emitted. Regtested on x86_64-pc-linux-gnu and arm-none-eabi. gcc/testsuite/ChangeLog: * g++.dg/warn/pr33738.C: Added -fshort-enums and removed xfail. Signed-off-by: Torbjörn SVENSSON --- gcc/testsuite/g++.dg/warn/pr33738.C | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/g++.dg/warn/pr33738.C b/gcc/testsuite/g++.dg/warn/pr33738.C index 73e98d5e083..84bbdaeecc7 100644 --- a/gcc/testsuite/g++.dg/warn/pr33738.C +++ b/gcc/testsuite/g++.dg/warn/pr33738.C @@ -1,5 +1,5 @@ // { dg-do run } -// { dg-options "-O2 -Wtype-limits -fstrict-enums" } +// { dg-options "-O2 -Wtype-limits -fstrict-enums -fshort-enums" } extern void link_error (void); enum Alpha { @@ -15,11 +15,11 @@ int GetM1() { int main() { a2 = static_cast(GetM1()); - if (a2 == -1) { // { dg-warning "always false due" "" { xfail *-*-* } } */ + if (a2 == -1) { // { dg-warning "always false due" } */ link_error (); } a2 = static_cast(GetM1()); - if (-1 == a2) { // { dg-warning "always false due" "" { xfail *-*-* } } */ + if (-1 == a2) { // { dg-warning "always false due" } */ link_error (); } return 0;