From patchwork Wed Jul 31 09:07:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kewen.Lin" X-Patchwork-Id: 1966966 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=HHk3Nnni; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WYmV916ZFz1ybV for ; Wed, 31 Jul 2024 19:08:33 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69124385DC3C for ; Wed, 31 Jul 2024 09:08:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 45F05385B529 for ; Wed, 31 Jul 2024 09:08:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 45F05385B529 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 45F05385B529 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722416884; cv=none; b=eFKkYNaYeRjoM+nntMl9L8sqK8E72d1C257ZLwN5jxjmclqz3HT3gEICTTGgHgck76PmRGWXYaWhFSUlwPxgGB4Q6eh5saiMnsmZiQRmdsSmY4NbI6601oSwhhyCGnnA3bS6oje51n2ugxW4msJ/46iWrdpdCasRfL/tg1rfcU8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722416884; c=relaxed/simple; bh=bbYBoWFJDFrkLS7ibiS5JpuAcO1+65+eenIaT0x3zkk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=tOwvNMQfAjn1wHKy4Nkz2MSIMegsmq4/zKw9a1eqabbKy4wTkkFoust8/Qks8ck4oX49eoQ/qkINYC1Vft16v/rAN717DBvH2GgZbuTIoBK505Hatd2BefnBq/RcOsqSW6FJ4F6FB9qgeMkSO0bWpyHoquAenGLRtYuWrSk8cmk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46V7wVqd007647; Wed, 31 Jul 2024 09:08:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:to:cc:from:subject:content-type :content-transfer-encoding; s=pp1; bh=AtQgGwRAU5V+AcLDrS5YNP1x02 67fGWteEUgWKB/UmA=; b=HHk3NnniL4zm2UXawY2Zj1n6iEekpDOKLBASX8Z2Hi h1FJ+NR0ulvC4ITbvDdAGxHpg6kjTrdnM+P6uvy2BD9xX2h8eONSpYkD/zFZ6v5H l9MURBzYqKOOVCx8e+0ROYhvsi9kYtNdL5KYIHcyun3LxTPaDtThqCCQxse8Vo0n SlVYWMQfZB0UCr8KcE8pcpva+84Jt2bcqYK6E+bcqsqtR/fmHKkNVGX+/LfUVFdk U0uPtCvhX2WRFuUoPBc1UjGPwnxnQ6/4yl0EgjE0fyEMp0rQjMQr5OJG+G3fw9PE xv0IH6z14T3rxsPrsvouDjbrvasRx8HY641rDzlCysHA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40qhbmg63u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jul 2024 09:08:01 +0000 (GMT) Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 46V94Kof025062; Wed, 31 Jul 2024 09:08:01 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 40qhbmg63r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jul 2024 09:08:01 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 46V8o4AA011133; Wed, 31 Jul 2024 09:08:00 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 40ncqmthjp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 31 Jul 2024 09:08:00 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 46V97udM29819198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Jul 2024 09:07:58 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4A3F820040; Wed, 31 Jul 2024 09:07:56 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F3F762004D; Wed, 31 Jul 2024 09:07:54 +0000 (GMT) Received: from [9.200.158.244] (unknown [9.200.158.244]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 31 Jul 2024 09:07:54 +0000 (GMT) Message-ID: <0287f4f8-8389-0fd3-cd0e-8b02275c3e95@linux.ibm.com> Date: Wed, 31 Jul 2024 17:07:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Content-Language: en-US To: GCC Patches Cc: Segher Boessenkool , David Edelsohn , Peter Bergner From: "Kewen.Lin" Subject: [PATCH] testsuite, rs6000: Remove useless powerpc_{altivec,vsx}_ok X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: aRCIwDsJQBHz22d7dXKM7nF0e5RvlkPL X-Proofpoint-GUID: J6jAZSDAtnupHBLREJqh4PkP5Urevy-p X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-31_06,2024-07-30_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=774 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407310066 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TVD_SUBJ_WIPE_DEBT, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Hi, Checking the existing powerpc_{altivec,vsx}_ok test cases, I found there are some test cases which don't require the checks powerpc_{altivec,vsx} even, some of them already have other effective target check which can cover check powerpc_{altivec,vsx}, or some of them don't actually require VSX/AltiVec feature at all. So this patch is to remove such useless checks. Bootstrapped and regtested on powerpc64-linux-gnu P8/P9 and powerpc64le-linux-gnu P9 and P10. I'm going to push this next week if no objections. BR, Kewen ---- PR testsuite/114842 gcc/testsuite/ChangeLog: * gcc.target/powerpc/amo2.c: Remove powerpc_vsx_ok effective target check as p9vector_hw already covers it. * gcc.target/powerpc/p9-sign_extend-runnable.c: Likewise. * gcc.target/powerpc/clone2.c: Remove powerpc_vsx_ok effective target check as ppc_cpu_supports_hw already covers it. * gcc.target/powerpc/pr47251.c: Remove powerpc_vsx_ok effective target check as it doesn't need VSX. * gcc.target/powerpc/pr60137.c: Likewise. * gcc.target/powerpc/pr80098-1.c: Likewise. * gcc.target/powerpc/pr80098-2.c: Likewise. * gcc.target/powerpc/pr80098-3.c: Likewise. * gcc.target/powerpc/sd-pwr6.c: Likewise. * gcc.target/powerpc/pr57744.c: Remove powerpc_vsx_ok effective target check and option -mvsx as it doesn't need VSX. * gcc.target/powerpc/pr69548.c: Remove powerpc_vsx_ok effective target check as it doesn't need VSX, remove lp64 and use int128 instead. * gcc.target/powerpc/vec-cmpne-long.c: Remove powerpc_vsx_ok effective target check as p8vector_hw already covers it. * gcc.target/powerpc/darwin-save-world-1.c: Remove powerpc_altivec_ok effective target check as vmx_hw already covers it. --- gcc/testsuite/gcc.target/powerpc/amo2.c | 1 - gcc/testsuite/gcc.target/powerpc/clone2.c | 1 - gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c | 2 +- gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c | 1 - gcc/testsuite/gcc.target/powerpc/pr47251.c | 1 - gcc/testsuite/gcc.target/powerpc/pr57744.c | 3 +-- gcc/testsuite/gcc.target/powerpc/pr60137.c | 1 - gcc/testsuite/gcc.target/powerpc/pr69548.c | 6 +++--- gcc/testsuite/gcc.target/powerpc/pr80098-1.c | 1 - gcc/testsuite/gcc.target/powerpc/pr80098-2.c | 1 - gcc/testsuite/gcc.target/powerpc/pr80098-3.c | 1 - gcc/testsuite/gcc.target/powerpc/sd-pwr6.c | 1 - gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c | 1 - 13 files changed, 5 insertions(+), 16 deletions(-) -- 2.43.5 diff --git a/gcc/testsuite/gcc.target/powerpc/amo2.c b/gcc/testsuite/gcc.target/powerpc/amo2.c index 9cb493da53e..592f0fb3f92 100644 --- a/gcc/testsuite/gcc.target/powerpc/amo2.c +++ b/gcc/testsuite/gcc.target/powerpc/amo2.c @@ -1,5 +1,4 @@ /* { dg-do run { target { powerpc*-*-linux* && { lp64 && p9vector_hw } } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-O2 -mvsx -mpower9-misc" } */ /* { dg-additional-options "-mdejagnu-cpu=power9" { target { ! has_arch_pwr9 } } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/clone2.c b/gcc/testsuite/gcc.target/powerpc/clone2.c index e64940b7952..4098e878c21 100644 --- a/gcc/testsuite/gcc.target/powerpc/clone2.c +++ b/gcc/testsuite/gcc.target/powerpc/clone2.c @@ -1,6 +1,5 @@ /* { dg-do run { target { powerpc*-*-linux* } } } */ /* { dg-options "-mvsx -O2" } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-require-effective-target ppc_cpu_supports_hw } */ #include diff --git a/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c b/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c index 3326765f4fb..27fc1d30a8b 100644 --- a/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c +++ b/gcc/testsuite/gcc.target/powerpc/darwin-save-world-1.c @@ -1,7 +1,7 @@ /* { dg-do run { target powerpc*-*-* } } */ /* { dg-options "-maltivec" } */ /* { dg-require-effective-target powerpc_altivec } */ -/* { dg-skip-if "need to be able to execute AltiVec" { ! { powerpc_altivec_ok && vmx_hw } } } */ +/* { dg-skip-if "need to be able to execute AltiVec" { ! vmx_hw } } */ /* With altivec turned on, Darwin wants to save the world but we did not mark lr as being saved any more as saving the lr is not needed for saving altivec registers. */ diff --git a/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c b/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c index f0514993bc0..595aa4768cc 100644 --- a/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c +++ b/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c @@ -1,5 +1,4 @@ /* { dg-do run { target { *-*-linux* && { lp64 && p9vector_hw } } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-O2 -mdejagnu-cpu=power9 -mvsx -save-temps" } */ /* These builtins were not defined until ISA 3.1 but only require ISA 3.0 diff --git a/gcc/testsuite/gcc.target/powerpc/pr47251.c b/gcc/testsuite/gcc.target/powerpc/pr47251.c index bb7ea64ff08..b4bcec58398 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr47251.c +++ b/gcc/testsuite/gcc.target/powerpc/pr47251.c @@ -1,6 +1,5 @@ /* { dg-do compile { target { powerpc*-*-* && ilp32 } } } */ /* { dg-skip-if "" { powerpc*-*-darwin* } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-O2 -msoft-float -mdejagnu-cpu=power7" } */ /* PR 47151: libgcc fails to build when using --with-cpu=power7 due to a missed diff --git a/gcc/testsuite/gcc.target/powerpc/pr57744.c b/gcc/testsuite/gcc.target/powerpc/pr57744.c index 9e51dc7fb9c..73f524580ac 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr57744.c +++ b/gcc/testsuite/gcc.target/powerpc/pr57744.c @@ -1,7 +1,6 @@ /* { dg-do run { target { powerpc*-*-* && lp64 } } } */ /* { dg-skip-if "" { powerpc*-*-darwin* } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ -/* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3" } */ +/* { dg-options "-mdejagnu-cpu=power8 -O3" } */ void abort (void); diff --git a/gcc/testsuite/gcc.target/powerpc/pr60137.c b/gcc/testsuite/gcc.target/powerpc/pr60137.c index 1b1b69aab39..d91079f608b 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr60137.c +++ b/gcc/testsuite/gcc.target/powerpc/pr60137.c @@ -1,6 +1,5 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ /* { dg-skip-if "" { powerpc*-*-darwin* } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3 -mno-vsx" } */ /* target/60137, compiler got a 'could not split insn error'. */ diff --git a/gcc/testsuite/gcc.target/powerpc/pr69548.c b/gcc/testsuite/gcc.target/powerpc/pr69548.c index 259d8d287c0..287b38ffabb 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr69548.c +++ b/gcc/testsuite/gcc.target/powerpc/pr69548.c @@ -1,7 +1,7 @@ -/* { dg-do assemble { target { powerpc*-*-* && lp64 } } } */ +/* { dg-do assemble } */ /* { dg-skip-if "" { powerpc*-*-darwin* } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ -/* { dg-options "-mdejagnu-cpu=power8 -mvsx -Os -mbig" } */ +/* { dg-require-effective-target int128 } */ +/* { dg-options "-mdejagnu-cpu=power8 -Os -mbig" } */ __int128 quad_exchange (__int128 *ptr, __int128 newval) diff --git a/gcc/testsuite/gcc.target/powerpc/pr80098-1.c b/gcc/testsuite/gcc.target/powerpc/pr80098-1.c index f22c8d93fb4..f7f3dfdcb3c 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr80098-1.c +++ b/gcc/testsuite/gcc.target/powerpc/pr80098-1.c @@ -1,5 +1,4 @@ /* { dg-do compile { target { powerpc64*-*-* } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-mdejagnu-cpu=power9 -mno-vsx -mpower9-minmax" } */ int i; diff --git a/gcc/testsuite/gcc.target/powerpc/pr80098-2.c b/gcc/testsuite/gcc.target/powerpc/pr80098-2.c index 964b849111b..c42200e6d3c 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr80098-2.c +++ b/gcc/testsuite/gcc.target/powerpc/pr80098-2.c @@ -1,5 +1,4 @@ /* { dg-do compile { target { powerpc64*-*-* } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-mdejagnu-cpu=power8 -mno-vsx -mcrypto" } */ int i; diff --git a/gcc/testsuite/gcc.target/powerpc/pr80098-3.c b/gcc/testsuite/gcc.target/powerpc/pr80098-3.c index 5dcae1a8b7c..d8023c0707f 100644 --- a/gcc/testsuite/gcc.target/powerpc/pr80098-3.c +++ b/gcc/testsuite/gcc.target/powerpc/pr80098-3.c @@ -1,5 +1,4 @@ /* { dg-do compile { target { powerpc64*-*-* } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-mdejagnu-cpu=power7 -mno-vsx -mcrypto" } */ int i; diff --git a/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c b/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c index 55b32a9115e..e2775fcb530 100644 --- a/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c +++ b/gcc/testsuite/gcc.target/powerpc/sd-pwr6.c @@ -1,6 +1,5 @@ /* { dg-do compile { target { powerpc*-*-* } } } */ /* { dg-skip-if "" { powerpc*-*-darwin* powerpc-ibm-aix* } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-require-effective-target dfp } */ /* { dg-options "-O2 -mdejagnu-cpu=power6 -mhard-dfp" } */ /* { dg-final { scan-assembler-not "lfiwzx" } } */ diff --git a/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c b/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c index 7086156bef8..9ccf1b544d0 100644 --- a/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c +++ b/gcc/testsuite/gcc.target/powerpc/vec-cmpne-long.c @@ -1,5 +1,4 @@ /* { dg-do run { target { powerpc64*-*-* && { p8vector_hw } } } } */ -/* { dg-require-effective-target powerpc_vsx_ok } */ /* { dg-options "-mdejagnu-cpu=power8 -mvsx -O3" } */ /* Test that the vec_cmpne builtin works as expected for long long