From patchwork Mon Jul 29 08:55:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hubicka X-Patchwork-Id: 1965904 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=ucw.cz header.i=@ucw.cz header.a=rsa-sha256 header.s=gen1 header.b=RsPc1Y62; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WXXKN6sPzz1yf4 for ; Mon, 29 Jul 2024 18:56:40 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4071D3858C60 for ; Mon, 29 Jul 2024 08:56:39 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id E11E33858C35 for ; Mon, 29 Jul 2024 08:55:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E11E33858C35 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kam.mff.cuni.cz ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E11E33858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722243355; cv=none; b=SKO7E03Tc38zlZOArexb/g+HtzM5xOStpR0XPJtoEjRDrdSAVtAQz3qzVJ+IgbBm4qHVhnYI3U3GwuJYB+hvgUcOWxatyLjDrdyUE7sOXA0Fyfi0/7bzGy+lyNWMrs5H4Ctu6C/wlvsPOoLF1pK9AE4krR1f6OYoJFGo+QQ74gE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1722243355; c=relaxed/simple; bh=yf7iX0dkW9oLDqlfubIawJmgrqGxxnXzY7vF8a6lkXM=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Yyu6oai625JCXwKcSJzmkEsuILuCpPSf7kUwhPZ/s7sY/sZVKy5ogDQfJPypYOV3Ux6vsQCOqemiYqk991aQWAlyv7Hk1PrR7+IlHn+zUze0jLelTdno1mOfSmdNdOFdYNe+LDXErdCvsyT3qCSqnjNItCD2jC9EtPlI6+aUBtA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 35F2A28793C; Mon, 29 Jul 2024 10:55:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1722243350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=O+rjRG/LOQhrll3133zaeIuTvlEZY1vV/IopQyl8qQI=; b=RsPc1Y62T8MZbWQiGTgwSvWK59YrG7sUBYFsWw4a6PmXumHMAAsANoWUkt02VJ7syYGMIl m6QyK6wSDKg+PFroGxiCRIQubb4b/pK46/6IS5csdavtDvpPF+Tok1/5QSG4wl7FcLi5AV /knKsGdJCmkfSMQ7AhnUUheQ6RWQqQ0= Date: Mon, 29 Jul 2024 10:55:50 +0200 From: Jan Hubicka To: gcc-patches@gcc.gnu.org Subject: Fix ICE with -fdump-tree-moref Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Hi, this patch fixes sanity check in modref dumping which is no longer correct now when we give up on parameters being readonly after store merging. Bootstrapped/regtested x86_64-linux, comitted. gcc/ChangeLog: PR ipa/116055 * ipa-modref.cc (analyze_function): Do not ICE when flags regress. diff --git a/gcc/ipa-modref.cc b/gcc/ipa-modref.cc index f6a758b5f42..59cfe91f987 100644 --- a/gcc/ipa-modref.cc +++ b/gcc/ipa-modref.cc @@ -3297,7 +3297,8 @@ analyze_function (bool ipa) fprintf (dump_file, " Flags for param %i improved:", (int)i); else - gcc_unreachable (); + fprintf (dump_file, " Flags for param %i changed:", + (int)i); dump_eaf_flags (dump_file, old_flags, false); fprintf (dump_file, " -> "); dump_eaf_flags (dump_file, new_flags, true); @@ -3313,7 +3314,7 @@ analyze_function (bool ipa) || (summary->retslot_flags & EAF_UNUSED)) fprintf (dump_file, " Flags for retslot improved:"); else - gcc_unreachable (); + fprintf (dump_file, " Flags for retslot changed:"); dump_eaf_flags (dump_file, past_retslot_flags, false); fprintf (dump_file, " -> "); dump_eaf_flags (dump_file, summary->retslot_flags, true); @@ -3328,7 +3329,7 @@ analyze_function (bool ipa) || (summary->static_chain_flags & EAF_UNUSED)) fprintf (dump_file, " Flags for static chain improved:"); else - gcc_unreachable (); + fprintf (dump_file, " Flags for static chain changed:"); dump_eaf_flags (dump_file, past_static_chain_flags, false); fprintf (dump_file, " -> "); dump_eaf_flags (dump_file, summary->static_chain_flags, true);