From patchwork Fri Jul 26 12:05:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 1965286 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Xsu1nc/g; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=sourceware.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WVmfq2jxRz1yY5 for ; Fri, 26 Jul 2024 22:05:39 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89C56382DB20 for ; Fri, 26 Jul 2024 12:05:37 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by sourceware.org (Postfix) with ESMTPS id 6CA82382E69B for ; Fri, 26 Jul 2024 12:05:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CA82382E69B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CA82382E69B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721995518; cv=none; b=fz9VWUvxNeFP/zmEU2wwDihypmLzHSijLlr87730w+FdXbeD8jOF3krzKZpff0iRz2/Wh9Zy6dVrYZP+cy2pqTk7hh8KcP0e21x1ufkUgptr3FH/cmFc0ckgBQZk8oAvVHg2fMErGyLbMXBjLNGTM6e/jndKIbPe4czFk+TYzBY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721995518; c=relaxed/simple; bh=/MEWTviL0yRBB0te7S2e7wkD0pyg5/fSOmHm1eixUOg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=aD6y2HvsycUaiSF6ZotZ2TsP+hEamwkq96Xrk4EoH1ex949faqxWaqPDF1whR/FPZS3KZ/2OmQj5Jhr7PzCapRWUz/KuxyKYgMabWySyPrWdqX9vajnC5BwiJXdA7sFjADraADXYqj1XqgrEu6Qx0nfljcQz71awnQ9ORAjEplA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-6b7a0ef0dfcso3220226d6.1 for ; Fri, 26 Jul 2024 05:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721995514; x=1722600314; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aECBwq2+664PkTaXki3ymmX7kd94SFzFJ4sHFeg98GU=; b=Xsu1nc/gquXWivGMj9mrmfYIc49NKw4bJ0/92Iy/jiBc3+Br64zruRvXh9uudGgLKq 2AzM5nQDDEiXh45dnVdBLmWiXNPR6G/qlqmq3f6fQmD4QJHc0JcoYxD4iFqCUFy/AoL3 oLJMaYm87hKgK21fTUFhktByPrLZniDMpt7c86Iv+ZYHdKIJ2r7oEji2MPSIxiCODhcI +uxfqrA8pZFl165wk03Jf4znqbUtS8yqt8sR3yTgDu8a3DIxNXLlHQTmSrytNKgmfLK2 WH7fWfSTs2VkhV0fefjYCZRmOZgmuCnDoPepno2m8whqdr1KHyvEKqUnAPQGXoaiULtX g3cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721995514; x=1722600314; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aECBwq2+664PkTaXki3ymmX7kd94SFzFJ4sHFeg98GU=; b=gkBeQNDDwpEDcEuwRmsKBymo5EeWQ7EQ9Q4/nowDoPXq7883QVSJprXzoYU/j3mYdC 3prUyDWTCDG0Ek/4vZF00lZ9OeJMQ+GcB0gJrF8HS9y4Rp0LRYNkZ5WqALWPJQcp28GW hISDofWQxNRrNIpXbUFSDwdMSNxxdWFPhJJ35fxrkxWyjjKBt9oaGHSpUKnWCIHwBAoR fXIXXWzCB5SACxag68G4zOI4/LmcwqcZMSDVCpPYEDiXZ9WNcqPOxr5b7ObOsG0SYuyo mwfBfIQhNaZ8nYD63+yAYqk9nz5Rx/Y7wjig1Z84T24W0TZOOvxi1ytAlTVz2C7JSX5M tSMA== X-Gm-Message-State: AOJu0YzsGVBDAD7kfiHjb6FBey8+XuUba8e6mZdt6g9ik+EQtX53ZZ5y drSOOr+cv2ilBoMT8kjJmTctmn7gnq3cAULy/izfqVqMJoiV7lZ4pW9LLqmF5cQ= X-Google-Smtp-Source: AGHT+IGGlu3iXysY/DTvvsCpJU4yJXuxd6mwXywnIBT+/BB2+3iNAFzN3kn2ZCU1EHtN2cH7ZJNDgg== X-Received: by 2002:a05:6214:1255:b0:6b7:944f:3cef with SMTP id 6a1803df08f44-6bb3cacd7e7mr70229196d6.44.1721995514393; Fri, 26 Jul 2024 05:05:14 -0700 (PDT) Received: from noahgold-desk.sh.intel.com ([192.102.204.43]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6bb3f8d82acsm15870356d6.22.2024.07.26.05.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jul 2024 05:05:14 -0700 (PDT) From: Noah Goldstein To: libc-alpha@sourceware.org Cc: goldstein.w.n@gmail.com, hjl.tools@gmail.com, carlos@systemhalted.org Subject: assert: Mark `__assert_fail` as `cold` Date: Fri, 26 Jul 2024 20:05:02 +0800 Message-Id: <20240726120502.3230804-1-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240726084100.2582635-1-goldstein.w.n@gmail.com> References: <20240726084100.2582635-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~incoming=patchwork.ozlabs.org@sourceware.org This helps compilers split the codegen for setting up the arguments (`__expression`, `__filename`, etc...) from the potentially hot cold where the `assert` is to a presumably cold region on the assertion failure path. --- assert/assert.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/assert/assert.h b/assert/assert.h index 266a41df06..14d3be9cac 100644 --- a/assert/assert.h +++ b/assert/assert.h @@ -66,18 +66,18 @@ __BEGIN_DECLS /* This prints an "Assertion failed" message and aborts. */ extern void __assert_fail (const char *__assertion, const char *__file, unsigned int __line, const char *__function) - __THROW __attribute__ ((__noreturn__)); + __THROW __attribute__ ((__noreturn__)) __COLD; /* Likewise, but prints the error text for ERRNUM. */ extern void __assert_perror_fail (int __errnum, const char *__file, unsigned int __line, const char *__function) - __THROW __attribute__ ((__noreturn__)); + __THROW __attribute__ ((__noreturn__)) __COLD; /* The following is not at all used here but needed for standard compliance. */ extern void __assert (const char *__assertion, const char *__file, int __line) - __THROW __attribute__ ((__noreturn__)); + __THROW __attribute__ ((__noreturn__)) __COLD; __END_DECLS