From patchwork Thu Jul 25 10:44:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1964694 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kqXOv4jA; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=awEbAebT; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kqXOv4jA; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=awEbAebT; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WV6w14yjtz1yXp for ; Thu, 25 Jul 2024 20:44:49 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 82393385840B for ; Thu, 25 Jul 2024 10:44:47 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 9C2583858D29 for ; Thu, 25 Jul 2024 10:44:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C2583858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9C2583858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721904266; cv=none; b=Hks1YhtcAQNS7rfAU9a4zAc1OLs15FriwO4hoG73CKDQuaZnK3Cnh1KuD7DOWt0Gm3mQaXCrFVPpzL60OVfn1eit5ORYRzf9yMNmY0Vc4d2EuUMOfCVgdksjYOm1JPZy9wqNYB9nOenPJqunIoZ1J2jmuyzW01jX8c/Sbik6pd4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721904266; c=relaxed/simple; bh=alH4yYIqKxFIhoY5+VvhNobVGKfIpriL9Db/K7lfC7U=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=kqit0ulwfqeSaaIyjSsC0JplB3kEGbJg9hBeJMpg/RrPfKm1ouOtJUyd3/oVV9ylSB9dLM/T8ryyp6Hz/T/236fkAk0bhbuh1LP+dXe9zFmO9lZstOC0xU5CTBR423X5hZIOn6uMNynqkkt2/l4nuRHgBjNDRFI8QTt4aI/SjAs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7E7CB21B00 for ; Thu, 25 Jul 2024 10:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721904261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IhzfedsRyFHutTjsQY8oTeRq7JIDrvQ2luNz0DFJuzg=; b=kqXOv4jAL1s2Jcf4kQcsYBx4fZ8kKH0CfDVd2SvQBSQXQxVUtv4TCIADvnsjoLseF5BAVF 7DlC5WO0wt3QRY0OUTOtS36S+5a3l8Urb2lKorM7TmThygoA8f2SRMAZDsCArIPbL4YpFY wvTi1Lf0bE+Iv6eYozOobfzroff7z6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721904261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IhzfedsRyFHutTjsQY8oTeRq7JIDrvQ2luNz0DFJuzg=; b=awEbAebT3zGTBDBJ0+HPeXtO0G/RuFvZn2BNjefg40q5nTTe17++XqqKZYsijzFIqrVbuv kid5/F4QvgI7GkBQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=kqXOv4jA; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=awEbAebT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1721904261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IhzfedsRyFHutTjsQY8oTeRq7JIDrvQ2luNz0DFJuzg=; b=kqXOv4jAL1s2Jcf4kQcsYBx4fZ8kKH0CfDVd2SvQBSQXQxVUtv4TCIADvnsjoLseF5BAVF 7DlC5WO0wt3QRY0OUTOtS36S+5a3l8Urb2lKorM7TmThygoA8f2SRMAZDsCArIPbL4YpFY wvTi1Lf0bE+Iv6eYozOobfzroff7z6E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1721904261; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IhzfedsRyFHutTjsQY8oTeRq7JIDrvQ2luNz0DFJuzg=; b=awEbAebT3zGTBDBJ0+HPeXtO0G/RuFvZn2BNjefg40q5nTTe17++XqqKZYsijzFIqrVbuv kid5/F4QvgI7GkBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 64DA813874 for ; Thu, 25 Jul 2024 10:44:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id WODwFoUsoma2TgAAD6G6ig (envelope-from ) for ; Thu, 25 Jul 2024 10:44:21 +0000 Date: Thu, 25 Jul 2024 12:44:12 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/116081 - typedef vs. non-typedef in vectorization MIME-Version: 1.0 Message-Id: <20240725104421.64DA813874@imap1.dmz-prg2.suse.org> X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-1.31 / 50.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MISSING_XM_UA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Spam-Score: -1.31 X-Rspamd-Queue-Id: 7E7CB21B00 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org The following addresses a behavioral difference in vector type analysis for typedef vs. non-typedef. It doesn't fix the issue at hand but avoids a spurious difference in the dumps. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/116081 * tree-vect-stmts.cc (vect_get_vector_types_for_stmt): Properly compare types. --- gcc/tree-vect-stmts.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index a47482375c1..aa98599c1f5 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -14905,7 +14905,7 @@ vect_get_vector_types_for_stmt (vec_info *vinfo, stmt_vec_info stmt_info, vector size per vectorization). */ scalar_type = vect_get_smallest_scalar_type (stmt_info, TREE_TYPE (vectype)); - if (scalar_type != TREE_TYPE (vectype)) + if (!types_compatible_p (scalar_type, TREE_TYPE (vectype))) { if (dump_enabled_p ()) dump_printf_loc (MSG_NOTE, vect_location,