From patchwork Thu Jul 25 01:56:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Pinski X-Patchwork-Id: 1964580 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=QCmvS5gI; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WTvCl49hVz1yXp for ; Thu, 25 Jul 2024 11:57:39 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A5B933858C3A for ; Thu, 25 Jul 2024 01:57:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by sourceware.org (Postfix) with ESMTPS id F0EDF3858C48; Thu, 25 Jul 2024 01:57:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F0EDF3858C48 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=quicinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F0EDF3858C48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721872636; cv=none; b=qX3aoQtuFJ+gC2Ivt/i9QWi31WvSew8bePomSYxKfs/Szj0a1xFrVys9OpHDYaNqjfbklI8XqPq+3ZqTBXpPRwXjtJpXmEaA9dsQ8qbCdVvoEl5mr10zus7Q9r/1IwO9OCHBenIIrNSnFtfy/rzc0Lnd+bufrRN2xM/8Dqlvlq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721872636; c=relaxed/simple; bh=TW+34Q1pu9GJbDP54kUlqGX/PrPHVhd/CJz3xZnQFCE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WJ6n9nlqyS9tzDzTAnKODAurKbYz60ih1HSUfBseOwMbYGWkPY7AnyV+o7TJYPWOLTSCN9TlAXIzeypEXH7i80suf+zKYtWCKxl52mkB1b1h3jBHOUoVlo5iINwfDEtrYj2X19cWYqFQszTEt+A2+YG9FSXEcCrX5DGo2pNCgjI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 46OFA394014889; Thu, 25 Jul 2024 01:57:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=6x3y7myPnyGbunghnIGwLe rZjH8oOXIcYyxWZofJkfw=; b=QCmvS5gIPy0Cb5yAiHBNGIiT4DMRxlLJ04U/iK bzypvJwI45A+fCh4EtNOxtgjytjyeA2CUMZxSeOxMvYBTtlFj4ZqTXzoGIoURotO MhjF5+HN2PYLoUuiQl91zLebmJA28bcI0q8xETmnBVwTJNJTRBA9t4MZgYs2OnWI r8SKVUgoJHIovddznQGWTvelxzvgThr2/rauoh0rFMpjv2ivNmQ34pcBND3jNSla 0RhBZsYTLW9TnbJU32A0otypBoF9gzVMa/ttcqjGAbP4p5daCbUyv39pJteAmrNL BrwPJTrzCdOx4lmt0aZ8Uk+NI9/1AXq2FxTDuiCPvSaM0diw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40k40yh5hx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2024 01:57:13 +0000 (GMT) Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 46P1vCeP005703 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 25 Jul 2024 01:57:12 GMT Received: from hu-apinski-lv.qualcomm.com (10.49.16.6) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 24 Jul 2024 18:57:12 -0700 From: Andrew Pinski To: CC: , Andrew Pinski Subject: [PATCH] libstdc++: Fix testsuite for remote testing (and sim) Date: Wed, 24 Jul 2024 18:56:40 -0700 Message-ID: <20240725015640.3647102-1-quic_apinski@quicinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.49.16.6] X-ClientProxiedBy: nalasex01c.na.qualcomm.com (10.47.97.35) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: PGjJ01Vs1qH79EOD4ZEfab48RD4updYp X-Proofpoint-ORIG-GUID: PGjJ01Vs1qH79EOD4ZEfab48RD4updYp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-24_27,2024-07-24_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 mlxlogscore=999 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2407110000 definitions=main-2407250011 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org The problem here is that v3_additional_files will have a space at the begining of the string as dg-additional-files will append `" " $files` to it. Then when split is called on that string, there will be an empty file and copying a dir will just fail for remote/sim testing (I didn't look at why it works for native testing though). Ran a full libstdc++ testsuite using a sim board for testing. libstdc++-v3/ChangeLog: * testsuite/lib/libstdc++.exp (v3_target_compile): Call string trim on v3_target_compile before calling split. Signed-off-by: Andrew Pinski --- libstdc++-v3/testsuite/lib/libstdc++.exp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp index 4bf88e72d05..c11e752ecfb 100644 --- a/libstdc++-v3/testsuite/lib/libstdc++.exp +++ b/libstdc++-v3/testsuite/lib/libstdc++.exp @@ -639,7 +639,8 @@ proc v3_target_compile { source dest type options } { lappend options "timeout=[timeout_value]" global v3_additional_files - foreach file [split $v3_additional_files " "] { + # There will be an empty file at the begining of the list so trim it off. + foreach file [split [string trim $v3_additional_files] " "] { global srcdir v3-copy-file "$srcdir/data/$file" $file }