From patchwork Wed Jul 17 05:50:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve French X-Patchwork-Id: 1961410 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=nbKTbz91; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=linux-cifs+bounces-2317-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WP4mg1JMGz20B2 for ; Wed, 17 Jul 2024 15:50:59 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DB9921C20F08 for ; Wed, 17 Jul 2024 05:50:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B7CD2B64C; Wed, 17 Jul 2024 05:50:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nbKTbz91" X-Original-To: linux-cifs@vger.kernel.org Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053062C9A for ; Wed, 17 Jul 2024 05:50:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721195452; cv=none; b=MZzzJfa0XbxSfKxIYKfK0OD9vKyF1gfeMzvow+Zbo6QJobmIXrZey0njSYwecPlJxGHUPXu9VfIX7Nilg3i/PT/FHtl1gdIBNOMpIb2XS7+L+pFXMjkmQvTIUFoHphj5dtTEcwMCgkxqlKuvagPUfhG1tuINHRLs67Sf9ZF07hE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721195452; c=relaxed/simple; bh=W/D+jJmCSwuSX9SfaTomxuiWVuFCohxPJ6ezCDHoaUg=; h=MIME-Version:From:Date:Message-ID:Subject:To:Cc:Content-Type; b=qvCYZq92guwAVkdfyXUyfgNg8QWQQzJRREePMOUtXNJ7LAWGn9Zs5zGT35vrWbs6OcYZxHzvAjQQCo+Oue1jUc6YS20IRsZDm5+meeat6hbCWKjuzPJlrLUo64Nm5IcLFa0XtTPa+5QYFKmvCUTqlfkJRgD7DhwZ+7//ErtAAZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nbKTbz91; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52e9c55febcso8297660e87.2 for ; Tue, 16 Jul 2024 22:50:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721195449; x=1721800249; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=e5+fpx10z9O3WcsMVXb5CUAhch/EF91R0lvtjEgsWko=; b=nbKTbz91aRztSZbdw+bhAyddzaPQdU+GxdoaBaO5kWZswX6/QcMf3bMVWTA6fZldkZ iSgPtgRBUzjvwL1u/nZDdLFZPyaeTQmRLhT+AncGnjPGW52aPntvkb6s3DM1LvMlVRVm zFaS30+3esnii88g+fl8dW4SgOqb+xlHjRn2Nmz5fpKk9S/ZtQlUCmr2OvdLRSMSXzpK jjcjDYGo0LadnPw6XaPXRcH+CHIjfAH1FA5klaIhg6HTlRBgvgoAWiGisKNf2gswbvxq xZPZ1KelR0ooMhuPRGoRtncw2BuVgm3cbKcwu0ZYUnFfBbAmAB28C7KsH2dTh8b0u6l1 liKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721195449; x=1721800249; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=e5+fpx10z9O3WcsMVXb5CUAhch/EF91R0lvtjEgsWko=; b=XWZGUpW5hgKaLyiUjttieUBietyCcQ3x8Ap6pjYCMbZzrZle/Ir1GhsLX5CR9VzR7q alBXfKWxrIMwgnbEUPjtxj+54o06oYH6PEucWfD8wIPw7b5MYT6GsEH2PEI4onJF4k61 vYKAE9+YnJnBrCJDzPwvUfQi+7WfGd5N/FNY56s7ow5i0LbR2sJppCbB3+hUZB+w9DCM MCvdAzo/z+nwDUCBxtjKCcS5KAJpkvAQcGlZHAm5czV33EEacZ8FOgSVTFAqtU+lS1d+ 7efLvAYPM+sq68hsUkhKs7PBruax7DyCfwG00n2jPQMdgaj7SC8pvfl5CghoFafCSiX5 u79Q== X-Gm-Message-State: AOJu0Yyo9SayPPux/TguPU/Z90FOrAtLHQ8h3r7LnQwAsT/BSBvvOz6w qamMiEvZROk3eqAPRxtkodg0elPjC41Fonkhf59AijV93C7+SNHHPQK1hAPLrB+PZlLgum2Uipn b0F8Kc4JJ9fsUiXsH0DRWHtAEAD+RCuZC X-Google-Smtp-Source: AGHT+IGAKHFTdNeB4FFqzQPGf2mvavDQr1uQgndW6blQSK8mcsGC7ggkjKUts5nxY1fkQ/O2Nyzgrk9wlaC9jhvAdr8= X-Received: by 2002:a05:6512:234f:b0:52e:9382:a36 with SMTP id 2adb3069b0e04-52ee53d694amr414423e87.30.1721195448410; Tue, 16 Jul 2024 22:50:48 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-cifs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Steve French Date: Wed, 17 Jul 2024 00:50:36 -0500 Message-ID: Subject: [PATCH][SMB3] fix noisy error message logged on cross share copy_file_range To: CIFS Cc: Shyam Prasad N , Bharath S M There are common cases where copy_file_range can noisily log "source and target of copy not on same server" e.g. the mv command across mounts to two different server's shares. Change this to informational rather than logging as an error. A followon patch will add dynamic trace points e.g. for cifs_file_copychunk_range From bb367fbd3f01935bb7c754c411424d1dc49772fd Mon Sep 17 00:00:00 2001 From: Steve French Date: Wed, 17 Jul 2024 00:42:22 -0500 Subject: [PATCH] cifs: fix noisy message on copy_file_range There are common cases where copy_file_range can noisily log "source and target of copy not on same server" e.g. the mv command across mounts to two different server's shares. Change this to informational rather than logging as an error. A followon patch will add dynamic trace points e.g. for cifs_file_copychunk_range Cc: stable@vger.kernel.org Signed-off-by: Steve French --- fs/smb/client/cifsfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c index 6397fdefd876..c92937bed133 100644 --- a/fs/smb/client/cifsfs.c +++ b/fs/smb/client/cifsfs.c @@ -1359,7 +1359,7 @@ ssize_t cifs_file_copychunk_range(unsigned int xid, target_tcon = tlink_tcon(smb_file_target->tlink); if (src_tcon->ses != target_tcon->ses) { - cifs_dbg(VFS, "source and target of copy not on same server\n"); + cifs_dbg(FYI, "source and target of copy not on same server\n"); goto out; } -- 2.43.0