From patchwork Tue Jul 16 11:18:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christoph_M=C3=BCllner?= X-Patchwork-Id: 1961020 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=vrull.eu header.i=@vrull.eu header.a=rsa-sha256 header.s=google header.b=e/mNL7xN; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WNc5X5ycsz1xqc for ; Tue, 16 Jul 2024 21:18:56 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 71DA3384A49E for ; Tue, 16 Jul 2024 11:18:54 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 77D673860C2B for ; Tue, 16 Jul 2024 11:18:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 77D673860C2B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 77D673860C2B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721128706; cv=none; b=kNzn14DIsBPjoneMwS7Opwvq4k1Gbzh//ubdKVEdoSz0wiyJj1SP4Ta8w+Gpid57hojjBCCl7lGffJkO9g6LOVSOv6KI1qpxn6cWeEd8UZdz+AGsMgWDv5hNtrGZUWVO/13KQragdnNpbsBTwE1vwqtOlB+nvKBqIls2LkLYg0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1721128706; c=relaxed/simple; bh=/cJ/UqN5eMhpK8xhOLnUbXHR46psENaa+QNcAmnsTvU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bS61WKVg5VlN2oL3cURNuH2MtxzVFpMQ2VCMo0mUX2ACX1cJ2EVNCBonuV4xNBQ5QTVWLRoFAvSZCBhF927QQVJ6cN+ooOlAxtApgsUjTCocJxIvwpxOcx4hXnK6VYrM9c0bkN/7kCu2r6zJLZNbw4ZzGrwWfHCT83Lo4zV2iAY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a77b550128dso671006366b.0 for ; Tue, 16 Jul 2024 04:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1721128699; x=1721733499; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EcnN8AlKe7ItbA7J2mXvm3RRimKxKEn1NAS5pyXC+8U=; b=e/mNL7xNQScFzx1BZi1pjncBF4D3w/cvve6Po6Kg5jxf7dMBw38nMVVXiByxyJwJ3P 2nrBIh7zNxAWeQ+xpZRSc9YfwQm5Uq35s6PWu2tvYE6x8zLiP3ys65g66chFTUJsPo0O szXK544OYO97hFKhispPsc2Y8wdsunbfGj5ewLLbjlCWvb9foS0ZmdagvTAMvSN5KIhx zCx+Qr1ba4u+S8Xz7rulcVaZJ4V86q/6IpWSx/GM61dfjfxku0IOZlKuuWGBYP5cz6It Qt8ztj2Df7YDt7F751FneT6Kw4GN2rEtq3CIPPT/QOJEenaodVckmTL6zNo/jNlOJxSz ni+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721128699; x=1721733499; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EcnN8AlKe7ItbA7J2mXvm3RRimKxKEn1NAS5pyXC+8U=; b=bx6mKbp+TRBdEkTWIjAgLaG2FG8fB/PaNHMZejamctmvkrLBmNkyd7qmys8QIGPO5V uhxr9G0HFHoNLp1sePS+3ykiZ00lA9bbJ7MFnA6em6osTdsYjWR+Hainp4kBDEiE9lsc OogppcIofEuHIz9ugtWvzNCqzW4vtQBT0Auv+bmZNa9Sc2ApJp0xzKk8Q5Oo8atQRNgA COlT1gChvS09uUx+JBJWXzrpznDTBx8Zwie5hrP2wjqfwBX6bLyT+rIO006a+Pp4AJ3l v5AvlwNdZXgqErDB1P8iQaPb8L0NK03wmvYiipGuscfpVeTbCw5bN+lIk0zEtoK9Pb9z LP/A== X-Gm-Message-State: AOJu0Yw26jVbjFqbsvx397Y2BO1W8FVLSFc5pdn/s/AZzkNzt22Kdp3E pixvYqHgBLPoGrRlUhwW45Zryx/l2iierFDRuyz5voyy5s7qE9RRX92jgRbcdFKhMjMtiVK6q/k pYKk= X-Google-Smtp-Source: AGHT+IGZe81l4zBvZjdeJSg8IiXXOj1g3mhB+EiBUC+PcY6iVBSAD8HpzrJXU07xk5VdHoolzrB7Gg== X-Received: by 2002:a17:906:2b0c:b0:a6f:b29f:8304 with SMTP id a640c23a62f3a-a79ea4389e0mr123324066b.29.1721128699556; Tue, 16 Jul 2024 04:18:19 -0700 (PDT) Received: from antares.fritz.box (62-178-148-172.cable.dynamic.surfer.at. [62.178.148.172]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a79bc820dfbsm297952166b.211.2024.07.16.04.18.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 04:18:19 -0700 (PDT) From: =?utf-8?q?Christoph_M=C3=BCllner?= To: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , Palmer Dabbelt , Andrew Waterman , Philipp Tomsich , Jeff Law , Vineet Gupta , Pan Li , Patrick O'Neill Cc: =?utf-8?q?Christoph_M=C3=BCllner?= Subject: [committed][GCC-14] RISC-V: testsuite: Properly gate LTO tests Date: Tue, 16 Jul 2024 13:18:10 +0200 Message-ID: <20240716111815.129028-1-christoph.muellner@vrull.eu> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_MANYTO, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org There are two test cases with the following skip directive: dg-skip-if "" { *-*-* } { "-flto -fno-fat-lto-objects" } This reads as: skip if both '-flto' and '-fno-fat-lto-objects' are present. This is not the case if only '-flto' is present. Since both tests depend on instruction sequences (one does check-function-bodies the other tests for an assembler error message), they won't work reliably with fat LTO objects. Let's change the skip line to gate the test on '-flto' to avoid failing tests like this: FAIL: gcc.target/riscv/interrupt-misaligned.c -O2 -flto check-function-bodies interrupt FAIL: gcc.target/riscv/interrupt-misaligned.c -O2 -flto -flto-partition=none check-function-bodies interrupt FAIL: gcc.target/riscv/pr93202.c -O2 -flto (test for errors, line 10) FAIL: gcc.target/riscv/pr93202.c -O2 -flto (test for errors, line 9) FAIL: gcc.target/riscv/pr93202.c -O2 -flto -flto-partition=none (test for errors, line 10) FAIL: gcc.target/riscv/pr93202.c -O2 -flto -flto-partition=none (test for errors, line 9) gcc/testsuite/ChangeLog: * gcc.target/riscv/interrupt-misaligned.c: Remove "-fno-fat-lto-objects" from skip condition. * gcc.target/riscv/pr93202.c: Likewise. (cherry picked from commit 0717d50fc4ff983b79093bdef43b04e4584cc3cd) Signed-off-by: Christoph Müllner --- gcc/testsuite/gcc.target/riscv/interrupt-misaligned.c | 2 +- gcc/testsuite/gcc.target/riscv/pr93202.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gcc.target/riscv/interrupt-misaligned.c b/gcc/testsuite/gcc.target/riscv/interrupt-misaligned.c index b5f8e6c2bbe..912f180e4d6 100644 --- a/gcc/testsuite/gcc.target/riscv/interrupt-misaligned.c +++ b/gcc/testsuite/gcc.target/riscv/interrupt-misaligned.c @@ -1,6 +1,6 @@ /* { dg-do compile } */ /* { dg-options "-O2 -march=rv64gc -mabi=lp64d -fno-schedule-insns -fno-schedule-insns2" } */ -/* { dg-skip-if "" { *-*-* } { "-flto -fno-fat-lto-objects" } } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ /* Make sure no stack offset are misaligned. ** interrupt: diff --git a/gcc/testsuite/gcc.target/riscv/pr93202.c b/gcc/testsuite/gcc.target/riscv/pr93202.c index 5501191ea52..5de003fac42 100644 --- a/gcc/testsuite/gcc.target/riscv/pr93202.c +++ b/gcc/testsuite/gcc.target/riscv/pr93202.c @@ -1,7 +1,7 @@ /* PR inline-asm/93202 */ /* { dg-do compile { target fpic } } */ /* { dg-options "-fpic" } */ -/* { dg-skip-if "" { *-*-* } { "-flto -fno-fat-lto-objects" } } */ +/* { dg-skip-if "" { *-*-* } { "-flto" } } */ void foo (void)