From patchwork Fri Jul 12 01:00:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Lance Taylor X-Patchwork-Id: 1959633 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=golang-org.20230601.gappssmtp.com header.i=@golang-org.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=EOWhe98r; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WKtZj3sSrz1xqx for ; Fri, 12 Jul 2024 11:01:17 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8F10F385DDEE for ; Fri, 12 Jul 2024 01:01:15 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by sourceware.org (Postfix) with ESMTPS id 6B63E385DDEE for ; Fri, 12 Jul 2024 01:00:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B63E385DDEE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=golang.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=golang.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B63E385DDEE Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::112b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720746046; cv=none; b=JbK6uHKNPRdlJNn5jmV+0WBKf7vydpH7m355A4se+WsfcWR4I63g7Q1Oes/Mob1lsOy2klrYFW9xKBmaKmKepa+6ayZ216SkCZ2vXw/a78JxHJIRIvX5jUv/K4n3EJEhyP/JCPPnrrqOZIfwr15N3tlnISZwiAC2AbAVKWp4g48= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1720746046; c=relaxed/simple; bh=zTEbKFpN5gNPj9iurbnhOOm4O622uYPUiB9+DtHK+4s=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=V9QMIIwuh8oVR/3zwtguhgsRl+zZ6+48fV6xWMt4G8cuKP2/xcJNI0i1/FT8GvU5mffjF66okBVzlxYz5MfW8kL9p+ohMgllP5aEZCCfYmJnEfNFawoItdLcxS6w79ogka4YbttBhxb0NhpIx4Z7DMo1jYW2a3Lan/oPKAEyX3c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-64b3655297aso14070737b3.1 for ; Thu, 11 Jul 2024 18:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golang-org.20230601.gappssmtp.com; s=20230601; t=1720746043; x=1721350843; darn=gcc.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Ct4Vl4V1Iqz9RQPJMr4clOxdA5XtdPfS1mrQL0rnJT8=; b=EOWhe98rC/3U8QX79TmXBWR1X9FDwfJK3S7cP8f1B0EdlqAAU+6l5TxcM6TyV93UhY pDU76kqwf3OoNSfMKjvEEmdeBjd2C32j2+SbOsOVlWpZu3hQGwwasuQJ9J9NIUyEp8rw d7bk6qzds8HT+UZms2jg3iLNXGugWbDyH/CmEWjFywC8JhkAj8HQp/N4DFfI6zDVJay5 fUKLWsDQ+1LhgVTwlHPa6K8wxRowOOHCVHbC4+sQD46Gj8UF4j3OIB29GjmaLUoGRqJU 5MXEfMQ9Fs4c7t6RDIdsIWEKRbFlrqrLYXAUQaa6vT/b3YKlPUqAUGs0AmX/dnJNFuAj mWKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720746043; x=1721350843; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ct4Vl4V1Iqz9RQPJMr4clOxdA5XtdPfS1mrQL0rnJT8=; b=teRVr+elNgclhM1f9fF8z3JDCM3RMGnh71LUf102qm5mo1+OLyn702muH7BhJC+BeD zqf5mMnB7/8Zr0/HIsSw2+Z+bGNUIAxz0vi8W8WHDw45aiiVK47Ag5d7zCfzy9arRQ1T 56wHK2OqijQpjWDCy8D36I2jjHsvJmVqjXD0Girw63S9KR9v6ZejhNiNPB1rscdQPVJB F/cq93ynkz2HvwPXoKwYQA69FYEAmF3+Y3cgCzmeaxQv0z6NJr6iU9o8ciCexFNInDzF stmrom81kOqRDoyuxsxJ5QhpT+LfitXsP2HZNhYeVk4dEBw5A0nubppfhFMN5EF2Fz8l fSlQ== X-Gm-Message-State: AOJu0YxmYUzmZjf1dYjaELui+3ca9EFUdUnAOsz8sFpglRvQqdNP0/eV 9WcDfHqJ6ekz9uXYym+8K1yyAkFWRK2l5jbZSjF/KhUW/81Mg9KSzlHJ9/67iK4sBkZjE0WXn9R S1T+O7Lq4LhjmvXKDOB2jgRL+w+m8nC/SkEV9IYcgwjrpMYxViD8= X-Google-Smtp-Source: AGHT+IGusUwoqqLzMhrbur5o5by8qCfPkz8ZuTUzJ+u6ghs+P5gdYdNwNtzLc57VIpqxigZMSo09oF7JRenEAW8WDxs= X-Received: by 2002:a05:690c:64ca:b0:64a:9fc7:3b15 with SMTP id 00721157ae682-658ef24b011mr134047577b3.26.1720746043454; Thu, 11 Jul 2024 18:00:43 -0700 (PDT) MIME-Version: 1.0 From: Ian Lance Taylor Date: Thu, 11 Jul 2024 18:00:31 -0700 Message-ID: Subject: libbacktrace patch committed: Don't fail if symbol size is unknown To: gcc-patches X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org Mach-O and PE/COFF don't record symbol sizes in the symbol table. Adjust the libbacktrace testsuite so that it doesn't fail if the symbol size is unknown, only if it is incorrect. Ran libbacktrace tests on macOS on the compile farm and on x86_64-pc-linux-gnu. Committed to mainline. Ian * btest.c (test5): Don't fail if symbol size is 0. * mtest.c (test5): Likewise. d7318f4cf89c2a934fcd1f87d711081285fad242 diff --git a/libbacktrace/btest.c b/libbacktrace/btest.c index c4b2db2cce2..3b603f643fa 100644 --- a/libbacktrace/btest.c +++ b/libbacktrace/btest.c @@ -440,7 +440,7 @@ test5 (void) (unsigned long) (uintptr_t) &global); symdata.failed = 1; } - else if (symdata.size != sizeof (global)) + else if (symdata.size != sizeof (global) && symdata.size != 0) { fprintf (stderr, "test5: unexpected syminfo size got %lx expected %lx\n", diff --git a/libbacktrace/mtest.c b/libbacktrace/mtest.c index f793391653d..5ec43c7bbce 100644 --- a/libbacktrace/mtest.c +++ b/libbacktrace/mtest.c @@ -373,7 +373,7 @@ test5 (void) (unsigned long) (uintptr_t) &global); symdata.failed = 1; } - else if (symdata.size != sizeof (global)) + else if (symdata.size != sizeof (global) && symdata.size != 0) { fprintf (stderr, "test5: unexpected syminfo size got %lx expected %lx\n",