From patchwork Mon Jul 8 09:17:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qiang Qiang45 Zhang X-Patchwork-Id: 1957999 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=lenovo.com header.i=@lenovo.com header.a=rsa-sha256 header.s=DKIM202306 header.b=TXqgIczN; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WHnQL0dqtz1xr9 for ; Tue, 9 Jul 2024 01:01:46 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6386740613; Mon, 8 Jul 2024 15:01:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Tza54baqHvr4; Mon, 8 Jul 2024 15:01:41 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B947840536 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lenovo.com header.i=@lenovo.com header.a=rsa-sha256 header.s=DKIM202306 header.b=TXqgIczN Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id B947840536; Mon, 8 Jul 2024 15:01:41 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 9EB85C0A97; Mon, 8 Jul 2024 15:01:41 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id B16C7C0A96 for ; Mon, 8 Jul 2024 14:53:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 92E984054E for ; Mon, 8 Jul 2024 14:53:04 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AqPxiCnk7mWr for ; Mon, 8 Jul 2024 14:53:03 +0000 (UTC) X-Greylist: delayed 20149 seconds by postgrey-1.37 at util1.osuosl.org; Mon, 08 Jul 2024 14:53:02 UTC DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org D6945403F7 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=reject dis=none) header.from=lenovo.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D6945403F7 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.152.46; helo=mx0b-00823401.pphosted.com; envelope-from=zhangqiang45@lenovo.com; receiver= Received: from mx0b-00823401.pphosted.com (mx0b-00823401.pphosted.com [148.163.152.46]) by smtp4.osuosl.org (Postfix) with ESMTPS id D6945403F7 for ; Mon, 8 Jul 2024 14:53:02 +0000 (UTC) Received: from pps.filterd (m0355089.ppops.net [127.0.0.1]) by mx0b-00823401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4687cS83005530 for ; Mon, 8 Jul 2024 09:17:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lenovo.com; h= content-type:date:from:message-id:mime-version:subject:to; s= DKIM202306; bh=rOBDsHD2A3tTZIsDPPEsT6uDrm9vqoAVcwVfTOFbeJQ=; b=T XqgIczNZ0j9M3iSclsGgEmwcgLeAQpBHuD7oyFiCUjyWtSwyn0eFR3sjzT7HjmfX +e5TZX9MJPi6v8IXWUcv08hfLQZXKz0yjcNbzG/LQrMhPrpGJE4n98v1bEWQuOEq go3guWgo+IAbJaG/5UvctQL4IfDZhDCq/2SzpA+rd8QPeihYHFKOshmqLAwEJ3fL s0tOhBoaodGMIwIzcGn1/4oTgBfZNkmj1MGeyLPV+JuUyB3hQkxF0vrU//BYmDKk yC7PpiVKX5Q4lG4f9/v6YMeEDaSTvvtToNBLAZmrWEj+5HnCOhs6u5hkXt2nYYzO 9OLN1V110SYNXsZZuTZ4Q== Received: from apc01-sg2-obe.outbound.protection.outlook.com (mail-sgaapc01lp2105.outbound.protection.outlook.com [104.47.26.105]) by mx0b-00823401.pphosted.com (PPS) with ESMTPS id 407jfm9qjy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 08 Jul 2024 09:17:11 +0000 (GMT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YS5LYuPFuXrByE4RPwc78n0oiHknVs3BI3zR+UV4upn+21fTqL24PKU12dzk7vEdp5TWcsPw8HAOnPA/3kWOr88hL/tJSRW7ZI7XVf9NO3l/KIcKW2xsrrcl5QdJY4swdTbMdCwffo0pMtYGyc8Yx2V1sq3AxaqvXX8iEeDv8ySQ0PNlCmT8wx2JmzmMOrM/i8BfOPrg0fAZH3j0fBsqm7e5RfXritsmr2p2447jTDGNE7liUw3Fp4t1cD+DA3mQ1zzwsd5LE3/CXFBIROg1klOzXjVHMCKiSboIiyhLg6biG4B+UIx85UBH3WOZb8HTg+cMZ08PK8Hb95c5JnKnFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rOBDsHD2A3tTZIsDPPEsT6uDrm9vqoAVcwVfTOFbeJQ=; b=XwbFr+KG9+6h9Cx5FDLgUTYu6qFjba20+4pjg8zRDuJpw1XzJTDMuPAkoHoZMK/a7tBUqcBrA/1Lj6Odt/v/f/q3kl6kfsBaz3Q4JOGlgMNvrdEwGtbtApOD9RRdtn8INI7YZjchBYN8XuQDBMwh6CiMiMdMAmdREJjyAkcw/TFO5qq62/QGCsOErtW8woKDQj8/ZVQfzIJLLTVWg6CcJu8hDY/3jjgi6h3xYCztslwX3s+XHwRpvET+f2zDHTxkLgFSfz0hQh4z2D/NyALyeEmoRTlNk/r40cajI74xc+hGsP2WNyhkH56Jv/+YxSi43GnB6hY/g7msewL0bEa/RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=lenovo.com; dmarc=pass action=none header.from=lenovo.com; dkim=pass header.d=lenovo.com; arc=none Received: from SEZPR03MB7402.apcprd03.prod.outlook.com (2603:1096:101:12e::8) by TYZPR03MB8055.apcprd03.prod.outlook.com (2603:1096:400:45b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.34; Mon, 8 Jul 2024 09:17:06 +0000 Received: from SEZPR03MB7402.apcprd03.prod.outlook.com ([fe80::ef3e:3dcf:f408:780e]) by SEZPR03MB7402.apcprd03.prod.outlook.com ([fe80::ef3e:3dcf:f408:780e%4]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 09:17:05 +0000 To: "dev@openvswitch.org" Thread-Topic: [PATCH ovn] northd: Fix issues for Forwarding_Group Thread-Index: AdrRCeNELPyUOyh9T5CUi72uzO0seQ== Date: Mon, 8 Jul 2024 09:17:05 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEZPR03MB7402:EE_|TYZPR03MB8055:EE_ x-ms-office365-filtering-correlation-id: 0135705d-56bb-4438-e118-08dc9f2ebc71 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|376014|366016|1800799024|38070700018; x-microsoft-antispam-message-info: bqHwwceoEfWdxAW0Eh/wnVYafouNsJ/BwCDiBj+igsXY4rxidmogGsk7IaAqSKAJreAO/GM9u1w6kWy5+DQ0BL6vmaIhUvqu55rqxiXJEf1DpIx2Y9EJnPd/pRDN5InqQn10aJiOgMfBMax1SVV2u0qO6tnVe48M1PSqLYDxaam7Pms+UmHCKMn3rTAW4VxHZiYizeKKj24UL7oQbgJNT0ddDxAI7P8MZA0AGBrPDb5NdWa4MduR6M56pZWgNCzKIHBG5yBkRKOKDRHPusypCcL04pGsEXsbXkWxZBxrc+JDGrMKrSqpK3MnxvEHcqOvEJuL4mtiZsJ7PbfOxtFFJg1u1FN0/OPKCkDgu5iPXqLH9KdKVXzdMYJxv/w7Q04oTaHQEB46ll3C5eg9KDclJue8SBxEPUqDnM7I60NjDA4EREWWxSl/QOXp7cJiRRWUX1qAxmSvMnuop/w1r4FBMWeLGDe9khP4gLFiZfFlsAraWcVeH50rY3iGlsq55cg7CNzz9o5i/aRNNQsoyM0Z7M6ftIuvLgIMd4DlgoyjA43bs90kvwkAnNDyhcLo/lYtwv90+IhOwJ+tVuxt9xyJ/xxCFWgZCd5KdM5w2T05fGuQ8yTuV93njD5zBVahcCZo19XtwygPnZ/5vfa7g6h/N8SPRSj3QHjAJ52rRFHX2VuziXVWu2rxZh9KE0P8xAHi6cnZTFah1imtTDI/JKG8HyVudDTT53mY4cJGxn3GoF7rEzfpw0XypfbErGk3g28oiv9ObmgEPF1x0928j/hw9Yu4pUyAIDxRXeGfzUOT5oSSOlvbTIILUedA0dFX9PIT+sgXVUno6bFRilCPBy0Lha16glt/nxkWvv4iScgCktxVTiZitlopF6vjq1aHnQBS3ke9IAmAfSpFoCGrd/ay7YDVL2wG94U+cam+uHFmVja0hiVgOyJCKBbW1mD1/cOIsO//bcnz/56hi5CTuUBBvcidsukPX4a8tWjn3OLhtfcN3gRQ4IjejCRmRXhSPqyglO7WHEUk4vcdnlT/GGj0b2M9zIu7Nc3QGm0tSFrnnldGvJjIHUbdGGDfUM1109xnCr9GX4BzgFeiZhYiCKxKWRh7aHICE6SURvJ++mtHHumJu3CCty5C7EKUXu60zjhKgOJYnKpOe1kChqTogM4bO2Mrgt63vGh40IspLbj6b5bfU9rnmFeEGRqVeeHSNcRnoUKO6XPs5EhNhoXnJdYdCRaMH0D9eQOZMcRabUL71W4kV/2bFEHL2v2Fa40FBknkFOrmclcregVi7STNecy1VEaPAPx/5DttftwtLRE7YOaxORTu8IQsfm8WyL1WsFEDoUS43q280rBn5TbDfb/HXlBQpe6NLN/hJlreCfcho3c= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SEZPR03MB7402.apcprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: Q1EJZCUhdnXL2H7K5ZK57tGc/6FNXgkKro9BG7yRi98u5QdkAhIDpKzZjGkereT+Qy8sH59VDBVGbqFWCvRPJGZ05zs/9vlc2prqHNx5zUb09hmE1NWkynIULDrxa1RxooqLW0m5W7RBnWBmBOqTr/HYFKxKfORcCA0YpPyePSxsOtQbo9+dC/KUKcOp+0B6Aqudcj9VnhV3Kldj2DJJtE5DXd8dIFh9gwS8xGA9PBzFF2CR4dmTselHO5h1+XDcFyi8Vb3Rrb661tUjXLA8ELB/GypBTo6kwqnr7NFZkwnucIbnvug1tsdjfQabSsNvdoR6GbTquLO3Y5JchuoiULpjVzdQ0i8u5a07kTJICT2apBjASwkfx/oehIIWzyX5rBbUmbM5Hlv4FHorRbTfMpQSBxybrLmkjH9OIRuVo0H1Np4e7rn//iddtTz1hGEu+56UJxpU4Q2LHgMnCaNu3qYj0Vm7WdVwTnZc8O2QW1Sjbc+AxOoIjf8aK8IQNSwomq3ONq8EbR8ZJp1VJEXjcXbgy8uof2gQK34pkZUuqTjGHsaInHQ4uz2hDr/OWMskFwmtHbbaboC19pQTZAlpS7vj6rlqSL6Bw7xdgcEl00umjwEBplLi2fk+ch5vzXUVGkm1c2H41CBbZWXnDhusstitiH05H7Qp6j12/zye2AmDxZWUL8KKNDWFx1vRxeNYSeeeyWb+zc8IXROD6uydDkRUXey+LVmcmPUktGsA9F8KIEqejGnK+f04/GqWB2r45ITEjc5t8jGeaI5oO6YTokRzhryH+F6RPL/8UDEcUqrN6s08ZvuyMK4EYy6y+eLI+g83JNR0jQdVlmCqUs5bRbeZxqtyvNgWFzNwhkXcjtIZBljN+WzcRJ52qcNw9dIVeH3TJ4N5zHLox0MyQLWcopKR04eS6g08sn2O8oFTp2FfZYK2rOJe3u2hQ+7VZj4bHMmsF73T87Bb/YV8BroNI6qpzL8fC26OA5g7kEbljcro5KSBkG1RV4+optcaY1o0pFU5ydMJiljzU03zKjCPiCCClqXgC2nVQwlWDzTVyIlAJrtqpwJdxeos5X18zPSKtEyQqR4vHOq+G4dG6CvT13kitTImJQsk0lGlDmhwWuwcS0B/17Q2E0frQ/WxbMVPAdkXOFWG5qV8iy70TlWXBQHT+TddlAvda09d6Dwk46R4raXe6AtT7WinUI41/4jpRsQEx1stQPrljt67fxnFGeTOC5ygv0//TCnlReIUTrIOLLBEa55gVAqhgOwXH2TMw6d2VVtKkm6GhB40vHweh5RbVmQyEWzJFcwI+MMZMhIWodrfFbVlDFphUsKeiufMF7ZbARvRYCsf/hF+gIprmAa3IBprXVDID/qb+c00IYbAniU/QpSnf7Qj7SgUZN34l6KXRIVrSlW6/4cUQ9rEyZna3QHiPiNoVeWCNbONRt04QagR5IKjzE9WDC65oF7dKCcaaKFVc/Q47lMjaaC8xZ7qj+Ux+9J8YsbsudPSpnWlZpaO3hONuaGqxpdrzw/8LNJhquTlmEArAJhcFaDkKi7bKA5xJk0KYY0pnATNDH4ZcOTtKH6fKYtRHyqNsIzv MIME-Version: 1.0 X-OriginatorOrg: lenovo.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEZPR03MB7402.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0135705d-56bb-4438-e118-08dc9f2ebc71 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2024 09:17:05.8201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5c7d0b28-bdf8-410c-aa93-4df372b16203 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nrpjVholHeu6xdtqYdQImg4Ff2LC4xeCZ9ahG5kL1NB8lcq4l+YCAZ+c57XxIerzlsAazqTazZnkZHPBeZJU0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYZPR03MB8055 X-Proofpoint-GUID: DSNCvGZBl_ww_XIPn_5VfGAiHMShzkHh X-Proofpoint-ORIG-GUID: DSNCvGZBl_ww_XIPn_5VfGAiHMShzkHh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-07-08_04,2024-07-05_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1011 lowpriorityscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=-20 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2407080072 X-Mailman-Approved-At: Mon, 08 Jul 2024 15:01:40 +0000 X-Content-Filtered-By: Mailman/MimeDel 2.1.30 Subject: [ovs-dev] [PATCH ovn] northd: Fix issues for Forwarding_Group X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Qiang Qiang45 Zhang via dev From: Qiang Qiang45 Zhang Reply-To: Qiang Qiang45 Zhang Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" When a logical switch has 2 FWGs and each FWG has 3 ports, Logical-Flow only has one fwg_group() action. Submitted-at: northd: Fix issues for Forwarding_Group by ZhangQiang3 * Pull Request #250 * ovn-org/ovn (github.com) From 02186da234426bc361615eb6b5142c76f296202f Mon Sep 17 00:00:00 2001 From: zhangqiang45 zhangqiang45@lenovo.com Date: Mon, 8 Jul 2024 14:25:04 +0800 Subject: [PATCH ovn] northd: Fix issues for Forwarding_Group The use of variables from the outer loop in the inner loop causes the outer loop to terminate prematurely. eg. LVS are three fwgs, fwg1(p1,p2,p3,p4),fwg2(p11,p22),fwg3(p31,p32),only fwg1 in logical_flows --- northd/northd.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) -- 2.39.3 diff --git a/northd/northd.c b/northd/northd.c index 6898daa00..21ab0bb91 100644 --- a/northd/northd.c +++ b/northd/northd.c @@ -7929,6 +7929,9 @@ build_fwd_group_lflows(struct ovn_datapath *od, struct lflow_table *lflows, continue; } + ds_clear(&match); + ds_clear(&actions); + /* ARP responder for the forwarding group's virtual IP */ ds_put_format(&match, "arp.tpa == %s && arp.op == 1", fwd_group->vip); @@ -7959,9 +7962,9 @@ build_fwd_group_lflows(struct ovn_datapath *od, struct lflow_table *lflows, ds_put_cstr(&group_ports, "liveness=\"true\","); } ds_put_cstr(&group_ports, "childports="); - for (i = 0; i < (fwd_group->n_child_port - 1); ++i) { + for (int j = 0; j < (fwd_group->n_child_port - 1); ++j) { ds_put_format(&group_ports, "\"%s\",", - fwd_group->child_port[i]); + fwd_group->child_port[j]); } ds_put_format(&group_ports, "\"%s\"", fwd_group->child_port[fwd_group->n_child_port - 1]);