From patchwork Fri Jun 28 08:20:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qingfang Deng X-Patchwork-Id: 1953826 X-Patchwork-Delegate: robimarko@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QrJFWYj7; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=mkwItCpO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W9T263Gh5z20X6 for ; Fri, 28 Jun 2024 18:22:21 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZWZnYXemxF0vu9awLop4OFcV9nmd0mi3rj9q+3IR5dw=; b=QrJFWYj7mYXtQg iyJCBZojcRu481ft07Bg6gNpFFzvw1mNWG9qYC7K4ovkra4NQkc1AbTctXmSLjPrMZWp0okNhZ26h kdI43r2vNlKEsc4nzu6+xSZI/dhKG0yP2TuimbgNz81/pZ/DfEpHSzDiwpxdFrkJy1qb75HuEmjIG hIhxjk7RMV9BiJdCAGWFL+XsZzLCfMYh8QERRou61QFGm3YUK7sWFWriZFL3dmZwnpes7AYvSbsNF 5ZzQVHMeEilYDs7Bodg4LkutxFmcTGVh0PuGBbJ++YQ6pd0g8+ad2qeBvxx8SRQWShZ9JZr/bQS+j tb2V2cxXZgIF7HQ2+a+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6qJ-0000000D2oO-1Och; Fri, 28 Jun 2024 08:20:27 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6qF-0000000D2nb-117O for openwrt-devel@lists.openwrt.org; Fri, 28 Jun 2024 08:20:24 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1fa07e4f44eso1730755ad.2 for ; Fri, 28 Jun 2024 01:20:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719562822; x=1720167622; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dnv9vN0e+8hiRG6t9ZwAdF8th0AVYCODbGoEYlJWnOw=; b=mkwItCpOaHt22zZOpa1mpcV+aQghustAq1/1epS2g3YS+tadmuvlhcn2/R3hFLqINy deVc+L8fURis5uK/glzH5B/5JLmm22isFvm3AlntyOapiasb7nP+9SMhT0svg6fMs4ug qKZAWxVjoYd0G54hXn3QjMc5PncguSUBoq2LHPgrY3RUTcDLyn2mid6dx6KvRBMUiF3w ZWRcd/u4uPjLuQDt3ICBDGDUFFV2seu2P8LCdFK1D493KR7eQhKDarw1YF5U/xjwCbIC IrJWzxycIYpWL1VRR1U7AlRtYcxzkocHQL7aBVgf0qxvM9qbTzDD4bO/FgaRjluvfcPw 8ayQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719562822; x=1720167622; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dnv9vN0e+8hiRG6t9ZwAdF8th0AVYCODbGoEYlJWnOw=; b=YB4/6BlDrl5gdz4bTw7AjS2Ang/UI2HDgJETEfzL+J5PfpL2s8Td1fY4a+kvs+fzkx rnFamocUXExAN/BMamv79xoY3CVFeDoLuzoR6YMFVUNx7zorlRKm8Zs5iEeZGSHzaKkY fEN1nqzXzhE8xeFn7og0k8G/+KKRFDXqRrqbN4OsXYevwEb4m70bJQ4kxmD/TqpFUn/u CKYCw387WpPHCYimy2erlGsf258ATrMSQwU9UGWW4VIHgXaaezh57qhUl2jtp5I3dlOM 1KNTOswDW+wWKOc4BSuh8qx13A6ZxL0wlOmwelLwRHX4kKLUWin1SbfSPbaaZlyXlslg yZvg== X-Gm-Message-State: AOJu0YzxKL1/0B+MTLl1kelIgwcqe032NojbyLnR0+FYjXR8lhYGcVEx SVtB6/Vv7VzJQiv5cBSMOVv58sIAIK5gcOgENlMKltTkYnKeVvQaUj0Cvu0Y X-Google-Smtp-Source: AGHT+IG1lnsuhsLkipFvjXlPDJI+n+9ruNSGD2W0JGkp481y2Pe88HtBw7a/hOGh2n4lNfLyr7iwuQ== X-Received: by 2002:a17:902:db07:b0:1fa:e0c:8bd4 with SMTP id d9443c01a7336-1fa23f07142mr162034355ad.68.1719562821602; Fri, 28 Jun 2024 01:20:21 -0700 (PDT) Received: from gmail.com ([2a09:bac5:80c9:183c::26a:88]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fac10e3810sm9989185ad.90.2024.06.28.01.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jun 2024 01:20:21 -0700 (PDT) From: Qingfang Deng To: openwrt-devel@lists.openwrt.org Cc: Qingfang Deng , Felix Fietkau Subject: [PATCH] kernel: switch crc32 implementation back to default Date: Fri, 28 Jun 2024 16:20:09 +0800 Message-Id: <20240628082009.2472-1-dqfext@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_012023_309761_0F4A82B6 X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Qingfang Deng Commit ec885796c05a switched the crc32 implementation from default to byte-at-a-time algorithm, which runs slower but consumes less memory. A decade has passed, and we have already abandoned targets t [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [dqfext(at)gmail.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:632 listed in] [list.dnswl.org] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Qingfang Deng Commit ec885796c05a switched the crc32 implementation from default to byte-at-a-time algorithm, which runs slower but consumes less memory. A decade has passed, and we have already abandoned targets that had small memory, so switch it back to default for faster speed. Signed-off-by: Qingfang Deng --- target/linux/generic/config-5.15 | 4 ++-- target/linux/generic/config-6.1 | 4 ++-- target/linux/generic/config-6.6 | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/linux/generic/config-5.15 b/target/linux/generic/config-5.15 index cba00711ca..8e2223aebb 100644 --- a/target/linux/generic/config-5.15 +++ b/target/linux/generic/config-5.15 @@ -1043,10 +1043,10 @@ CONFIG_CRAMFS_BLOCKDEV=y # CONFIG_CRC16 is not set CONFIG_CRC32=y # CONFIG_CRC32_BIT is not set -CONFIG_CRC32_SARWATE=y +# CONFIG_CRC32_SARWATE is not set # CONFIG_CRC32_SELFTEST is not set # CONFIG_CRC32_SLICEBY4 is not set -# CONFIG_CRC32_SLICEBY8 is not set +CONFIG_CRC32_SLICEBY8=y # CONFIG_CRC4 is not set # CONFIG_CRC64 is not set # CONFIG_CRC7 is not set diff --git a/target/linux/generic/config-6.1 b/target/linux/generic/config-6.1 index 70e87665b7..aa47384137 100644 --- a/target/linux/generic/config-6.1 +++ b/target/linux/generic/config-6.1 @@ -1102,10 +1102,10 @@ CONFIG_CRAMFS_BLOCKDEV=y # CONFIG_CRC16 is not set CONFIG_CRC32=y # CONFIG_CRC32_BIT is not set -CONFIG_CRC32_SARWATE=y +# CONFIG_CRC32_SARWATE is not set # CONFIG_CRC32_SELFTEST is not set # CONFIG_CRC32_SLICEBY4 is not set -# CONFIG_CRC32_SLICEBY8 is not set +CONFIG_CRC32_SLICEBY8=y # CONFIG_CRC4 is not set # CONFIG_CRC64 is not set # CONFIG_CRC64_ROCKSOFT is not set diff --git a/target/linux/generic/config-6.6 b/target/linux/generic/config-6.6 index 20fe98099f..46cf505969 100644 --- a/target/linux/generic/config-6.6 +++ b/target/linux/generic/config-6.6 @@ -1003,10 +1003,10 @@ CONFIG_CRAMFS_BLOCKDEV=y # CONFIG_CRC16 is not set CONFIG_CRC32=y # CONFIG_CRC32_BIT is not set -CONFIG_CRC32_SARWATE=y +# CONFIG_CRC32_SARWATE is not set # CONFIG_CRC32_SELFTEST is not set # CONFIG_CRC32_SLICEBY4 is not set -# CONFIG_CRC32_SLICEBY8 is not set +CONFIG_CRC32_SLICEBY8=y # CONFIG_CRC4 is not set # CONFIG_CRC64 is not set # CONFIG_CRC64_ROCKSOFT is not set