From patchwork Tue Jun 25 08:03:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= X-Patchwork-Id: 1951979 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=kolabnow.com header.i=@kolabnow.com header.a=rsa-sha256 header.s=dkim20240523 header.b=jgsKPyFi; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W7cmY6r8bz20X6 for ; Tue, 25 Jun 2024 18:04:13 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 44CBF384514A for ; Tue, 25 Jun 2024 08:04:12 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx.kolabnow.com (mx.kolabnow.com [212.103.80.155]) by sourceware.org (Postfix) with ESMTPS id 79E763857000 for ; Tue, 25 Jun 2024 08:03:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 79E763857000 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 79E763857000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.103.80.155 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719302625; cv=none; b=Ss9AzZh1pLloweVzR/1qKI49J4LVUdTbzc5GTc4CfOH3UJweQDqvUaCdd5hVFQk95pcfUBa8heEuzeGDTf5fc60oFZDYKQISVuH/vKYRPA9cOR4Op/IdBeWLcKXLfx6Mi/7B5iynRNQTuU1mA0TpGc2uemjkaDDv6ewsa+PQ6ao= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719302625; c=relaxed/simple; bh=knctxGc+YgXH+QyIiVTtSvtLNcaR0P+Oo0Q0OP6Kdno=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=u08VnzKweK55AI6qkcbqq+deKP9FSoL/wpTOKpVifoLXG1IZkDnMPs1qTrnvp7QH/ynrRKbZDt/5m+ePgvol+Qj1fNfPkIHVNcCh9gzQtKvbx+2g0i+mA0InzuYVpSwscLgNeJ596/iPDnNSURdc6/VDFkuUjKhgYgA3oc2Ix4E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 69C2F20D136E; Tue, 25 Jun 2024 10:03:42 +0200 (CEST) Authentication-Results: ext-mx-out011.mykolab.com (amavis); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20240523; t=1719302621; x=1721117022; bh=RiVW4tsGhksajxInAT1csXd+wFOOgsK0HOQEgDMqk58=; b=jgsKPyFi3eBE a0wdXhcjIgeaWYQMmmZIAcO/012fr9uRVEirV2yxR3Kob/XcDA54RTAv9HZ74bJn N221W3CRCj23q8xZPAuQJ6n+WRciLhGvZIBB1MWDVI7Q6SoEhOSXT5e8Pm9bECmU DcQU07RV42CSxonmZm8EkibruOhzUbmtgN05aeUze17YeMqaXueYn4jQKPmm/RFt kB9jgHUiTSns7zzKESmCcVYG95O9aaTBEu4W8ILxwS26o6fj/35rQBmirxdYPPjn ErdbRMdfzvId2ntjeqf8/TlLEWyOLbO7tmXzyWfXm8qBFPi9nN37u9WGueByhJ6G nZgecgaafQ== X-Virus-Scanned: amavis at mykolab.com X-Spam-Score: -0.999 X-Spam-Level: X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out011.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id zqd56tz1SeVX; Tue, 25 Jun 2024 10:03:41 +0200 (CEST) Received: from int-mx011.mykolab.com (unknown [10.9.13.11]) by mx.kolabnow.com (Postfix) with ESMTPS id A030320D1348; Tue, 25 Jun 2024 10:03:41 +0200 (CEST) Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx011.mykolab.com (Postfix) with ESMTPS id 66E5832F126A; Tue, 25 Jun 2024 10:03:41 +0200 (CEST) From: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= To: gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz, =?utf-8?q?J=C3=B8rgen_Kvalsvik?= Subject: [PATCH 1/3] Release structures on function return Date: Tue, 25 Jun 2024 10:03:30 +0200 Message-Id: <20240625080332.1517736-2-j@lambda.is> In-Reply-To: <20240625080332.1517736-1-j@lambda.is> References: <20240625080332.1517736-1-j@lambda.is> MIME-Version: 1.0 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The value vec objects are destroyed on exit, but release still needs to be called explicitly. gcc/ChangeLog: * tree-profile.cc (find_conditions): Release vectors before return. --- gcc/tree-profile.cc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/tree-profile.cc b/gcc/tree-profile.cc index e4bb689cef5..18f48e8d04e 100644 --- a/gcc/tree-profile.cc +++ b/gcc/tree-profile.cc @@ -919,6 +919,9 @@ find_conditions (struct function *fn) if (!have_post_dom) free_dominance_info (fn, CDI_POST_DOMINATORS); + for (auto expr : exprs) + expr.second.release (); + cov->m_masks.safe_grow_cleared (2 * cov->m_index.last ()); const size_t length = cov_length (cov); for (size_t i = 0; i != length; i++) From patchwork Tue Jun 25 08:03:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= X-Patchwork-Id: 1951981 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=kolabnow.com header.i=@kolabnow.com header.a=rsa-sha256 header.s=dkim20240523 header.b=f7WV7sLb; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W7cpD1mmsz20X1 for ; Tue, 25 Jun 2024 18:05:40 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6E7B93845142 for ; Tue, 25 Jun 2024 08:05:38 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx.kolabnow.com (mx.kolabnow.com [212.103.80.154]) by sourceware.org (Postfix) with ESMTPS id 6CFEE386C59D for ; Tue, 25 Jun 2024 08:03:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6CFEE386C59D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6CFEE386C59D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.103.80.154 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719302632; cv=none; b=j/AHC0ANIhsCPXiG2Qhv0voPeVnA8+fjLYpw9rqaDu88gk5bvE7T+m6aAEWuY851pxNi5gaRGkG7TYGMGYtth32PxSO3jEZEKDpjxCKSa5MWLffmtVhBoJFnwd5AwLL0/mo8ldrQ34mTpIJ9b+TLQAxpHHIBI8GnX5RFnQl85yQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719302632; c=relaxed/simple; bh=JrCq3fYxcLcdUnceyLWW7rNNjMgps1e8E7iehhPfBwo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=G12hti2eF+mHnisHnXMBP9sCi5fX8iJG8pSkK/f/2guaTW1pWgDinl09AMFR293GWwDNP/frIcLTJdoz+OY6cAwjucuhChJHKR+vbqASX1rudyOzCZ3EyQE1WNJ9LQxHwHnl5k30+FypT6PBBircdnnXIRMb0wtEI/7VM7M/ovE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 7E9F33004C4C; Tue, 25 Jun 2024 10:03:43 +0200 (CEST) Authentication-Results: ext-mx-out013.mykolab.com (amavis); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20240523; t=1719302622; x=1721117023; bh=Que0IEqL+gfkVuelscewoK9/l9Tc4OrTZxmC1PYyhC0=; b=f7WV7sLbeGny Gp7oyM54d176WFWcA3RwIrRAILXiYIAC3PgdW0fzNYF7pxFwz13dolsAbSUWpzr0 Ds9wIdFvAhPjKKu+tQicp0pZBheHioMqLkC1GjrINzg04ieOidJTYgggWQq1svk7 /2+pUNrh5xMfmHOs+kfTyB4ihpTiCSWR8Co62eM0iYZcVgrFvVnAzwi03YQyRY+B TOhNyKYMct2bfTMtH9NOpEn8aCzVKNREDVfG/M7vzB5kFxGHyO08yB3wsq5nNC8S Pu/EXOvqbE7xsoyzu9v9KV7LpClNWzVnTjKcHartFWOddXvlpR9BrfV40kytbex+ GoDM8mEK/Q== X-Virus-Scanned: amavis at mykolab.com X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out013.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id FrNodVOFzg3y; Tue, 25 Jun 2024 10:03:42 +0200 (CEST) Received: from int-mx009.mykolab.com (unknown [10.9.13.9]) by mx.kolabnow.com (Postfix) with ESMTPS id 8E52D3004C5C; Tue, 25 Jun 2024 10:03:42 +0200 (CEST) Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx009.mykolab.com (Postfix) with ESMTPS id 5F41C21F0909; Tue, 25 Jun 2024 10:03:42 +0200 (CEST) From: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= To: gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz, =?utf-8?q?J=C3=B8rgen_Kvalsvik?= Subject: [PATCH 2/3] Add section on MC/DC in gcov manual Date: Tue, 25 Jun 2024 10:03:31 +0200 Message-Id: <20240625080332.1517736-3-j@lambda.is> In-Reply-To: <20240625080332.1517736-1-j@lambda.is> References: <20240625080332.1517736-1-j@lambda.is> MIME-Version: 1.0 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org gcc/ChangeLog: * doc/gcov.texi: Add MC/DC section. --- gcc/doc/gcov.texi | 72 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+) diff --git a/gcc/doc/gcov.texi b/gcc/doc/gcov.texi index dc79bccb8cf..a9221738cce 100644 --- a/gcc/doc/gcov.texi +++ b/gcc/doc/gcov.texi @@ -917,6 +917,78 @@ of times the call was executed will be printed. This will usually be 100%, but may be less for functions that call @code{exit} or @code{longjmp}, and thus may not return every time they are called. +When you use the @option{-g} option, your output looks like this: + +@smallexample +$ gcov -t -m -g tmp + -: 0:Source:tmp.cpp + -: 0:Graph:tmp.gcno + -: 0:Data:tmp.gcda + -: 0:Runs:1 + -: 1:#include + -: 2: + -: 3:int + 1: 4:main (void) + -: 5:@{ + -: 6: int i, total; + 1: 7: total = 0; + -: 8: + 11: 9: for (i = 0; i < 10; i++) +condition outcomes covered 2/2 + 10: 10: total += i; + -: 11: + 1*: 12: int v = total > 100 ? 1 : 2; +condition outcomes covered 1/2 +condition 0 not covered (true) + -: 13: + 1*: 14: if (total != 45 && v == 1) +condition outcomes covered 1/4 +condition 0 not covered (true) +condition 1 not covered (true false) + #####: 15: printf ("Failure\n"); + -: 16: else + 1: 17: printf ("Success\n"); + 1: 18: return 0; + -: 19:@} +@end smallexample + +For every condition the number of taken and total outcomes are +printed, and if there are uncovered outcomes a line will be printed +for each condition showing the uncovered outcome in parentheses. +Conditions are identified by their index -- index 0 is the left-most +condition. In @code{a || (b && c)}, @var{a} is condition 0, @var{b} +condition 1, and @var{c} condition 2. + +An outcome is considered covered if it has an independent effect on +the decision, also known as masking MC/DC (Modified Condition/Decision +Coverage). In this example the decision evaluates to true and @var{a} +is evaluated, but not covered. This is because @var{a} cannot affect +the decision independently -- both @var{a} and @var{b} must change +value for the decision to change. + +@smallexample +$ gcov -t -m -g tmp + -: 0:Source:tmp.c + -: 0:Graph:tmp.gcno + -: 0:Data:tmp.gcda + -: 0:Runs:1 + -: 1:#include + -: 2: + 1: 3:int main() + -: 4:@{ + 1: 5: int a = 1; + 1: 6: int b = 0; + -: 7: + 1: 8: if (a && b) +condition outcomes covered 1/4 +condition 0 not covered (true false) +condition 1 not covered (true) + #####: 9: printf ("Success!\n"); + -: 10: else + 1: 11: printf ("Failure!\n"); + -: 12:@} +@end smallexample + The execution counts are cumulative. If the example program were executed again without removing the @file{.gcda} file, the count for the number of times each line in the source was executed would be added to From patchwork Tue Jun 25 08:03:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= X-Patchwork-Id: 1951982 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=kolabnow.com header.i=@kolabnow.com header.a=rsa-sha256 header.s=dkim20240523 header.b=bU20rrFq; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (unknown [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W7cr956R2z20X1 for ; Tue, 25 Jun 2024 18:07:21 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F33D9384514B for ; Tue, 25 Jun 2024 08:07:09 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx.kolabnow.com (mx.kolabnow.com [212.103.80.155]) by sourceware.org (Postfix) with ESMTPS id 173AA386C5A4 for ; Tue, 25 Jun 2024 08:03:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 173AA386C5A4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=lambda.is Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lambda.is ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 173AA386C5A4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.103.80.155 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719302632; cv=none; b=n+R9TueXQnUhMSTJa2dh8BJEooFNlYKRs16z5qH9HOVInKpe1RtezJXfUcggjhWG/gkESLA2sk2HxpmaE8b/9YMFJKKGl6BjWRuO222yWluv3y39qDmao6wlQUNkql/E2OJccQWg+yGwRyiQLDcCPVhdvsWvso4FYJbM+qsuL00= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719302632; c=relaxed/simple; bh=HtGDTex/4FhOOdq2kjoIe6Kt0VN70wPRXmhmiiuCR78=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Mr/Es6z3eucpFz136Wf6/kATVs5C/WvyUtOU/21UZEpYwiWOJhTNvXdGiRYoRCrqqqHB78QZD78RspOI+kC1XSgN9nKSxclkwQDRzBKj8WI8G3YOabTitwn8C3MEbilyOVZh0/zVZcUl1wJ4UpzH4ZaModp1k+dTYxxIqQBWxBc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (unknown [127.0.0.1]) by mx.kolabnow.com (Postfix) with ESMTP id 393A520D136F; Tue, 25 Jun 2024 10:03:45 +0200 (CEST) Authentication-Results: ext-mx-out011.mykolab.com (amavis); dkim=pass (2048-bit key) reason="pass (just generated, assumed good)" header.d=kolabnow.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20240523; t=1719302624; x=1721117025; bh=VjqUolrvsoiQLqNlHQZT1AIKMxm1d2LUoOAmSkkAE/M=; b=bU20rrFqBPoa KPfnpKAREI8wpbnPdPnvzw2kQ19P8MVvqzcG2vDmLZce5RywNDVx06hM89MvyoO/ uKFzgfFWbEf7tgf7NjXxsb7NqWfljnSYUbmsEW77bZ6lB8cfMI1CtRqlMqRKOd+H m1sa+1FIkEpZu4fJ0s2f//wUALcbfKmj16YcP1AMBEgp9/5oJ0+wp1aK8HdH1S9F irS1/s+wUaA5P7Eg4Ev+3U56e9ugXyzT7gcaJ0XGVHH4eHPiTpLoYexuLvipnO9/ DEeQZeXbLIrFBXoV2SKUe47zQp8jLZi/Ml/tfJ5G95zr3Gnitr91uZJJJPzUND2m 19Tg6UiNaA== X-Virus-Scanned: amavis at mykolab.com X-Spam-Score: -0.999 X-Spam-Level: X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out011.mykolab.com [127.0.0.1]) (amavis, port 10024) with ESMTP id 8SUAZa-J9_Wq; Tue, 25 Jun 2024 10:03:44 +0200 (CEST) Received: from int-mx011.mykolab.com (unknown [10.9.13.11]) by mx.kolabnow.com (Postfix) with ESMTPS id 6170720D1348; Tue, 25 Jun 2024 10:03:44 +0200 (CEST) Received: from ext-subm010.mykolab.com (unknown [10.9.6.10]) by int-mx011.mykolab.com (Postfix) with ESMTPS id 314FF32F1269; Tue, 25 Jun 2024 10:03:44 +0200 (CEST) From: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= To: gcc-patches@gcc.gnu.org Cc: hubicka@ucw.cz, =?utf-8?q?J=C3=B8rgen_Kvalsvik?= Subject: [PATCH 3/3] Use the term MC/DC in help for gcov --conditions Date: Tue, 25 Jun 2024 10:03:32 +0200 Message-Id: <20240625080332.1517736-4-j@lambda.is> In-Reply-To: <20240625080332.1517736-1-j@lambda.is> References: <20240625080332.1517736-1-j@lambda.is> MIME-Version: 1.0 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Without key terms like "masking" and "MC/DC" it is not at all obvious what --conditions actually reports on, and there is no easy path for the user to figure out. By at least including the two key terms MC/DC and masking users have something to search for. gcc/ChangeLog: * gcov.cc (print_usage): Reference masking MC/DC. --- gcc/gcov.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/gcov.cc b/gcc/gcov.cc index f6787f0be8f..1e2e193d79d 100644 --- a/gcc/gcov.cc +++ b/gcc/gcov.cc @@ -1015,7 +1015,7 @@ print_usage (int error_p) fnotice (file, " -c, --branch-counts Output counts of branches taken\n\ rather than percentages\n"); fnotice (file, " -g, --conditions Include modified condition/decision\n\ - coverage in output\n"); + coverage (masking MC/DC) in output\n"); fnotice (file, " -d, --display-progress Display progress information\n"); fnotice (file, " -D, --debug Display debugging dumps\n"); fnotice (file, " -f, --function-summaries Output summaries for each function\n");