From patchwork Sun Jun 23 09:40:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 1951176 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xG+SUaLx; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ys3XAJie; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=xG+SUaLx; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ys3XAJie; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W6R0d2Pj9z20X6 for ; Sun, 23 Jun 2024 19:40:33 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7A431385DDD3 for ; Sun, 23 Jun 2024 09:40:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 7CDA5385C6CB for ; Sun, 23 Jun 2024 09:40:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CDA5385C6CB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7CDA5385C6CB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719135614; cv=none; b=qpVf73FuY+UmGzuwmdOsYrEoBRdBxF5CfrEEgLYK5oo1Hll30VrcmT9i8MthZGU+eVcriIXAIHvrHVFQEFC72WyNMnFZP+f3jaDs6O+h2oyqMQLqO8QnmBOQcdFSRJ65k+bF4MP7Y8hTWhXGLPU13gZLcwB/o0KqekLqGwTCwS8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719135614; c=relaxed/simple; bh=qY3mGmj864COMcYyjymPzt9MqZLqYSuMfSV29Yl85iA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version:Message-Id; b=d8GVgkUJ0G8LnNtxeKc0llbXxq9C3OviSjSuXRtllPL0dGHZSbTbObk/RsylfcclnTX1rvj3f3Lh4kPFO+OIfLHnIkDolr+d+Km2zvORj5qKUZcpW1F3hWAG1PCILcnntBExF313/W9OQrsI0Z2ASalItrckXWWEp+nMZlpdEtg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 352C021A49; Sun, 23 Jun 2024 09:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1719135610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KMgEUEzydbLdsUaioB7DUkOa+Op6O6MtYeHTWNmhuDc=; b=xG+SUaLxe2HeiDmIFMYjpI2UAEg1s//e6gnTF0bwR1QHRURkauuIAwb7tkEW8fL+NWOOsT uH4FZAOL5VjHC+I+4hDRYuCc4GLF5i6p4cX+WMsStPu0iRv6f50IVWetS7oQ1SmfwrSlLl 5UQB4cKAKjv0UDbVFpXV6yyPuOA3870= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1719135610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KMgEUEzydbLdsUaioB7DUkOa+Op6O6MtYeHTWNmhuDc=; b=Ys3XAJiehvGbXcXpq4YvpLsLlflLoQt4bfIvh3/nz1ndc3sQuqNvrzWNvFzXAaiTSNYngj PGETBaEmvH3EeBCg== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=xG+SUaLx; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Ys3XAJie DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1719135610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KMgEUEzydbLdsUaioB7DUkOa+Op6O6MtYeHTWNmhuDc=; b=xG+SUaLxe2HeiDmIFMYjpI2UAEg1s//e6gnTF0bwR1QHRURkauuIAwb7tkEW8fL+NWOOsT uH4FZAOL5VjHC+I+4hDRYuCc4GLF5i6p4cX+WMsStPu0iRv6f50IVWetS7oQ1SmfwrSlLl 5UQB4cKAKjv0UDbVFpXV6yyPuOA3870= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1719135610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=KMgEUEzydbLdsUaioB7DUkOa+Op6O6MtYeHTWNmhuDc=; b=Ys3XAJiehvGbXcXpq4YvpLsLlflLoQt4bfIvh3/nz1ndc3sQuqNvrzWNvFzXAaiTSNYngj PGETBaEmvH3EeBCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1138B13AC1; Sun, 23 Jun 2024 09:40:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id se4bAnrtd2Z0MQAAD6G6ig (envelope-from ); Sun, 23 Jun 2024 09:40:10 +0000 Date: Sun, 23 Jun 2024 11:40:05 +0200 (CEST) From: Richard Biener To: gcc-patches@gcc.gnu.org cc: tamar.christina@arm.com Subject: [PATCH] tree-optimization/115597 - allow CSE of two-operator VEC_PERM nodes MIME-Version: 1.0 Message-Id: <20240623094010.1138B13AC1@imap1.dmz-prg2.suse.org> X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; MISSING_XM_UA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 352C021A49 X-Spam-Score: -4.51 X-Spam-Level: X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org The following makes sure to always CSE when there's SLP_TREE_SCALAR_STMTS as otherwise a chain of two-operator node operations can result in exponential behavior of the CSE process as likely seen when building 510.parest on aarch64. Bootstrap and regtest running on x86_64-unknown-linux-gnu. PR tree-optimization/115597 * tree-vect-slp.cc (vect_cse_slp_nodes): Allow to CSE VEC_PERM nodes. --- gcc/tree-vect-slp.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 9465d94de1a..212d5f97f7d 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -6085,7 +6085,6 @@ static void vect_cse_slp_nodes (scalar_stmts_to_slp_tree_map_t *bst_map, slp_tree& node) { if (SLP_TREE_DEF_TYPE (node) == vect_internal_def - && SLP_TREE_CODE (node) != VEC_PERM_EXPR /* Besides some VEC_PERM_EXPR, two-operator nodes also lack scalar stmts and thus CSE doesn't work via bst_map. Ideally we'd have sth that works for all internal and external nodes. */