From patchwork Fri Jun 21 09:31:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Potin Lai X-Patchwork-Id: 1950684 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=KvRoRuX5; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W5C0c3Mxbz20X6 for ; Fri, 21 Jun 2024 19:36:16 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=KvRoRuX5; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W5C0b29Kxz3dBt for ; Fri, 21 Jun 2024 19:36:15 +1000 (AEST) X-Original-To: openbmc@lists.ozlabs.org Delivered-To: openbmc@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=KvRoRuX5; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::62c; helo=mail-pl1-x62c.google.com; envelope-from=potin.lai.pt@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W5By84Cmdz3c6n; Fri, 21 Jun 2024 19:34:07 +1000 (AEST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1f9e2affc8cso7374115ad.2; Fri, 21 Jun 2024 02:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718962442; x=1719567242; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BlPyR2DwNKIhgYcJR7RVlheTP0T99OY10zKkh8vPfJo=; b=KvRoRuX5ebP84Jz1vXobk5vUrm6wQSD3PR6U4HsRDgLEPj3Fl1grmc+HtBGWQQYAFB Lm1QHicAxDjcVAk8+Kmyaye33x86zUBN74LOS4S0eBdg2S3/IyL0jiLC9aZ/vAAnrn/x PF//i1nnQN9fP0Ta6Txablv4p6XtmEKKFo1vKn2TdifASY8XpcUXKGuMw/FEdC7S+pIf bOusFAwDDqv/yQZi9Npgnx+FBHxrqfT0XNdj0LtcDRpt9jFEUwsGctB6yOY4PnFZMzij EL0I+KCUq874gdiXdZdSTUCPCtgzCq2pkwFk5XjQ9GNKvAZ22qaF1HKrCDd3iudBN4EI Z3zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718962442; x=1719567242; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BlPyR2DwNKIhgYcJR7RVlheTP0T99OY10zKkh8vPfJo=; b=Z7sBb6ywFNFQuTrLzl6Kz+Dx+6GlWsCxe9YjFx/IGPkeNzii5zic/0hpIRSHW/M9Lj tmjHirXRBTzMiyjsvy6AdYF0DmNFE5S5FON3CKGL5oc4clcmsx5/iPkY8JNfHRCxIicG cpnMWegyStHNsHNZ+rOuYbRY4Af7mcjmFbaT6HaYd1iMg0ZS0TZnPczXn85Tdf14Wie0 Y2nENZRh011MBhSXztvdk6SgGhB+TWd0NVFX0YuGX4YTlfTTQL9xt06l+c8t0hSnmpbH idloJgwk/QCbKQ2AlMpX5PP6eeuTXZxInxiGKyb2eSpQwMHAnw1Wf1XhAsJ40eKUnaRT 2YdA== X-Forwarded-Encrypted: i=1; AJvYcCXifLajN1Fydzczh8vO9REZxf1owJ4VGOaXsgggsBCFodNEoqcBhGr6s6fQOkOGrC6EINI3yOgwy7Af7paz4aO/lJyhvZvthEo= X-Gm-Message-State: AOJu0YwxMbJxUe+MQbEArgkdVnTi975k/VsLNOaMsQ+7p32PXMd8j5Cb ZzA/2Hk82n60rcqMYLIabJxagOfmfVnZ4IZWPY3N49YhL/yHIFF6 X-Google-Smtp-Source: AGHT+IFfA7C54egHwv68x+7wV7g0a7OIDYQlMXJVlMpjxHZw9f4QfFjmcMgrvV4MeiBayo09KJSZQg== X-Received: by 2002:a17:902:cec1:b0:1f8:67e4:398a with SMTP id d9443c01a7336-1f9aa3bcab8mr82874115ad.13.1718962441726; Fri, 21 Jun 2024 02:34:01 -0700 (PDT) Received: from localhost.localdomain (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbc72e9sm9810365ad.296.2024.06.21.02.33.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 02:34:01 -0700 (PDT) From: Potin Lai To: Andrew Jeffery , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Subject: [PATCH v4 1/2] dt-bindings: pinctrl: aspeed,ast2600-pinctrl: add NCSI groups Date: Fri, 21 Jun 2024 17:31:41 +0800 Message-Id: <20240621093142.698529-2-potin.lai.pt@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240621093142.698529-1-potin.lai.pt@gmail.com> References: <20240621093142.698529-1-potin.lai.pt@gmail.com> MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Cosmo Chou , Potin Lai , linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "openbmc" In the NCSI pin table, the reference clock output pin (RMIIXRCLKO) is not needed on the management controller side. Add "NCSI" pin groups that are equivalent to the RMII pin groups, but without the RMIIXRCLKO pin. Acked-by: Krzysztof Kozlowski Signed-off-by: Potin Lai Reviewed-by: Andrew Jeffery --- .../bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml index 00b6974a5ed3d..80974c46f3ef9 100644 --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml @@ -19,6 +19,11 @@ description: |+ Refer to the bindings described in Documentation/devicetree/bindings/mfd/syscon.yaml + Note: According to the NCSI specification, the reference clock output pin + (RMIIXRCLKO) is not required on the management controller side. To optimize + pin usage, add "NCSI" pin groups that are equivalent to the RMII pin groups, + but without the RMIIXRCLKO pin. + properties: compatible: const: aspeed,ast2600-pinctrl @@ -337,6 +342,8 @@ additionalProperties: - MDIO2 - MDIO3 - MDIO4 + - NCSI3 + - NCSI4 - NCTS1 - NCTS2 - NCTS3 From patchwork Fri Jun 21 09:31:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Potin Lai X-Patchwork-Id: 1950682 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=gvlpRVHi; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=patchwork.ozlabs.org) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W5Bzc09XLz20X6 for ; Fri, 21 Jun 2024 19:35:24 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=gvlpRVHi; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4W5BzZ6KQRz3d94 for ; Fri, 21 Jun 2024 19:35:22 +1000 (AEST) X-Original-To: openbmc@lists.ozlabs.org Delivered-To: openbmc@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=gvlpRVHi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::633; helo=mail-pl1-x633.google.com; envelope-from=potin.lai.pt@gmail.com; receiver=lists.ozlabs.org) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4W5By83c8mz3bsR; Fri, 21 Jun 2024 19:34:07 +1000 (AEST) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1f6da06ba24so13455265ad.2; Fri, 21 Jun 2024 02:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718962444; x=1719567244; darn=lists.ozlabs.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=gvlpRVHiLkgvO3gEn1NTpW/w5CNMFz/wAA6wJIRmBSfZSK+6gorhUETOcMVFAlNjl+ wHccj7sY9pPaAsmD6ad8vidCPbvubquJRLQcBkHXeyBTP8Qt9kTfhU31nODuwC/hYj07 BTURvaQjDXWFc8b4CKu+9m34Sr3aIDaErb5ZQJ5vG96UzdXaI8ocPzheYbadvkXrne3S U9dW97EC3ZSWnDOyxJuCAGnRgijifh+0BXueI3K6Pvk94WLGYnsXEmbW/QDZFxR08GkW 4vkUXO+friLzR08D/WZG6dDXE4DJ0uun4rT/LDU/Vnbi5dbr77YTR5rCSRwTUlvAETW1 tMtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718962444; x=1719567244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EiJfmKO8nNBSX1oUuFOSypNRXVZPBtzmshynKzoPzUw=; b=n0Q+GKgdtc37fTWPK6/Q/nbvf03zhPv8tmZBftxm/3VhCQgXQCG2ENpVYqpij05oOb 3qZDS413IIt+pfY9QEQSE4sB9KYn+h2tOzoA1Pvjon7Ck2Bf5ssmr+ctwS/r3LoFtTFb 5w7NdyWz+ldH4Up3C34Zur3JpreQM9xg21B+4l0nO35yNNywb9UTKbb/dmNKCIN/C6C9 OjyxFTnByUET53afKATFTCbvHkZBkT+/peuZIwwN8eYop/4aWeMHbXGZAEcn7e4H+VPc o43AFuEC7U2EOlapowkV+Sx2XWk4iuiyxAi3qhqU5pmVYJzJnKdJpxSsYwqM+iJRO/eJ SvwA== X-Forwarded-Encrypted: i=1; AJvYcCUrL3sy1diRgMzs7bFQKsatVhhcVue0cYbdyYWFnhlN59kt0vaEAX70dOsIIYyM0aGVMde/mmXFaaBFh9Hqueh9jURjePz3vP8= X-Gm-Message-State: AOJu0Yye3ZW7QQM81HEQ7stg/EbDtkiZjrV+W0zGlmzZXTVFSUBBM3mj yzAzm5/mVnUBNLw+OQ44bt52xxaXPtCk9iqAEBQedMIB6vlk59+C X-Google-Smtp-Source: AGHT+IFOKXrh2SxGVKHFT+5si9TabUQXPaizDpK8J7kyQ+x11v7jWslxqA6il5ABG6GwYYLtHI0tSA== X-Received: by 2002:a17:902:d4c1:b0:1f6:7f8f:65c7 with SMTP id d9443c01a7336-1f9aa3e9e54mr90810285ad.26.1718962444561; Fri, 21 Jun 2024 02:34:04 -0700 (PDT) Received: from localhost.localdomain (61-220-246-151.hinet-ip.hinet.net. [61.220.246.151]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbc72e9sm9810365ad.296.2024.06.21.02.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 02:34:04 -0700 (PDT) From: Potin Lai To: Andrew Jeffery , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Subject: [PATCH v4 2/2] pinctrl: aspeed-g6: Add NCSI pin group config Date: Fri, 21 Jun 2024 17:31:42 +0800 Message-Id: <20240621093142.698529-3-potin.lai.pt@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20240621093142.698529-1-potin.lai.pt@gmail.com> References: <20240621093142.698529-1-potin.lai.pt@gmail.com> MIME-Version: 1.0 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Cosmo Chou , Potin Lai , linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "openbmc" Based on the NCSI pin table (Table 181) in NCSI spec[1], the reference clock output pin (RMIIXRCLKO) is not needed on the management controller side. To optimize pin usage, add new NCSI pin group that excludes RMIIXRCLKO, reducing the number of required pins. LINK: [1] https://www.dmtf.org/sites/default/files/standards/documents/DSP0222_1.2.0a.pdf Signed-off-by: Potin Lai Reviewed-by: Andrew Jeffery --- drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c index 7938741136a2c..31e4e0b342a00 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c @@ -249,7 +249,9 @@ PIN_DECL_2(E26, GPIOD3, RGMII3RXD3, RMII3RXER); FUNC_GROUP_DECL(RGMII3, H24, J22, H22, H23, G22, F22, G23, G24, F23, F26, F25, E26); -FUNC_GROUP_DECL(RMII3, H24, J22, H22, H23, G23, F23, F26, F25, E26); +GROUP_DECL(RMII3, H24, J22, H22, H23, G23, F23, F26, F25, E26); +GROUP_DECL(NCSI3, J22, H22, H23, G23, F23, F26, F25, E26); +FUNC_DECL_2(RMII3, RMII3, NCSI3); #define F24 28 SIG_EXPR_LIST_DECL_SESG(F24, NCTS3, NCTS3, SIG_DESC_SET(SCU410, 28)); @@ -355,7 +357,9 @@ FUNC_GROUP_DECL(NRTS4, B24); FUNC_GROUP_DECL(RGMII4, F24, E23, E24, E25, D26, D24, C25, C26, C24, B26, B25, B24); -FUNC_GROUP_DECL(RMII4, F24, E23, E24, E25, C25, C24, B26, B25, B24); +GROUP_DECL(RMII4, F24, E23, E24, E25, C25, C24, B26, B25, B24); +GROUP_DECL(NCSI4, E23, E24, E25, C25, C24, B26, B25, B24); +FUNC_DECL_2(RMII4, RMII4, NCSI4); #define D22 40 SIG_EXPR_LIST_DECL_SESG(D22, SD1CLK, SD1, SIG_DESC_SET(SCU414, 8)); @@ -1976,6 +1980,8 @@ static const struct aspeed_pin_group aspeed_g6_groups[] = { ASPEED_PINCTRL_GROUP(MDIO2), ASPEED_PINCTRL_GROUP(MDIO3), ASPEED_PINCTRL_GROUP(MDIO4), + ASPEED_PINCTRL_GROUP(NCSI3), + ASPEED_PINCTRL_GROUP(NCSI4), ASPEED_PINCTRL_GROUP(NCTS1), ASPEED_PINCTRL_GROUP(NCTS2), ASPEED_PINCTRL_GROUP(NCTS3),