From patchwork Fri Jun 14 18:03:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 1948108 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QQAXEw6D; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W16bj56b1z20X9 for ; Sat, 15 Jun 2024 04:04:01 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ECA5D3882652 for ; Fri, 14 Jun 2024 18:03:59 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 34F1D3882642 for ; Fri, 14 Jun 2024 18:03:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34F1D3882642 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34F1D3882642 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718388218; cv=none; b=ELqr47hjoylMKv9NFtySI7mHvt6N3xayI/tHEzNW5WlGbFhVYCa/0gGyCAkQuiOnvpMR1fi5FLO0h04bpOJUADHpM/9yX9WcRqHG3Pq8XfGXN9RG3zzXtqscNuUp/3lEMl+3F3EzKiQCXjnOOSxyU1Z6oDXl+oSrcWy/1g41PB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718388218; c=relaxed/simple; bh=KykugqDJXRuDCG3bdOcdJetUFQNysMN2TVU/3BJ+9Cc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=KOA3XtzvTjmHbUyVViFvKqu74Nzei7am4TuCkkp0weRxcTcihodEx7qssdqiSOIQScRuoXQkVJR69NDeZ3ll0FD+EfyiVkMW7LCqPWb1tyuO+EDlXVK7AHl6W/9w4qnRwn2Jj35sliqVDqC0h70TT73mF4eLNxNqKWvt+9qyv9U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718388216; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=jcA2F7aHv5ZHgJ5QNW22+Mpyxq+F+zoWjqvQ7UYUiXQ=; b=QQAXEw6DE7ITkFlaH4YPlhJDn3wgZSQNo+agkoKpV/oluTtOY9R4kfQRly8KO9Ey8L9GfX 0QRIL+JKBw+jYkWqlVfe9yU4g5FqNW7pCfmRzTJF6G8I11YeogPug8iIqMXEhFMySa1duD FHZX0Cr6vZUu9p034lxzDM410z4tSSs= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-lBwwS6quMpeKZ4xr8QktcQ-1; Fri, 14 Jun 2024 14:03:33 -0400 X-MC-Unique: lBwwS6quMpeKZ4xr8QktcQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6971B19560BD; Fri, 14 Jun 2024 18:03:32 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A17AB1956050; Fri, 14 Jun 2024 18:03:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 45EI3SL92614600 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 14 Jun 2024 20:03:28 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 45EI3StX2614599; Fri, 14 Jun 2024 20:03:28 +0200 Date: Fri, 14 Jun 2024 20:03:28 +0200 From: Jakub Jelinek To: Andreas Krebbel Cc: gcc-patches@gcc.gnu.org Subject: [committed] testsuite: Add -Wno-psabi to vshuf-mem.C test Message-ID: References: <20240610080631.189196-1-krebbel@linux.ibm.com> MIME-Version: 1.0 In-Reply-To: <20240610080631.189196-1-krebbel@linux.ibm.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-1.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org On Mon, Jun 10, 2024 at 10:06:31AM +0200, Andreas Krebbel wrote: > The current implementation assumes to always be invoked with register > operands. For memory operands we even have an instruction > though (vlrep). With the patch we try this first and only if it fails > force the input into a register and continue. > > vec_splats generation fails for single element 128bit types which are > allowed for vec_splat. This is something to sort out with another > patch I guess. > > Bootstrapped and regtested on IBM Z. Committed to mainline. Needs to > be committed to GCC 14 branch as well. The newly added test FAILs on i686-linux. On x86_64-linux make check-g++ RUNTESTFLAGS='--target_board=unix\{-m64,-m32/-msse2,-m32/-mno-sse/-mno-mmx\} dg-torture.exp=vshuf-mem.C' shows that as well. The problem is that without SSE2/MMX the vector is passed differently than normally and so GCC warns about that. -Wno-psabi is the usual way to shut it up. Also wonder about the // { dg-additional-options "-march=z14" { target s390*-*-* } } line, doesn't that mean the test will FAIL on all pre-z14 HW? Shouldn't it use some z14_runtime or similar effective target, or check in main (in that case copied over to g++.target/s390) whether z14 instructions can be actually used at runtime? Tested on x86_64-linux, committed to trunk as obvious. 2024-06-14 Jakub Jelinek * g++.dg/torture/vshuf-mem.C: Add -Wno-psabi to dg-options. Jakub --- gcc/testsuite/g++.dg/torture/vshuf-mem.C.jj 2024-06-14 19:45:09.116781920 +0200 +++ gcc/testsuite/g++.dg/torture/vshuf-mem.C 2024-06-14 19:56:08.744135867 +0200 @@ -1,4 +1,4 @@ -// { dg-options "-std=c++11" } +// { dg-options "-std=c++11 -Wno-psabi" } // { dg-do run } // { dg-additional-options "-march=z14" { target s390*-*-* } }