From patchwork Fri Jun 14 10:27:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Cohen X-Patchwork-Id: 1947746 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=VACtq5TE; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W0sqY0tqHz20X9 for ; Fri, 14 Jun 2024 18:28:25 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1CB8C388211C for ; Fri, 14 Jun 2024 08:28:23 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 91B423882126 for ; Fri, 14 Jun 2024 08:27:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 91B423882126 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 91B423882126 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718353649; cv=none; b=kmFKl1tDt5T/ww0884jctt0RyTEBk7ENUQPoUUbg5f8QtE1LGZh3xqaYnfsHUhtkECNp4lUW0J/noFuuIZen4ymP5nhAKSxsOy2ysXyjVbzW57IU08VO8EkljYjTxX5NvbzsxRBhXC9YUsFB3MkzPoiZnwUkJGtBHxdosFxNL2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718353649; c=relaxed/simple; bh=XH0zxYWN66wLfM+vXMHLiWiB2rCPf0JDf3CzHQs2z2o=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VbCQr7d7g1guYjMqPZMhRSpQzxZvxJuT9x+ojdXCXlNCpEQt9MWtJthfQlGHaIzw0jwioUha1ZI7HYp5ax5uFT1NlYJqhbtwEnDUKLBKmIOSmGoDPBec3VpKNBVE4CcaaqdT27xDU4PSUu8KptAzazGzkyrujuTgd62aE9VBFMs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-57cad452f8bso2008241a12.2 for ; Fri, 14 Jun 2024 01:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1718353645; x=1718958445; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OoF9zZ/ocHeoxWFZzdsZK87t3ZNs4Io6cN4hNBaZynI=; b=VACtq5TEX4w9vtTdAKUS3YNX1Mm51JtTCzlh1Qd3CuAV3ee6FYZIR4Yp7Rm1F2RivR 2tefSIfDY8jjFSLE/oO3aYih6t3Pe8ZHSW7qxbWzWREnLzdInvWO3rmVd8/BEO+BP/iY wP8f6B5x+UIKvdyTgd76vR3dl+TY7DpA/ufZRkSm+zLQFsAO7zh0SbgWNDYXYdS0TMr2 +IzpFdHXR3Sxua7cTdKG5kVTG19eMRhEIPTNqcFI804mn2IH+KfX4GeyeMEMVfu1e1sd XrGxfT8Xtfxk6reuWbrXag+iasFJ/kD35SaOh5Wp4viQrG5tUhD9H2zclMZgCb7/8Ub/ Zdlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718353645; x=1718958445; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OoF9zZ/ocHeoxWFZzdsZK87t3ZNs4Io6cN4hNBaZynI=; b=C6KJuqcnlLHgZAs+62RHFxwY4ByllJzvyfMUj7orpgcVCO3Ish0oFcm+rjlxlAY7Og ptqYH36uPzzYx1n/lUgQPzNqtVnKNj5XIY3wzpZ7t7oXbfzPsT/AhS8cVqU3eLqDqpul t7D0H4HTRaxDx4lEZ+aV/zyX14efBu5pC3p3YdG1rfwJfk6JAFPdSalTZDhhPOwKr1J+ SJigay6rM8TbSvAi+bVhMkOaD21s+YwU0P9T210c+tsYdZh9Eoqlnw/hjmc1+PFzIq5C CujKz+TrzLsrDiKETOI9jZk2fcSgYvUxPMnHIiNh6mIVaJItiVc1RtNla20zRxIMOg7Y RTWw== X-Gm-Message-State: AOJu0YxDiBPB66zSCS9a1c9+sZIBR9fBTM83OsgsiJTsAGqeu95hKWU6 06HjIhFB10NT5mOxkRnFIdV4KnA20T8ma6PVewgjdfxMMQA0YsZr7R1dW9coMxvrn9/b5sm47ks JaQ== X-Google-Smtp-Source: AGHT+IFsTY+o8QueeVhQ+UsKS5EytduGY35krUlIFruUgXO4MNoAwNJ/0VTAQFfrsDZmhDUWiwnHWA== X-Received: by 2002:a50:9e07:0:b0:57a:1b41:55fe with SMTP id 4fb4d7f45d1cf-57cbd652458mr1285936a12.6.1718353645402; Fri, 14 Jun 2024 01:27:25 -0700 (PDT) Received: from localhost.localdomain ([2a04:cec2:26:2e08:be74:f961:1e88:9892]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb7439855sm1936150a12.91.2024.06.14.01.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 01:27:25 -0700 (PDT) From: Arthur Cohen To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Arthur Cohen Subject: [PATCH] gccrs: configure.ac: Fix quoting around ldl/lpthread checks Date: Fri, 14 Jun 2024 12:27:02 +0200 Message-ID: <20240614102701.10712-2-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org ChangeLog: * configure.ac: Add quoting around both variable checks performed, which will fix the noise reported when libc contains both ldl and lpthread. A typo around `pthread_create` being typed `pthread_crate` is also fixed. * configure: Regenerate. --- configure | 10 +++++----- configure.ac | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/configure b/configure index a9ea5258f0f..46f00b476c5 100755 --- a/configure +++ b/configure @@ -8827,7 +8827,7 @@ fi -# Rust requires -ldl and -lpthread if you are using an old glibc that does not include them by +# Rust requires -ldl and -lpthread if you are using a libc which does not include them by # default, so we check for them here missing_rust_dynlibs=none @@ -8945,15 +8945,15 @@ if test "$ac_res" != no; then : fi -if test $ac_cv_search_dlopen = -ldl; then +if test "$ac_cv_search_dlopen" = -ldl; then CRAB1_LIBS="$CRAB1_LIBS -ldl" -elif test $ac_cv_search_dlopen = no; then +elif test "$ac_cv_search_dlopen" = no; then missing_rust_dynlibs="libdl" fi -if test $ac_cv_search_pthread_create = -lpthread; then +if test "$ac_cv_search_pthread_create" = -lpthread; then CRAB1_LIBS="$CRAB1_LIBS -lpthread" -elif test $ac_cv_search_pthread_crate = no; then +elif test "$ac_cv_search_pthread_create" = no; then missing_rust_dynlibs="$missing_rust_dynlibs, libpthread" fi diff --git a/configure.ac b/configure.ac index adb738ac346..0befcc01cd6 100644 --- a/configure.ac +++ b/configure.ac @@ -2036,7 +2036,7 @@ fi AC_SUBST(PICFLAG) -# Rust requires -ldl and -lpthread if you are using an old glibc that does not include them by +# Rust requires -ldl and -lpthread if you are using a libc which does not include them by # default, so we check for them here missing_rust_dynlibs=none @@ -2044,15 +2044,15 @@ missing_rust_dynlibs=none AC_SEARCH_LIBS([dlopen], [dl]) AC_SEARCH_LIBS([pthread_create], [pthread]) -if test $ac_cv_search_dlopen = -ldl; then +if test "$ac_cv_search_dlopen" = -ldl; then CRAB1_LIBS="$CRAB1_LIBS -ldl" -elif test $ac_cv_search_dlopen = no; then +elif test "$ac_cv_search_dlopen" = no; then missing_rust_dynlibs="libdl" fi -if test $ac_cv_search_pthread_create = -lpthread; then +if test "$ac_cv_search_pthread_create" = -lpthread; then CRAB1_LIBS="$CRAB1_LIBS -lpthread" -elif test $ac_cv_search_pthread_crate = no; then +elif test "$ac_cv_search_pthread_create" = no; then missing_rust_dynlibs="$missing_rust_dynlibs, libpthread" fi