From patchwork Mon Jun 10 12:54:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Naveen Yerramneni X-Patchwork-Id: 1945858 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=proofpoint20171006 header.b=zi+ZvmAQ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=selector1 header.b=KzhxQJwW; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VyWwb1KQwz20Tk for ; Mon, 10 Jun 2024 22:54:38 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2B3EA4066A; Mon, 10 Jun 2024 12:54:37 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id zGcYTKYny-0z; Mon, 10 Jun 2024 12:54:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7B3AF40324 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=proofpoint20171006 header.b=zi+ZvmAQ; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=selector1 header.b=KzhxQJwW Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 7B3AF40324; Mon, 10 Jun 2024 12:54:35 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 559D8C0012; Mon, 10 Jun 2024 12:54:35 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 91C58C0011 for ; Mon, 10 Jun 2024 12:54:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 812D981A6F for ; Mon, 10 Jun 2024 12:54:33 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id DFVrPj0bSu-r for ; Mon, 10 Jun 2024 12:54:32 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.155.12; helo=mx0b-002c1b01.pphosted.com; envelope-from=naveen.yerramneni@nutanix.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 8FE2C819F8 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=nutanix.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8FE2C819F8 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=proofpoint20171006 header.b=zi+ZvmAQ; dkim=pass (2048-bit key, unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=selector1 header.b=KzhxQJwW Received: from mx0b-002c1b01.pphosted.com (mx0b-002c1b01.pphosted.com [148.163.155.12]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8FE2C819F8 for ; Mon, 10 Jun 2024 12:54:32 +0000 (UTC) Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45ABTmG7009596 for ; Mon, 10 Jun 2024 05:54:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=proofpoint20171006; bh=V2d44qhxSSqrf Wrv9Ecl8T4ycHP10AssArmRgrC/1Ok=; b=zi+ZvmAQ9/yMufufGcNmJ25kq+4lS GBuGjwI0CBCAHblDf4NLLV8bqNlaZqajtH2p9HxGrGvnyR3Tcz7iLMlOwwu/y0O8 ptWz5fLr+iTMmpqdehtnaK6mVamFuTRom6gksyfQxCAdOFTb+WlONow73PduDO55 3I6VKRs9Yp178iounRIcUwSAk7MD8cp9bRirycC5AH3BNkhvR2da7vUnHFUXwGPE ghIBjtdmVmZUXcCtUMzpG/XxR4i9fItti33oETI25q99HiI1yZ0ox4FiUKnVqOXn X6e0rWEtVaHIvDUJXDMWNyGQKyjtX7mqpfesH9Uim5ompDS5o4HYJl0uw== Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2040.outbound.protection.outlook.com [104.47.51.40]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 3ymmu6k92m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Jun 2024 05:54:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OCXhoCnrKHCW974G/HULOna6oTYWz9cSJM4OTqKM+eAGZER3ECLbjmfz8FNJdY+0vhgRG6LnIDTuUGySyDhLr9rqYMbwySa44OjBS+1Avtz1EsskVXf5qgA1CLKTT1Cr/P8MGDRIMH9EP4l6iEhUjVYBm0RhCip7tuQzjiTb28qOFeoULTP4syVqchrJD+V1jYASzqJMvXNpCk2B5GrtIuTRKqiXJhfXeFed/bMIGhnawfFLP+Yvbi9Fhqrev3x73j1yVDvwfCeMSSr5fu7aC0f+2y4Fq5vdiUwwoKd6ldfS503qJkpx6HqSypVK20odzyxXnSvpf8hCDhrHS0ZJ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V2d44qhxSSqrfWrv9Ecl8T4ycHP10AssArmRgrC/1Ok=; b=fqbtyqVZg3SNxsCAj5PKtlKIFqW56wrKp3GK8Ps2cOox9zYBLlsZ/1+EVMjzBkVm94ojd3DYZYtipXT+Q9o0e+gV+CpzZN6qmxiVXt5vrNMmUFM/Xy6XT/f0+Sx48dybewRGWyDOr/URmmV+139Vr12mooQyAxukn7kmQaYMyQBPncUrHGW0jyA4qJbE2cXu1UqULTcoP0IvoSZKGPr/aAPlk5Vy/QK7OJPeAHjvZlQ35YY/Vaa5HIYJ5a5l3mKawGQ53v/KVtIDYuWJc65M1U2A4eL/DaR9eQekFR9YI7kR1XxN30kjFXpE2Z7pXccxmjTdDjMN4OCYgxDV/PCeyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V2d44qhxSSqrfWrv9Ecl8T4ycHP10AssArmRgrC/1Ok=; b=KzhxQJwWQqnrJObokHFGS1pBiQCW91n0E8+5D22wOH4juAwQui4f+VfBCCiU28p4jPYwcfaFoDVZqXKqgPVO69fCDp8TUVuHGxYKPoRtB+yN8cLH0+6NR0aUI/fcPmERZFFzQbk/pdhBYYxHUi1lM4hhXtUsFPMwTvP9uEZ666RwsnSqtQxgq0FOKiwgf1UYJdednU0M1Js88XX9zzmiYFwq0waQlhZujSvRIkJmCf8SGPB4P0WuYfVznaslFG7QPXK8sVKaeuOCC6BIIin+SWvZFivXN3cNofFNr4x2PQJAW8EHrCsKR2wILVbySxiN/SUypqsqm+8TerQCrgO62w== Received: from SJ0PR02MB7808.namprd02.prod.outlook.com (2603:10b6:a03:326::16) by DS0PR02MB10289.namprd02.prod.outlook.com (2603:10b6:8:1a1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.36; Mon, 10 Jun 2024 12:54:29 +0000 Received: from SJ0PR02MB7808.namprd02.prod.outlook.com ([fe80::c879:5909:29d3:9770]) by SJ0PR02MB7808.namprd02.prod.outlook.com ([fe80::c879:5909:29d3:9770%2]) with mapi id 15.20.7633.036; Mon, 10 Jun 2024 12:54:28 +0000 From: Naveen Yerramneni To: dev@openvswitch.org Date: Mon, 10 Jun 2024 12:54:21 +0000 Message-Id: <20240610125421.23461-1-naveen.yerramneni@nutanix.com> X-Mailer: git-send-email 2.36.6 X-ClientProxiedBy: BY5PR04CA0028.namprd04.prod.outlook.com (2603:10b6:a03:1d0::38) To SJ0PR02MB7808.namprd02.prod.outlook.com (2603:10b6:a03:326::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR02MB7808:EE_|DS0PR02MB10289:EE_ X-MS-Office365-Filtering-Correlation-Id: 02dafbf2-4b5d-406a-ad14-08dc894c771d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|52116005|366007|376005|38350700005; X-Microsoft-Antispam-Message-Info: kfikbG3KaK9hNsx33FQSSEOn51O3QNfsIZXF3oUEXK+SK+4o4PekuWIQ6IpNCbsCpdFcwkZt7arhGPrJn38wrrQN3IF5DJFVbCdq8z3R4e2oBsur3vOj4bXXzdDk5UrDdYiNumXVigAiXWFMqkpe4cX9dMUqdnCI9uduD6093hr4xChOWAyxo8bb5dRWMGTVjayrtkqDzzhsrRWOA3cTrzpevwHdItV8H2hV3p8bmFGdxGFneLUrxGkTlNAVMExczcQoYWHa/YrS+Z2k7nuciSqzhtw5b66+DN/mMlt0NuyZP64+TrnDzWwvGUJ3LSFNs+c/h7Ak9xctf8gWGEoF2idr5stnlmhr9lk3DqVN9gpOabYe4bsAdT5L4XiaancJH24mlevfUwT/hn7S+fcfREa7QLtASngQ2CUoAyYT5oK2gYSmGOsTCS/Oz6tCo3RIU6mopxsXzIkcD0gN3WIwRxJCApwemMmYFuyWl64C7qBHBi/BcXNhzojTEVcU/a8NIETUSgYbQunZGjpJwwj2+CuXeH9706Y7pcGFBFGmns86wXhkk+VTZxTYwTXJMKT506lyfPXEG9QqCCq1cplc2Z4nCVQ6KY4N+bxp+fcqq8YvbmFoBFBl5mMsUzd3uyxQML9bxh9Eu5ONEzbjF0vkmL2t0SjeN0YtkmQiiWX4zviNMAMpByZdW0q3EeMWx1/1hD9Ua5sq+sxj+EwYQl2qe+H9/VnPbs7OwnUreHdDw7eWMUTt2BvV/jcsWnkQA+6g50qDjGZeY1F6cdxUl46vwFVNfpSQIECv3kTM1tmDQrWrUCzzjPBThOytH1JeNagQ2EFqGJWo+m8fHi/AVZTPO/M26J/guo8C6vKRsWkOcyTXjPb4cn2qODiuPSrLRbjjaP0DiOgceC9RsLuSG/BtQpErmgPDyuK/gvC5rrO6PV6WS3zPBgOjROvvAocrWRONLlvJcV0gIsX3ufuQDP3g0B4h1hOu/WJ4thfVqeMVOHmwM7xx6L7vowcyzwLpGkTm/ibAkpzGaMYkY6Q7yuDUJnSzisptuhq9ipU+KSNJjPsqS3V5ErMa22G/qydweNXOsrm/Rb9qI+cgrW/GNeieDe79aWlEa73Xog55cBsko7n2U1p6Da8vihZSfhDWcCcJO+h/XsI2Nx98dn66yjlsRJ0InvMs0vSFUg3ErmAl3N49nDgNLcwpZuHz+1XodSOnNKjR2VC8lhT9f6zh3fJdZrPVc2aq7dll+WMo85RcqRH/uMV98zQLH8ZGDYxaPvRQ2IAwC3ArspCU3DCTUAApEBxktN/fUupt/ifLAFCrP0UDnz29xP5eqiiDAHqqydGdtDMgXlTrlTVd2iMIf4IqTAjD2E/n49WzF/Gx4M+HiSM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR02MB7808.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(366007)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 75O4UzKFVoQCOoIztap0PoBIeR9V74RfeVc3UUQdWZ4eQRpB4RIAse6emOph4HDdi4SvCT1sjESLtVEHdjQsSWo4L0LfJ6pyKzhoB2FzAVnSA9WzrgqnHthpKv/ci+4n4Bgr7Sdw5+yiUCiX+aMlUdgggcJWq8/eduuBJ0YrwLz3yppbUJjjDtEXEoEG3mQBt8VUrba4t3Wbb/9bG/IqNZi36hyGO6VGhn8IAQ6viIgoX5kBDQjd/+uJ00NgG6cGVYVt88IlaZDsSjOi1BvndVDT9IgsJLP+EUAYvxQZY+b4NXOlmai+X6+EU7hnDUNtauZcN6hY22lqUtDzpwkTIZkkj+UW0BZJQ2CJEAqSuCJtE0j5/IGPyXYP9AywbTkhywwh1lWCsZ0ERryUAbZmqe+5JWqI1fuxR0bRBKGgZiFDV60XC6YVGgzsxlXaA/2BrzBORbFLpi7Fs8EHak1R6BFwKXoL0nwVYryV2u5gKe7XMY2vcTAg+7ie8cfLYSdfQU50YiH0Hg2E7q/60t+K+CyTJZV3z8z9RF1DNsQYnMca0ENAqrgj1Yv1aWYm11eFvYeuKQuEyNwfm7tABmN7MXocy8XLfDX0wW5gpy99t4W7DwyIEpDsdqM0VVUaovah34JaUmq0U2jAeV0eSP+goEPp3I0mD+tpn/VM1RFAU/2W/XURAkFmcVTZfKSpcT1D33MRnDr826QsEerGxrM7B996gZbUeLDsyuK+NZOpnixK7oCeNAKRFk9EOiHgRyQUHRmMcTjhep5ZTxNSJqOANHcLJ1+I0psG5zof/8feiR2GwplxMjlmTEyNpPY01CxPZuH++kz80P3H5SQmnlLSeN1WhZs2LiDhYhWRd4XtTJsAglIp4JUxtkvN2z2omBcVGyYWd1PxohergFMVM1m5G0XzBXgBqcU5mO9yA7IJIwUtbqkERMspG2PH9faSpomFQe9PfpVGJj2WtcotTCyT0gnZdk1U9U6s2E306uuCWzcFowmS0klzwd8VOx+yBjB1cogAEKU9PFFl7AfW9WsWubpXpe7NlV5Ut/Hn12TVJUb86nuAL6ycWyeq6DYtLtZpuZv0jiIK2nrO0N9aoOzpGEcRtFRy8f8ho1sFZIWp5YhOcokKrLGHdNoB113PK3gNTtY9OMHjfjHNwTkdMGaAzlrs56YNLM2ydRaM9V2SSuOsyWvqWWhvu08lYzbunv3xYuvwg8Sy8Vu8ehHhhacoI+0rGMJ4ATbahX/gDqruyXSnJpkuTcRosqvlMTX6GBKyz9uI+ukqBdng+rAeD8lfdCEHj8gGKLPX0ye9IoBG4voh+vHjflcOpeSQMXFpafoDV/LdhJ1FhPxgOxLj7H0Qv7773lW+N7sYFfeK+aP+024ntiofpdm8p+Nd4itdADfW7CIWlVM2czSdoWJV79ji4LuM6DkcHTPq4qYDbK2fhiTqw/YRBfZr+8RGkBwyJ0T0VQmTHFOuWpnlGtCSZcBAf3diCS2U9sxjo+089fEcbuCUF36ND8+XsKYaAwN+5XUgAa6h5iTPICnj4XA72DBiVDlYRMgC2w8f8CLHdaZbixbChRDCmVT4umykwZHfuTP7h9g2eQsV2xeTye+5DAJxVLq3dxyd4kM4W54DdTFpja0= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02dafbf2-4b5d-406a-ad14-08dc894c771d X-MS-Exchange-CrossTenant-AuthSource: SJ0PR02MB7808.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2024 12:54:28.9376 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dzEC6ZwLiBZalF8XPgniw1AyKO6qzGMVIDwoBv19i1pbd+1yJ9981fpmNqmE5ThL2FKx/6eqtkSv7gWLioOZKE5PKe0fM48Ys3l3fISA28g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10289 X-Proofpoint-ORIG-GUID: D8iyjbAswCNzvrgpIro8t8ODF1LWLaqn X-Proofpoint-GUID: D8iyjbAswCNzvrgpIro8t8ODF1LWLaqn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-10_02,2024-06-10_01,2024-05-17_01 X-Proofpoint-Spam-Reason: safe Subject: [ovs-dev] [PATCH ovn v1] controller: Fix issue with ct_commit encode. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Action length is getting set incorrectly during ct_commit encode due to which ct action is getting skipped during phsycial flows creation. This issue is noticed only if ct_commit is prefixed with other actions. logical flow: reg8[17] = 1; ct_commit { ct_mark.blocked = 1; }; without fix: encodes as set_field:0x2000000000000/0x2000000000000->xreg4 with fix: encodes as set_field:0x2000000000000/0x2000000000000->xreg4,ct(commit,zone=NXM_NX_REG13[0..15],exec(set_field:0x1/0x1->ct_mark)) Signed-off-by: Naveen Yerramneni --- v1: - Addressed review comments from Ales. --- lib/actions.c | 3 +++ tests/ovn.at | 3 +++ 2 files changed, 6 insertions(+) diff --git a/lib/actions.c b/lib/actions.c index 361d55009..794d2e916 100644 --- a/lib/actions.c +++ b/lib/actions.c @@ -760,6 +760,8 @@ encode_CT_COMMIT_V2(const struct ovnact_nest *on, const struct ovnact_encode_params *ep OVS_UNUSED, struct ofpbuf *ofpacts) { + size_t ct_offset = ofpacts->size; + ofpbuf_pull(ofpacts, ct_offset); struct ofpact_conntrack *ct = ofpact_put_CT(ofpacts); ct->flags = NX_CT_F_COMMIT; ct->recirc_table = NX_CT_RECIRC_NONE; @@ -791,6 +793,7 @@ encode_CT_COMMIT_V2(const struct ovnact_nest *on, ofpacts->header = ofpbuf_push_uninit(ofpacts, set_field_offset); ct = ofpacts->header; ofpact_finish(ofpacts, &ct->ofpact); + ofpbuf_push_uninit(ofpacts, ct_offset); } static void diff --git a/tests/ovn.at b/tests/ovn.at index dc6aafd53..d4f62f487 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -1315,6 +1315,9 @@ ct_commit { ct_label=0x181716151413121110090807060504030201; }; 141-bit constant is not compatible with 128-bit field ct_label. ct_commit { ip4.dst = 192.168.0.1; }; Field ip4.dst is not modifiable. +reg8[[17]] = 1; ct_commit { ct_mark.blocked = 1; }; + encodes as set_field:0x2000000000000/0x2000000000000->xreg4,ct(commit,zone=NXM_NX_REG13[[0..15]],exec(set_field:0x1/0x1->ct_mark)) + has prereqs ip # Legact ct_commit_v1 action. ct_commit();