From patchwork Mon May 27 18:24:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shibir Basak X-Patchwork-Id: 1940069 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=proofpoint20171006 header.b=wA977g8v; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=selector1 header.b=pF6sIJdx; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vp3wW57BHz20KL for ; Tue, 28 May 2024 04:25:13 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id ED82B81819; Mon, 27 May 2024 18:25:09 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id d0KDolc2KHmc; Mon, 27 May 2024 18:25:08 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8FA1F80EA3 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=proofpoint20171006 header.b=wA977g8v; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=nutanix.com header.i=@nutanix.com header.a=rsa-sha256 header.s=selector1 header.b=pF6sIJdx Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8FA1F80EA3; Mon, 27 May 2024 18:25:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 705C1C0072; Mon, 27 May 2024 18:25:08 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 98002C0037 for ; Mon, 27 May 2024 18:25:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 6149F80F04 for ; Mon, 27 May 2024 18:25:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id CIlyhrNQExs4 for ; Mon, 27 May 2024 18:25:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=148.163.151.68; helo=mx0a-002c1b01.pphosted.com; envelope-from=shibir.basak@nutanix.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org B1D6C80EA3 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=nutanix.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B1D6C80EA3 Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) by smtp1.osuosl.org (Postfix) with ESMTPS id B1D6C80EA3 for ; Mon, 27 May 2024 18:25:05 +0000 (UTC) Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 44RE8sWs020945 for ; Mon, 27 May 2024 11:25:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=proofpoint20171006; bh=eyTz1Uoo/MtFN yvjHbBisXgENn7oQK29Mf/itCrZngA=; b=wA977g8vtKHCWxE30SD5XF+DslLRb 2xVme+piI1eovA2u/k27ecaVt3Y9BnMtPWjOp0Gm6LzUXWlvJfdXb6/YokOJltZr TcHIkD75Ebu64ae8wIPtf8Ryg4HdckH8Eu2D8RvAaOx+B27Vu1T4cPE2pPDvtiZV ggPjS2bAaDfjIdbQiJNr6BdUHsvSoyKaUIeq4ubPptnGGwDM+KtW1QAbbjG+vpsC WAiIbNxMyJST9U//FD/esEvdMSdHEIyFtFASktJmA80vbnTDdt2nbINkZxSkv8Q/ qaIwjgahl9jzudSXPE1EQYIXU4tuGVc3YgpYs3tOInfjAyrMIE58RuXRw== Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 3ycup50buw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 27 May 2024 11:25:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PcEGd/1DRBCuOxA+jCgRE+DGl3ywrJ6t2VlEFWvsGGI9J+upC71x7C1d0v+BJJh0+m2tSbQvWqDq8jK4NFr/6W0/5W0L5crxQSoZq4Dajher7tvdOJOAB+zHhJq2qWr+pDj0PitX8acIsk5iCrcAXuAER0kn1ViXHZjtqikBWO79tDlRo1y/JRsEfErT6hXlwlTNWuEKml46hYymlax0ULBJl4Ql0z7rHtfj4f4a33YkCt2zTGU9s6lqP8DyTQl/iN+uch54RRKQti7qd3aMtqpQZjFidPj1AgltVmcuRgMvUH62HKVaubfA6xF6N+wkolke6hRXlvvhNJH6H+AtQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eyTz1Uoo/MtFNyvjHbBisXgENn7oQK29Mf/itCrZngA=; b=Asg3Uwryj01XyHAHVvy7JvMQg61NcxFP2lXvdGBKzFxcZ7osDaYarbl0el24F5H4o8YcMuAHZ+zRS531nevNyT32F1Me8VKHwVt2Ce18ZDSIf61BH1ZLdY/mtubhYD7dHU3IgrLFSzeTY9ulbjIJ6AJJJAbS9/t8uRD9viuf/GQ0GS79HQy4E6zIiM30oC91+crSv3dELG9lP0YK+hetxxUwV8kgy4SxhQiKPbpBpUlGQJ7au/1FZ+jnHVaJ119dDQmKym96/wUKCm7HcO5kpU3m0OyVPIhYwKAzAPRMPwLqxeZtIWwGnUJej6AYP3unRZBJ23uYXypplFrZWaDjVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eyTz1Uoo/MtFNyvjHbBisXgENn7oQK29Mf/itCrZngA=; b=pF6sIJdx6Bgf1SOpV7Zwx6TuixPYO98tHmQIS70qHD8qIdjUNEk/cE7cKfrCfnSJ6zvx00TjOKSfc1topM1JBJ8QPQC2jh17qjJHHYQ9I9OIGZ8u96RLAkjuYuElRQ3v+h4W4rUborqL3lw8kcQZidfY9vo9qIZNRwUokkDf4uIRahFgaDbs2Gm8r7M4gqezBiL5npcNm4sd2CCguEttJtL0OgkyWcGmO+/11noKzZLQkRvUZoXf2FFjaqGUEOTbERKdYVSNjJliMaaEosAtY9ZEE9guiH4axkNvmU847ZEEDh/YMBvLmgEIXnEYRocmQJYYGwsv/YRjSeMMhun6Sw== Received: from DM6PR02MB5529.namprd02.prod.outlook.com (2603:10b6:5:30::11) by SA3PR02MB9996.namprd02.prod.outlook.com (2603:10b6:806:37d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 18:25:01 +0000 Received: from DM6PR02MB5529.namprd02.prod.outlook.com ([fe80::baa7:c095:e8a8:5c0c]) by DM6PR02MB5529.namprd02.prod.outlook.com ([fe80::baa7:c095:e8a8:5c0c%4]) with mapi id 15.20.7611.030; Mon, 27 May 2024 18:25:01 +0000 From: Shibir Basak To: dev@openvswitch.org Date: Mon, 27 May 2024 18:24:45 +0000 Message-Id: <20240527182445.233431-1-shibir.basak@nutanix.com> X-Mailer: git-send-email 2.22.3 X-ClientProxiedBy: SJ0PR03CA0183.namprd03.prod.outlook.com (2603:10b6:a03:2ef::8) To DM6PR02MB5529.namprd02.prod.outlook.com (2603:10b6:5:30::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR02MB5529:EE_|SA3PR02MB9996:EE_ X-MS-Office365-Filtering-Correlation-Id: c55ef4a2-6264-4cbb-ac00-08dc7e7a5205 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|52116005|1800799015|376005|366007|38350700005; X-Microsoft-Antispam-Message-Info: vMNKmj1zzYaZCYCxkNwP+RHBXucS/eyJu4ceGlF3QZAkCu1aqEKxqHETzzQJPrQTy48N1drPBncRljJoe3bMUFPe8QHKq6ZmCPJerW9gLTBwFHuV3KrviaIvdGgnA9ewmss125AMsg5e9gPjof/EisuSWOn01SKgt+7/jWBhBbDWJ02d0E0Bx+zuyKPd8h4LjRIug1JcdQF2WdpnOzR9ZOGFIGyx8xrbGDsF/twozGC2bfxVfG2AnG2Fx98v6SkbZzPttjBXRJ37eePrW5ydekFJppamwvDo+f4hizkEBf6FsQshZjmXeZcto/FB0rMSqchf72TMkQ4GyJohqd+2MzPHDR0EBUKRpVUTDTBAu8dmjH2FgCj0jFVhvZ+E197XmsQCxKm9CrBR9jIgy6X7f7oVZPaxwpAaI560NZjquz1X1SGkkd1CnAv/jhI9qUS3w2SquuUla1/i5L6myWzuHExBnTFaE3XKRajRd+XJcZgCxLLVPoGWvth5EO6+gKDZj+i6oBj6Dial8os3809YtRNjp/9QyC8AvqSz2zGqzxdDNPzWXd3bmSk8OHnFD8432/u7/Wh+P8d7VPL0i6Nl+W+1gVdU+tKsigijYAAmXsq6pymINdTtXlOp2NCIgMtl+J2BOUgC6xiJQOZWzM2n27d9whtwV+n4bNrw3HRbKsYTNCvaCbxycjGZPQaRpI/6+Uo8vR48nGu8ZVt++Vm3H0FzIAfrtyrw6cpMJ3o80AS7A2gdVEv6qgOohm0+L9CGOupVJDXK5KsMGo7//CW8mQ/79JnqZjfEf417dB3MJ/4lWpN4jPEsNBhS+AngxX96+QgOdGdUt6IFkzsdiZUCUROphlLsfWkDHRIbeGEAqL2keJKsheZdl/XJfDo4JcuiBTUGn6Y8jye0S8GVziuCv+Oe11TryCPAXXDLHwCkasyPr2jhDemIcx7j9LlxyZB+j8ayURdcSzAZHV+PsQPe9aN4O4kaWIJDSRML8XnOiQEZnE4+7qgZct+E2oHXPZvgC52DrkDJpvYUHxeIpMzpmY4XaQcOwdRGyg7IySZ7tq5+GEwawbkH6TQgP52P2kpbZLAd0S5owJxoZzGUupDn8lSiSKdbMA+r6B4vwMSsNymNCeIqTxUMWq98xc6ylVseK1shn2wGEvGzc7DW5E+jMjltVTvL3y3N6ZvoOLA5NpaabNq7IqrDhVwcGA8WuyKSCUNM3rCAE5Q5UPKTokdRGiYi0zPTbmo0gm3K9Hs07/WEMyq+arW1q8+Pw65XuxFILfP44xWDdk+w6ZfrqnoNrvXOq1zpf14d5eV9H3NlV+WXwGtXJdGUHF80n+f6mvjcmxqAI4GcPT3fk3tajcuvyw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR02MB5529.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(52116005)(1800799015)(376005)(366007)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: K1NjoXk+fBEljqxYHRfDofgnDwxpVZPA+h4D6ALt740aJMiZxg0I9zsH4tj1jWVnfVXlAxclZZwX/7NVSAdnuEbkbb1L9DxTEG0tUhczfgxAaoIe2bhjB4s6F4HOdZNkRBCu/FNU5PXn9Xr3W/EQlUSbvFXQM6nBEuYXAZeoO6PTyKbwEJcb4hKb3I+2w/8jgTOwoHu1I4bTRWWQEfXFamPOxDZYv2Znw8WcyD4xN0pVodVVfmSq++uTUNFqr2oe7dUqqOcwS5bArh777NouMeqdnFKdrT3JGotfTuWNM09+74XTggffgkGMhzaYB/5gXiwlD4gxBUAxmOs0IdTX07A0E8cVGYIMHroIJyc5L3Nc9DAtnbSBXmZZjEM23kXwYSP+ixd/x04tdkWwLrm/x4NaivqSYmViqvqP/n1iAqsvMEw+eT6tD8xZ+w4NsFooR1vz1i2tzG0bEqCbqJtEjR6r0thfZtKqYZVGOShLHQmDj1ZKmNHEWpUa2qESLFLwiS4hizDrA1ud3Br5hWakAmH46l/BlydDpDO2Oq72Y9weUPpsejV0zxCNGcEVgbX4V6vnzJlXm5CsptvXGdb37vOycswY0iLDmWUtz/P6vOEeifR/h402g7v+NKZ6LvHht+9QXn7Vma45saTHdbXOaD1220zSrLKwX5wIgyVakfHBSNDsjlwnzifgX6MR17iZcF7INIcLilaou25NsiszE7KPE+ml4mAOMEICTS4C95kv2Wk24Xg5Ra2VX9oI4Jbpbe2DvZn+1g0mVHV8NP/MaUyCSJ5JieONfc/OvEYCf0KB+3k9Lh/NLiNVpDJo5fu/+tB007er9cE9AvgN0kFp3EkNx7ms2sAxaoXc5ZxdBuTOEfEp7uQdmbteCvK9huCE8BB8vIlDyet6XKXUEjNfPcHXJTFUDps3ZyaruEx7zfI15jiGhUuiMeKLoNHdqvb0qsFyKjuseZ+uf+wSuqb20bhwwjt50K6g1BpVbAhCaMrMezYRbyAqlKZifEAJGUuKVXbD7pLK4uFxa2mAPWWHnuRxmPUZ8xh2f7mlHa2mOKb6C8sV9GCeoNKXbhp/vcnW9C/mxMoaEHYa356XrZqpW0ikfY1tDkj8GsfiUL7aeTiHLlQJbmX7pyzw8u2ZTurI0prNHob2m8nUkjRt0eEiobKgd4H0tGAPsatrhfzgk3etVEBc1l4CZkqd8wWS74tW78xJRt9RKv0KfAIt4dgnlMAoJsEDGpa45wlaSD0Aeyn2E0yEfRvysBFnHUS4pny78V4RMKjL+3KdbHyetgTqWkceoVZ2lUg2twgSu2nmDprFjs+XVlpvU6FmgFdDL1cP+ERtegHEKdMvhCGhKJG7dYBk1iqUY/d9ZW71lehifGz3+1oJdDdBGjG67srpYZJppbKTQOc+ivXov2+4lfkpJ0hq4FBRriUBcriQTNT3JE4KsjQSfQ9Ew+8lxWjjKqIDm6PaTPU69TQBYlUexcSIfa8tRDHcTn+8paEWP4SITmXT1B9TTk2F+hk85VGUV8tOUwujrgnC9UZmNzRtoTpWBbTZF9hN9arYt6qacNRRTWHRibxI5nvIoqpXfPE+oioBiilNBIayZ6alKn9vy0FOxw== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c55ef4a2-6264-4cbb-ac00-08dc7e7a5205 X-MS-Exchange-CrossTenant-AuthSource: DM6PR02MB5529.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 18:25:00.7985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YHbO5MZq2EI2FIR72afHyug6Eff2TzqqlxDSJe8efwfhR0vaKegF4VTBxajRav2YyFcp+n9lJ7CIPG4EtCJ8f348jn6zC6BrExLeBjIvMos= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR02MB9996 X-Proofpoint-GUID: PEBsLC7rQ7s5jR_-qSVToAzRWXxeUI95 X-Proofpoint-ORIG-GUID: PEBsLC7rQ7s5jR_-qSVToAzRWXxeUI95 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16 definitions=2024-05-27_04,2024-05-27_01,2024-05-17_01 X-Proofpoint-Spam-Reason: safe Cc: Shibir Basak Subject: [ovs-dev] [PATCH ovn] controller: Send RARP/GARP for VIF post link state is up. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Currently, GARP/RARP broadcast is sent for VIFs (part of logical switch with localnet port) after iface-id is set. This fix is to avoid packet loss during migration if iface-id is set even before the VM migration is completed. Signed-off-by: Shibir Basak Acked-by: Naveen Yerramneni Signed-off-by: Shibir Basak Acked-by: Naveen Yerramneni Acked-by: Mark Michelson Acked-by: Mark Michelson --- controller/ovn-controller.c | 1 + controller/pinctrl.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c index 6b38f113d..982378a50 100644 --- a/controller/ovn-controller.c +++ b/controller/ovn-controller.c @@ -1128,6 +1128,7 @@ ctrl_register_ovs_idl(struct ovsdb_idl *ovs_idl) ovsdb_idl_add_table(ovs_idl, &ovsrec_table_queue); ovsdb_idl_add_column(ovs_idl, &ovsrec_queue_col_other_config); ovsdb_idl_add_column(ovs_idl, &ovsrec_queue_col_external_ids); + ovsdb_idl_add_column(ovs_idl, &ovsrec_interface_col_link_state); chassis_register_ovs_idl(ovs_idl); encaps_register_ovs_idl(ovs_idl); diff --git a/controller/pinctrl.c b/controller/pinctrl.c index 6a2c3dc68..b5d3162b8 100644 --- a/controller/pinctrl.c +++ b/controller/pinctrl.c @@ -6375,6 +6375,10 @@ get_localnet_vifs_l3gwports( if (!pb || pb->chassis != chassis) { continue; } + if (!iface_rec->link_state || + strcmp(iface_rec->link_state, "up")) { + continue; + } struct local_datapath *ld = get_local_datapath(local_datapaths, pb->datapath->tunnel_key);