From patchwork Mon May 27 14:42:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 1939970 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vnz0v5s60z20ds for ; Tue, 28 May 2024 00:43:43 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1sBbZY-0004Gs-4l; Mon, 27 May 2024 14:43:36 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1sBbZW-0004Gi-28 for kernel-team@lists.ubuntu.com; Mon, 27 May 2024 14:43:34 +0000 Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 516B53F2B7 for ; Mon, 27 May 2024 14:43:33 +0000 (UTC) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2bf5bb360baso3511349a91.1 for ; Mon, 27 May 2024 07:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716821012; x=1717425812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KEnqH+k2BrFYSnCBXB41ESAZXBAOk6tKMM7isDvN5WY=; b=qAN10It6fDWuS3KGvb68Y4BBIAhkf/Qbb2+Zvl9DYz4el3blAFShlgFmYupPtSiL18 rnHahRxJM1DMGXHCI6PBEH1CSme4ZmaX59FXZosqQoHy9zUzXqm61lDREtVP7m10mpqc pjRqE/l7Hh5nGz1Jh2jCQor7YrUNy+EXLLG3vTd2pcog9yD6p7o5JW2Er/LFKujYY9d2 bpY83zZDcVBvfFg7eK9HSMBR2pzbzzlchsEAQS3Qh89b/i4bWhYQTWJjhqsyVxH96bsy U4KbZmg57lFoqCBqOs1cJW32MZ+Jr+EuNOzYCU3C8vpHSq08K4/48czzYVgZFggMkFaf VFZg== X-Gm-Message-State: AOJu0YwvF4nmAA3K0FwhJ6D49/hee3VnFMu/Z6jWp3mDI2GtJwJ/RVpI 2j8fIk3yFZUYSh0y3pVlG9CPmEdud9UaLisqTiZA8XhsObmcMAUtqVG73U/p76edX3U91XAZ3JJ R+6H/NSIpKbQjPinmGAxfaK/RSS93YMQGNmqQhOux4eJ1yeWj/phZ0qYbfYxYpVdDV+RFHMn1WC 8MV5kl+wiswQ== X-Received: by 2002:a17:902:d4c8:b0:1f3:590:71d9 with SMTP id d9443c01a7336-1f4486b5a59mr111935075ad.2.1716821011804; Mon, 27 May 2024 07:43:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaWf/sNaYihWzvbCs8DoKXxU4lXuExnLdfK2s9GT8eY8LnymHz4m8EwCBkN8oER5xnUq3juA== X-Received: by 2002:a17:902:d4c8:b0:1f3:590:71d9 with SMTP id d9443c01a7336-1f4486b5a59mr111934815ad.2.1716821011342; Mon, 27 May 2024 07:43:31 -0700 (PDT) Received: from zoe.localdomain ([2001:f74:8f00:c00:6aff::1001]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f48bb6163asm26520675ad.37.2024.05.27.07.43.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 07:43:31 -0700 (PDT) From: Masahiro Yamada To: kernel-team@lists.ubuntu.com Subject: [SRU Noble/Oracular PATCH 1/1] Revert "UBUNTU: SAUCE: selftests: net: fix "from" match test in fib_rule_tests.sh" Date: Mon, 27 May 2024 23:42:52 +0900 Message-Id: <20240527144252.2033315-2-masahiro.yamada@canonical.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240527144252.2033315-1-masahiro.yamada@canonical.com> References: <20240527144252.2033315-1-masahiro.yamada@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" The commit in question dates back to 2019 and still persists in the Noble kernels. It has been unnecessary since the upstream kernel applied a similar fix, d1abf388604f ("selftests: fib_rule_tests: enable forwarding before ipv4 from/iif test"). Now, it is causing an issue with this kselftest: $ linux/tools/testing/selftests/net$ sudo ./fib_rule_tests.sh Cannot open network namespace "testns": No such file or directory The reason for the failure is obvious; there is no such a namespace since the upstream commit 6c0ee7b4d69d ("selftests/net: convert fib_rule_tests.sh to run it in unique namespace"). In our SRU cycles, net:fib_rule_tests.sh in ubuntu_kselftests_net fails across all Noble kernels: 11238 20:50:51 DEBUG| [stdout] # Cannot open network namespace "testns": No such file or directory Reverting the outdated commit fixes this failure. BugLink: https://bugs.launchpad.net/bugs/2066332 Signed-off-by: Masahiro Yamada --- tools/testing/selftests/net/fib_rule_tests.sh | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index c8d1c297b7a1..51157a5559b7 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -87,8 +87,6 @@ setup() $IP address add $DEV_ADDR/24 dev dummy0 $IP -6 address add $DEV_ADDR6/64 dev dummy0 - ip netns exec testns sysctl -w net.ipv4.ip_forward=1 - set +e }