From patchwork Mon May 27 11:00:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1939850 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=h1ZddCok; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vnt4C1l2Hz20KL for ; Mon, 27 May 2024 21:01:15 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 2CA3781ECD; Mon, 27 May 2024 11:01:12 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ez4asgmJY47y; Mon, 27 May 2024 11:01:10 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 52B2681EB2 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=h1ZddCok Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 52B2681EB2; Mon, 27 May 2024 11:01:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id D9AE4C0DD4; Mon, 27 May 2024 11:01:09 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 71CCEC0072 for ; Mon, 27 May 2024 11:01:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4D78E40105 for ; Mon, 27 May 2024 11:01:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 73a0zmWQuEiy for ; Mon, 27 May 2024 11:01:04 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2417::600; helo=nam12-dm6-obe.outbound.protection.outlook.com; envelope-from=roid@nvidia.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 29996400AB Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 29996400AB Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=h1ZddCok Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2417::600]) by smtp2.osuosl.org (Postfix) with ESMTPS id 29996400AB for ; Mon, 27 May 2024 11:01:03 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/dYsAw5ofrC3v9rZJt+X23vyqF6OjYrRX6EaQFjBQwfOgRurdhxP2DZL1pNRYAzO/bnTSuv1iwH7Ey1SLUw9qpklGgCYulQooPEnaLuvdeUF3h1izj5e0FlRvu2VHX5ziNV92lk9TCD7z/1D2daJ+MLTD8FQyLvPt3r9v6pHoulHcHC8adsggv88/ir/nXxGpctxI5JmguFTaIF7lpFXvaw/vBkOimzxJ+LLE5lkmNXoGD2wGyPhXg7jsygXosg14wXyC4+I8BhAY28gLthHUnd6wxMXDIBvmK/Xo0Rs6vBFzOCCHA3Zn5uQ8JpuBd+Zdkr4tlZa0RqUayzp9kqUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hbm0DAhflr3BLlEqWXlJpgcVt/kgIrY5H0wt9vrRIwI=; b=fRnQrD6BGbHagFpXEt4jfleaULDcrbG1w8pYtWCB1oW/vPfHblgl59nAJ8MdK9mcXMN+VRBZ2WdltM8YzplqBO0xQ//fW5LDU2zRXmx3vadoayG+2/jkkwl847vgDz2lskSAozrAQASdXy3ZBQRvw/wV88X/PasZQpks/oIlrOdkv960zrPmeLDe+a9xr3uGDFQt+foI59FAWLsIITSWgeZTTmRf2TmOSb85x9GqPs025fRmGdpAKCh7l55lIxf2faWy3B3bPYYW0d0EHb/Q8De8GojkvWq6YjocZPjg8in44cj90EfrQHpJlQcmCwFX3ATxu51zEYGdHonqd4oFAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hbm0DAhflr3BLlEqWXlJpgcVt/kgIrY5H0wt9vrRIwI=; b=h1ZddCokkDWkkApkrRMni56KkxCpe9enXF0Pb1+X8hHvFAaXv4U4y+X+3+YRkNuK0EZJQlRk8JCguCHNoZncP8N32IXQSSUpVbi18os/+nxrWrultJ41x29IUBk6/zj4Megs/w1cbmqAdeuVITuB5kHXl5OAUuXS056bx4ENKb964abJDUXVUmfBTW3phKHU1cdNzbvPe7QaJQ06LVyxgB2YNz8gALhFhiVdojQp038YlJkiZhpOzVoAQtC0cCVaM5njl6IvujqK/R5hZgkwh9gksfPlDnw1T5/b4CQAVh4Gax6P6PVQUUDT8rjvjVZGD3TUOWa/oKm/nhkt8tdDUw== Received: from SJ0PR13CA0098.namprd13.prod.outlook.com (2603:10b6:a03:2c5::13) by LV2PR12MB5872.namprd12.prod.outlook.com (2603:10b6:408:173::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 11:00:59 +0000 Received: from SJ5PEPF000001EE.namprd05.prod.outlook.com (2603:10b6:a03:2c5:cafe::ca) by SJ0PR13CA0098.outlook.office365.com (2603:10b6:a03:2c5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.16 via Frontend Transport; Mon, 27 May 2024 11:00:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001EE.mail.protection.outlook.com (10.167.242.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 27 May 2024 11:00:58 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 04:00:41 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 04:00:41 -0700 Received: from mtr-vdi-198.wap.labs.mlnx (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 27 May 2024 04:00:40 -0700 To: Date: Mon, 27 May 2024 14:00:32 +0300 Message-ID: <20240527110033.531720-1-roid@nvidia.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EE:EE_|LV2PR12MB5872:EE_ X-MS-Office365-Filtering-Correlation-Id: e54707c9-52af-4ed9-b000-08dc7e3c49e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ToXLUrUrSB4bZXF/d+3HQrHl9jvwU6O?= =?utf-8?q?c7eLgVudEDFq8Ugqr5S5Sh8vLRoPgdeGMF9QjszRO/JUNHo0uIVbvzGrBDjBzAFHb?= =?utf-8?q?+29ydL4doYb6iPsh+7uqWet1yCy2FhD2OeBjgykArxwt2aP3dX0X1TbJ3IZMX+4ar?= =?utf-8?q?8Ual36BJSOKm+xOFNQD8HD3ZGvsC5ywLfDYNH1AzAYMavydeRr7cFzHiW/L1GcZMC?= =?utf-8?q?T81YbsNYvUTFtA9mWPQVXGTEy0PPnfxC5DRPjYvdXctPOH1L/oLV4kmba+L0/RfPp?= =?utf-8?q?TbYRlAYXPCP3+YVySFM85CB0T9oQMQgIISJPgMSx7TjRxDRnGwzOc8LtQ4VDTrgyh?= =?utf-8?q?9ecftF6zoAryAxEibYqqlJ3Lljjtf57Y/gO+CxAoe4HlXI7H0/fdL/H7nqvkCBvU4?= =?utf-8?q?5DhP9WxoFEF+MNe/GiY53HIylpCfy87awtIIfv+lF1b+bPrhowlGnpDEBZB5Z0pt6?= =?utf-8?q?NQzaI4bnUJktXLGARVR5uxNqrc89ns1h1RFmpRQcSNjrra/WWXpf/Q0p24aBSEl/9?= =?utf-8?q?Swn5hn0H9NCVxeitlV9Lt5BUKklNTQWSwFrd3q8MlwI2b4hycaJytdy4iHnETxTtO?= =?utf-8?q?3YmeGbydxSANWYmRnU53yPs5eceP+XuJUzCHyZzVpKnssxDdNpbYYP2C79xTlgMk4?= =?utf-8?q?QyMxE4IQ43yLeNuKi353sMrDloTYlHJk/ih7X8XgFVQET+8LqZS9ItYJXwGbTWg3E?= =?utf-8?q?8Y/h/VW3BEqUAXA4SUzw1Y85ntojDGWlGMLdU0WobvvAVVj1DEGWPfmeZVdKK+qzK?= =?utf-8?q?e3+D0LF5hs6INw+GwNTpZVGvc6H8/On6NINaIp91NosAtaViEvV+J8PLmHWJU12TG?= =?utf-8?q?bv9pHKYou+TWAQBYcjTrtAK00tuoRjy2zPrfKG1NCaVyrTQYbRuYYalYBrVVZdP9U?= =?utf-8?q?WvfHuev65zTe9XKGo5aG9guDRIRvj3SHtkDecfgmQ6zP8SRCXqevg2/vZtst8pWoA?= =?utf-8?q?vbvieixFcW2g/Ha6gl6f76Y5KcGgzl3ZPRUMqMiEGsqvgiZ/iyA+OwUcrldxAdXiW?= =?utf-8?q?VCCDm6oZnDOpcMpHIm0E9sm4y1C5UGnNiJOU7Nyh3CX+W9N78vTGtGq3/9iX5Dm7Q?= =?utf-8?q?2E2fq4O6UgPc9uyVSZyv9uGzlNKeyC76viINIOUWIsgH4MLj7V9B/wiIbSFoakOhv?= =?utf-8?q?fcQmvy53DDQPvXLSEF9UMslgEKK/hzGe+8gVah7j0Dr9kp8hEbeMbvbaHXTL6mud6?= =?utf-8?q?aTZ+KrSEUS1DMlICEM04KJQwvORVevTgkeDRtvB92NG9cxXF5wJ6c1cKaWf3ELTu9?= =?utf-8?q?sb+Cb9foTWnAYzwtV0TfMOW6QQcj01kab4jQ/gFnwI81A9Qnb0hT2MzajgYSucAoI?= =?utf-8?q?dKP4tRGFPzt5?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 11:00:58.1117 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e54707c9-52af-4ed9-b000-08dc7e3c49e0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5872 Cc: Maor Dickman Subject: [ovs-dev] [PATCH 1/2] netdev-linux: Fix using uninitialized current_speed. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roi Dayan via dev From: Roi Dayan Reply-To: Roi Dayan Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0 lib/netdev-linux.c:4985:54: error: ‘current_speed’ may be used uninitialized in this function [-Werror=maybe-uninitialized] Fixes: b8f8fad86435 ("netdev-linux: Use speed as max rate in tc classes.") Signed-off-by: Roi Dayan --- lib/netdev-linux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 25349c605cdb..0cb379295af1 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -4957,7 +4957,7 @@ htb_parse_qdisc_details__(struct netdev *netdev, const struct smap *details, { hc->max_rate = smap_get_ullong(details, "max-rate", 0) / 8; if (!hc->max_rate) { - uint32_t current_speed; + uint32_t current_speed = 0; uint32_t max_speed OVS_UNUSED; netdev_linux_get_speed_locked(netdev_linux_cast(netdev), @@ -5429,7 +5429,7 @@ hfsc_parse_qdisc_details__(struct netdev *netdev, const struct smap *details, { uint32_t max_rate = smap_get_ullong(details, "max-rate", 0) / 8; if (!max_rate) { - uint32_t current_speed; + uint32_t current_speed = 0; uint32_t max_speed OVS_UNUSED; netdev_linux_get_speed_locked(netdev_linux_cast(netdev), From patchwork Mon May 27 11:00:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 1939849 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=sgMhjCAp; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Vnt481C7sz20KL for ; Mon, 27 May 2024 21:01:11 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 4E05D4029B; Mon, 27 May 2024 11:01:10 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id 5cDNh4XDSBVO; Mon, 27 May 2024 11:01:09 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=2605:bc80:3010:104::8cd3:938; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1FEFD40144 Authentication-Results: smtp2.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=sgMhjCAp Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1FEFD40144; Mon, 27 May 2024 11:01:09 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F05CFC0072; Mon, 27 May 2024 11:01:08 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 66202C0037 for ; Mon, 27 May 2024 11:01:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5273840310 for ; Mon, 27 May 2024 11:01:07 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id PnGy6N9AHTeM for ; Mon, 27 May 2024 11:01:06 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2415::600; helo=nam11-dm6-obe.outbound.protection.outlook.com; envelope-from=roid@nvidia.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org DD3DF402D7 Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DD3DF402D7 Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=sgMhjCAp Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2415::600]) by smtp4.osuosl.org (Postfix) with ESMTPS id DD3DF402D7 for ; Mon, 27 May 2024 11:01:05 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Egbijy6PQ406c+V37A/DKQUVQWJHRaZRFQBTrQoGWxPN01fD4ObCjIFbrXA7mMsI764EBxwKCAaEBJIMekNwDL74sYa+iXeYsLngg/qpafoJiDzv6ErKpD8NVFQYC8IHW6+Ao6nse6hisSfcZsWFsZ5TjJ0cwah4nkKOCxqIGx55nL/0SpUhckUl5qnedL1ASIEuEp+2DbB5a33cXJ4ZfbBLj28hciOzrLsMzv4OhxK7nENVG9oKnDYGf2FL+pCw3WysDDvo8lWv4FtzS/a50EF4LUscb9dWP5vKSr3F71CcPM+b7qeWOW+YRKWzT32xUKmoIsbYNjuaalOq53aWwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s1ZTdS2k/y5mudIrXzKqO+mzZnUWBy0Qx59DHfB6T5g=; b=kGz5dl72PXZk0luZ38kmJBWoOlDmfk4IlLZrrgPaiJMv/9SEALaV/LojGbUMp11ay1A7GmtSpfJI54UYkxsPSfaSySrEsgcx+f/lHHzZD/SGXRObri1V2OFFs2OlKfix/zAC0lsnX0CwDp+DVIhPhwLt79Jq9YbynGiwHYVs2Mih4mG4uw4uR1KQRzMikiNKs2IU12D7gsawKowBW1uo6nkjZawewKRFpPpAYJaFCY7c9fp19XHELPZkL/HWuQp1B+FTNhE1SA1h0v7bDRbQxYLhp2hAnFrUV7JeACDjloJObNyRWw0mvcDxRidp4w98s5XEBlHZNId5Q5ohrF0Pqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=openvswitch.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s1ZTdS2k/y5mudIrXzKqO+mzZnUWBy0Qx59DHfB6T5g=; b=sgMhjCAp3w/oiaACFwvgkI+TMQm0bshZx8fYQc3bsrcBnoLwV44B4Tsw0xzmQ6Sr/eUUUErNC3C8sdoHvF0KMfuwwR6tQNtDhgus15dsV+uwBerx2Ard5LfGe5D7Z9N7SeLwl1blF/zMR7PAbLW962eGIaaG28K4cyqOA0Vao6MFP6BT7t/DkFw4twdLWOnFdWwFYojU8pEFhaQa54pJRIgwka4/siLRq55o9FUjuN6qgbK5x5gshcgk2CY5YTAfMdDOpHXdhKfXS0hy5oJXcL5+jLxr0dcFvHkDZsqJIKAC6E45GDBlvme5zA4aF94pu5Bpxd1GrRzctq4UfitJOg== Received: from BY5PR03CA0002.namprd03.prod.outlook.com (2603:10b6:a03:1e0::12) by PH7PR12MB6468.namprd12.prod.outlook.com (2603:10b6:510:1f4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29; Mon, 27 May 2024 11:00:59 +0000 Received: from SJ5PEPF000001E9.namprd05.prod.outlook.com (2603:10b6:a03:1e0:cafe::c) by BY5PR03CA0002.outlook.office365.com (2603:10b6:a03:1e0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7611.29 via Frontend Transport; Mon, 27 May 2024 11:00:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ5PEPF000001E9.mail.protection.outlook.com (10.167.242.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 27 May 2024 11:00:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 04:00:43 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 27 May 2024 04:00:42 -0700 Received: from mtr-vdi-198.wap.labs.mlnx (10.127.8.13) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 27 May 2024 04:00:41 -0700 To: Date: Mon, 27 May 2024 14:00:33 +0300 Message-ID: <20240527110033.531720-2-roid@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240527110033.531720-1-roid@nvidia.com> References: <20240527110033.531720-1-roid@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E9:EE_|PH7PR12MB6468:EE_ X-MS-Office365-Filtering-Correlation-Id: 0dee9403-9fa4-4710-c433-08dc7e3c4a25 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?q?4nVYnZkF+NeJwpXVTbgOmqaSsX1rTTP?= =?utf-8?q?kM+gJ5OgOug00e00NrfQbG3P1JgkrFVoIMwl7p+G/hwGxGaL0UlxQKyn+JBVjdnG1?= =?utf-8?q?vEWn6n7CmCq2k/ORf59Q/SwQQX9srSszI58pd1cTg9diopjqUBN+rgOeoyZYA5Fw1?= =?utf-8?q?GFnk6wj+pbu7i0oc7/2M2GjpJMXDInpjEKTHZXrGD4IsOj5cXB+TSA751EV1VK6+a?= =?utf-8?q?PeWb/psntOqRWmQRaFhU9LEEM9oy3omlljiIKFG+aYKhIcJW+hzoT+BoG20zElaqT?= =?utf-8?q?7pMPMF8LWDpwOAyUZcBtpxA5XxwOcXm4xtoL3FreB9rzlQ14UnC7GpWPaZ8B4BNzx?= =?utf-8?q?tvYITXDCIetIMYmazL3csnAgw7iNOj91395cz/0xbkWnx1fTr8i4sj9jZdLgUxE5i?= =?utf-8?q?ZmgkncMPRXo2o69bpQwgw8hGmR6VSop3M2OOY39plYOiFaAwOwGu9wTGQ8HCl6Cqi?= =?utf-8?q?Eo9E0dRHNHxH+uHRg4fdEzegPU174dMlrX345uGq9w1scwkhuxuPOjn2be0GFPyc5?= =?utf-8?q?3dzBeQnjM6ZcnGOoSpRcyrUQqX53furY2DOP36AAj5VTXTr5VAbH8oiZrrV8mQVUE?= =?utf-8?q?7EDpVjoRHqRSTesdfYBsJGDZFC9amiBigymGN1HvRPnMVUilLZ8Svkns5JnrDfs+6?= =?utf-8?q?qn5oAb3MUq4tHczfA+nqNDG6RXsMeau3i1G8ZM9adQAn+sOw+q9VsEdzVQqaXrIcJ?= =?utf-8?q?GOdSCjURlyQzt1F1cocC88jvfkGVee5MCcgRqlhQ3Lav4EmySIyXBuaj0KsLHIStE?= =?utf-8?q?iC/LuYRVNbafYNPnNpHh5djpOjxb0/HM60UqET2obKD1FIoAkn99V+obEBDM8Pffq?= =?utf-8?q?s36scQ1gWVVes5MVIcUP8JUd7r+FdDk8xQrkRFBlbLjC5HJxybB2m2Ui3GkCKyDg2?= =?utf-8?q?EP020gHkvevcGjWKmuyDeLhZ3JmYm8Xq6BWKffbFC/kNkNI1oCw5B2zGNCsUvulMF?= =?utf-8?q?3nlgTXefLyCmSmDmGAXo0EWZuZaXt5AELTVKZ3Y41O46+WbEQdG26FhdkCIooP3KM?= =?utf-8?q?E9kTXEHImrkGEFijiqQjxIPUYaVkiDoRvcqXidrSNsBJFI0z8/QQemmEJwEzo6E70?= =?utf-8?q?oVrzhJI1PioGDcDHoZyvWcJ7NZj2vm9U1s5HlztmiAQ/3yuMrHAVplC2+8l5y8yIz?= =?utf-8?q?JqpKYNnXQP7FwwYClzcy35EcYfBxJXPhrLTIXBhbiXhiZ6Ot1MWDy0wn1WExQ6ern?= =?utf-8?q?yZSaa5f395EjSNt7FnRCb868zX9FTSyPBOBO4v/BiCkDYhDD6zx2LBfRCYRWhxo7g?= =?utf-8?q?BCNIruUJINsEjQcCdx6UgdALqSVgptkxIcRfZUgG5znIvwxAkApVS+OJVHLCygqy/?= =?utf-8?q?9bteRXaG4edH?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 May 2024 11:00:58.5644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0dee9403-9fa4-4710-c433-08dc7e3c4a25 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6468 Cc: Maor Dickman Subject: [ovs-dev] [PATCH 2/2] netdev-linux: Fix ethtool_cmd is partly outside array bounds. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roi Dayan via dev From: Roi Dayan Reply-To: Roi Dayan Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Used Ubuntu with gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0 lib/netdev-linux.c: In function ‘netdev_linux_construct’: lib/netdev-linux.c:7003:15: error: array subscript ‘struct ethtool_cmd[0]’ is partly outside array bounds of ‘union [1]’ [-Werror=array-bounds] 7003 | ecmd->cmd = cmd; | ~~~~~~~~~~^~~~~ lib/netdev-linux.c:2411:7: note: while referencing ‘sset_info’ 2411 | } sset_info; | ^~~~~~~~~ Fixes: 6c59c195266c ("netdev-linux: Use ethtool to detect offload support.") Signed-off-by: Roi Dayan --- lib/netdev-linux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 0cb379295af1..ec6fcf7b2c6a 100644 --- a/lib/netdev-linux.c +++ b/lib/netdev-linux.c @@ -2402,6 +2402,7 @@ static int netdev_linux_read_stringset_info(struct netdev_linux *netdev, uint32_t *len) { union { + struct ethtool_cmd ecmd; struct ethtool_sset_info hdr; struct { uint64_t pad[2];