From patchwork Wed May 22 01:17:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2" X-Patchwork-Id: 1937565 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=QffrissE; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VkYMW6Vnlz20PS for ; Wed, 22 May 2024 11:17:59 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 058A6385F014 for ; Wed, 22 May 2024 01:17:55 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by sourceware.org (Postfix) with ESMTPS id B50B63858D1E for ; Wed, 22 May 2024 01:17:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B50B63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B50B63858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.18 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716340654; cv=none; b=KKx4vlUdJAJaeIQeRv/7U0WBbx9fWXdk7m8rnWWfhlk3S430XuYrC+tfBQxioz5dRm4yLkp1MO6b+rgWZpi6GxGFhBNqS7qP1XNE9IAlctTYbcvUdHHwNMkCgv5iXaD9nMRte9PrRnxgPk9BUQXZHdaF93Hep3PTRHj8eKAs06M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716340654; c=relaxed/simple; bh=rhSpEi8jD5w5ZOSxPQw1gTxSlI/hFXYG7h0U9Mft0Zw=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=Uudo20KiBadYTtO/tLp7OXr4kl1dzrtw/EkF5GPLbE/XWQlsxNubuYrV08tXltm6wQEJ78OSt1tlanbvEEy2XDCnK00KRIAec41CcKIw8WWpUPMtbTazaT712gBhIVe+7/+YbdAZB6nq+O9nQN8Ewjod5mnvHp+Se8YHfgP7JvI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716340650; x=1747876650; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=rhSpEi8jD5w5ZOSxPQw1gTxSlI/hFXYG7h0U9Mft0Zw=; b=QffrissErSgfHMsaqAj8RVt5D99RVxncTivL2Xw6XtFsc2lgBPRsemYb bcFZzGZrR5FW0TXWyaBsicAC3V8hNdD5+WtVbOdCFmimQzmcDvhkapKjH X9eFuH+dOeft+3x5JI34IKDv4CeFZaAJ/SgZ0ZP4+WBDn/yVw6BvCPPmW U2A3zJlAvrJyahj9wbdVTQ4XfKPLEnSPQVp39TJondyTrYY7Q0Gn9yi/E RrZRW0x1DvmLAofBBDLW1/BCHg3zH+adApSnNNLbwkbEtD+pfYoKuRmKH V9PGRblOGBsO2pPCUNwlf047wiPcdjjfBqz4MfO/ca89fZh9QT0aUI5WA Q==; X-CSE-ConnectionGUID: NKthAK44QRybywkZNQUcjQ== X-CSE-MsgGUID: TRgNIrLdTpuDWjOrqAFvLQ== X-IronPort-AV: E=McAfee;i="6600,9927,11079"; a="12357079" X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="12357079" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2024 18:17:29 -0700 X-CSE-ConnectionGUID: x+pZKPYJSDK1OZhtVJLZLg== X-CSE-MsgGUID: gOvJERWzRHiYoceEk/H8gw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="33028432" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by fmviesa007.fm.intel.com with ESMTP; 21 May 2024 18:17:27 -0700 Received: from pli-ubuntu.sh.intel.com (pli-ubuntu.sh.intel.com [10.239.159.47]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 663D9100736B; Wed, 22 May 2024 09:17:26 +0800 (CST) From: pan2.li@intel.com To: gcc-patches@gcc.gnu.org Cc: juzhe.zhong@rivai.ai, kito.cheng@gmail.com, tamar.christina@arm.com, richard.guenther@gmail.com, pinskia@gmail.com, Pan Li Subject: [PATCH v2] Match: Support __builtin_add_overflow branch form for unsigned SAT_ADD Date: Wed, 22 May 2024 09:17:25 +0800 Message-Id: <20240522011725.424952-1-pan2.li@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org From: Pan Li This patch would like to support the __builtin_add_overflow branch form for unsigned SAT_ADD. For example as below: uint64_t sat_add (uint64_t x, uint64_t y) { uint64_t ret; return __builtin_add_overflow (x, y, &ret) ? -1 : ret; } Different to the branchless version, we leverage the simplify to convert the branch version of SAT_ADD into branchless if and only if the backend has supported the IFN_SAT_ADD. Thus, the backend has the ability to choose branch or branchless implementation of .SAT_ADD. For example, some target can take care of branches code more optimally. When the target implement the IFN_SAT_ADD for unsigned and before this patch: uint64_t sat_add (uint64_t x, uint64_t y) { long unsigned int _1; long unsigned int _2; uint64_t _3; __complex__ long unsigned int _6; ;; basic block 2, loop depth 0 ;; pred: ENTRY _6 = .ADD_OVERFLOW (x_4(D), y_5(D)); _2 = IMAGPART_EXPR <_6>; if (_2 != 0) goto ; [35.00%] else goto ; [65.00%] ;; succ: 4 ;; 3 ;; basic block 3, loop depth 0 ;; pred: 2 _1 = REALPART_EXPR <_6>; ;; succ: 4 ;; basic block 4, loop depth 0 ;; pred: 3 ;; 2 # _3 = PHI <_1(3), 18446744073709551615(2)> return _3; ;; succ: EXIT } After this patch: uint64_t sat_add (uint64_t x, uint64_t y) { long unsigned int _12; ;; basic block 2, loop depth 0 ;; pred: ENTRY _12 = .SAT_ADD (x_4(D), y_5(D)); [tail call] return _12; ;; succ: EXIT } The below test suites are passed for this patch: * The x86 bootstrap test. * The x86 fully regression test. * The riscv fully regression test. gcc/ChangeLog: * match.pd: Add new simplify to convert branch SAT_ADD into branchless, if and only if backend implement the IFN. Signed-off-by: Pan Li --- gcc/match.pd | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/gcc/match.pd b/gcc/match.pd index cff67c84498..2dc77a46e67 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -3080,6 +3080,17 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (match (unsigned_integer_sat_add @0 @1) (bit_ior:c (usadd_left_part_2 @0 @1) (usadd_right_part_2 @0 @1))) +#if GIMPLE + +(simplify + (cond (ne (imagpart (IFN_ADD_OVERFLOW@2 @0 @1)) integer_zerop) + integer_minus_onep (realpart @2)) + (if (ternary_integer_types_match_p (type, @0, @1) && TYPE_UNSIGNED (type) + && direct_internal_fn_supported_p (IFN_SAT_ADD, type, OPTIMIZE_FOR_BOTH)) + (bit_ior (plus@3 @0 @1) (negate (convert (lt @3 @0)))))) + +#endif + /* x > y && x != XXX_MIN --> x > y x > y && x == XXX_MIN --> false . */ (for eqne (eq ne)