From patchwork Mon May 20 06:31:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tobias Burnus X-Patchwork-Id: 1936907 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=ugvP7gQF; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VjSQL2nDWz20KF for ; Mon, 20 May 2024 16:31:36 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2CB2F3858C60 for ; Mon, 20 May 2024 06:31:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 618C63858D20 for ; Mon, 20 May 2024 06:31:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 618C63858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 618C63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716186676; cv=none; b=rhZ50HzDtS6n12Y5zeGerNdp0S94Hi74vUiX/ImA0PebPeDYo5hZeE5C2FPT2FEyhiLc6bTD5QReWQybZm3K6trzBwp0+ZL0kyCiDV0DkCkR9nLlXy8yMvOsbm/bHS11iK4yAmDhSKvLrrnDPxYIv2pv4KvTbPJRw87kp88DLzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716186676; c=relaxed/simple; bh=iAZF5H2nxJa4zTriXXdvJqMP+tOGz3p5plLhBzr6j1A=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=Q+6blmAE/NoQW7el2WmYAilkFt6W/dI3qIN7iIwLMKY+lS8vy9XMsAMChvxtbNBU791Prhpz/9yB0Nu6DxN3WUOLRSLvP1MKXsQhNCVcZ/QfZD3k5YI1RGwx01zfUytKa98stunXrZOqljXMZpP33Rj9MLz35DfkPbddbm89uv0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-572a93890d1so7618111a12.3 for ; Sun, 19 May 2024 23:31:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1716186665; x=1716791465; darn=gcc.gnu.org; h=in-reply-to:content-language:references:to:from:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=AgZs4mDRaKsWZHCUGwpHzVm+9c0HBW7DXi8Avn7Wawk=; b=ugvP7gQFm1VyI/2YTdcL8Gumc6ZjYWzhEHBXEZQ9T+E3kB7IblwF4ZX9sW3fX+bHSp FCkOrBtwctJDWDqCLXvYtLG/v/d2uEDjZ+CII9ty5rEZdIlEQ/4IX0QNtlp3zPnm+VnE 45TUrGe0HiNw+A+dMe3BbwjLygcgT+JTnqYE0leG12Zk63BnTFIN5XvDEk3P0ZKcH1RG MpImfftkPx6buLw4U4x2sPBCf7XXYXW8rtgm7ScBpl+Ta78WTKiX6BSwj1a9hri4AJxP D6P3O/ZTWLxJEqKjutKNNjnp7jTB6pfDrhtQE0z/+M6yVaDxjO3bc0oAMG6ocO7c/0Yo yfcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716186665; x=1716791465; h=in-reply-to:content-language:references:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AgZs4mDRaKsWZHCUGwpHzVm+9c0HBW7DXi8Avn7Wawk=; b=AGpAhuh01fVxGcvxp0ASocdhnctZW0p5CV60xA3ToMsotkken8kZUBqeWUhn/tfsAZ ABEHJnMXaLVogZMiZ1z0UKqtXllXXuMI1NZv0ehyfz9qotF/F8yceENoxdjuYLj3cOyM 9ss9RlwpknSk+kEwszP0+BgcgpR/7syW24trF826aZeThyPtmdX4eFgp7899mrqTMjA5 djH9oH/Vgxe4pu5Bv+7Kkqafa9N3P2hWWfTnz7aUobS1VNcPlWBVlnxQowIwDT6XsAg+ kDNBvxJsf9vQmGjfPYiFfCyeWyjO6fxzr+wmIOJlXHGh1M2fm1SvziI7CuYtHm+edicm 0fnw== X-Forwarded-Encrypted: i=1; AJvYcCXuH/XEtJn3Ik7pMlYgYIDVQ1d1EZYA3ounraiv2SkOiJO+mlvo/j7aJuf0EqbwEy2kq5Q6ZXcyiCQxIbvyQ39jPUHTot5voA== X-Gm-Message-State: AOJu0YyUBt7LrbMXcKeEij9RbOOueYV0j5UbaeZM5m3icJ4KC31erorZ 3P/vewIIDGOz4HI1/dgY3JF/j9FiYD2YtSYwu+jHj5XXGgeXyPh2h0xWSoTGVco= X-Google-Smtp-Source: AGHT+IEWHKkNTdTw3IKsg+WrJyqTFYrpB+2ktIDlrt5zXfm7kFTZdF5WIB4Ucbii6Zmo2kzozgCXYA== X-Received: by 2002:a17:907:2d13:b0:a59:c577:c5c3 with SMTP id a640c23a62f3a-a5a2d57a48emr3098818366b.29.1716186664842; Sun, 19 May 2024 23:31:04 -0700 (PDT) Received: from [192.168.8.102] (tmo-086-79.customers.d1-online.com. [80.187.86.79]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a179c7f32sm1427713966b.106.2024.05.19.23.31.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 May 2024 23:31:04 -0700 (PDT) Message-ID: <85f94d8f-7a25-4000-9243-9e7e814a1e36@baylibre.com> Date: Mon, 20 May 2024 08:31:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [Patch] contrib/gcc-changelog/git_update_version.py: Improve diagnostic (was: [Patch] contrib/gcc-changelog/git_update_version.py: Add ignore commit, improve diagnostic) From: Tobias Burnus To: Jakub Jelinek , Richard Biener , gcc-patches References: Content-Language: en-US In-Reply-To: X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, HTML_MESSAGE, KAM_LOTSOFHASH, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Hmm, there were now two daily bumps: Date:   Mon May 20 00:16:30 2024 +0000 Date:   Sun May 19 18:15:28 2024 +0000 I really wonder why. I guess, the 'ignore commit' is hence not needed – but I think the improved diagnostic part still makes sense. See updated patch. On May 19, 24 Tobias Burnus wrote: > I noticed that the last bump happened on Thursday. > > * * * > > The error is according to > https://gcc.gnu.org/pipermail/gccadmin/2024q2/021298.html > > 2024-05-19 00:17:28,643:INFO:root:cannot find a ChangeLog location in > message > > That's the commit > --------------- >     Revert "Revert: "Enable prange support."" > >     This reverts commit d7bb8eaade3cd3aa70715c8567b4d7b08098e699 and > enables prange >     support again. > --------------- > > * * * The attached patch adds this commit to the ignore list and helps > with the diagnosis by showing the failing hash in the error message. > > OK for mainline? > > Post commit: Can someone install the new version + fix the ChangeLog > for the ignored commit? > > * * * > > What I do not understand: Why does this commit get applied? I do see > for both > > contrib/gcc-changelog/git_check_commit.py -v -p > da73261ce7731be7f2b164f1db796878cdc23365 > > and > > contrib/gcc-changelog/git_email.py > 0001-Revert-Revert-Enable-prange-support.patch the error above. - And > I do not understand why it made it past the commit check but now fails? > > Likewise for8057f9aa1f7e70490064de796d7a8d42d446caf8 > > Does the commit hook use an older version of the check scripts? Does > it ignore the errors? Or what goes wrong here? Any idea? Tobias From f56b1764f2b5c2c83c6852607405e5be0a763a2c Mon Sep 17 00:00:00 2001 From: Tobias Burnus Date: Sun, 19 May 2024 08:17:42 +0200 Subject: [PATCH] contrib/gcc-changelog/git_update_version.py: Improve diagnostic contrib/ChangeLog: * gcc-changelog/git_update_version.py (prepend_to_changelog_files): Output git hash in case errors occurred. diff --git a/contrib/gcc-changelog/git_update_version.py b/contrib/gcc-changelog/git_update_version.py index 24f6c43d0b2..ec0151b83fe 100755 --- a/contrib/gcc-changelog/git_update_version.py +++ b/contrib/gcc-changelog/git_update_version.py @@ -58,6 +58,7 @@ def read_timestamp(path): def prepend_to_changelog_files(repo, folder, git_commit, add_to_git): if not git_commit.success: + logging.info(f"While processing {git_commit.info.hexsha}:") for error in git_commit.errors: logging.info(error) raise AssertionError() -- 2.45.0