From patchwork Wed May 15 03:28:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hepeng X-Patchwork-Id: 1935257 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bytedance.com header.i=@bytedance.com header.a=rsa-sha256 header.s=google header.b=JGknRnQH; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VfJbw0WZbz1ymf for ; Wed, 15 May 2024 13:28:58 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D95C281418; Wed, 15 May 2024 03:28:55 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id l8DsXJBTSWXZ; Wed, 15 May 2024 03:28:55 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 8A81281330 Authentication-Results: smtp1.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=bytedance.com header.i=@bytedance.com header.a=rsa-sha256 header.s=google header.b=JGknRnQH Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8A81281330; Wed, 15 May 2024 03:28:54 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 596F8C0072; Wed, 15 May 2024 03:28:54 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 8F02DC0037 for ; Wed, 15 May 2024 03:28:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7624140AA5 for ; Wed, 15 May 2024 03:28:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gvoLUBE-J9-h for ; Wed, 15 May 2024 03:28:51 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::42e; helo=mail-pf1-x42e.google.com; envelope-from=hepeng.0320@bytedance.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 5269240A53 Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 5269240A53 Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bytedance.com header.i=@bytedance.com header.a=rsa-sha256 header.s=google header.b=JGknRnQH Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by smtp2.osuosl.org (Postfix) with ESMTPS id 5269240A53 for ; Wed, 15 May 2024 03:28:50 +0000 (UTC) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-6f44ed6e82fso5550781b3a.3 for ; Tue, 14 May 2024 20:28:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1715743730; x=1716348530; darn=openvswitch.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sG7PW4McjGg+K/M1uMiCh7WXd6DyOvRNjQpRaznwgmo=; b=JGknRnQHZ/U3hCLGExkkfXlDsGQHs4TSah833tkfTkrTUKkC24c1OMFEXw4JYttOxG bqmfwH+MrNzzlw4JMVXAlN3tWZoBG7UtJioUN7kY5XvqEanA1tk2R1ydodhCgyo4LewL Xd6exjgnTloOL6kvLfMYICXuZAFgMkGAJn11YAfCcZ6kBBpM7VTfONo3pZrPERBXzOE+ ZiNLtwUownSu2tGPWX0Ex9pt22T7onYRWpfjpkpwLJA4n23m/zf7iJsZbp1vsT7u9XOR sqz4Uolkeaq/gvEteq9L2WNgG2EQ4BFx9wYyR1ug25tfn8JSnjekrnZk/n2RqyTzr+Nt SlSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715743730; x=1716348530; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sG7PW4McjGg+K/M1uMiCh7WXd6DyOvRNjQpRaznwgmo=; b=UqR10Ai/s+jETTf9NXf7YYGmu/qTf/Xn2vJWq2HI1XDLFbn20xI0bdVYak9GVxo5hR qqt7XeiZ9cdNF4NtRn0/4gnIiRsXC3m92tZPsCgmCJA0qFxMIpurPhHU4MtC6njWN3an 6LXD7Ecuw3JcSD0a5EriayjeEIuNEjntkYpn7Ce9V3+M2n0OpWi4fPU/aeSlAh3bswdW Z5CEuziGcseO2NdNfaTUJXvjZ3IJT91daf3dEMsCsSDoMTbpfAkJcHqs1lFcDK4KQcJi q6994t3QraeTRi3zXddkGx9w0Y/tBbOILtknGkwPC8gCftusukO7OFuUIj+tkkBX+aOr aeCw== X-Gm-Message-State: AOJu0YxJV6mhtDrCYU3dFUhLIgOX3OK1v9wl5ZutMj14R0i9bqK7KBpi WBgPDMJkRANSYM3w5JhTHzYK++1Xod369pCMuILoHEHa2vYeIoSfxCbTW6AzqjQ= X-Google-Smtp-Source: AGHT+IEEs4WhhBQj0yX7u0Kx4z06FEVALCwWSXV3Z9bqtnUAY0UvGOJjmQyzjpALM46/fv3GkQiy0w== X-Received: by 2002:a05:6a21:800f:b0:1af:9c7a:a16d with SMTP id adf61e73a8af0-1afde1ddab5mr16640143637.51.1715743730165; Tue, 14 May 2024 20:28:50 -0700 (PDT) Received: from localhost.localdomain ([61.213.176.12]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c13908bsm106459855ad.265.2024.05.14.20.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 May 2024 20:28:49 -0700 (PDT) To: i.maximets@ovn.org Date: Wed, 15 May 2024 11:28:21 +0800 Message-Id: <20240515032821.26843-1-hepeng.0320@bytedance.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Cc: dev@openvswitch.org, Peng He Subject: [ovs-dev] vlog: Destroy async_append first then close log_fd. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: hepeng via dev From: hepeng Reply-To: hepeng Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: Peng He async_append stores log_fd, it should be destructed before log_fd is closed. Signed-off-by: Peng He Acked-by: Simon Horman --- lib/vlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/vlog.c b/lib/vlog.c index e78c785f7..59b524b09 100644 --- a/lib/vlog.c +++ b/lib/vlog.c @@ -411,10 +411,10 @@ vlog_set_log_file__(char *new_log_file_name) /* Close old log file, if any. */ ovs_mutex_lock(&log_file_mutex); + async_append_destroy(log_writer); if (log_fd >= 0) { close(log_fd); } - async_append_destroy(log_writer); free(log_file_name); /* Install new log file. */