From patchwork Wed May 8 20:15:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 1933180 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=G4PqLITr; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=sipsolutions.net header.i=@sipsolutions.net header.a=rsa-sha256 header.s=mail header.b=RSqx7jYk; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VZRHg5YFSz214K for ; Thu, 9 May 2024 06:16:29 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=kdBuE3PgsB9hRz3WLyDuzY5RhfAMfked4Ha7I1yNmc0=; b=G4PqLITrh2e2pq ZAKWiamsLXFRP1YClMV5VHURypvG2YKIyTyRae7dBTvSun4FTd2NuLNNnlxK3qMq7mF9eGwMJlkXw sOcv6wDQtbmlvuiAEMQIO/n7V1xgHFttkbxzh4FJ4HnqLDe4cfnRU2LPC3CQhgSIh4vIxjOXTdQqu 6AKndYO0wnW+v10e5BT9DBI+m26uiDRoaAg6Gfljua6qY7E3Da5AMhM++UR2w0nVXjBIJdveU2MJR NrSZtRz8D8OaDct2K1oQvSRbt2F4n7aXEdA94DfeXLqw6CVbmZOHqyp6ioMLzPeFpHLJZjPICxKCG l5heUzLIemt+1Ebl19GQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4nhk-0000000GrEd-3xbr; Wed, 08 May 2024 20:15:56 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4nhh-0000000GrD8-01iy for hostap@lists.infradead.org; Wed, 08 May 2024 20:15:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Content-Type:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-To:Resent-Cc: Resent-Message-ID:In-Reply-To:References; bh=szTP1Fcn3TB/ylSm4BCFpwXYHjjED2ZNyc2RhiL9504=; t=1715199348; x=1716408948; b=RSqx7jYkR/GtwJa52QJflM97Ou18i6jCLS8PfC9R5sxBQlqW6HJoEs5uoC+PIX24iozg3Z8PsHk REEl436eFukJLJY+M/MVuE0zc8HO4zWyLsRzERd4fRI5pvOcfWLgTRwV6O1vFbPpAnWgUWpCtfOVp KaNfY7u6IDtvpMk5iCxcg72eexGj/vl0uNw6gz6Vw3fZQhO5k/Z8urQaLgVHeEDSPXHpMrpmM37tC wXlP5vY0zO5pnLFNblrnlt+Y20tUK6cokeak0xt6ht2amlg71iQqDKQ8+dUpJ8/bmhvXeeGxcsyWI lddA38gyG/N+/ElTqPnb7KQFZ0k7VN93azhg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1s4nhZ-0000000BhOb-2Wyh; Wed, 08 May 2024 22:15:46 +0200 From: Johannes Berg To: hostap@lists.infradead.org Cc: Johannes Berg Subject: [PATCH] wlantest: ICMP: use sta_find_mlo() Date: Wed, 8 May 2024 22:15:43 +0200 Message-ID: <20240508221542.a6cadcfd35d4.I3950b93f79ebea781ef6737c0c0d3d64a31a3792@changeid> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240508_131553_281509_B9726958 X-CRM114-Status: GOOD ( 10.31 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Johannes Berg Using just sta_find() won't work for any link addresses but the assoc link, use sta_find_mlo() instead. Signed-off-by: Johannes Berg --- wlantest/rx_ip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: hostap@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Hostap" Errors-To: hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org From: Johannes Berg Using just sta_find() won't work for any link addresses but the assoc link, use sta_find_mlo() instead. Signed-off-by: Johannes Berg --- wlantest/rx_ip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/wlantest/rx_ip.c b/wlantest/rx_ip.c index b0fdd2068c96..5dc186c45577 100644 --- a/wlantest/rx_ip.c +++ b/wlantest/rx_ip.c @@ -85,7 +85,7 @@ static void rx_data_icmp(struct wlantest *wt, const u8 *bssid, if (sta_addr == NULL) return; /* FromDS broadcast ping */ - sta = sta_find(bss, sta_addr); + sta = sta_find_mlo(wt, bss, sta_addr); if (sta == NULL) { add_note(wt, MSG_INFO, "No STA " MACSTR " known for ICMP packet", MAC2STR(sta_addr)); @@ -93,7 +93,7 @@ static void rx_data_icmp(struct wlantest *wt, const u8 *bssid, } ping_update(wt, sta, hdr->type == ICMP_ECHO, src, dst, id, seq); - if (peer_addr && (sta = sta_find(bss, peer_addr))) + if (peer_addr && (sta = sta_find_mlo(wt, bss, peer_addr))) ping_update(wt, sta, hdr->type == ICMP_ECHO, src, dst, id, seq); }