From patchwork Mon May 6 19:02:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Hubbard X-Patchwork-Id: 1932135 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=r6PADBHC; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=140.211.166.136; helo=smtp3.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VY9l864Mlz1ydW for ; Tue, 7 May 2024 05:02:28 +1000 (AEST) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 10A12608BA; Mon, 6 May 2024 19:02:27 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id REcOlcvfwJGF; Mon, 6 May 2024 19:02:24 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.9.56; helo=lists.linuxfoundation.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6822760874 Authentication-Results: smtp3.osuosl.org; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=r6PADBHC Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 6822760874; Mon, 6 May 2024 19:02:24 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0FA18C007C; Mon, 6 May 2024 19:02:24 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1CDCBC0037 for ; Mon, 6 May 2024 19:02:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id F156E81E8B for ; Mon, 6 May 2024 19:02:22 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Mtc8PqR6d_Au for ; Mon, 6 May 2024 19:02:22 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a01:111:f403:2417::601; helo=nam12-dm6-obe.outbound.protection.outlook.com; envelope-from=jhubbard@nvidia.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 0E3C181E84 Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0E3C181E84 Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=r6PADBHC Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on20601.outbound.protection.outlook.com [IPv6:2a01:111:f403:2417::601]) by smtp1.osuosl.org (Postfix) with ESMTPS id 0E3C181E84 for ; Mon, 6 May 2024 19:02:21 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k2HaYNYTejmBNh5CFyI1++QsZbfOohRDVEyfC8lC0bNzlO4FzONKg6Rwy1cBsdpqY1ZOHZqbtr5/mXsPuXGmc51JHGENt8eCG5CY7LC0O+Uo44/a0LyXEZTxFBxzYlHyTmygXbBPizWxkG+6o9UjFLGTJJ6FooLPya2ZTQo37EwLc1nSaFpJjLsMEz3PDojmFDTJ1n4VYwgzbbly+zGO39HCXcRivk9rsLFB0Eo2Ne5itoL3OVbThnsuy8yJ9Y+Mcum3KPwrcC0WJ3kaJBr0HcHgX3sFmakzX++jfVCigRIcC4IAp+a9bbg5msbyXTYdx+KF1Ik7apRrhL5uIJMI/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vq0M87NzhO/Rv4P5a1urdnmGSGGLoAXkZGrXTiy37b8=; b=n607H3mRcwrHA440j6iEGvm8axnCovDTkTRVLaD4f211DBIqZV+vhW5BuY6F4kx5RfE5HbZn2hnQ/NFPDZEIRxJr4L+lQk0g8oDGxT4/+SZ686HOEAjJ7/yYoIbeR+2rK/V8tuEGSrAK0Hq3x+vAMbmQa+VgDQZKwffWVfb9xGZ8e9sNNuyhC9XZmrng8QVSA+GPWyoU3E9qbOLmymsuVzvje6UsIW+F18uCuvOsJM9Gxl2P8FRextbJTdpU9xeFXgs9aGCCG+BQcciosMEhzBV2aMD04qQ7rctaW/baYeFFRL0Yjw8obmRa44l5ApBv/WW1tG7xmFksuv+kTnkuBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vq0M87NzhO/Rv4P5a1urdnmGSGGLoAXkZGrXTiy37b8=; b=r6PADBHC/+vDr01UdqmuCp2GDZhcEAngn7k6El3B6StZLJcgCiva25eTUlHlE1hbKsXQyrV13pnftrxKHTD9zSTkNusCZ4cFyPVAaz4WZgpVwkzwWD1FCLr2xNpMDtuJnlc7Ns+dhPwTeJgCfBYs19tMzHdJ3CiCCfIS2LjugO4aD5rkCPzlRCkCys3P8Ci/o9B/USpH0tS8i3dIPn/AeYBHGC2KAZOajROtGjXkLl+/6YONM4tFgWDyrtr16GtU9ulD10x6N3yXknl9NQtuO7XQQa9UleAO4H9Ias8/EeL2WDNCEZS9t+RLYHktZT/TbOWgsPiMeLwTQ3cPFG6ANQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by MW4PR12MB6826.namprd12.prod.outlook.com (2603:10b6:303:20c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Mon, 6 May 2024 19:02:15 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::2cf4:5198:354a:cd07]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::2cf4:5198:354a:cd07%4]) with mapi id 15.20.7544.041; Mon, 6 May 2024 19:02:15 +0000 To: Shuah Khan Date: Mon, 6 May 2024 12:02:04 -0700 Message-ID: <20240506190204.28497-1-jhubbard@nvidia.com> X-Mailer: git-send-email 2.45.0 X-NVConfidentiality: public X-ClientProxiedBy: BYAPR05CA0079.namprd05.prod.outlook.com (2603:10b6:a03:e0::20) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BY5PR12MB4130:EE_|MW4PR12MB6826:EE_ X-MS-Office365-Filtering-Correlation-Id: ee76813a-3484-4c53-d19d-08dc6dff0b21 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|7416005|1800799015|376005|366007; X-Microsoft-Antispam-Message-Info: YhTRhNKXsoJ9JejY1P9hcabykamE0dREZkBbjsSIMP62T6sfBtBz4pi9A4WgTIaarkw/5Y4HM2fMyfq9cAE0D8d7ZmXYIp9kOJ4wXYHAwjo9P2YUpoeSS1wtFnIza+badBf7ep3zO8iQkpwDq4ZV196YnsZbGxcA/W08SsZ2sbeFwoXbQvkmi4yHey0tTuzwsd1s4CWLb0cq0zdCLUZQ8DmY4cV4SGGYSyCc3YH+TKKZLBx4YGVgoWR1PR3XPiGCkf+iDJRp5tviuvVn96MnLyBDlilU75TOjIQqAgVTRmoZm3pkfLzIhJY2+33k8WSbJMcSre/DwQJgVuRYHO+YTKFNwDgUHNk8617G29oqb89L59dPBRMdm8hweUMWN/b5Ragcna3I1HDwaRo7+rYegPkRsbR4xMCEdwUqZqY2pbCJlnzOdoJAtQengyMHaAG8vpqob6n7dqkxhE3yAayq6MEHJmf2hdM70/GO3SJ5NEeEnWroitpFey05oPJB16wm2ubNoJY/Bipajfvzuju9BkTjLgMuUPgFHpadpLteEbCDmrHS2d39C0S8utfQyrB+uSFtIJQFTMKQ6LA0ZLb+pKpRrZqkM8kok2a4RwCNDIBWD1VXO6W9dO5sAzB8WxrvQlutv6Fxwm32jVsImzgcWIvbnIN+m7JhD3CAHK620eLb9Xt/7XzXbAjlUOlHjRmdlOZSu07gd7VhYVtxSkVc0justT3al5U7+bDiP+XxuNEcsxRYP7wK6I0WEaSiwkjfPkTOqP2KXZYOJHgOWKYMZFawG0rAbtcrH0+xlg9SVvY6BkbwYbRZBKMOGjypROeqTDlmwaj4VzmRXSY1AA7YIFr4/Mz6m6+Emrn1Wy+jns6wrZ/0JYfk0EDH5YPWw2GRXNqDUNu7VEyFdOaXye4FnE8I66BbHViKn7mq4Ur4lNVC2DFDs0si0M8WizsoIcSEAQ6vyKOReLuR3UjBL9/Q0VqJ3vmlBrHv1Yu91GvXh6PoB6MEoBdTGRq/ZUG2GON7QGJ1rp8//XouvIjHambSd0cVR0sPl7FH80dr7hWnn7e2c2oSZkZ2qd2Fv40lG5lMzOs7YsmlRDW5fREdLe9UqpH80FupEuKb4aEeaXB/P9SOt8jQEpzYkrgIpHkRP3bAxO6/K8cjfVLb5WuQYnZk+CIQync1tzBpPmo42qbEWiR/euPa/m0OZehUkZa1GkSOo/bOqI+J8ESgl+mp5Cs+jM4DLZIBPmQWEXzuNP0x2jRsjG+59JFZ1rZk4cK9A/EXstKFM6aQgDjASF+JE7dC/g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BY5PR12MB4130.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(7416005)(1800799015)(376005)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: qzpRpBfjibkMgWeT74gnfFe/NRMdmYmkSmEJOl0DundnIw7JPekEpy7HtWgekSntY/R4sqW8PqMBpk2eQv7olZjTGjACfPtFKw08shmBgGkKOlPhf0NaSB3hDDSH/36hyvCL4CNdLBY+V+l5zCCQOFhOLs3xeOu2PR5/AEh5NC/XvSE7Ysn/lspcfwnN1LAZtXedaQv8OuW1Iwwpi/VEbKXBnvR0S9JmhmME5fN0XMt746O3eUyC30Z8Hdk4PRRAGnveHdBqPBop7MwTDNWfxZoFZ9MA93HQOjOoepxAQoJzd5Q1KdxdHSXtfT6WJRO0eUVXUbI/+NCPNj6TtcvsRlzA5jl1iZYrgrLXmQvy93KnNGMibJUmI9fhKiD8Zqmnt2dywAcxHa8F3TADj0SV7LIqX6WXh3+kySHndnGfgIX0J8gXPxu2gR0GXlSXJXivtrU3zc7H0t/aMPiCDfrR3WpzBQ7E/DgD+4OcRU0b92RhhAu2UY9AO+4ln2Q5aFlQ9mo6B3zGqTwYoB1kURGULxmtw0FgUEPiMZSNpwfspbJ3ZbeipPrwejhGvQ0dgJ858LqfyDBtDYy9xjgIMzHLXY0ZeBpvhJ2LDyzYIoj0kRB163Fef9nwPa5kic+88gB/drrbQR0V+7OrpyQEfvnxUIu/TA+sVmq0SN78jibV/zrSULhW19QaTz93grc4pyEfT2Ve15KgpqM7wUW8iF5HacHUXJVJbqB90x00KECIrBiA49ozKQs3Wmq5UqHlO+36jV40lFjNJX/A1053Y96Trmb7CjoIWgd7qh+OLE0q2U7ixHP9ytTg4UamWisyX/S5QJ1lz5apoY1dCZ+9P7m252Id6uVR4ISoj2QjXktW/eOUpxV5lwKAUNhN+k216E2gkUJ0kCaNMGMQ4ikgVJpFtdfF45HBBwwftGf4SG7RLQl7iW5YMEHCyNPhClI0j46YsoZZTUK1mL2pJWqJNlLI9nyB6DQiPAUN3O3u32YMkEl0YJtlagSImfhijtVmD0GHqW3nEBRnx4rZ6Kzxd/wxqGxuqRzEs8TRjvtS18Ys+JBXRX3vHJrqiZGy7TJvw4EXbXwnFuaS0NvizAYfFtn8wxtvF5HDK07nAZQl/sJ09KcY/ex5g4RHKZ3YRqZIwQCj/mCjzPAzxuIF/XOSLDvBDQPqW137A3DKbKCfD+uIcPM3DgOUL5r3Z0oLYakbIDw+/5nvieYdfEbooAgGlM0shSSFohIxs1q3jITQDJe4ypW6hxWQw23CTJ1HVJiQhApOxR8APRcgtt1a6yxM55MrIf+J7zW44sXBogBo/L+iRy6Etf4c7VcFhYxy5QndCzXr+FAqy+VW8xenlg4pG/3dzNph0BsZn6bv6nK8vq+CqqQkgg5BHrHPSc0NmyYxqlCsPm6kIeJJsHzlpOVfbjC9MlBLscpYhJ9nDW0fJ0l1uc9273No4ojwSmBzUe0iHuqEBiqMuHBag6kJM8KNC1BtFin4jGGFL8M6wLWS22vICHEqpLuRU/uxQ60Dj3+ZTKMnHquo+a1K/6YI0vB1uOEgP5OD6UN0DC9+BuM31ate6v/WpepkWbpGbljEw1HpUEnNXx51DUJBA6Lakjm4Uri3vA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ee76813a-3484-4c53-d19d-08dc6dff0b21 X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 19:02:15.1725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rzddJ/OmsmtsPK4ktt4UchpGnqhTYrOfPRYB++pLQeg5cwVYqb3tCY6ntPdPo6t31fIE8ki0lA6NJPIPtrRWfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6826 Cc: Nikolay Aleksandrov , llvm@lists.linux.dev, Dmitry Safonov <0x7f454c46@gmail.com>, zhujun2 , LKML , Matthieu Baerts , linux-kselftest@vger.kernel.org, Manivannan Sadhasivam , Steffen Klassert , Willem de Bruijn , Herbert Xu , Geliang Tang , Mat Martineau , John Hubbard , Jakub Kicinski , Paolo Abeni , Sebastian Andrzej Siewior , Alexander Mikhalitsyn , Benjamin Poirier , Ido Schimmel , linux-actions@lists.infradead.org, Hangbin Liu , mptcp@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Petr Machata , Valentin Obst , netdev@vger.kernel.org, Eric Dumazet , "David S . Miller" , dev@openvswitch.org, =?utf-8?q?An?= =?utf-8?q?dreas_F=C3=A4rber?= Subject: [ovs-dev] [PATCH v2] selftests/net: fix uninitialized variables X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: John Hubbard via dev From: John Hubbard Reply-To: John Hubbard Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" When building with clang, via: make LLVM=1 -C tools/testing/selftest ...clang warns about three variables that are not initialized in all cases: 1) The opt_ipproto_off variable is used uninitialized if "testname" is not "ip". Willem de Bruijn pointed out that this is an actual bug, and suggested the fix that I'm using here (thanks!). 2) The addr_len is used uninitialized, but only in the assert case, which bails out, so this is harmless. 3) The family variable in add_listener() is only used uninitialized in the error case (neither IPv4 nor IPv6 is specified), so it's also harmless. Fix by initializing each variable. Cc: Willem de Bruijn Signed-off-by: John Hubbard Reviewed-by: Willem de Bruijn Acked-by: Mat Martineau --- tools/testing/selftests/net/gro.c | 3 +++ tools/testing/selftests/net/ip_local_port_range.c | 2 +- tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 2 +- 3 files changed, 5 insertions(+), 2 deletions(-) base-commit: f462ae0edd3703edd6f22fe41d336369c38b884b prerequisite-patch-id: b901ece2a5b78503e2fb5480f20e304d36a0ea27 prerequisite-patch-id: e81ae5ca6c427dde802acd4c1442c82e170c251a diff --git a/tools/testing/selftests/net/gro.c b/tools/testing/selftests/net/gro.c index 353e1e867fbb..6038b96ecee8 100644 --- a/tools/testing/selftests/net/gro.c +++ b/tools/testing/selftests/net/gro.c @@ -119,6 +119,9 @@ static void setup_sock_filter(int fd) next_off = offsetof(struct ipv6hdr, nexthdr); ipproto_off = ETH_HLEN + next_off; + /* Overridden later if exthdrs are used: */ + opt_ipproto_off = ipproto_off; + if (strcmp(testname, "ip") == 0) { if (proto == PF_INET) optlen = sizeof(struct ip_timestamp); diff --git a/tools/testing/selftests/net/ip_local_port_range.c b/tools/testing/selftests/net/ip_local_port_range.c index 193b82745fd8..29451d2244b7 100644 --- a/tools/testing/selftests/net/ip_local_port_range.c +++ b/tools/testing/selftests/net/ip_local_port_range.c @@ -359,7 +359,7 @@ TEST_F(ip_local_port_range, late_bind) struct sockaddr_in v4; struct sockaddr_in6 v6; } addr; - socklen_t addr_len; + socklen_t addr_len = 0; const int one = 1; int fd, err; __u32 range; diff --git a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c index 7426a2cbd4a0..7ad5a59adff2 100644 --- a/tools/testing/selftests/net/mptcp/pm_nl_ctl.c +++ b/tools/testing/selftests/net/mptcp/pm_nl_ctl.c @@ -1276,7 +1276,7 @@ int add_listener(int argc, char *argv[]) struct sockaddr_storage addr; struct sockaddr_in6 *a6; struct sockaddr_in *a4; - u_int16_t family; + u_int16_t family = AF_UNSPEC; int enable = 1; int sock; int err;