From patchwork Tue Apr 24 08:05:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Alin_N=C4=83stac?= X-Patchwork-Id: 903316 X-Patchwork-Delegate: blogic@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="trPccTht"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="WNwilZ5/"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40VbVb5NXwz9s0v for ; Tue, 24 Apr 2018 18:05:43 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:Date:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=sgJzrUcmJVQ5b4as2d3PMsirxgZ+X2uqcEmzA+W0u68=; b=trPccTht+ZpTLQ z1ikzsauLYKSx5yc2d5w376GG+Nkps4u07Z6+3ypleIMIHKpAMxDlLm4DM/QTJDn6V7IsEZ7Gtonq iI1OWYq5bXtbpU1pTvyZrGcf4KUIRMFPy12QyZ7uk6ijZrExjNXx1959xWBGs0J+1e39VSbP4saYc s3K9c/elNmmmz+2FqVAeps5LnEBPdH8SEWPSMkNeT/nNtCZkWIXTly6z/f+5CLrQQ8+8AKrg/7/G1 qNaaBW2ppMn4RtQGIaXE+sqR5oFUy5nqGMkixt5iExj3AUkD7XJud+ZDJ6lRBmC9KYRycgH6G44d6 8geXMB6Mj/JH7700VT/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAsxG-000412-Mk; Tue, 24 Apr 2018 08:05:38 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAsx9-0003ys-Ql for lede-dev@lists.infradead.org; Tue, 24 Apr 2018 08:05:37 +0000 Received: by mail-wr0-x242.google.com with SMTP id u18-v6so20756480wrg.3 for ; Tue, 24 Apr 2018 01:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=VWgdZ3ses+5rKoeAH1iJHLoR0B3xYhXr/IRuNcB3k2o=; b=WNwilZ5/pxIvGWDcAHBfiohJEVwO89M01GpTL73zw+YmPpDcRPpKs+xQ8t/0n5Qlat 0L4zvq9feLx5EMrjpB02Uxco1MbhXqpL5PK6niNlB8TaXAHLyJTRUqQlj/8M8z2kO4Tf VLJBtcyOegOZAglw+mDWsjIxOQfET2czkGTA/vEOJ3QZPPciG89BfhWlWbQmiv05iNPQ mITZuAbohAYCfk/S60Cm7vRMjz6QsFRhS1Vb1IstX/dPFMVooL9Vk/o8tH5OetgmTCJV FJbePpEmCE10Wac7MM9U2sf04EkB6UtiK80t14bx3x4jtceiu4RVIEeajLnFbpnHHqps CZyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=VWgdZ3ses+5rKoeAH1iJHLoR0B3xYhXr/IRuNcB3k2o=; b=RQ7hK+6GWohD1V53oRFawlpnhcB25oaPuALuS3qL4Szqs+PU9ygJ9x2Yya/aKrc1T2 zhM86qM27TAXE5iL0ANjvsUoHszB5xmxqa0VYDXezaoz7vBaTZ05v4zsSmR2GCs0wKA0 BQSykl7X2Vu0YbmaR8pCeZ4dYyFhbYkbp/mMreorKNGZ6ftNZfV7qMq9Jtk6LhdHd1Xa Hd52ykAL6NZs6+rYZa4KYJW5aujqQbQsRcmuD3xWxbDw7gya0G3QCYyrnbkgXuPSX8MN UiMxQghkwxw56mf/W2fd1GYRIED3F6mEo7k6aUgxTVAwoKZ9Qa5fb9vMo1w1Im1oTOo0 dEZg== X-Gm-Message-State: ALQs6tC7wukeD45+W38v3+r05elc8PS3uia721HVK/RzFqlA2/gS46wr rNx06YHJkO1n1jWNdC97ClPg+Q== X-Google-Smtp-Source: AB8JxZrjIdrQdyTEkf5nUSA38Am44zc557S3c0f5/TIzk6tAcjoLH07Q1GqaN5SxqFRGA0ErTUPXsg== X-Received: by 10.28.35.72 with SMTP id j69mr11981943wmj.45.1524557119206; Tue, 24 Apr 2018 01:05:19 -0700 (PDT) Received: from cplx1037.edegem.eu.thmulti.com ([2001:4158:f012:240:2a10:7bff:fec5:6f08]) by smtp.gmail.com with ESMTPSA id e50-v6sm34614800wre.4.2018.04.24.01.05.18 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Apr 2018 01:05:18 -0700 (PDT) From: Alin Nastac To: lede-dev@lists.infradead.org Date: Tue, 24 Apr 2018 10:05:12 +0200 Message-Id: <1524557112-2455-1-git-send-email-alin.nastac@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180424_010531_866922_5DAF819C X-CRM114-Status: GOOD ( 10.04 ) X-Spam-Score: -0.1 (/) X-Spam-Report: SpamAssassin version 3.4.1 on bombadil.infradead.org summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2a00:1450:400c:c0c:0:0:0:242 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (alin.nastac[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain Subject: [LEDE-DEV] [PATCH] iptables: link extension libraries with -lm X-BeenThere: lede-dev@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Lede-dev" Errors-To: lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This fixes an iptables link error when kernel config include CONFIG_NETFILTER_XT_MATCH_STATISTIC=y related to the missing -lm argument on the linker command line. Error is caused by the odd looking linker argument ${$*_LIBADD} which get expanded to an empty string. Signed-off-by: Alin Nastac --- package/network/utils/iptables/patches/600-shared-libext.patch | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package/network/utils/iptables/patches/600-shared-libext.patch b/package/network/utils/iptables/patches/600-shared-libext.patch index a906d40..17e7fbe 100644 --- a/package/network/utils/iptables/patches/600-shared-libext.patch +++ b/package/network/utils/iptables/patches/600-shared-libext.patch @@ -28,27 +28,27 @@ -libext.a: initext.o ${libext_objs} - ${AM_VERBOSE_AR} ${AR} crs $@ $^; +libiptext.so: initext.o ${libext_objs} -+ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${$*_LIBADD}; ++ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${xt_statistic_LIBADD} ${xt_connlabel_LIBADD}; -libext_ebt.a: initextb.o ${libext_ebt_objs} - ${AM_VERBOSE_AR} ${AR} crs $@ $^; +libiptext_ebt.so: initextb.o ${libext_ebt_objs} -+ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${$*_LIBADD}; ++ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${xt_statistic_LIBADD} ${xt_connlabel_LIBADD}; -libext_arpt.a: initexta.o ${libext_arpt_objs} - ${AM_VERBOSE_AR} ${AR} crs $@ $^; +libiptext_arpt.so: initexta.o ${libext_arpt_objs} -+ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${$*_LIBADD}; ++ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${xt_statistic_LIBADD} ${xt_connlabel_LIBADD}; -libext4.a: initext4.o ${libext4_objs} - ${AM_VERBOSE_AR} ${AR} crs $@ $^; +libiptext4.so: initext4.o ${libext4_objs} -+ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${$*_LIBADD}; ++ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${xt_statistic_LIBADD} ${xt_connlabel_LIBADD}; -libext6.a: initext6.o ${libext6_objs} - ${AM_VERBOSE_AR} ${AR} crs $@ $^; +libiptext6.so: initext6.o ${libext6_objs} -+ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${$*_LIBADD}; ++ ${AM_VERBOSE_CCLD} ${CCLD} ${AM_LDFLAGS} -shared ${LDFLAGS} -o $@ $^ -L../libxtables/.libs -lxtables ${xt_statistic_LIBADD} ${xt_connlabel_LIBADD}; initext_func := $(addprefix xt_,${pfx_build_static}) initextb_func := $(addprefix ebt_,${pfb_build_static})