From patchwork Wed Apr 17 19:19:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 1924740 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=jiz9GMMY; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45d1:ec00::1; helo=ny.mirrors.kernel.org; envelope-from=linux-rtc+bounces-1042-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [IPv6:2604:1380:45d1:ec00::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VKW274B3Tz1yYB for ; Thu, 18 Apr 2024 05:19:59 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B50D81C21856 for ; Wed, 17 Apr 2024 19:19:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A591241E7; Wed, 17 Apr 2024 19:19:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jiz9GMMY" X-Original-To: linux-rtc@vger.kernel.org Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B764182AF; Wed, 17 Apr 2024 19:19:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713381593; cv=none; b=Hgm0C2B/sQfybCVyYzCkuc63xPiiGAAun3KaWanBC0RhBFDI+g1GGEOaBguQ601sFuUCpLPJl53urpdKPOODm/QJ0uAkvvEbksxvx22tuq1gQ6jvj0LNIE22rg5kKzIL8Pp6tUuQDIgsdCh71RVmLf4kNpItiDHVo1Ed804sVHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713381593; c=relaxed/simple; bh=AeUpsW2kfdTLP8cytZxJnozfmR5aDxkpG7wLSKBxCCM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=auHbSDcWdToOInAa/O2kGE0zEet7dyzU4g242xe/HehWzPVJA79NzX3/P6Zsf6zTqKoW1p450i1iJApJhxzyaJnk7IeezHSxfJTXBaI8EnN/Be15DpkYbs2VHklPJ8TZUIoqqMT2Ynd7Uk3RYJ7bgWC66Gbl3DnYlp4Au2+CAJs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jiz9GMMY; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 090FA240006; Wed, 17 Apr 2024 19:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713381588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=qnegySRP2t/rhTa6N++GcpoVh6UOOmzaniiw8ruo3KU=; b=jiz9GMMYydwERXWFLzxGKwFo1BrJj+wOXaf5lzHHANvPOPALLlLe5cDtPEfAoiioIsJR9Q bjVdwExgBRaCHztfdrra3HSHixE4BG5bEJxjf15yar53iiLOPiODV3eQYaad09rt8bKcki QvvSmHJrKj0TbGR2eYXtmPlHrrgJVs10ufXVJfFnHDXYs+biSLWBJxesJuoVHHPnMOXZFQ AeNagQGR4sHwjyNnE47+P9X0t8C62uqO5OvPMETHB/JnAI9MOTkfIo3t39hUxDbKWlxb6I uMrgtlAr7umZ0W4DM01wj2x2JiyxOsmyEkELQVXY7MD42UeJqXr6GDgfW5xlJg== From: alexandre.belloni@bootlin.com To: Alexandre Belloni Cc: Waqar Hameed , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] rtc: rx8111: demote warnings to debug level Date: Wed, 17 Apr 2024 21:19:35 +0200 Message-ID: <20240417191937.33790-1-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: alexandre.belloni@bootlin.com From: Alexandre Belloni The proper way for userspace to react on a read time error is to have a look at the voltage low information. There is no point in cluttering dmesg as it is often not even visible to the end user. Signed-off-by: Alexandre Belloni Reviewed-by: Waqar Hameed --- drivers/rtc/rtc-rx8111.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rx8111.c b/drivers/rtc/rtc-rx8111.c index 62d2352de102..4a35bd921b33 100644 --- a/drivers/rtc/rtc-rx8111.c +++ b/drivers/rtc/rtc-rx8111.c @@ -170,14 +170,14 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm) } if (FIELD_GET(RX8111_FLAG_XST_BIT, regval)) { - dev_warn(data->dev, - "Crystal oscillation stopped, time is not reliable\n"); + dev_dbg(data->dev, + "Crystal oscillation stopped, time is not reliable\n"); return -EINVAL; } if (FIELD_GET(RX8111_FLAG_VLF_BIT, regval)) { - dev_warn(data->dev, - "Low voltage detected, time is not reliable\n"); + dev_dbg(data->dev, + "Low voltage detected, time is not reliable\n"); return -EINVAL; } @@ -188,7 +188,7 @@ static int rx8111_read_time(struct device *dev, struct rtc_time *tm) } if (regval) { - dev_warn(data->dev, "Clock stopped, time is not reliable\n"); + dev_dbg(data->dev, "Clock stopped, time is not reliable\n"); return -EINVAL; } From patchwork Wed Apr 17 19:19:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Belloni X-Patchwork-Id: 1924741 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=oIgRsW3U; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.199.223; helo=ny.mirrors.kernel.org; envelope-from=linux-rtc+bounces-1043-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VKW2M3BhKz1yZ2 for ; Thu, 18 Apr 2024 05:20:11 +1000 (AEST) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 24E2C1C2193D for ; Wed, 17 Apr 2024 19:20:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8DC42241E7; Wed, 17 Apr 2024 19:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="oIgRsW3U" X-Original-To: linux-rtc@vger.kernel.org Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B1A2BB16; Wed, 17 Apr 2024 19:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713381599; cv=none; b=F78zuYr/oLOAD2ONQRVPCKIR3iS17hXQXLSgNBc9Y+8CDEmZQKHBcm3krwTThHBZXR9RtZNxFHSs/QFoHW/CkM1DWVa5vonrYicO4XborJbAUlE9tzF1sVV3X4OzJSFdS5MDSsVZ4xqgtAVfNkBERGNJHnGJjYem91Uy59VWNpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713381599; c=relaxed/simple; bh=1WkTOQjl0bt6iavNqrnDeQegNFNYwXSEDpYVQxuGjJ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LbLZ/9SzyGRYbUJMrMMi3l1M0aUWOrPw+Z/tXqEtjg9/SFR616gXotypVzXSS5ydZ5xMK1MGnR3M6wN+8RrC0+Q82UwOjANyxlHgIUwMl/xOM+kYJ+EVlFWNkr37ZLV4FBUW/2d69iZhtJClFXXvKCU8FXEX4y9scHd8oJEO6MA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=oIgRsW3U; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 4FB9460002; Wed, 17 Apr 2024 19:19:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1713381595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jQo9vcuwNFak9EahRUpeiFOj0bXZpNg5mHU6fet7Il4=; b=oIgRsW3UbIUkZDmclmiZaDkSJLJ7avJgIK/ktpfLzl05AZRllOBSQFqJaaYSZwKWFpTGMH tnW98VdSuTYN2q0RO298pBc9j+23NzAzm6xeovJUTiy9DcRFfNQcHCcWj78Dzzs517bocA hQLFlp0KV67qLvRR5rpxytjQ/icmuvGVAyW+rkgZaEJkR9+lcp4lVoLn98DZDFVBgyMWPB X1sz8emUKahIZ++XYFsnuWwW0YHrX2wFVoLsrIx7OoWJgaHZ5Vvu5nbShRrAfb+9L9S7eq I4n0qazoUj3C8A7sdxjmk1ayRgJHZGi8dciuNpowoay0e4+kPExrpesO/cvbuA== From: alexandre.belloni@bootlin.com To: Alexandre Belloni Cc: Waqar Hameed , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] rtc: rx8111: handle VLOW flag Date: Wed, 17 Apr 2024 21:19:36 +0200 Message-ID: <20240417191937.33790-2-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240417191937.33790-1-alexandre.belloni@bootlin.com> References: <20240417191937.33790-1-alexandre.belloni@bootlin.com> Precedence: bulk X-Mailing-List: linux-rtc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: alexandre.belloni@bootlin.com From: Alexandre Belloni Allow userspace to get battery status information and be able to warn when battery is low and has to be replaced. Signed-off-by: Alexandre Belloni Tested-by: Waqar Hameed Reviewed-by: Waqar Hameed --- drivers/rtc/rtc-rx8111.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/rtc/rtc-rx8111.c b/drivers/rtc/rtc-rx8111.c index 4a35bd921b33..8450d9f0b566 100644 --- a/drivers/rtc/rtc-rx8111.c +++ b/drivers/rtc/rtc-rx8111.c @@ -95,6 +95,9 @@ enum rx8111_regfield { RX8111_REGF_INIEN, RX8111_REGF_CHGEN, + /* RX8111_REG_STATUS_MON. */ + RX8111_REGF_VLOW, + /* Sentinel value. */ RX8111_REGF_MAX }; @@ -129,6 +132,8 @@ static const struct reg_field rx8111_regfields[] = { [RX8111_REGF_SWSEL1] = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 3, 3), [RX8111_REGF_INIEN] = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 6, 6), [RX8111_REGF_CHGEN] = REG_FIELD(RX8111_REG_PWR_SWITCH_CTRL, 7, 7), + + [RX8111_REGF_VLOW] = REG_FIELD(RX8111_REG_STATUS_MON, 1, 1), }; static const struct regmap_config rx8111_regmap_config = { @@ -276,6 +281,13 @@ static int rx8111_ioctl(struct device *dev, unsigned int cmd, unsigned long arg) vlval = regval ? RTC_VL_DATA_INVALID : 0; + ret = regmap_field_read(data->regfields[RX8111_REGF_VLOW], + ®val); + if (ret) + return ret; + + vlval |= regval ? RTC_VL_BACKUP_LOW : 0; + return put_user(vlval, (typeof(vlval) __user *)arg); default: return -ENOIOCTLCMD;