From patchwork Tue Apr 2 13:02:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1918786 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=n+iHVc/y; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Q3lJs5Rm; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V87PC4F66z1yZB for ; Wed, 3 Apr 2024 00:03:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+DgNY/4nc0qkkFZ89+13QRXYy5zmQ2O1gE2/NydjvBc=; b=n+iHVc/yEFapmI hA0bGKfCRDQQDMFgfuulvGcQQaa6T2DdVz6cvNtQgbvaW7MTiJGIP/gM2ozWkhAJ1rQBcDlZ1evsq kgV0L9/Jhq+5bM41pEoQDVHSD5h2h9gjY+V1c1bss1fSP0luuSiFeTTSZd2VO+s9tBEuB+YoGbT/T xu01gmQzbZDM9cw1sF2qrZamWEmg99SDDX1A/99bZGsbXHaeFXZjNYgVPdXFvoSzDcICg7a6a2tLw sCIjzW7HuBbiC1lu8Os/Y6DZIg71iF9NUh3Qi9X7KbNKWvkMcxYCYaidQ6hVFPs3URS6uotrrRflW G2u4CI3AmpIwHPGIg+cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmW-0000000BDQx-22eM; Tue, 02 Apr 2024 13:02:28 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmT-0000000BDPq-0l2G for openwrt-devel@lists.openwrt.org; Tue, 02 Apr 2024 13:02:26 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-513e10a4083so5869866e87.1 for ; Tue, 02 Apr 2024 06:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712062942; x=1712667742; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=ImfS2UxrHK3gDoolN8yX9t2R8fpZ4tJGTf5l8TI0prk=; b=Q3lJs5RmXzK+DyA2XtMdtllrLaaUV5ea/uNsHWmhahjJMUzDYavJEOemMXagnjxiHx a57voePikObCcJ+erHBS8Aaw/Ls2HC1BxkRdEdmsDElF9EDlC3qj2bQnlMaA6c3d8Mac px3QUjL3RBEqugTD7ewQM9sSiLujagLGygot6laRo+94w6k4AtT1Mg7/w0BnSY+CZ1bh yzEGIxy1vNjMA1mJ9SrhLLiDpxMj1yFaF/iIASZ+o/AoYIMPA5wNUBIoP4R9kr/08cCi hEZNUmkQ9/C5D+oHRMXQlfU02FkUTka1BM/BGYL3Lm1REtHAvI70JQnDkQ5qNXqEmsjt oPCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712062942; x=1712667742; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ImfS2UxrHK3gDoolN8yX9t2R8fpZ4tJGTf5l8TI0prk=; b=eYSmg2btS2xb0a1xjkuNivg4i5iC2Y4dY+IJKF35gmQZLQ2AEPNLYR/G5h+2hqfCwm 1vlyU/X1Wv0f03dU1KDxlucx3j0oiyM3tv/znBoBZChvRHSJaB/0IAvoONOLrydI9OlJ LgRqGFiSTVzttexxXCtDEQKkV06E6X/Fhpkts8hgTadAODpJNQfEmKHHzYg6kC2Fikhq +jRbooJld0tIYJo6VlgSN5nsZqz7hKqgvluAMRJGNEAFu8xV6P9K7XszC9g1nkLkq2ep ACTterBtrR3usi4QYJJ8QssVeTEgv5CoCck8tjBNK0KmrEN357vu89nsm72Z6H+9736S cWNA== X-Gm-Message-State: AOJu0YwMwTj54Xmx5EGK+/RZWugJaeamirbk9J78Tf1Ty30JseISlmqe 6HNzFkcob/8G6lhbX0Puyw9RjvUYjSYpI7pbVH2iCjGGFJVja/vUZDu+0mGw X-Google-Smtp-Source: AGHT+IET6eGv29Ysk8Qu2nX25db2tps6znT96U129IH/BvyfgZyx+QgeupYwMdEj85lYqE0IYQCiBg== X-Received: by 2002:a05:6512:3e4:b0:515:ccd8:37c2 with SMTP id n4-20020a05651203e400b00515ccd837c2mr7234906lfq.44.1712062942389; Tue, 02 Apr 2024 06:02:22 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id d8-20020ac241c8000000b00515fc468f45sm995071lfi.31.2024.04.02.06.02.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 06:02:22 -0700 (PDT) From: Paul Donald To: openwrt-devel@lists.openwrt.org Subject: [PATCH 1/7] lldpd: fixed interface(s) parsing Date: Tue, 2 Apr 2024 15:02:15 +0200 Message-ID: <20240402130221.58706-1-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_060225_497693_F6D94CAC X-CRM114-Status: GOOD ( 11.68 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: For interface type parameters, the man page documents patterns: ``` *,!eth*,!!eth1 uses all interfaces, except interfaces starting with "eth", but including "eth1". ``` While we must check that interfaces exist, first strip any prefixed "!" then pass the original string (with `!` prefix) again, to command lines. Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:12f listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org For interface type parameters, the man page documents patterns: ``` *,!eth*,!!eth1 uses all interfaces, except interfaces starting with "eth", but including "eth1". ``` While we must check that interfaces exist, first strip any prefixed "!" then pass the original string (with `!` prefix) again, to command lines. * Renamed `_ifname` to `_l3dev`. * Glob pattern `*` is also valid - pass those verbatim. The net result is that now interface 'names' including globs '*' and '!' inversions now are included in the generated lldpd configs. We must also `set -o noglob` and `set +o noglob` to disable and enable globbing respectively, because when we pass `*` as an interface choice everything goes to hell without them. Tested extensively on: 22.03.6 Signed-off-by: Paul Donald --- .../network/services/lldpd/files/lldpd.init | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 67ee011ae2..fc53520c5b 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -76,18 +76,32 @@ get_config_restart_hash() { } get_config_cid_ifaces() { + set -o noglob local _ifaces config_get _ifaces 'config' "$2" local _iface _ifnames="" for _iface in $_ifaces; do - local _ifname="" - if network_get_device _ifname "$_iface" || [ -e "/sys/class/net/$_iface" ]; then - append _ifnames "${_ifname:-$_iface}" "," + local _l3dev="" + # save any "!" or "!!" prefix from the interface name + _suffix=${_iface##*"!"} + _prefix=${_iface%%"$_suffix"} + + if network_get_device _l3dev "$_suffix" || [ -e "/sys/class/net/$_suffix" ]; then + # prepend the stripped "!" or "!!" prefix here if we had one + append _ifnames "$_prefix${_l3dev:-$_suffix}" "," + else + case $_iface in + *"*"*) + # Append any interface names including a glob '*' pattern + append _ifnames "$_iface" "," + ;; + esac fi done export -n "${1}=$_ifnames" + set +o noglob } write_lldpd_conf() From patchwork Tue Apr 2 13:02:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1918789 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=gGOz5wWE; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=eMQL4mu3; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V87PM3Kxmz1yYB for ; Wed, 3 Apr 2024 00:04:07 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H8TQBvg6a6HHpTmd9P2xDdwAMF7gwLb1/tiadVCMI3E=; b=gGOz5wWEjSw6AW 2OZSwtt/PBwSnANssu7rE6VDnaypXfVWoVA1y5u2sydys1T3iANW45cHwNmDUH+Iqb7bNC/ML1cuZ N71lO6N6YKzYp4DoOqSgaa6WjVpXsP7hF9glDs8IBUPv7g7V4yBRkk2N92lYYl93InD8Xs7it649f U4OHCGrbiB/wveks/jqcfrpechx+ei5PYmPLIi5dJkFvv5fb6onDIlcxMW+Sx4hNAmlHvcmDKwJgf B2SG8SlNsz+HPvocWc3myz+EE/Cy1q7zyeFx1yqYWshAZP+cKTILwLBuI8pXwXsegbqTJlbfJ+7Nh kT+hKuolqd6ojnb5gIAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmm-0000000BDUF-4305; Tue, 02 Apr 2024 13:02:44 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmb-0000000BDPr-0F2m for openwrt-devel@lists.openwrt.org; Tue, 02 Apr 2024 13:02:34 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-513e10a4083so5869873e87.1 for ; Tue, 02 Apr 2024 06:02:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712062943; x=1712667743; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=1cPpNGRd3aQpDMj64WCShILYivWahJKI2FdD8yWr6e8=; b=eMQL4mu3bA2/WcSp22NHJvMJnhQ+gwLf0iU+HqCmhq+CugF1ayOF7Brqe1e9niCoGD m0Xo1V22j3KVU0hIwCF0xZG2CTpTN4MPII/fycgGxam1Gs495Djo1+BncH6u5dKHtYLg ToPnaJlqurSzRApYP9hSg6mrgJH1FrZDwMp0n/gR5Y0BpE8Cwjm/0FtRgKela2DhXiyk F9wuinVtCbSqioXW3Uvv3NSb8icX8kinLj9sOVn+ppjOOPmDEKJL41eUYipMXwOxUyZq d+DPtJT3be7vOh62jfyPAI+e3tXFnx4Laj9iD4TEvxADzs6SAICfl0o1V5Ro1L9C5fgh qytQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712062943; x=1712667743; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1cPpNGRd3aQpDMj64WCShILYivWahJKI2FdD8yWr6e8=; b=QnmITWjaSod876Abe+QeUx1dibGYYabr4AMEu+sCJcImRuYLfOWEpe8Ljge72fmTZM xcyTdAhHImI/FKyby9TFJfhQWeXiwrgZ/wzsMVzdHnwT0nmfY+uveWnVB4ymQefAuP66 fokCHGUYFuqnMvY43ATSeNFo79zSIX2+lwoIpcGTENKgujWIOK0aJoU7TTnGx42oSLvQ Kz0SYpWgvIhQ4oQ9EUVeC9oxWB46L46i6fDw+iWxbyPNnRD7+wIL6zccfZeJPf7c5VHV Qxg/wBcAz/zsc6meL/vAsD8TKtQnKbAfjkSnf4LSR6OSdCoRPADVXGthwLGpYgTjWEaJ RFzQ== X-Gm-Message-State: AOJu0YzGY3DLix6hhuQtgb/hSn8fT80rT8S+/3TbboQJGn2aXdpA371L lWEpJGgAZPTnbUiywPvHKaS2HuGtm/4V1xjxBPDd0VYxxgEAKc3X71mllvYX X-Google-Smtp-Source: AGHT+IFZHmbTpdiO31avheRXXDwh5X90njF8omRm8zlQ1a84+wWiUoG1F3CJhLQUTf70+SBY+V6xnw== X-Received: by 2002:ac2:599a:0:b0:513:d08b:3790 with SMTP id w26-20020ac2599a000000b00513d08b3790mr7169860lfn.49.1712062942764; Tue, 02 Apr 2024 06:02:22 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id d8-20020ac241c8000000b00515fc468f45sm995071lfi.31.2024.04.02.06.02.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 06:02:22 -0700 (PDT) From: Paul Donald To: openwrt-devel@lists.openwrt.org Subject: [PATCH 2/7] lldpd: get_config_cid_ifaces() -> get_interface_csv_pattern() Date: Tue, 2 Apr 2024 15:02:16 +0200 Message-ID: <20240402130221.58706-2-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402130221.58706-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_060233_223644_4DB84F25 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Make the function more generic. Can use it for not only 'config'. Now it can be used to parse interfaces for additional lldpd settings Tested on: 22.03.6 Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:130 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Make the function more generic. Can use it for not only 'config'. Now it can be used to parse interfaces for additional lldpd settings Tested on: 22.03.6 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index fc53520c5b..069c8fee80 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -75,10 +75,10 @@ get_config_restart_hash() { export -n "$var=$_hash" } -get_config_cid_ifaces() { +get_interface_csv_pattern() { set -o noglob local _ifaces - config_get _ifaces 'config' "$2" + config_get _ifaces "$2" "$3" local _iface _ifnames="" for _iface in $_ifaces; do @@ -115,7 +115,7 @@ write_lldpd_conf() config_get lldp_hostname 'config' 'lldp_hostname' "$(cat /proc/sys/kernel/hostname)" local ifnames - get_config_cid_ifaces ifnames "interface" + get_interface_csv_pattern ifnames 'config' "interface" local lldp_mgmt_ip config_get lldp_mgmt_ip 'config' 'lldp_mgmt_ip' @@ -327,7 +327,7 @@ start_service() { # ChassisID interfaces local ifnames - get_config_cid_ifaces ifnames "cid_interface" + get_interface_csv_pattern ifnames 'config' "cid_interface" [ -n "$ifnames" ] && procd_append_param command -C "$ifnames" From patchwork Tue Apr 2 13:02:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1918787 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=y5KO2HJD; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=lGrfebRG; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V87PJ6D1vz1yYB for ; Wed, 3 Apr 2024 00:04:04 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FLTzdpY1n8HtTg9UZCX/MtvxZIyvr174FN02ilzuFw4=; b=y5KO2HJD/sb6Ql EH6FJYY1i/hKqjSjRMaLoVKsYFuwwi+7adiyFd7AZjGlKwTXRjqIaKBDl9DUyH2KzMn10cyL9FFiP +c8kY6FPoGQWUAAKsQ48y/W0ofCrckB0CaqBuKrawe82rdTC/24+u7DXXO19O2JXCx995Q4mZVwm4 muUZ91tWtiqdxEQFeLjNQHo/PvACgjeDZU0wdFrQYPWSuu4QD4+hJs1fHsJTdpFLsDyDtVSxxaA8h mSmDRMznyFyeedPX1ai6s36eYYYiKBO8unT/T9gxnj+cUbE7MOhZalhQr6DiADBW4Hv2LuDUUplb1 M2/oyucYa8rXU0isAtsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmv-0000000BDZH-44j5; Tue, 02 Apr 2024 13:02:53 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmb-0000000BDQ6-0EEf for openwrt-devel@lists.openwrt.org; Tue, 02 Apr 2024 13:02:35 +0000 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-516afb04ec7so1562191e87.2 for ; Tue, 02 Apr 2024 06:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712062944; x=1712667744; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=svbBmpUnwB9Q5MUXctX7SMY6TVb1QTXJwF5tC5caJJs=; b=lGrfebRGXSt6NLxLpT1N5iC0EqSgBMG7rgF8GHkmHgR1i543dPGOpW1qiVtOrySVIf 9qVh6XPzYJ1TvJkE70K32QpQWBx46SWiVRdTY61AQS1pAoAJV2doEYuL2LZ89hZr1Py3 +T7nMpxsXJQ1XW2cT+wzY1z+i/hOuyE5Cdp8TRXXw8IECd6iNb/9XPd//EMxBmZcasvT vSePHMiTn/8ORXsOGR4jyrhqSslSX3/SX6silGG+xQOSH4Wmprlkcto+WpjOvKQurTDf DFwmt9r+uOLLR7yX2eAf/9zDr2hE81RCB9IUlOSJs2fZLUkj9hxWpRFUdw2vgW7YLq2S K0gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712062944; x=1712667744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=svbBmpUnwB9Q5MUXctX7SMY6TVb1QTXJwF5tC5caJJs=; b=qm18F3XDxXkZdK9piEydRUCISGCTJZIC5fgsl0prIYMaLzDG74nrLjLVuKE9yGSbWO mYvo3dwxHJ0UfAo3q4J1aA+kajwKInvOtrJXBealUCOpfjHykghyXjnDy2IP3qM5gWkE P50KRV+LQrshEtLrd0oLIiP0lfkfA2nSqOUEQUvFWx/cssGlvv6zt09RZ3rc0bu7nbu+ hGhCLgk0G9VoKWHzq+sRRkupYsdjAmZQnnsTd3gYui+KBgGt1IRSz1DPrfVJGlkFBDwN 52FWv6JGsvDLk5Dgnh9esCLWRv2Aip7Pap7snV0oI7094UY0pjGISbaQeNLEsXCX9TZJ d54Q== X-Gm-Message-State: AOJu0YzCV9XpkUrZR/0cnPy5Z7mJaa1njFgqROkW/6z3KmRbwj7fFUcE Yj0hDg5jpaxU00bn2+F+BSvhfYcFDDdIow8Si1y6uYzlRk30Xpg+Mpc1k9Ky X-Google-Smtp-Source: AGHT+IFl2QMrtZJvJAFifcNERLuetXBEuKxqse2zWvrcpp0NinLcrIdmv1oC32Ixz76FL9iKXTjlLQ== X-Received: by 2002:ac2:5f59:0:b0:513:cbf2:50b2 with SMTP id 25-20020ac25f59000000b00513cbf250b2mr7865148lfz.13.1712062943982; Tue, 02 Apr 2024 06:02:23 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id d8-20020ac241c8000000b00515fc468f45sm995071lfi.31.2024.04.02.06.02.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 06:02:22 -0700 (PDT) From: Paul Donald To: openwrt-devel@lists.openwrt.org Subject: [PATCH 3/7] lldpd: fix restart Date: Tue, 2 Apr 2024 15:02:17 +0200 Message-ID: <20240402130221.58706-3-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402130221.58706-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_060233_239315_ACE6A9FF X-CRM114-Status: GOOD ( 10.70 ) X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: redirection broke in 5364fe0f01ca11b47c55d78f756d3176748dd0c2 redirects to /dev/null shall be handled correctly (i.e. last). This fixes these errors on `/etc/init.d/lldpd reload`: Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:131 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org redirection broke in 5364fe0f01ca11b47c55d78f756d3176748dd0c2 redirects to /dev/null shall be handled correctly (i.e. last). This fixes these errors on `/etc/init.d/lldpd reload`: 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` 2024-03-16T20:39:00 [WARN/lldpctl] unknown command from argument 1: `/dev/null` Tested on: 22.03.6 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 069c8fee80..0334156fee 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -363,7 +363,7 @@ reload_service() { return 0 fi - $LLDPCLI -u "$LLDPSOCKET" 2>&1 /dev/null <<-EOF + $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF pause unconfigure lldp custom-tlv unconfigure system interface pattern @@ -373,7 +373,7 @@ reload_service() { unconfigure system platform EOF if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ]; then - $LLDPCLI -u "$LLDPSOCKET" 2>&1 /dev/null <<-EOF + $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF unconfigure med fast-start EOF @@ -381,9 +381,9 @@ reload_service() { # Rewrite lldpd.conf # If something changed it should be included by the lldpcli call write_lldpd_conf - $LLDPCLI -u "$LLDPSOCKET" -c "$LLDPD_CONF" -c "$LLDPD_CONFS_DIR" 2>&1 /dev/null + $LLDPCLI -u "$LLDPSOCKET" -c "$LLDPD_CONF" -c "$LLDPD_CONFS_DIR" >/dev/null 2>&1 # Broadcast update over the wire - $LLDPCLI -u "$LLDPSOCKET" 2>&1 /dev/null <<-EOF + $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF resume update EOF @@ -391,6 +391,6 @@ reload_service() { } stop_service() { - rm -rf ${LLDPD_RUN} "$LLDPSOCKET" 2> /dev/null + rm -rf ${LLDPD_RUN} "$LLDPSOCKET" >/dev/null 2>&1 } From patchwork Tue Apr 2 13:02:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1918783 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=xXjnqNIH; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=fWwjSZnf; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V87P54zvPz1yYB for ; Wed, 3 Apr 2024 00:03:53 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jPsIO7P7UHX1uUs0z29RQcxRbuNfiPNmrBp9+1XUGcI=; b=xXjnqNIHfRQAgd MGNjjt2ruIaWsVjEUVdLIHjGj/Hsp6bBUmc/iLimFoTr3lmsi+kLZUIY8r0NbBpkzNaOuk20/YKBV NqSEg7JTJcWvnbtsQLEZFrK70MOmqFZgcNJtcIDhaBu6e4Te2aaGYx0TxmC6uieu4UsGPVw9amo2d 2MVjvRiPGhaRHgN5gFyRyxM6On2Sf0m/NnniV003lO7JWWbg3TcSIbHlRbC6emj3ViO3IlDrhfdc5 M/EoInbVRehGVxr42QcAbN2+qKydfxWMj0NddSPmnGSgYFA//drQ/ZmQuCh6St/3io8dPa++86+lX BB0rkTbU4r089/x68Wrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdme-0000000BDTl-1O91; Tue, 02 Apr 2024 13:02:36 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmb-0000000BDQK-0D6r for openwrt-devel@lists.openwrt.org; Tue, 02 Apr 2024 13:02:34 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-515d55ab035so2014094e87.2 for ; Tue, 02 Apr 2024 06:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712062944; x=1712667744; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=kH1MXqODf+rEAt8qScUpijP1kgnc2Yg65QdH3Tv0x64=; b=fWwjSZnfmlGoWeAvHSnYbdf73RONqXIFvflA6Yi6OQ6pnrKn4GmbneAZRwz5a9+gZa XrKqkdzW9S0XET/+Hpp5h3bI3ss9Wc8fVWmWNEa4VpB/Mgmz/Zbs/KE3/rwYihmqNG4W sQV/k7ZIT9v/QY7u9XMD11EZVyY6KPTO2cYSOK99/raiZN2e6FSgcqu8762IAyoU/+bT U7SgukVA4IGda/QQoObPHvODdjWrXP2syIZMlvCdEnDyUN+QQnLExUtAkJ1OyP3/TeA5 uWUeQ7fkW7sDZF2oUNNEMFJImc7mrMEAyKgOGR83c2TQiL+FE9GJPRZo4dm+IsgoNUWg 9gJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712062944; x=1712667744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=kH1MXqODf+rEAt8qScUpijP1kgnc2Yg65QdH3Tv0x64=; b=QfoqnaWGIwjtbSBzOHGbsMsBWV32xtNqNo1IPHnON4B5fwSOtWTYtDzals/nkDlXKL du+nwEQcEHRpgqkkqXKP7JWhi8DMkU1BiJARhMHXQw5n0XCX+5/11XS+dzkFQgudGdNn s7uI/k3Ije7A3z0YzOJhlPpJRP+tJK3qgFzLj7ZDujiQYAD9xzsHiX5lQBJh1wG9k3A6 DJk9JZtO30rB/gC2cuFB/yJ/XJUC38KzydgdPXJRJLggf1UX4RAaBhWC49JEYsU9paLb FwqcfQsvZe6NHGI4+KUs5Dtu2Zpg6sH/zgWZ/lWPlFudER6guBCr3o+3SmLghRQzTSu3 03Yg== X-Gm-Message-State: AOJu0YzZoN5HV11ImOYAVtyVQbulg2Z1+JHAUn/Amk9ttzqX1Ei+T6ZF 39SXk7e36l59HC7LWYi1exe3Y85op24QwUSyMCN+R0kHM0gWQ+kVXsjYapX3 X-Google-Smtp-Source: AGHT+IGwVX7ObpoDooGm3ekCgP4kIIi4r98hU9HDl0+/+DgcjNs5XvyhzSP0aWAHJ++eAhd/VumyhQ== X-Received: by 2002:ac2:414e:0:b0:512:cc50:c3e0 with SMTP id c14-20020ac2414e000000b00512cc50c3e0mr7934377lfi.52.1712062944454; Tue, 02 Apr 2024 06:02:24 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id d8-20020ac241c8000000b00515fc468f45sm995071lfi.31.2024.04.02.06.02.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 06:02:24 -0700 (PDT) From: Paul Donald To: openwrt-devel@lists.openwrt.org Subject: [PATCH 4/7] lldpd: note about capabilities Date: Tue, 2 Apr 2024 15:02:18 +0200 Message-ID: <20240402130221.58706-4-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402130221.58706-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_060233_209488_11B41E74 X-CRM114-Status: UNSURE ( 7.48 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: only available from >= 1.0.15 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 1 + 1 file changed, 1 insertion(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 0334156fee..284c37c2ef 100644 --- a/package/network/services/lldpd/files/lldpd.init [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:135 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org only available from >= 1.0.15 Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 1 + 1 file changed, 1 insertion(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 0334156fee..284c37c2ef 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -120,6 +120,7 @@ write_lldpd_conf() local lldp_mgmt_ip config_get lldp_mgmt_ip 'config' 'lldp_mgmt_ip' + # Configurable capabilities in lldpd >= v1.0.15 local lldp_syscapabilities config_get lldp_syscapabilities 'config' 'lldp_syscapabilities' From patchwork Tue Apr 2 13:02:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1918784 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=4tSpwyKi; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=aAP2lMUS; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V87PC0shLz1yYB for ; Wed, 3 Apr 2024 00:03:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WUvbulBwhd1EMPF7MT3wSWUSzlag7c6cl2sMeWgngoI=; b=4tSpwyKiHABxZt hX1J/Jowdpwd2GoWfQ08w64pJuVwtkbZOZ/7a2E3EYjEjf+PitQFlTFH4MOx46kgzRMo58D3wORdC HDMK5ismaZD+G4p+VyYmplHgoDnUqhe70ZU9iujtaOc6Iaw3J844o5hnhm/rNC6dchOpnULq/G1M2 h5xwv3HBxR+eY7BW8p6Yetykx4uh4byEzjKY07fBPENbS9PuBK22VuO7eJYmMKt0LWTecVuaziiX5 dPyVlLBJ1IR3CDddksQDLDv8MP0Yt4vVPdRxwDVK1K5RfTDhuh8wPkVOOCU3h/cG6tvaf34E4dLaK gmTccPZftBq1JVOWU7Bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmZ-0000000BDRq-1ffW; Tue, 02 Apr 2024 13:02:31 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmV-0000000BDQX-36Qc for openwrt-devel@lists.openwrt.org; Tue, 02 Apr 2024 13:02:28 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-516b80252c6so443625e87.0 for ; Tue, 02 Apr 2024 06:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712062946; x=1712667746; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=GUcsWqJQ2fMHHRRogyFeem/TLC5Rx7oDoRVPuGsL9+g=; b=aAP2lMUSNBHt009nbAQ48UA0QGcBQdIqpHaQrjXnkBocTHcDcPUQEoqlWEd3mOLGCe Wvf4FHowWPmKFkrNQJAAwi/Oz+M9SsowNaGgbyONJWeyRBUnpGQ8TCrSY8KvsK7CzaGh 18Xir7hCIU0cJmTTKjMBLOpg/jYKbD08y16voQQENuAiT9TIUGOjxEh8fO4r6jp/vxPq Rrefgtw841m0pTCVuPbJqAEDfZChpBQsgJhQmwxW7sbdvQqxq8KuhLL4DbiyrAox27Z+ ERmzMuLR7xZs19DP9QM86SMDFJHuQw6mtt1H4OcPuQTjxYTgicsLrdM+k8hx3dXt2zkk BwOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712062946; x=1712667746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GUcsWqJQ2fMHHRRogyFeem/TLC5Rx7oDoRVPuGsL9+g=; b=BKM5QumOqcS1SsUh8RrxsJhUh/76B2XemQGHU4jIpPY0RsZ7QQTND+IZ5vFj5VUx1c 4XNLsWDMEtb5v/ErYBmEW4irNIPzi8O3K8dOfjPRM7mV+BzMoesqfzZT6y6NleNqonRd 5hDOAa7gLP211h2vRIfl3XWOKzsr8gC0FBIg9fiHM+qtHUay6rD7Pd1BWVmZZPtgvHQ9 qjZ8P0fgp6XJv2MNBah2c8lq12I6IOb3mP2VoDQmwrpjk2wRb1bglyowp7OLI8sQe1zu MNIXhavoo8f/J0AnunY83thyWhChYzGSx2+gZv1ksvSKTfnkNQ8SvkozE3eQ7Zh9tIXK pyBA== X-Gm-Message-State: AOJu0Yz2hhmgTyBNyReVAvk7rUfDpO6qD25t4HCyxFRdZsihcNN1epyu sEwQ2xfaJaDQiaOKsvYLCqKi15B9Gy3yiSzY/tIHKqpf3Adx0xlo6XjwArrE X-Google-Smtp-Source: AGHT+IHP2HJ4bco99fxsnD1Fl/plAtU9mUcXEyyPMfker+4oq5XCEcj2yNHGKxcJ5gXto48F9DK+jw== X-Received: by 2002:ac2:47f8:0:b0:515:acca:d75b with SMTP id b24-20020ac247f8000000b00515accad75bmr7912536lfp.22.1712062945521; Tue, 02 Apr 2024 06:02:25 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id d8-20020ac241c8000000b00515fc468f45sm995071lfi.31.2024.04.02.06.02.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 06:02:24 -0700 (PDT) From: Paul Donald To: openwrt-devel@lists.openwrt.org Subject: [PATCH 5/7] lldpd: make capabilities advertisement controllable Date: Tue, 2 Apr 2024 15:02:19 +0200 Message-ID: <20240402130221.58706-5-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402130221.58706-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_060227_809070_774648B2 X-CRM114-Status: UNSURE ( 8.20 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Defaults to off. Only available from >= 1.0.15 These capabilities are sent in TLV. Content analysis details: (1.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:12f listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] 1.8 LONGWORDS Long string of long words X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Defaults to off. Only available from >= 1.0.15 These capabilities are sent in TLV. Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 284c37c2ef..3e804cd033 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -124,6 +124,10 @@ write_lldpd_conf() local lldp_syscapabilities config_get lldp_syscapabilities 'config' 'lldp_syscapabilities' + # Configurable capabilities in lldpd >= v1.0.15 + local lldp_capadv + config_get_bool lldp_capadv 'config' 'lldp_capadv' 0 + if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ]; then local lldpmed_fast_start config_get_bool lldpmed_fast_start 'config' 'lldpmed_fast_start' 0 @@ -164,6 +168,7 @@ write_lldpd_conf() [ -n "$lldp_hostname" ] && echo "configure system hostname" "\"$lldp_hostname\"" >> "$LLDPD_CONF" [ -n "$lldp_mgmt_ip" ] && echo "configure system ip management pattern" "\"$lldp_mgmt_ip\"" >> "$LLDPD_CONF" [ -n "$lldp_syscapabilities" ] && echo "configure system capabilities enabled $lldp_syscapabilities" >> "$LLDPD_CONF" + if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ] && [ "$lldpmed_fast_start" -gt 0 ]; then if [ "$lldpmed_fast_start_tx_interval" -gt 0 ]; then echo "configure med fast-start tx-interval $lldpmed_fast_start_tx_interval" >> "$LLDPD_CONF" @@ -189,6 +194,7 @@ write_lldpd_conf() [ -n "$lldp_platform" ] && echo "configure system platform" "\"$lldp_platform\"" >> "$LLDPD_CONF" [ -n "$lldp_tx_interval" ] && echo "configure lldp tx-interval $lldp_tx_interval" >> "$LLDPD_CONF" [ "$lldp_tx_hold" -gt 0 ] && echo "configure lldp tx-hold $lldp_tx_hold" >> "$LLDPD_CONF" + [ "$lldp_capadv" -gt 0 ] && echo "configure lldp capabilities-advertisements" >> "$LLDPD_CONF" # Since lldpd's sysconfdir is /tmp, we'll symlink /etc/lldpd.d to /tmp/$LLDPD_CONFS_DIR [ -e "$LLDPD_CONFS_DIR" ] || ln -s /etc/lldpd.d "$LLDPD_CONFS_DIR" @@ -367,6 +373,7 @@ reload_service() { $LLDPCLI -u "$LLDPSOCKET" >/dev/null 2>&1 <<-EOF pause unconfigure lldp custom-tlv + unconfigure lldp capabilities-advertisements unconfigure system interface pattern unconfigure system description unconfigure system hostname From patchwork Tue Apr 2 13:02:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1918788 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=FW5TnfJV; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=aY50K4hu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V87PK4DDRz1yZ3 for ; Wed, 3 Apr 2024 00:04:05 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GCIK1uai9WNUjcn6+JSxGTAU4OKiOtZfziBd1qR/Nsk=; b=FW5TnfJVSSJ5mg 8WwklI/jBfSyLdL847JQ6Ohj9biQ2jddzyKOOtrFvEVCzCIM6gnh8sy75UuG0kmrJjlmZbrm1Z50h FSDf4qzh45BquyyQuDQN51XrzFGQkdHFbUa/C3qszeVxZMd4HCmBXPlHz5uJo08vkNaUeS1joNvt0 L2+RqyyPUQ1k50r5d3+rsD/uewwLy5tLv0pUxdcOv0WNUxTgcwpGKMUh/I8bXRdQvUC0Bd+aaScg3 vKzFuAVoKbDiMTo11mfhAgwSGqzCw4ow9sKNJ40yXAhm+Mj9aXQsy+RpNMYJ0xTIMOgIrsKZWR+ls wRUaDoyjARnaTTpj0yAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmq-0000000BDXA-3UMv; Tue, 02 Apr 2024 13:02:48 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmb-0000000BDQZ-0GDf for openwrt-devel@lists.openwrt.org; Tue, 02 Apr 2024 13:02:35 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5157af37806so5587840e87.0 for ; Tue, 02 Apr 2024 06:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712062946; x=1712667746; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=QNhb6vNqxrdorRZGlfaSMzS8VVy4XYLZteZvJ8ab0Ac=; b=aY50K4huWW9C740RWiK0LIKPeBlROfeSxcmYV17G79PRH40BXvJl33Xec7VtqMZzdK vne18pL9BKUpPZFzjct6jIfc7/tWEb6OjiVC0HYRk8YXq15upNt0dh/laYGdAOGITipu GcG8MEoHaxKJ/FDDoC7yHzwV3x+jhLhkBWzkTA4EJzHesWlbsUtbNWUCwaQ2kX7UFqO1 CYQRwvMHhwmCUZp1a4t5bApZHRyM7dRT1zauwYJfiUqoumkB45CQ3xKG+9mLk6FCFe1B SXFVwwYKPZWthfSKViADV3Cf4/juTPcwz0xWSSRBhjLWUYThJAZThqSBIY6HmQbcaw3h 1qpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712062946; x=1712667746; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QNhb6vNqxrdorRZGlfaSMzS8VVy4XYLZteZvJ8ab0Ac=; b=ia5tJBxaAtOGXFAksRH8RmgOtvO6RPWgtKTihaVt30Cymutm0xOwVigdWaLHV945uj yU+9U4NxiI/eQK03elMd3VGZLZ3TDuxO9VuykG/mQdtA23sfqWI3v9jWTu880ziALIe3 vM/Rd4LxqCBvQGttlDbyeqNvSyml/IytbrY8171QxdemvHXNIZa/SAEfP//ngD/POJha h57I9n+GoRXawCDMs4PMxe6fn1zbJoyDnmGlSQCyf1gw4DscHtNHMw5a50AFrk4Ia26Q Q3dtIY5FoJwH5NeY4JfxMnKp75RROAzWwFKvfmoKij7Q9T8XckwZMY80noknD6R6rkOc zWiA== X-Gm-Message-State: AOJu0YySiCyrGaq6+aXzSxLHNuxlcppwwgCoIeqpjoRkmLS4AqVltGkr gdQucgOuhX7ip993a5QB20OQcnDeFTFWwFwkP9voxRust2vBZut9iUZWoh+4 X-Google-Smtp-Source: AGHT+IH68eY6X3XXHILITfI2CCHcjiGqo3XkcYo+99mIXhYwrQ3CKCs1F01eYuc4D+A20BH8BiunzA== X-Received: by 2002:ac2:4f13:0:b0:516:aaa4:d118 with SMTP id k19-20020ac24f13000000b00516aaa4d118mr5023799lfr.41.1712062946040; Tue, 02 Apr 2024 06:02:26 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id d8-20020ac241c8000000b00515fc468f45sm995071lfi.31.2024.04.02.06.02.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 06:02:25 -0700 (PDT) From: Paul Donald To: openwrt-devel@lists.openwrt.org Subject: [PATCH 6/7] lldpd: make management address advertisement controllable Date: Tue, 2 Apr 2024 15:02:20 +0200 Message-ID: <20240402130221.58706-6-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402130221.58706-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_060233_235942_BF1DC29D X-CRM114-Status: UNSURE ( 8.17 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 1.6 (+) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Defaults to off. Available from >= 0.7.15 These are sent in TLV Content analysis details: (1.6 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:130 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] 1.8 LONGWORDS Long string of long words X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Defaults to off. Available from >= 0.7.15 These are sent in TLV Signed-off-by: Paul Donald --- package/network/services/lldpd/files/lldpd.init | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/package/network/services/lldpd/files/lldpd.init b/package/network/services/lldpd/files/lldpd.init index 3e804cd033..72baf19cc5 100644 --- a/package/network/services/lldpd/files/lldpd.init +++ b/package/network/services/lldpd/files/lldpd.init @@ -128,6 +128,10 @@ write_lldpd_conf() local lldp_capadv config_get_bool lldp_capadv 'config' 'lldp_capadv' 0 + # Broadcast management address in lldpd >= 0.7.15 + local lldp_maddradv + config_get_bool lldp_maddradv 'config' 'lldp_maddradv' 0 + if [ "$CONFIG_LLDPD_WITH_LLDPMED" = "y" ]; then local lldpmed_fast_start config_get_bool lldpmed_fast_start 'config' 'lldpmed_fast_start' 0 @@ -195,6 +199,7 @@ write_lldpd_conf() [ -n "$lldp_tx_interval" ] && echo "configure lldp tx-interval $lldp_tx_interval" >> "$LLDPD_CONF" [ "$lldp_tx_hold" -gt 0 ] && echo "configure lldp tx-hold $lldp_tx_hold" >> "$LLDPD_CONF" [ "$lldp_capadv" -gt 0 ] && echo "configure lldp capabilities-advertisements" >> "$LLDPD_CONF" + [ "$lldp_maddradv" -gt 0 ] && echo "configure lldp management-addresses-advertisements" >> "$LLDPD_CONF" # Since lldpd's sysconfdir is /tmp, we'll symlink /etc/lldpd.d to /tmp/$LLDPD_CONFS_DIR [ -e "$LLDPD_CONFS_DIR" ] || ln -s /etc/lldpd.d "$LLDPD_CONFS_DIR" @@ -374,6 +379,7 @@ reload_service() { pause unconfigure lldp custom-tlv unconfigure lldp capabilities-advertisements + unconfigure lldp management-addresses-advertisements unconfigure system interface pattern unconfigure system description unconfigure system hostname From patchwork Tue Apr 2 13:02:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1918785 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=HucUWHYL; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=HFxuvoRV; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V87PC1Db8z1yZ3 for ; Wed, 3 Apr 2024 00:03:59 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NRrHRxd0AlVw6/EeRELiIcsNYcH/OQLJ4uA0LiCQE5g=; b=HucUWHYLHF1hM7 PCuHjZGGFrrVUPOE6VQlmUW6IPMXoGgxMHAyGQo5tY6rawYn/J/XudetqvQC9FjNb1T+lYRxBCxCX Gj44+Sd2ni8DnUJwoQvYt0ORckgqE81wQwdUiIzkWjG7DzdYnRNxW5iaUpq25Z3i7f9uJmsE+Uccv /bhLXf4CRWABqtbBbWtEeLrdQJ/urc/ytrae1g8w2oyMFDSFBAjKCuvqGyA2YnxrX0cL9v0fo3I76 dFAnxTm2Q9WblsSu+5hnedA8VURtUqZMrdceKe6O/q18SLnwDq/9TpuCUGTZqBcV1/BQSf+iQqFig d332FHLvG1dRvZ/KMHRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmb-0000000BDSM-34WU; Tue, 02 Apr 2024 13:02:33 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrdmX-0000000BDQz-0rYh for openwrt-devel@lists.openwrt.org; Tue, 02 Apr 2024 13:02:30 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-513d247e3c4so4700440e87.0 for ; Tue, 02 Apr 2024 06:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712062947; x=1712667747; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=ichJccNIHkW4epvRC/+f2H/2Gi4hhVkdhOAn8TNMAQA=; b=HFxuvoRV1Qxg7x/M2AQA9rkoMWyPZ3dKq0HwEEdxjaRYWrSn6TCG/GQrAzgL5Pyheu 5+wBe/UvDN39VKbclPUtSoYLMfTDZ0OE6jSUKIt8nP9+xad1TwjwXJf8x7MfzflALwI+ G63zqSfelGZm3xzv4GVtxP7x3rj4Vwq/rODBUkPhNxSGNrb+75O6CZ+u7K9NlsU97mSK RDY0no+mEeWSekuYWcFwlWCcebK8OH4SwZg/45QUaaynzRHRu5DQViFiT3O9gZAC5lwD Wx/mF22I5/TGXOfVx+nYHKOh5PLwCTvuJ5n4CCPPCfO6ppaNIlgt7MDrMcjJfMQ605Wq QxnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712062947; x=1712667747; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ichJccNIHkW4epvRC/+f2H/2Gi4hhVkdhOAn8TNMAQA=; b=VbmcMDE0eDQTrT44OZjqpxwAkR3HmoMow6Yv/4/nuL/Lu4/DqvN7GWhM0zISsjY7n6 0DOQGtQ9UMVDEr8Av7sm5en8voVH9HdWQG+wAgN756TisfGq5F0cV/56/GWADi7SMvRP Tor77x9uBeIog+Sg4ykf/fTAUQckw1AS76NsTF3pNMIedmonBJkEeVdey7H9ahSk2dH4 7CspusJ4ezk0Xag+yr35R7CikdxTYeP//y/dvF2Xtry7iNKVwK0W/rYScLC/P30THoS5 sf/fQoMaNLxdy5DewoQcgtYTG2wuKy3hNzDIMS4SEEUB9lePhizHTcKTaCB+wKlxI/Le BndQ== X-Gm-Message-State: AOJu0Yz+9fNFZURXTLoO/VxYvz6RTSkGOWx2HQLkvVJldMks0rvK4jfY bCIx3Y8lPXz7p33MLahJuJRE6e316bV9FusbqCHSrbM7qmB0Nr+qGJMK1GC1 X-Google-Smtp-Source: AGHT+IFXNiJzPnesdwtIHpGom8Yj6oNXK76ZQLJ7FomQ9WJnKi1YH+4t77+J0nmKeadQwJGLfnBt9Q== X-Received: by 2002:ac2:4e6f:0:b0:516:b9ff:c502 with SMTP id y15-20020ac24e6f000000b00516b9ffc502mr166397lfs.3.1712062947422; Tue, 02 Apr 2024 06:02:27 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id d8-20020ac241c8000000b00515fc468f45sm995071lfi.31.2024.04.02.06.02.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 06:02:26 -0700 (PDT) From: Paul Donald To: openwrt-devel@lists.openwrt.org Subject: [PATCH 7/7] lldpd: bump version Date: Tue, 2 Apr 2024 15:02:21 +0200 Message-ID: <20240402130221.58706-7-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240402130221.58706-1-newtwen+github@gmail.com> References: <20240402130221.58706-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240402_060229_284008_5EC14DF3 X-CRM114-Status: UNSURE ( 8.68 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: 3 -> 4 Signed-off-by: Paul Donald --- package/network/services/lldpd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/lldpd/Makefile b/package/network/services/lldpd/Makefile index 18cdda33ce..5a9a9732d2 100644 --- a/package/network/services/lldpd/Makefile +++ b/package/network/s [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:12f listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org 3 -> 4 Signed-off-by: Paul Donald --- package/network/services/lldpd/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/network/services/lldpd/Makefile b/package/network/services/lldpd/Makefile index 18cdda33ce..5a9a9732d2 100644 --- a/package/network/services/lldpd/Makefile +++ b/package/network/services/lldpd/Makefile @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=lldpd PKG_VERSION:=1.0.17 -PKG_RELEASE:=3 +PKG_RELEASE:=4 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz PKG_SOURCE_URL:=https://github.com/lldpd/lldpd/releases/download/$(PKG_VERSION)/