From patchwork Thu Apr 19 15:16:58 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Elwell X-Patchwork-Id: 901317 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=raspberrypi.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=raspberrypi.org header.i=@raspberrypi.org header.b="pwe2Zxhs"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi-org.20150623.gappssmtp.com header.i=@raspberrypi-org.20150623.gappssmtp.com header.b="cS2ahNP+"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40RjMc493rz9s1v for ; Fri, 20 Apr 2018 01:19:40 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753099AbeDSPTi (ORCPT ); Thu, 19 Apr 2018 11:19:38 -0400 Received: from mx08-00252a01.pphosted.com ([91.207.212.211]:56670 "EHLO mx08-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbeDSPSF (ORCPT ); Thu, 19 Apr 2018 11:18:05 -0400 Received: from pps.filterd (m0102629.ppops.net [127.0.0.1]) by mx08-00252a01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3JFEFVU021105 for ; Thu, 19 Apr 2018 16:18:03 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.org; h=from : to : subject : date : message-id : in-reply-to : references; s=pp; bh=mmNUTqdrhxd56nihAZs/bUCP5Q/ZqHW0uhTUY85/Bms=; b=pwe2ZxhsyofdGg7OOHYyyceAHGJKwy2ZdymXLWGZvaC7DU5Ro3rHq9ma9fboHc11Zcww RxIxoCVmzd9QJPcNvri7QIbjF+pLDh+Y76FtX5OvLaWd3gYlGtTBrhtbTJo/RjXWY1ep BP1/oqZfpwlHXVZnF22+sJGK1qON0a2XB6sk8CsnPEnTTd/ku0GwcrkJhkpYPRvPYJel voRXEUPxovHf5Y7Src0h0tRiY0+0BMPiyehdtGqHFNADIcxS8ba0FT2Ugvx7lBef6hQA PtYgpf3Ec8HeP6SMhX9lXVH3uwkKjm9xdI96UtLT1RJbZlK3Hy2PtMoOSjKHOPmwT4pD fQ== Received: from mail-wr0-f200.google.com (mail-wr0-f200.google.com [209.85.128.200]) by mx08-00252a01.pphosted.com with ESMTP id 2hdry78xgv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Thu, 19 Apr 2018 16:18:03 +0100 Received: by mail-wr0-f200.google.com with SMTP id 47-v6so5568683wru.19 for ; Thu, 19 Apr 2018 08:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=mmNUTqdrhxd56nihAZs/bUCP5Q/ZqHW0uhTUY85/Bms=; b=cS2ahNP+oF66p7cjCmgll0uBnmfKTbc2mGBA25LSUae1MF0Dd0HK5L+fa8Cyc5fgc2 3Sk/awE5ro0B8Ud3jULfS79U+/9FnIIIdU+sEvUqlKj+TYb4uYdkIWv856Gr0iwI6PxF QQvcyOWxkbxvHXYl+sMblwsJo6qJGevwolT2ZgafgZmRFFuUuctFXtcYHTP4IBFNrKTC nq7okjbpCyrZVAG2hHt1oM10BWFTvkaDmBmidHa/0KiPxPtM0jpfy+DyJ060MxBlJWpW diAvwPS7XLwFSrOk0YaTuMC3ODW7EmU7UM1Jv/PfbiRM/akrv+M6TDPoNsrcjsEC9ojU qL+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=mmNUTqdrhxd56nihAZs/bUCP5Q/ZqHW0uhTUY85/Bms=; b=ENSRGjpAAKU6kwBqLp0gwS5A0Id8l1sE8sa8DEC87a/FaDV0/T+Q99TZbHlP1eDkvm IuXs3cCUOju9Yy5WObFv1wfUZmA+mjypLMoPHnQCTv5MxtE713DP8UV+ifpXlF3HUm++ XAFc7AJSBPfSw0VzNHDSCF06Ct5xk01M1+o6Wro8UB+2WdSJP+kRRGLTewrRFdz4fWgW EwB3fSt5SM+7wef+rnM8spcbdssDSMQbeeQV6QmboMEAAkJ7yGdulfbF8MmUm6oo3fG6 ESGJAEE41G8uKn5dJeb5eQfqYo6F7gQBn1ll0ecCLoDfQ4Ej1UM+Oybc84vVNJqU+NgC x3sQ== X-Gm-Message-State: ALQs6tAG/ZEeliuUGFMH1vh55nyOq1LvIWvNYA40COOEuE1t7iwl+XkM YjCSqs7EFy7V18acGqQQoGtDVT/1yoQZbNNHTA9swY7ewHPFgNMNd2iu9iumzEevtQ33bjPXU/V PTKWcj+tUCjQsA3QJr2j8gw== X-Received: by 10.28.229.212 with SMTP id c203mr5074684wmh.2.1524151083333; Thu, 19 Apr 2018 08:18:03 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+hCo5WeQ0Cc5Eca4ozYQqCXEg3wh060uCM4CB2gsVFovYtj89Ohw3unORKRukD6iY2YvWfrA== X-Received: by 10.28.229.212 with SMTP id c203mr5074664wmh.2.1524151083030; Thu, 19 Apr 2018 08:18:03 -0700 (PDT) Received: from buildbot.pitowers.org ([2a00:2381:fdf7:14:3509:880e:14cc:3c11]) by smtp.gmail.com with ESMTPSA id f15-v6sm4322342wrh.35.2018.04.19.08.18.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Apr 2018 08:18:02 -0700 (PDT) From: Phil Elwell To: Woojung Huh , Microchip Linux Driver Support , Rob Herring , Mark Rutland , Andrew Lunn , Florian Fainelli , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , Phil Elwell , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH resend v3 2/3] lan78xx: Read LED states from Device Tree Date: Thu, 19 Apr 2018 16:16:58 +0100 Message-Id: <1524151019-82823-3-git-send-email-phil@raspberrypi.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1524151019-82823-1-git-send-email-phil@raspberrypi.org> References: <1524151019-82823-1-git-send-email-phil@raspberrypi.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-04-19_05:, , signatures=0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Add support for DT property "microchip,led-modes", a vector of zero to four cells (u32s) in the range 0-15, each of which sets the mode for one of the LEDs. Some possible values are: 0=link/activity 1=link1000/activity 2=link100/activity 3=link10/activity 4=link100/1000/activity 5=link10/1000/activity 6=link10/100/activity 14=off 15=on These values are given symbolic constants in a dt-bindings header. Also use the presence of the DT property to indicate that the LEDs should be enabled - necessary in the event that no valid OTP or EEPROM is available. Signed-off-by: Phil Elwell --- MAINTAINERS | 1 + drivers/net/phy/microchip.c | 25 ++++++++++++++++++++++ drivers/net/usb/lan78xx.c | 32 ++++++++++++++++++++++++++++- include/dt-bindings/net/microchip-lan78xx.h | 21 +++++++++++++++++++ include/linux/microchipphy.h | 3 +++ 5 files changed, 81 insertions(+), 1 deletion(-) create mode 100644 include/dt-bindings/net/microchip-lan78xx.h diff --git a/MAINTAINERS b/MAINTAINERS index b60179d..23735d9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14573,6 +14573,7 @@ M: Microchip Linux Driver Support L: netdev@vger.kernel.org S: Maintained F: drivers/net/usb/lan78xx.* +F: include/dt-bindings/net/microchip-lan78xx.h USB MASS STORAGE DRIVER M: Alan Stern diff --git a/drivers/net/phy/microchip.c b/drivers/net/phy/microchip.c index 0f293ef..ef5e160 100644 --- a/drivers/net/phy/microchip.c +++ b/drivers/net/phy/microchip.c @@ -20,6 +20,8 @@ #include #include #include +#include +#include #define DRIVER_AUTHOR "WOOJUNG HUH " #define DRIVER_DESC "Microchip LAN88XX PHY driver" @@ -70,6 +72,8 @@ static int lan88xx_probe(struct phy_device *phydev) { struct device *dev = &phydev->mdio.dev; struct lan88xx_priv *priv; + u32 led_modes[4]; + int len; priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -77,6 +81,27 @@ static int lan88xx_probe(struct phy_device *phydev) priv->wolopts = 0; + len = of_property_read_variable_u32_array(dev->of_node, + "microchip,led-modes", + led_modes, + 0, + ARRAY_SIZE(led_modes)); + if (len >= 0) { + u32 reg = 0; + int i; + + for (i = 0; i < len; i++) { + if (led_modes[i] > 15) + return -EINVAL; + reg |= led_modes[i] << (i * 4); + } + for (; i < ARRAY_SIZE(led_modes); i++) + reg |= LAN78XX_FORCE_LED_OFF << (i * 4); + (void)phy_write(phydev, LAN78XX_PHY_LED_MODE_SELECT, reg); + } else if (len == -EOVERFLOW) { + return -EINVAL; + } + /* these values can be used to identify internal PHY */ priv->chip_id = phy_read_mmd(phydev, 3, LAN88XX_MMD3_CHIP_ID); priv->chip_rev = phy_read_mmd(phydev, 3, LAN88XX_MMD3_CHIP_REV); diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index a823f01..6b03b97 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include "lan78xx.h" @@ -1760,6 +1761,7 @@ static int lan78xx_mdiobus_write(struct mii_bus *bus, int phy_id, int idx, static int lan78xx_mdio_init(struct lan78xx_net *dev) { + struct device_node *node; int ret; dev->mdiobus = mdiobus_alloc(); @@ -1788,7 +1790,13 @@ static int lan78xx_mdio_init(struct lan78xx_net *dev) break; } - ret = mdiobus_register(dev->mdiobus); + node = of_get_child_by_name(dev->udev->dev.of_node, "mdio"); + if (node) { + ret = of_mdiobus_register(dev->mdiobus, node); + of_node_put(node); + } else { + ret = mdiobus_register(dev->mdiobus); + } if (ret) { netdev_err(dev->net, "can't register MDIO bus\n"); goto exit1; @@ -2077,6 +2085,28 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) mii_adv = (u32)mii_advertise_flowctrl(dev->fc_request_control); phydev->advertising |= mii_adv_to_ethtool_adv_t(mii_adv); + if (phydev->mdio.dev.of_node) { + u32 reg; + int len; + + len = of_property_count_elems_of_size(phydev->mdio.dev.of_node, + "microchip,led-modes", + sizeof(u32)); + if (len >= 0) { + /* Ensure the appropriate LEDs are enabled */ + lan78xx_read_reg(dev, HW_CFG, ®); + reg &= ~(HW_CFG_LED0_EN_ | + HW_CFG_LED1_EN_ | + HW_CFG_LED2_EN_ | + HW_CFG_LED3_EN_); + reg |= (len > 0) * HW_CFG_LED0_EN_ | + (len > 1) * HW_CFG_LED1_EN_ | + (len > 2) * HW_CFG_LED2_EN_ | + (len > 3) * HW_CFG_LED3_EN_; + lan78xx_write_reg(dev, HW_CFG, reg); + } + } + genphy_config_aneg(phydev); dev->fc_autoneg = phydev->autoneg; diff --git a/include/dt-bindings/net/microchip-lan78xx.h b/include/dt-bindings/net/microchip-lan78xx.h new file mode 100644 index 0000000..0742ff0 --- /dev/null +++ b/include/dt-bindings/net/microchip-lan78xx.h @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _DT_BINDINGS_MICROCHIP_LAN78XX_H +#define _DT_BINDINGS_MICROCHIP_LAN78XX_H + +/* LED modes for LAN7800/LAN7850 embedded PHY */ + +#define LAN78XX_LINK_ACTIVITY 0 +#define LAN78XX_LINK_1000_ACTIVITY 1 +#define LAN78XX_LINK_100_ACTIVITY 2 +#define LAN78XX_LINK_10_ACTIVITY 3 +#define LAN78XX_LINK_100_1000_ACTIVITY 4 +#define LAN78XX_LINK_10_1000_ACTIVITY 5 +#define LAN78XX_LINK_10_100_ACTIVITY 6 +#define LAN78XX_DUPLEX_COLLISION 8 +#define LAN78XX_COLLISION 9 +#define LAN78XX_ACTIVITY 10 +#define LAN78XX_AUTONEG_FAULT 12 +#define LAN78XX_FORCE_LED_OFF 14 +#define LAN78XX_FORCE_LED_ON 15 + +#endif diff --git a/include/linux/microchipphy.h b/include/linux/microchipphy.h index eb492d4..8e4015e 100644 --- a/include/linux/microchipphy.h +++ b/include/linux/microchipphy.h @@ -70,4 +70,7 @@ #define LAN88XX_MMD3_CHIP_ID (32877) #define LAN88XX_MMD3_CHIP_REV (32878) +/* Registers specific to the LAN7800/LAN7850 embedded phy */ +#define LAN78XX_PHY_LED_MODE_SELECT (0x1D) + #endif /* _MICROCHIPPHY_H */ From patchwork Thu Apr 19 15:16:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Elwell X-Patchwork-Id: 901313 Return-Path: X-Original-To: incoming-dt@patchwork.ozlabs.org Delivered-To: patchwork-incoming-dt@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=devicetree-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=raspberrypi.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=raspberrypi.org header.i=@raspberrypi.org header.b="S9FhmjRC"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi-org.20150623.gappssmtp.com header.i=@raspberrypi-org.20150623.gappssmtp.com header.b="kPzqKcY3"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 40RjLJ2LvWz9s27 for ; Fri, 20 Apr 2018 01:18:32 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbeDSPS3 (ORCPT ); Thu, 19 Apr 2018 11:18:29 -0400 Received: from mx07-00252a01.pphosted.com ([62.209.51.214]:6578 "EHLO mx07-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752946AbeDSPSI (ORCPT ); Thu, 19 Apr 2018 11:18:08 -0400 Received: from pps.filterd (m0102628.ppops.net [127.0.0.1]) by mx07-00252a01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w3JFHMxY014500 for ; Thu, 19 Apr 2018 16:18:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.org; h=from : to : subject : date : message-id : in-reply-to : references; s=pp; bh=xSSD9SvLCvUPLV3TsLO9yFBlCax29EsDDiA9e9toJmo=; b=S9FhmjRChTwyL2wOEa5Qhayr5UMf9e7SAD3BQxYq9dUFCmSRelgn4Y8lUQdENcpT5o1w ITm1Vq+QaeklBRw0WXcetAaZ31oGwwLpNMkYcDSuZW54Tm998zgGVYdQ3zEIsn3dWwYu 0iaqknrrcF74rupPIUWpBnw64J3rBQVPIr3g0b2onnA4eCfiTHQ/MLVzHuJMlp4mcKqt OLPYqvSq7yGQPaUPcPQQ9cMCuExsIOxIBTGYutYUEK29rWQe9cHXztbNFL1NFaWgnGNS NExg6VSouhfisRPWyomRdEHo4BJrTH9HP77Zof5wLjkpr7OxsGwUR2xl86stBduq55F6 Jw== Received: from mail-wr0-f200.google.com (mail-wr0-f200.google.com [209.85.128.200]) by mx07-00252a01.pphosted.com with ESMTP id 2hdrya8xn0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Thu, 19 Apr 2018 16:18:06 +0100 Received: by mail-wr0-f200.google.com with SMTP id b10-v6so5603401wrf.3 for ; Thu, 19 Apr 2018 08:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=xSSD9SvLCvUPLV3TsLO9yFBlCax29EsDDiA9e9toJmo=; b=kPzqKcY3cEOMeV6+nz1O0jqyK0NmBzpycg+cGQWFdc7/eAmm8Gt5snJ24QcxJo9anV qWoIySkV7VfLGouo4ybM7AtZUYmHWsYF9xoO0wiEoeeMncOpMdB0eJfNWtqny0ZvTg63 286ngYHfMz7PGCaaGEwS7f8v3sQR7HHLREj9pmu36W1TgeqGsMC2vdB7rcaUqMGwHvjH f5w2bTxtkdakmXvpE/2gzlLP2QrxolpMQjAKXXCzeUAMaih0faEffO9bh8C0N5bZBNxK hn5wx+dkaGAoS6uoWaZkZ1iSeuQ9W6KB8C1Xd3qF5DfDG4qK3wBKta+wrFl/KyRoPIx7 rL1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=xSSD9SvLCvUPLV3TsLO9yFBlCax29EsDDiA9e9toJmo=; b=alOBVUlY4T2JFNmfTDSzqpD8zMQjfTkP4g5qCb86itxrU9KmlK6xN+zJ/4G8YbCiad xM2H0RuPW7wVSYbrdLWeczlnFiv4uGI4LwX3HlRBBA9G/jhOOJY+raavwtdYw0IrVLy4 2QKfe8Adf7ICore43y8FO8JjD06ntMQ7ZqFK44WshTmYWGijFhnAIWwXtKgGxKouB+Cd SOFmBl4JdtXnBTPx+PDHnBWu3gFN7sSRHlS3SHaRo5a0S1ovWiEOz46zEwkujdV9/1/J 8G54yLe/VqrFLYaHgXrzhysJJuFiOsUoVdeGleCRCJbkzn4UYRwksnKl6AMl+XPIFu9R 21Aw== X-Gm-Message-State: ALQs6tCWi3YNc02p44x8gKFWUBSEKWPD4LHoSRLBD9f1oVysPDKg+h/b M233b4ekuqHAjyNbGQiT6D3QHV+ew3JDrHGdxaGO2wSGJogWI8N4dVcxKnyMQwnhHgxCe+Emp7m Ep/Woo05+EugWY30tbBanow== X-Received: by 10.28.28.137 with SMTP id c131mr5081251wmc.45.1524151084853; Thu, 19 Apr 2018 08:18:04 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/kuPQVF6+5dpoLHjU1MyOxAFNHesxCYv7i3mLMIRFjImdRmno/KziG9NsW9k92hz5YD0UFVQ== X-Received: by 10.28.28.137 with SMTP id c131mr5081227wmc.45.1524151084591; Thu, 19 Apr 2018 08:18:04 -0700 (PDT) Received: from buildbot.pitowers.org ([2a00:2381:fdf7:14:3509:880e:14cc:3c11]) by smtp.gmail.com with ESMTPSA id f15-v6sm4322342wrh.35.2018.04.19.08.18.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Apr 2018 08:18:03 -0700 (PDT) From: Phil Elwell To: Woojung Huh , Microchip Linux Driver Support , Rob Herring , Mark Rutland , Andrew Lunn , Florian Fainelli , "David S. Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linus Walleij , Andrew Morton , Randy Dunlap , Phil Elwell , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH resend v3 3/3] dt-bindings: Document the DT bindings for lan78xx Date: Thu, 19 Apr 2018 16:16:59 +0100 Message-Id: <1524151019-82823-4-git-send-email-phil@raspberrypi.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1524151019-82823-1-git-send-email-phil@raspberrypi.org> References: <1524151019-82823-1-git-send-email-phil@raspberrypi.org> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2018-04-19_05:, , signatures=0 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The Microchip LAN78XX family of devices are Ethernet controllers with a USB interface. Despite being discoverable devices it can be useful to be able to configure them from Device Tree, particularly in low-cost applications without an EEPROM or programmed OTP. Document the supported properties in a bindings file. Signed-off-by: Phil Elwell --- .../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt diff --git a/Documentation/devicetree/bindings/net/microchip,lan78xx.txt b/Documentation/devicetree/bindings/net/microchip,lan78xx.txt new file mode 100644 index 0000000..a5d701b --- /dev/null +++ b/Documentation/devicetree/bindings/net/microchip,lan78xx.txt @@ -0,0 +1,54 @@ +Microchip LAN78xx Gigabit Ethernet controller + +The LAN78XX devices are usually configured by programming their OTP or with +an external EEPROM, but some platforms (e.g. Raspberry Pi 3 B+) have neither. +The Device Tree properties, if present, override the OTP and EEPROM. + +Required properties: +- compatible: Should be one of "usb424,7800", "usb424,7801" or "usb424,7850". + +Optional properties: +- local-mac-address: see ethernet.txt +- mac-address: see ethernet.txt + +Optional properties of the embedded PHY: +- microchip,led-modes: a 0..4 element vector, with each element configuring + the operating mode of an LED. Omitted LEDs are turned off. Allowed values + are defined in "include/dt-bindings/net/microchip-lan78xx.h". + +Example: + +/* Based on the configuration for a Raspberry Pi 3 B+ */ +&usb { + usb1@1 { + compatible = "usb424,2514"; + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + + usb1_1@1 { + compatible = "usb424,2514"; + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + + ethernet: usbether@1 { + compatible = "usb424,7800"; + reg = <1>; + local-mac-address = [ 00 11 22 33 44 55 ]; + + mdio { + #address-cells = <0x1>; + #size-cells = <0x0>; + eth_phy: ethernet-phy@1 { + reg = <1>; + microchip,led-modes = < + LAN78XX_LINK_1000_ACTIVITY + LAN78XX_LINK_10_100_ACTIVITY + >; + }; + }; + }; + }; + }; +}; diff --git a/MAINTAINERS b/MAINTAINERS index 23735d9..91cb961 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14572,6 +14572,7 @@ M: Woojung Huh M: Microchip Linux Driver Support L: netdev@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/net/microchip,lan78xx.txt F: drivers/net/usb/lan78xx.* F: include/dt-bindings/net/microchip-lan78xx.h